Il 17/09/2013 15:32, Igor Mammedov ha scritto:
> user is able to crash running QEMU when following monitor
> command is called:
>
> device_add intel-hda-generic
>
> crash is caused by assertion in object_initialize_with_type()
> when type is abstract.
>
> Checking if type is abstract before instance is created in
> qdev_device_add() allows to prevent crash on incorrect user input.
>
> Signed-off-by: Igor Mammedov <imamm...@redhat.com>
> ---
> qdev-monitor.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/qdev-monitor.c b/qdev-monitor.c
> index 410cdcb..bb2e1b6 100644
> --- a/qdev-monitor.c
> +++ b/qdev-monitor.c
> @@ -472,6 +472,12 @@ DeviceState *qdev_device_add(QemuOpts *opts)
> return NULL;
> }
>
> + if (object_class_is_abstract(obj)) {
> + qerror_report(QERR_INVALID_PARAMETER_VALUE, "driver",
> + "non-abstract device type");
> + return NULL;
> + }
> +
> k = DEVICE_CLASS(obj);
>
> /* find bus */
>
Looks good,
Paolo
