Am 17.09.2013 17:06, schrieb Anthony Liguori: > On Sat, Sep 14, 2013 at 2:47 PM, Michael Tokarev <m...@tls.msk.ru> wrote: >> Just a bit late but here's the next trivial-patches pull request. >> >> Thanks, > Breaks the build: > > /home/anthony/git/qemu/cpu-exec.c: In function ‘cpu_alpha_exec’: > /home/anthony/git/qemu/cpu-exec.c:204:15: error: variable ‘cpu’ might > be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] > /home/anthony/git/qemu/cpu-exec.c:202:28: error: argument ‘env’ might > be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] > cc1: all warnings being treated as errors > > I think it's one of the warning patches from Stefan. I cannot bisect > here. My gcc info is below:
Yes, it's the new -Wextra compiler (see "configure: Enable extra compiler warnings"). Some versions of gcc complain about this code in cpu-exec.c: /* Reload env after longjmp - the compiler may have smashed all * local variables as longjmp is marked 'noreturn'. */ cpu = current_cpu; env = cpu->env_ptr; I think that lines can be simply removed (which also fixes the warning). Please apply the trivial patches without my -Wextra patch or wait until I have sent a patch to fix cpu-exec.c. Regards Stefan