[Qemu-devel] [PATCH 01/15] openpic: fix debug prints

2012-12-21 Thread Scott Wood
Fix various format errors when debug prints are enabled. Also cause error checking to happen even when debug prints are not enabled, and consistently use 0x for hex output. Signed-off-by: Scott Wood --- hw/openpic.c | 40 1 file changed, 24 insertions(

[Qemu-devel] [PATCH 15/15] openpic: fix CTPR and de-assertion of interrupts

2012-12-21 Thread Scott Wood
Properly implement level-triggered interrupts by withdrawing an interrupt from the raised queue if the interrupt source de-asserts. Also withdraw from the raised queue if the interrupt becomes masked. When CTPR is written, check whether we need to raise or lower the interrupt output. Signed-off-b

[Qemu-devel] [PATCH 04/15] ppc/booke: fix crit/mcheck/debug exceptions

2012-12-21 Thread Scott Wood
Book E does not play games with certain bits of xSRR1 being MSR save bits and others being error status. xSRR1 is the old MSR, period. This was causing things like MSR[CE] to be lost, even in the saved version, as soon as you take an exception. rfci/rfdi/rfmci are fixed to pass the actual xSRR1 r

[Qemu-devel] [PATCH 13/15] openpic: add some bounds checking for IRQ numbers

2012-12-21 Thread Scott Wood
The two checks with abort() guard against potential QEMU-internal problems, but the EOI check stops the guest from causing updates to queue position -1 and other havoc if it writes EOI with no interrupt in service. Signed-off-by: Scott Wood --- hw/openpic.c | 15 +++ 1 file changed

[Qemu-devel] [PATCH 10/15] Revert "openpic: Accelerate pending irq search"

2012-12-21 Thread Scott Wood
This reverts commit a9bd83f4c65de0058659ede009fa1a241f379edd. This counting approach is not robust against setting a bit that was already set, or clearing a bit that was already clear. Perhaps that is considered a bug, but besides the lack of any documentation for that restriction, it's a pretty

[Qemu-devel] [PATCH 11/15] openpic: use standard bitmap operations

2012-12-21 Thread Scott Wood
Besides the private implementation being redundant, namespace collisions prevented the use of other things in bitops.h. Serialization does get a bit more awkward, unfortunately, since the standard bitmap operations are "unsigned long" rather than "uint32_t", though in exchange we will get faster q

[Qemu-devel] [PATCH 14/15] openpic: move IACK to its own function

2012-12-21 Thread Scott Wood
Besides making the code cleaner, we will need a separate way to access IACK in order to implement EPR (external proxy) interrupt delivery. Signed-off-by: Scott Wood --- hw/openpic.c | 95 -- 1 file changed, 53 insertions(+), 42 deletions(

Re: [Qemu-devel] [PULL 00/34] migration thread and queue

2012-12-21 Thread Anthony Liguori
Juan Quintela writes: > Hi > > Changes for yesterday: > - Paolo Acked the series > - Rebaso on top of today git (only conflicts were due to header re-shuffle) > > Please pull. Pulled. Thanks. Regards, Anthony Liguori > > [20121219] > > This is my queue for migration-thread and patches associa

[Qemu-devel] [PATCH 03/15] openpic: fix sense and priority bits

2012-12-21 Thread Scott Wood
Previously, the sense and priority bits were masked off when writing to IVPR, and all interrupts were treated as edge-triggered (despite the existence of code for handling level-triggered interrupts). Polarity is implemented only as storage. We don't simulate the bad effects that you'd get on rea

[Qemu-devel] [PATCH 00/15] openpic: cleanups and fixes

2012-12-21 Thread Scott Wood
Here's another patch of cleanups and fixes, dealing with critical interrupts, interrupt deassertion, task priority, and other issues. Scott Wood (15): openpic: fix debug prints openpic: lower interrupt when reading the MSI register openpic: fix sense and priority bits ppc/booke: fix crit/m

[Qemu-devel] [PATCH 09/15] openpic: always call IRQ_check from IRQ_get_next

2012-12-21 Thread Scott Wood
Previously the code relied on the queue's "next" field getting set to -1 sometime between an update to the bitmap, and the next call to IRQ_get_next. Sometimes this happened after the update. Sometimes it happened before the check. Sometimes it didn't happen at all. Signed-off-by: Scott Wood --

[Qemu-devel] [PATCH 12/15] openpic: IRQ_check: search the queue a word at a time

2012-12-21 Thread Scott Wood
Search the queue more efficiently by first looking for a non-zero word, and then using the common bit-searching function to find the bit within the word. It would be even nicer if bitops_ffsl() could be hooked up to the compiler intrinsic so that bit-searching instructions could be used, but that'

[Qemu-devel] [PATCH 06/15] openpic: rework critical interrupt support

2012-12-21 Thread Scott Wood
Critical interrupts on FSL MPIC are not supposed to pay attention to priority, IACK, EOI, etc. On the currently modeled version it's not supposed to pay attention to the mask bit either. Also reorganize to make it easier to implement newer FSL MPIC models, which encode interrupt level information

[Qemu-devel] [PATCH 05/15] openpic: make register names correspond better with hw docs

2012-12-21 Thread Scott Wood
The base openpic specification doesn't provide abbreviated register names, so it's somewhat understandable that the QEMU code made up its own, except that most of the names that QEMU used didn't correspond to the terminology used by any implementation I could find. In some cases, like PCTP, the ph

[Qemu-devel] [PATCH 08/15] openpic/fsl: critical interrupts ignore mask before v4.1

2012-12-21 Thread Scott Wood
Signed-off-by: Scott Wood --- hw/openpic.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/openpic.c b/hw/openpic.c index 9d22e9c..268f312 100644 --- a/hw/openpic.c +++ b/hw/openpic.c @@ -194,6 +194,7 @@ typedef struct IRQ_src_t { bool level; /* level-trigge

[Qemu-devel] [PATCH 07/15] openpic: make ctpr signed

2012-12-21 Thread Scott Wood
Other priorities are signed, so avoid comparisons between signed and unsigned. Signed-off-by: Scott Wood --- hw/openpic.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/openpic.c b/hw/openpic.c index 94a7807..9d22e9c 100644 --- a/hw/openpic.c +++ b/hw/openpic.c @

[Qemu-devel] [PATCH 02/15] openpic: lower interrupt when reading the MSI register

2012-12-21 Thread Scott Wood
This will stop things from breaking once it's properly treated as a level-triggered interrupt. Note that it's the MPIC's MSI cascade interrupts that are level-triggered; the individual MSIs are edge-triggered. Signed-off-by: Scott Wood --- hw/openpic.c |1 + 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH 2/2] xen: add missing include

2012-12-21 Thread Andreas Färber
Am 20.12.2012 12:29, schrieb Paolo Bonzini: > xen-all needs to access CharDeviceState's filename field, so > it needs to include char/char.h. > > Signed-off-by: Paolo Bonzini Tested-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,

Re: [Qemu-devel] trying to use -cpu qemu64, +hv_relaxed , get CPU feature hv_relaxed not found

2012-12-21 Thread Andreas Färber
Hi, Am 21.12.2012 11:47, schrieb Alexandre DERUMIER: > I'm trying to pass hyper-v feature, with -cpu qemu64,+hv_relaxed (qemu 1.3) > but I got an > > "CPU feature hv_relaxed not found" > > > Does this require an specific host kernel or host cpu feature support ? I believe it's -cpu qemu64,h

[Qemu-devel] [RFC][PATCH v2] add realtime option

2012-12-21 Thread Satoru Moriya
Changelog v1 -> v2 - add RFC tag again - change semantics as follows - set event threads' priority to maxprio - set vcpu threads' priority to maxprio - 1 - isolate all the posix stuff and put them into os_prioritize() in os-posix.c/qemu-os-win32.h to avoid breaking win32 build - introd

Re: [Qemu-devel] [PATCH 00/27] More source reorganization and build system TLC

2012-12-21 Thread Lluís Vilanova
Paolo Bonzini writes: [...] > Finally, patches 25 to 27 affect tracing, which is also moved to > libqemuutil.a. Patch 25 is Lluis's already posted patch to introduce > trace/Makefile.objs. I just skimmed through the patches, but is there a clean way to have files included only in binaries that ar

[Qemu-devel] [PULL 00/34] migration thread and queue

2012-12-21 Thread Juan Quintela
Hi Changes for last version: - inlined paolo fixes, attached here (they were very small, and only change error cases locking) - I tested with autotest and see no problems Please pull. Thanks, Juan. diff --git a/arch_init.c b/arch_init.c index 86f8544..ea75441 100644 --- a/arch_init.c +++ b/ar

Re: [Qemu-devel] [PATCH v7 4/8] trace: Provide a detailed event control interface

2012-12-21 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> This interface decouples event obtention from interaction. > Are you sure "obtention" is a word? :) Looks like a spanglish word escaped from my keyboard XD I'll wait for other comments before sending a new version. Thanks, Lluis --

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-21 Thread Scott Wood
On 12/21/2012 04:56:05 AM, Robert Schiele wrote: On Fri, Dec 21, 2012 at 9:56 AM, Gerd Hoffmann wrote: > I mean with --cross-prefix specifying the absolute location (so you > don't have to mess with PATH), why does that not work? He actually wrote already previously: The name is thrown into c

Re: [Qemu-devel] [PATCH 3/6] snapshot: design of common API to take snapshots

2012-12-21 Thread Juan Quintela
Wenchao Xia wrote: > + > +typedef struct SNTime { > +uint32_t date_sec; /* UTC date of the snapshot */ > +uint32_t date_nsec; This two fields are just struct timespec, does it makes sense to use it? > +uint64_t vm_clock_nsec; /* VM clock relative to boot */ > +} SNTime; > + > +typede

Re: [Qemu-devel] [PATCH 3/6] snapshot: design of common API to take snapshots

2012-12-21 Thread Eric Blake
On 12/16/2012 11:25 PM, Wenchao Xia wrote: > This patch added API to take snapshots in unified style for > both internal or external type. The core structure is based > on transaction, for that there is a qmp interface need to support > , qmp_transaction, so all operations are packed as requests.

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-21 Thread Juan Quintela
Wenchao Xia wrote: > This patch is the implemention of transaction based snapshot > internal API. Internal snapshot for specified block device > is added, which can be used as part of functionality in one way > to live full back up vm seperating internal block snapshot and > vmstate(vmstate goes

Re: [Qemu-devel] [PATCH] qemu-ga: Extend guest-network-get-interfaces

2012-12-21 Thread Eric Blake
On 12/21/2012 05:59 AM, Michal Privoznik wrote: > Nowadays only basic information is reported. However, with the > current implementation much more can be exposed to users. like > broadcast/destination address (the former in case of standard > ethernet device, the latter in case of PPP interface),

Re: [Qemu-devel] [RFC] lively write vmstate with predictable size

2012-12-21 Thread Juan Quintela
Wenchao Xia wrote: > resent the mail to mail-list. > --- > > Hi, Paolo and Juan > Currently savevm needs pause vm, and I am working on that make it > lively. Considering the flexibility I'd like to split out the > functions apart as following: > 1) snapshot lively internal/e

Re: [Qemu-devel] [PATCH 20/20] monitor: add commands to start/stop dirty bitmap

2012-12-21 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 55 +++ > blockdev.h | 1 + > hmp-commands.hx | 39 ++ > hmp.c| 27 +++ > hmp.

Re: [Qemu-devel] [PATCH 2/3] HMP: pass in parameter for info sub command

2012-12-21 Thread Eric Blake
On 12/21/2012 07:49 AM, Markus Armbruster wrote: >>> +static const mon_cmd_t *monitor_parse_command(Monitor *mon, >>> + const char *cmdline, >>> + const mon_cmd_t *table, >>> +

Re: [Qemu-devel] [PATCH 1/6] snapshot: export function in block.c

2012-12-21 Thread Juan Quintela
Wenchao Xia wrote: > This patch moves bdrv_snapshotfind from savevm.c to block.c and export > it, also added bdrv_deappend in block.c. I think this patch can be splitted in two: - new bdv_deappend - move bdrv_snapshot_find

[Qemu-devel] [PATCH 10/27] libcacard: use per-target variable definitions

2012-12-21 Thread Paolo Bonzini
This lets the libcacard Makefile use more rules.mak magic. Signed-off-by: Paolo Bonzini --- libcacard/Makefile |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index ddab5d8..7fc6a06 100644 --- a/libcacard/Makefile +++ b/libca

[Qemu-devel] [PATCH 09/27] libcacard: prepare to use -y trick in the Makefile

2012-12-21 Thread Paolo Bonzini
Rename variables to follow the conventions of the rest of the build systems. Signed-off-by: Paolo Bonzini --- libcacard/Makefile | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index a526eae..ddab5d8 100644 --- a/libcacard

Re: [Qemu-devel] [PULL 00/34] migration thread and queue

2012-12-21 Thread Juan Quintela
Juan Quintela wrote: > Anthony Liguori wrote: >> Juan Quintela writes: >> >>> Hi >>> >>> Changes for yesterday: >>> - Paolo Acked the series >>> - Rebaso on top of today git (only conflicts were due to header re-shuffle) >>> >>> Please pull. >>> >>> [20121219] >>> >>> This is my queue for migrat

[Qemu-devel] [PATCH 26/27] build: fold trace-obj-y into libqemuutil.a

2012-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile| 14 +++--- Makefile.objs | 10 ++ Makefile.target |1 - libcacard/Makefile |3 ++- tests/Makefile |8 trace/Makefile.objs | 10 +- 6 files changed, 20 insertions(+), 26 deleti

[Qemu-devel] [PATCH 13/27] libcacard: link vscclient to dynamic library

2012-12-21 Thread Paolo Bonzini
There is no reason for vscclient to duplicate the code. rules.mak takes care of invoking libtool to do the link. Signed-off-by: Paolo Bonzini --- libcacard/Makefile |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index 34ef3b4..

[Qemu-devel] [PATCH 06/27] build: remove CONFIG_SMARTCARD

2012-12-21 Thread Paolo Bonzini
The passthru smartcard does not have the shared library dependency, build it unconditionally. Signed-off-by: Paolo Bonzini --- configure| 67 ++--- hw/Makefile.objs |2 +- hw/usb/Makefile.objs |2 +- 3 files changed, 27 insert

[Qemu-devel] [PATCH 11/27] libcacard: add list of exported symbols

2012-12-21 Thread Paolo Bonzini
Do not export internal QEMU symbols. Signed-off-by: Paolo Bonzini --- libcacard/Makefile |3 +- libcacard/libcacard.syms | 77 ++ 2 files changed, 79 insertions(+), 1 deletions(-) create mode 100644 libcacard/libcacard.syms diff --git a/l

[Qemu-devel] [PATCH 17/27] build: move files away from tools-obj-y, common-obj-y, user-obj-y

2012-12-21 Thread Paolo Bonzini
Split them between libqemuutil.a and, for those used by qemu-img/io/nbd, block-obj-y. Static libraries ensure that binaries such as qemu-ga do not include unused modules. Signed-off-by: Paolo Bonzini --- Makefile | 10 +++--- Makefile.objs | 39 +++

[Qemu-devel] [PATCH 12/27] libcacard: rewrite Makefile in non-recursive style

2012-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile | 35 +-- configure |9 + libcacard/Makefile | 33 + 3 files changed, 19 insertions(+), 58 deletions(-) diff --git a/Makefile b/Makefile index 68e3a83..92f

[Qemu-devel] [PATCH 21/27] build: move QAPI definitions for QEMU out of qapi-obj-y

2012-12-21 Thread Paolo Bonzini
There is no reason why for example qemu-ga should include all the definitions for the QEMU monitor. However, there are a few that are needed (qapi_free_SocketAddress, qapi_free_InetSocketAddress, ErrorClass_lookup). These should be moved to a separate "core" .json schema that goes into libqemuuti

[Qemu-devel] [PATCH 07/27] libcacard: fix missing symbol in libcacard.so

2012-12-21 Thread Paolo Bonzini
From: Alon Levy Before patch: $ make libcacard.la $ nm ./libcacard/.libs/libcacard.so.0.0.0 | grep " U " | \ egrep -v "(g_)|(GLIBC)|(SECMOD)|(PK11)|(CERT)|(NSS)|(PORT)|(PR)" U error_set Signed-off-by: Alon Levy Signed-off-by: Paolo Bonzini --- libcacard/Makefile |2 +-

[Qemu-devel] [PATCH 05/27] build: move dtrace rules to rules.mak

2012-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs |8 rules.mak |9 + 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 346bf9d..7858c4e 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -169,14 +169,6 @@ trace-dtrace.dtra

[Qemu-devel] [PATCH 16/27] build: move util-obj-y to libqemuutil.a

2012-12-21 Thread Paolo Bonzini
Use a static library to eliminate repetition in the linking rules. Signed-off-by: Paolo Bonzini --- Makefile| 17 + Makefile.objs |1 - Makefile.target |8 tests/Makefile | 17 - 4 files changed, 21 insertions(+), 22 deletions(-) d

[Qemu-devel] [PATCH 08/27] libcacard: require libtool to build it

2012-12-21 Thread Paolo Bonzini
Do not fail at build time, instead just disable the library if libtool is not present. Signed-off-by: Paolo Bonzini --- Makefile |2 ++ configure |3 ++- libcacard/Makefile |8 rules.mak |6 +- 4 files changed, 5 insertions(+), 14 deletion

[Qemu-devel] [PATCH 02/27] stubs: fully replace qemu-tool.c and qemu-user.c

2012-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile |2 +- Makefile.objs |3 +- exec.c |2 +- qemu-tool.c| 115 qemu-user.c| 37 -- stubs/Makefile.objs

[Qemu-devel] [PATCH 04/27] build: support linking with libtool objects/libraries

2012-12-21 Thread Paolo Bonzini
This patch moves the complication of using libtool to the generic rules.mak file. Signed-off-by: Paolo Bonzini --- configure |8 +++- libcacard/Makefile | 11 +++ rules.mak | 10 -- 3 files changed, 22 insertions(+), 7 deletions(-) diff --git a/conf

[Qemu-devel] [PATCH 24/27] build: remove coroutine-obj-y

2012-12-21 Thread Paolo Bonzini
Just fold it into block-obj-y. Signed-off-by: Paolo Bonzini --- Makefile.objs | 29 + 1 files changed, 13 insertions(+), 16 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 60da50e..9713538 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -4,32 +4,29

[Qemu-devel] [PATCH 27/27] build: improve quiet output for .stp rules

2012-12-21 Thread Paolo Bonzini
Mention the directory in which the .stp file is being generated. Signed-off-by: Paolo Bonzini --- Makefile.target |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.target b/Makefile.target index 9cbe6fe..2c28f54 100644 --- a/Makefile.target +++ b/Makefile.target

[Qemu-devel] [PATCH 19/27] build: move qobject files to qobject/ and libqemuutil.a

2012-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile |2 +- Makefile.objs | 17 +++-- qobject/Makefile.objs |3 +++ json-lexer.c => qobject/json-lexer.c |0 json-parser.c => qobject/json-parse

[Qemu-devel] [PATCH 25/27] build: Use separate makefile for "trace/"

2012-12-21 Thread Paolo Bonzini
From: Lluís Vilanova Signed-off-by: Lluís Vilanova Signed-off-by: Paolo Bonzini --- .gitignore |8 ++-- Makefile| 15 +--- Makefile.objs | 57 ++ Makefile.target

[Qemu-devel] [PATCH 22/27] build: move base QAPI files to libqemuutil.a

2012-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile |2 +- Makefile.objs |9 ++--- qapi/Makefile.objs |8 tests/Makefile |3 +-- 4 files changed, 8 insertions(+), 14 deletions(-) diff --git a/Makefile b/Makefile index a1e9fe0..06b3ad5 100644 --- a/Makefile +

[Qemu-devel] [PATCH 20/27] build: consolidate multiple variables into universal-obj-y

2012-12-21 Thread Paolo Bonzini
The directory descent mechanism, and a less-flat tree both helped in making some *-obj-y definitions very short. Many of these often end up in universal-obj-y, and used to be separate only because of libuser (which is now part of history...). Consolidate these variables in a single one. Signed-o

[Qemu-devel] [PATCH 23/27] build: move version-obj-y to the generic LINK rule

2012-12-21 Thread Paolo Bonzini
There is no reason for it to be in block-obj-y, in particular. Signed-off-by: Paolo Bonzini --- Makefile |2 +- Makefile.objs |3 +-- rules.mak |4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 06b3ad5..ce87375 100644 --- a/Mak

[Qemu-devel] [PATCH 14/27] libcacard: list oslib-obj-y file explicitly

2012-12-21 Thread Paolo Bonzini
We will grow the list of files in the next patches, but libcacard should remain slim. Signed-off-by: Paolo Bonzini --- libcacard/Makefile |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index 63d82f4..7e26082 100644 --- a/libc

[Qemu-devel] [PATCH 18/27] build: move libqemuutil.a components to util/

2012-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs | 12 ++-- libcacard/Makefile |6 +++--- util/Makefile.objs | 10 ++ acl.c => util/acl.c|

[Qemu-devel] [PATCH 15/27] build: rename oslib-obj-y to util-obj-y

2012-12-21 Thread Paolo Bonzini
This prepares the creation of libqemuutil.a in the next patch. Signed-off-by: Paolo Bonzini --- Makefile|4 ++-- Makefile.objs | 10 +- Makefile.target |4 ++-- tests/Makefile |2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/Makefile b/Make

[Qemu-devel] [PATCH 01/27] qemu-option: move standard option definitions out of qemu-config.c

2012-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/iscsi.c | 27 ++ blockdev.c | 118 fsdev/Makefile.objs|1 + fsdev/qemu-fsdev-dummy.c |7 - fsdev/qemu-fsdev-opts.c| 85 ++ fsdev/qemu-fsdev.c |8 - hw/qdev-monitor.c |

[Qemu-devel] [PATCH 03/27] build: make libtool verbose when making with V=1

2012-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- libcacard/Makefile |2 +- rules.mak |3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index c26aac6..9fa109f 100644 --- a/libcacard/Makefile +++ b/libcacard/Makefile @@ -36,7 +36,7 @@ in

[Qemu-devel] [PATCH 00/27] More source reorganization and build system TLC

2012-12-21 Thread Paolo Bonzini
Here is a light version of the source reorganization I proposed last September. While working on it I noticed that a useful part to start from was the utility routines, because this helps identifying missing unit tests and modularity problems. Also, this file are relatively rarely changed. Hence

Re: [Qemu-devel] [PATCH] pci-assign: Enable MSIX on device to match guest

2012-12-21 Thread Alex Williamson
On Fri, 2012-12-21 at 14:17 +0200, Michael S. Tsirkin wrote: > On Thu, Dec 20, 2012 at 03:15:38PM -0700, Alex Williamson wrote: > > On Thu, 2012-12-20 at 18:38 +0200, Michael S. Tsirkin wrote: > > > On Thu, Dec 20, 2012 at 09:05:50AM -0700, Alex Williamson wrote: > > > > When a guest enables MSIX o

Re: [Qemu-devel] [PATCH] vfio-pci: Make host MSI-X enable track guest

2012-12-21 Thread Alex Williamson
On Fri, 2012-12-21 at 14:21 +0200, Michael S. Tsirkin wrote: > On Thu, Dec 20, 2012 at 03:12:46PM -0700, Alex Williamson wrote: > > On Thu, 2012-12-20 at 18:36 +0200, Michael S. Tsirkin wrote: > > > On Thu, Dec 20, 2012 at 09:06:41AM -0700, Alex Williamson wrote: > > > > Guests typically enable MSI

Re: [Qemu-devel] [PATCH 2/3] HMP: pass in parameter for info sub command

2012-12-21 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 19 Dec 2012 18:17:09 +0800 > Wenchao Xia wrote: > >> This patch enable sub info command handler getting meaningful >> parameter. >> >> Signed-off-by: Wenchao Xia >> --- >> hmp-commands.hx |2 +- >> monitor.c | 79 >>

[Qemu-devel] Some questions about memory access-----target_mmap()&how can write one byte into memory

2012-12-21 Thread qi Lee
Hi all If I already have an emulator, all instructions have been carried out. In order to reuse these codes on the other simulation platforms, as Simics, QEMU, SystemC. So, I want to skip over QEMU's TCG(guest binary-->IR-->host binary). Just let QEMU controll the cpu's execution and the cpu ac

Re: [Qemu-devel] [PULL 00/34] migration thread and queue

2012-12-21 Thread Paolo Bonzini
Il 21/12/2012 01:27, Anthony Liguori ha scritto: > #!/bin/sh > > gzip -d -c lidb.ssmall.img.gz | \ > ~/build/qemu/x86_64-softmmu/qemu-system-x86_64 -cdrom \ > ~/isos/OCDC-lucid-Test-Drive-20110523_140333.iso -enable-kvm -m 2G \ > -incoming exec:dd > > With lidb.ssmall.img.gz being gen

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-21 Thread Gerd Hoffmann
Hi, >> ... and can't see what is wrong there ... > > Me neither, but this quick test seems to work here: Test works for me too. Bug turned out to be elsewhere: args_type in qmp-commands.hx not set correctly ... cheers, Gerd

Re: [Qemu-devel] [PULL 00/34] migration thread and queue

2012-12-21 Thread Anthony Liguori
Anthony Liguori writes: > Juan Quintela writes: > >> Hi >> >> Changes for yesterday: >> - Paolo Acked the series >> - Rebaso on top of today git (only conflicts were due to header re-shuffle) >> >> Please pull. >> >> [20121219] >> >> This is my queue for migration-thread and patches associated.

Re: [Qemu-devel] [PATCH 3/3] HMP: show internal snapshots on a single device

2012-12-21 Thread Markus Armbruster
Wenchao Xia writes: > This patch add an option to show snapshots on a single block > device, so some snapshot do not exist on other block device > could be shown. > > Signed-off-by: Wenchao Xia > --- > monitor.c |6 +++--- > savevm.c | 55 +++

[Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2012-12-21 Thread Jason J. Herne
From: "Jason J. Herne" Modify syncing algorithm in do_kvm_cpu_synchronize_state to avoid overwriting previously synced register data by calling do_kvm_cpu_synchronize_state twice. The problem occurs if the following sequence of events occurs: 1. kvm_arch_get_registers(env, KVM_REGSYNC_RUNTIME_ST

Re: [Qemu-devel] [PATCH 1/3] HMP: add QDict to info callback handler

2012-12-21 Thread Markus Armbruster
Wenchao Xia writes: > This patch change all info call back function to take > additional QDict * parameter, which allow those command > take parameter. [...] > diff --git a/monitor.c b/monitor.c > index c0e32d6..797680f 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -123,7 +123,7 @@ typedef st

[Qemu-devel] [PATCH 5/7] KVM regsync: Add register level parameter to cpu_synchronize_state

2012-12-21 Thread Jason J. Herne
From: "Jason J. Herne" cpu_synchronize_state is updated to take/propagate the register level parameter. All callers are modified to specify the runtime state. Signed-off-by: Jason J. Herne Reviewed-by: Christian Borntraeger --- cpus.c |4 ++-- dump.c |

[Qemu-devel] [PATCH 4/7] KVM regsync: Add register level parameter to kvm_cpu_synchronize_state

2012-12-21 Thread Jason J. Herne
From: "Jason J. Herne" kvm_cpu_synchronize_state is updated to take/propagate the register level parameter. All callers are modified to specify the runtime state. Signed-off-by: Jason J. Herne Reviewed-by: Christian Borntraeger --- hw/spapr_rtas.c |2 +- include/sysemu/kvm.h |4 +

[Qemu-devel] [PATCH 6/7] KVM regsync: S390 Relax register synchronization parameters

2012-12-21 Thread Jason J. Herne
From: "Jason J. Herne" Some S390 code paths do not need to synchronize the full register state. This patch changes those paths to only synchronize the runtime register set. Signed-off-by: Jason J. Herne Reviewed-by: Christian Borntraeger --- target-s390x/kvm.c |6 +++--- 1 file changed, 3

[Qemu-devel] [PATCH 3/7] KVM regsync: Add register level parameter to do_kvm_cpu_synchronize_state

2012-12-21 Thread Jason J. Herne
From: "Jason J. Herne" do_kvm_cpu_synchronize_state is called via run_on_cpu, so we can only pass a single argument. Create SyncStateArgs struct for this purpose and add register level data member to it. Signed-off-by: Jason J. Herne Reviewed-by: Christian Borntraeger --- include/sysemu/kvm.

[Qemu-devel] [PATCH 0/7] KVM regsync

2012-12-21 Thread Jason J. Herne
Note: This is rework for the patch set previously submitted: "s390/migration: Provide a cpu save for initial life migration work" http://lists.nongnu.org/archive/html/qemu-devel/2012-11/msg02203.html Rework the method used to synchronize CPU registers between Qemu & KVM. This patch set extends k

[Qemu-devel] [PATCH 2/7] KVM regsync: Add register level parameter to kvm_arch_get_registers

2012-12-21 Thread Jason J. Herne
From: "Jason J. Herne" Modify kvm_arch_get_registers interface such that it expects a register level parameter. Also modify the only caller of kvm_arch_get_registers such that it passes an appropriate level. The idea here is that, for all currently existing calls we want to do nothing different

[Qemu-devel] [PATCH 1/7] KVM regsync: Rename KVM_PUT_ constants to KVM_REGSYNC_

2012-12-21 Thread Jason J. Herne
From: "Jason J. Herne" It makes sense to rename these to KVM_REGSYNC in order to use them for specifying a register level parameter for both kvm_arch_put_registers and kvm_arch_get_registers. Signed-off-by: Jason J. Herne Reviewed-by: Christian Borntraeger --- include/sysemu/kvm.h | 10

Re: [Qemu-devel] [PATCH v7 4/8] trace: Provide a detailed event control interface

2012-12-21 Thread Markus Armbruster
Lluís Vilanova writes: > This interface decouples event obtention from interaction. Are you sure "obtention" is a word? :) > Events can be obtained through three different methods: > > * identifier > * name > * simple wildcard pattern

Re: [Qemu-devel] [PATCH 10/20] target-i386: prepare cpu_x86_parse_featurestr() to return a set of key, value property pairs

2012-12-21 Thread Eduardo Habkost
On Fri, Dec 21, 2012 at 01:56:56AM +0100, Igor Mammedov wrote: [...] > > All above said, I am not strongly against your approach, but I believe > > we could try to make the feature string parsing code generic and > > reusable (with target-specific properties or callbacks), instead of > > having to

Re: [Qemu-devel] [PULL 00/34] migration thread and queue

2012-12-21 Thread Paolo Bonzini
Il 21/12/2012 14:39, Anthony Liguori ha scritto: > Do you think this would cause the behavior I've seen? Not clear to me. No idea, the first two hunks however are locking fixes, who knows what they might cause. Paolo

Re: [Qemu-devel] [PULL 00/34] migration thread and queue

2012-12-21 Thread Anthony Liguori
Paolo Bonzini writes: > Il 21/12/2012 02:39, Juan Quintela ha scritto: >>> I can't bisect tonight but can attempt to tomorrow. How has this been >>> tested? >> >> I have tested with tcp, load/not-load with guests form 4GB to 16GB RAM. >> Will test tomorrow with your test case. I didn't tested

Re: [Qemu-devel] [PULL 00/34] migration thread and queue

2012-12-21 Thread Anthony Liguori
Juan Quintela writes: > Juan Quintela wrote: >> Anthony Liguori wrote: >>> Juan Quintela writes: >>> Hi Changes for yesterday: - Paolo Acked the series - Rebaso on top of today git (only conflicts were due to header re-shuffle) Please pull. [2012121

Re: [Qemu-devel] [PULL 00/34] migration thread and queue

2012-12-21 Thread Juan Quintela
Paolo Bonzini wrote: > Il 21/12/2012 02:39, Juan Quintela ha scritto: >>> I can't bisect tonight but can attempt to tomorrow. How has this been >>> tested? >> >> I have tested with tcp, load/not-load with guests form 4GB to 16GB RAM. >> Will test tomorrow with your test case. I didn't tested ex

[Qemu-devel] [announce] qemu firmware repo

2012-12-21 Thread Gerd Hoffmann
Hi, yum repository with fresh qemu firmware builds is available now: http://www.kraxel.org/repos/ Provides rpms with seabios, tianocore (efi), coreboot and ipxe binaries. enjoy, Gerd PS: /me will disappear into xmas season shortly, so any issues will have to wait 'til next year. je

[Qemu-devel] [PATCH] qemu-ga: Extend guest-network-get-interfaces

2012-12-21 Thread Michal Privoznik
Nowadays only basic information is reported. However, with the current implementation much more can be exposed to users. like broadcast/destination address (the former in case of standard ethernet device, the latter in case of PPP interface), if the interface is up, of type loopback, in promisc mod

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-21 Thread Paolo Bonzini
Il 21/12/2012 13:17, Gerd Hoffmann ha scritto: > { 'type': 'ChardevDummy', 'data': { } } > > { 'union': 'ChardevBackend', 'data': { 'file' : 'ChardevFile', >'port' : 'ChardevPort', >'socket' : 'ChardevSocket', >

Re: [Qemu-devel] [PULL 00/34] migration thread and queue

2012-12-21 Thread Paolo Bonzini
Il 21/12/2012 02:39, Juan Quintela ha scritto: >> I can't bisect tonight but can attempt to tomorrow. How has this been >> tested? > > I have tested with tcp, load/not-load with guests form 4GB to 16GB RAM. > Will test tomorrow with your test case. I didn't tested exec:, though. > >> >> I'm a l

Re: [Qemu-devel] [PULL 00/34] migration thread and queue

2012-12-21 Thread Juan Quintela
Juan Quintela wrote: > Anthony Liguori wrote: >> Juan Quintela writes: >> >>> Hi >>> >>> Changes for yesterday: >>> - Paolo Acked the series >>> - Rebaso on top of today git (only conflicts were due to header re-shuffle) >>> >>> Please pull. >>> >>> [20121219] >>> >>> This is my queue for migrat

Re: [Qemu-devel] [PATCH] vfio-pci: Make host MSI-X enable track guest

2012-12-21 Thread Michael S. Tsirkin
On Thu, Dec 20, 2012 at 03:12:46PM -0700, Alex Williamson wrote: > On Thu, 2012-12-20 at 18:36 +0200, Michael S. Tsirkin wrote: > > On Thu, Dec 20, 2012 at 09:06:41AM -0700, Alex Williamson wrote: > > > Guests typically enable MSI-X with all of the vectors in the MSI-X > > > vector table masked. O

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-21 Thread Gerd Hoffmann
On 12/21/12 12:53, Paolo Bonzini wrote: > Il 21/12/2012 12:45, Gerd Hoffmann ha scritto: >> On 12/20/12 14:02, Gerd Hoffmann wrote: >>> Hi, >>> /me wades through the socket code (unix+tcp) right now, which needs some refactoring to make it fly. >>> >>> Sneak preview attached. Goes on t

Re: [Qemu-devel] [PATCH] pci-assign: Enable MSIX on device to match guest

2012-12-21 Thread Michael S. Tsirkin
On Thu, Dec 20, 2012 at 03:15:38PM -0700, Alex Williamson wrote: > On Thu, 2012-12-20 at 18:38 +0200, Michael S. Tsirkin wrote: > > On Thu, Dec 20, 2012 at 09:05:50AM -0700, Alex Williamson wrote: > > > When a guest enables MSIX on a device we evaluate the MSIX vector > > > table, typically find no

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-21 Thread Paolo Bonzini
Il 21/12/2012 12:45, Gerd Hoffmann ha scritto: > On 12/20/12 14:02, Gerd Hoffmann wrote: >> Hi, >> >>> /me wades through the socket code (unix+tcp) right now, which needs some >>> refactoring to make it fly. >> >> Sneak preview attached. Goes on top of the series. >> Compile tested only so far.

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-21 Thread Gerd Hoffmann
On 12/20/12 14:02, Gerd Hoffmann wrote: > Hi, > >> /me wades through the socket code (unix+tcp) right now, which needs some >> refactoring to make it fly. > > Sneak preview attached. Goes on top of the series. > Compile tested only so far. Now that it comes to testing: how does the union look

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-21 Thread Robert Schiele
On Fri, Dec 21, 2012 at 9:56 AM, Gerd Hoffmann wrote: > I mean with --cross-prefix specifying the absolute location (so you > don't have to mess with PATH), why does that not work? He actually wrote already previously: The name is thrown into config.sub, which obviously is confused about this str

[Qemu-devel] trying to use -cpu qemu64, +hv_relaxed , get CPU feature hv_relaxed not found

2012-12-21 Thread Alexandre DERUMIER
Hi list, I'm trying to pass hyper-v feature, with -cpu qemu64,+hv_relaxed (qemu 1.3) but I got an "CPU feature hv_relaxed not found" Does this require an specific host kernel or host cpu feature support ? Regards, Alexandre Derumier

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-21 Thread Daniel P. Berrange
On Fri, Dec 21, 2012 at 10:01:46AM +0100, Gerd Hoffmann wrote: > Hi, > > >> pty looks like another non-trivial challenge. How does libvirt gather > >> the pty device today? IIRC there is some stderr parsing? Or was it > >> info chardev? With QMP we probably want switch to a more sane model >

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-21 Thread Gerd Hoffmann
Hi, >> pty looks like another non-trivial challenge. How does libvirt gather >> the pty device today? IIRC there is some stderr parsing? Or was it >> info chardev? With QMP we probably want switch to a more sane model >> here ... > > Yes, these days we use info chardev, or query-chardev as

[Qemu-devel] [PATCH] net: add missing include file

2012-12-21 Thread Liming Wang
To fix building error: CCnet/vde.o net/vde.c: In function ‘vde_cleanup’: net/vde.c:65:5: error: implicit declaration of function ‘qemu_set_fd_handler’ [-Werror=implicit-function-declaration] net/vde.c:65:5: error: nested extern declaration of ‘qemu_set_fd_handler’ [-Werror=nested-externs] cc

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-21 Thread Gerd Hoffmann
On 12/20/12 17:19, Scott Wood wrote: > On 12/20/2012 12:59:05 AM, Gerd Hoffmann wrote: >> Hi, >> >> >> Why do you need this? Any tools not picked up correctly if you don't >> >> set the PATH? Which ones? >> > >> > If I don't set the PATH for configure then I get this: >> > ERROR: "powerpc-linux

  1   2   >