On 12/21/2012 05:59 AM, Michal Privoznik wrote: > Nowadays only basic information is reported. However, with the > current implementation much more can be exposed to users. like > broadcast/destination address (the former in case of standard > ethernet device, the latter in case of PPP interface), if the > interface is up, of type loopback, in promisc mode or capable of > sending multicast. > --- >
> +++ b/qga/qapi-schema.json
> @@ -480,26 +480,57 @@
> #
> # @prefix: Network prefix length of @ip-address
> #
> -# Since: 1.1
> +# @dest-address: The broadcast or peer address.
> +#
> +# Since: 1.1, @dest-address since 1.3
Actually, since 1.4 now (1.3 is already out).
> ##
> { 'type': 'GuestIpAddress',
> 'data': {'ip-address': 'str',
> 'ip-address-type': 'GuestIpAddressType',
> - 'prefix': 'int'} }
> + 'prefix': 'int',
> + '*dest-address': 'str'} }
Is this field always going to be present in 1.4? If so, then it doesn't
need to be marked optional (even though it wasn't present in 1.3).
> ##
> +# @GuestNetworkInterfaceType:
> +#
> +# @broadcast: Interface has a broadcast address. In which case it is
> +# contained in @dest-address in @GuestIpAddress.
> +#
> +# @ppp: Interface is of point-to-point type. The peer address is then in
> +# @dest-address in @GuestIpAddress.
> +#
> +# Since: 1.3
1.4
> +##
> +{ 'enum': 'GuestNetworkInterfaceType',
> + 'data': ['broadcast', 'ppp'] }
> +##
> # @GuestNetworkInterface:
> #
> # @name: The name of interface for which info are being delivered
> #
> +# @up: If the interface is up
> +#
> +# @loopback: If the interface is of loopback type
> +#
> +# @promisc: If the interface is in promiscuous mode
> +#
> +# @multicast: If the interface is cappable of multicast
s/cappable/capable/
> +#
> +# @type: If the interface has a broadcast address(-es) assigned, or is a PPP.
> +#
> # @hardware-address: Hardware address of @name
> #
> # @ip-addresses: List of addresses assigned to @name
> #
> -# Since: 1.1
> +# Since: 1.1, @up, @loopback, @promisc, @multicast and @type since 1.3
1.4
> ##
> { 'type': 'GuestNetworkInterface',
> 'data': {'name': 'str',
> + 'up': 'bool',
> + 'loopback': 'bool',
> + 'promisc': 'bool',
> + 'multicast': 'bool',
> + '*type': 'GuestNetworkInterfaceType',
Again, is this field optional?
> '*hardware-address': 'str',
> '*ip-addresses': ['GuestIpAddress'] } }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
