On 12/21/2012 07:49 AM, Markus Armbruster wrote: >>> +static const mon_cmd_t *monitor_parse_command(Monitor *mon, >>> + const char *cmdline, >>> + const mon_cmd_t *table, >>> + QDict *qdict); >> >> Please, move the function instead. > > Move will make review harder. I don't mind forward declarations.
If you do move the function, then split this into two patches - one for JUST the code motion, and another that adds the 'table' argument to the function. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
