rule if it is really enabled.
Signed-off-by: Dominic Jäger
---
v1->v2: Thank you for the feedback, Dominik!
- The 10 top margin was intentional, but using 'auto' is better I think.
It has in my tests avoided that the field randomly sticks to the top without
breaking the rest o
Fixup for #2815: The existence of a rule alone should NOT yet trigger the
warning. Only if it is enabled but the whole firewall for that level is not.
Signed-off-by: Dominic Jäger
---
Didn't exist in v1. Not sure if we want this. If yes you can just apply both or
squash. Of course, I can
if it is really enabled.
Signed-off-by: Dominic Jäger
---
www/manager6/grid/FirewallRules.js | 32 --
1 file changed, 30 insertions(+), 2 deletions(-)
diff --git a/www/manager6/grid/FirewallRules.js
b/www/manager6/grid/FirewallRules.js
index ec2d1c84..7cb2baf0 100644
On Sat, Jun 06, 2020 at 07:56:20PM +0200, Thomas Lamprecht wrote:
> On 5/22/20 12:08 PM, Dominic Jäger wrote:
> > I'd appreciate a few hints for the importdisk GUI feature.
> >
> > Yes or no to automatically adding the drive as active (not unused)?
>
> Well
The literal usage of "qcow2+size" as well as what the command is supposed to do
has confused users [0].
[0]
https://forum.proxmox.com/threads/trying-to-convert-raw-disk-to-vmdk-using-pvesm.70046/
---
It has also confused me and I think some other devs, too.
pvesm.adoc | 8
1 file chang
---
PVE/CLI/pvesm.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm
index 30bdcf6..8c86714 100755
--- a/PVE/CLI/pvesm.pm
+++ b/PVE/CLI/pvesm.pm
@@ -204,7 +204,7 @@ __PACKAGE__->register_method ({
name => 'export',
path => 'expo
Is it a bad idea to move column2 as I did here? Seems strange to have column1
and 2 so different but I haven't found an easier way to make it available to
the subclass yet.
@Thomas Is this sort of what you had in mind for this feature?
Signed-off-by: Dominic Jäger
---
www/manager6/Mak
I'd appreciate a few hints for the importdisk GUI feature.
Yes or no to automatically adding the drive as active (not unused)?
Signed-off-by: Dominic Jäger
---
PVE/API2/Qemu.pm | 87 +++-
PVE/CLI/qm.pm| 57 +--
Add a radiobox to the settings to control if search should be done recursively
as default or not. Set to no recursion as default.
Signed-off-by: Dominic Jäger
---
v2: Like patch 2/3
www/manager6/storage/ContentView.js | 6 +++--
www/manager6/window/Settings.js | 38
his search.
Signed-off-by: Dominic Jäger
---
v2:
Adapt to Alwin's zstd patch
- Adapt tests
- Use file::stat
Dominik's Feedback
- Regex: Fix rule for double dots, no useless ORs, ? instead of *
- No full sub for recursion
- No unfamiliar names like 'notdir'
- Syntax: Mo
Default is no recursion.
This commit depends on "Recursive search for iso and vztmpl" in pve-storage.
Signed-off-by: Dominic Jäger
---
v2: Dominik's Feedback
- Use helper function for url => No more strange casts
- Template string
- Better separation of patches
ww
On Fri, May 08, 2020 at 01:37:37PM +0200, Thomas Lamprecht wrote:
> viewModel approach hiding all fields for this mode.
As I was the one complaining: In my opinion this solution looks a lot cleaner
than the glitchy line :)
___
pve-devel mailing list
pve
Thank you for merging the test files!
Love the dropdown to set a compression:
GZIP (good)
ZSTD (better)
Tests work and creating and restoring backups in the GUI with the new option,
too.
Tested-by: Dominic Jäger
On Wed, Apr 22, 2020 at 04:57:51PM +0200, Alwin Antreich wrote:
> Zstand
I like it. Having for example one $mocked_vmlist is clean.
Two ideas for further testing (in the future):
- Passing only a subset of $types to list_volumes
- Unintended situations, like when $mocked_vmlist has a VM without type =>
list_volumes roughly does if (defined($type) && $type eq 'lxc')
Move wipe_disks from PVE::Ceph::Tools to PVE::Diskmanage.
Relies on the corresponding patch in pve-storage.
Signed-off-by: Dominic Jäger
---
v3->v4: unchanged
v2->v3: unchanged
v1->v2: Fix syntax
To test this we need an OSD that is not managed by ceph-volume:
- Create a PVE 5 VM
Move wipe_disks from PVE::Ceph::Tools to PVE::Diskmanage and improve it by
- Handling invalid parameters
- Adding options for wiping
- Making names clearer
- Adding tests
Relies on the corresponding patch in pve-manager.
Signed-off-by: Dominic Jäger
---
v3->v4:
- Die more often
- M
Some leftovers are not detected by our "is disk in use" checks.
Signed-off-by: Dominic Jäger
---
v3->v4: Unchanged
v2->v3: Unchanged
v1->v2: Use new wipefs parameter
PVE/API2/Disks/Directory.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/PVE/API2/Disks/Directory.
Thank you for taking a look!
Most makes sense to me and is already changed.
On Wed, Apr 15, 2020 at 11:28:34AM +0200, Fabian Grünbichler wrote:
>
> > + if ($max_amount !~ /^[0-9]+$/);
>
> \d instead of [0-9]
This was \d previously. However, it was recommended to me to change it to [0-9]
in v2
pve-guest-common got a new log line [0] for rate and transport type of a
replication. This line must be added to the replication tests.
[0] e90f586aab5caad4d4c5e18711316e8dc5225c07
Signed-off-by: Dominic Jäger
---
Or did I miss something? Without this checks in pve-manager seem to fail with
pve
On Thu, Apr 09, 2020 at 09:37:37AM +0200, Alwin Antreich wrote:
> On Thu, Apr 02, 2020 at 01:34:11PM +0200, Dominic Jäger wrote:
> > Signed-off-by: Dominic Jäger
> > +
> > +is (($plugin->parse_volname($iso_volname))[$type_index],
> > +$iso_type, 'par
his search.
Signed-off-by: Dominic Jäger
---
Changes since RFC:
* Separate tests for existing and new stuff into 2 patches
* Die when .. appears in a path
* Make feature opt-in (relevant for symlinks)
PVE/API2/Storage/Content.pm | 9 +++-
PVE/API2/Storage/Status.pm | 12 +++---
PVE/Storage.pm
Signed-off-by: Dominic Jäger
---
This did not exist separately in RFC
test/Makefile| 5 +-
test/run_plugin_tests.pl | 184 +++
2 files changed, 188 insertions(+), 1 deletion(-)
create mode 100755 test/run_plugin_tests.pl
diff --git a/test
Default is no recursion.
This commit depends on "Recursive search for iso and vztmpl" in pve-storage.
Signed-off-by: Dominic Jäger
---
Changes since RFC:
* [0] became obsolte
* This did not exist in RFC
[0] https://pve.proxmox.com/pipermail/pve-devel/2019-December/040886.html
ww
Add a radiobox to the settings to control if search should be done recursively
as default or not. Set to no recursion as default.
Signed-off-by: Dominic Jäger
---
This did not exist in RFC
www/manager6/storage/ContentView.js | 2 +-
www/manager6/window/Settings.js | 38
=d1eb35ea74cf27713625ab7e7c3767a8254a4aee
Signed-off-by: Dominic Jäger
---
PVE/Storage/GlusterfsPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/Storage/GlusterfsPlugin.pm b/PVE/Storage/GlusterfsPlugin.pm
index 2cf2da9..70ea4fc 100644
--- a/PVE/Storage/GlusterfsPlugin.pm
+++ b/PVE/Storage
nd 4 "Node" options in the GUI the
correct guests and their disks were included in the backup according the the
log output.
Tested-by: Dominic Jäger
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Also print the reason why the function vma_writer_register_stream failed to
help debug errors like in [0].
[0]
https://forum.proxmox.com/threads/backup-error-vma_writer_register_stream-drive-scsi0-failed-pve-6-1-7.65925/
Signed-off-by: Dominic Jäger
---
.../0029-PVE-Backup-add-vma-backup
Move wipe_disks from PVE::Ceph::Tools to PVE::Diskmanage.
Relies on the corresponding patch in pve-storage.
Signed-off-by: Dominic Jäger
---
v2->v3: unchanged
v1->v2: Fix syntax
To test this we need an OSD that is not managed by ceph-volume:
- Create a PVE 5 VM
- Install Ceph Lu
Some leftovers are not detected by our "is disk in use" checks.
Signed-off-by: Dominic Jäger
---
v2->v3: Unchanged
v1->v2: Use new wipefs parameter
PVE/API2/Disks/Directory.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/PVE/API2/Disks/Directory.pm b/PVE/API2/Disks/Di
Move wipe_disks from PVE::Ceph::Tools to PVE::Diskmanage and improve it by
- Handling invalid parameters
- Adding options for wiping
- Making names clearer
- Adding tests
Relies on the corresponding patch in pve-manager.
Signed-off-by: Dominic Jäger
---
v2->v3:
- Relative instead of f
From Ceph Nautilus onwards reducing the number of placement groups is possible.
Signed-off-by: Dominic Jäger
---
v1->v2:
- s/later/later on/
- use {ceph_codename}
Thank you, Alwin!
pveceph.adoc | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/pveceph.ado
From Ceph Nautilus onwards reducing the amount of placement groups is possible.
Signed-off-by: Dominic Jäger
---
@Aaron: Thank you for the hint!
@Alwin: Please complain if I understood something wrong here.
pveceph.adoc | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a
Some leftovers are not detected by our "is disk in use" checks.
Signed-off-by: Dominic Jäger
---
v1->v2: Use new wipefs parameter
PVE/API2/Disks/Directory.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/PVE/API2/Disks/Directory.pm b/PVE/API2/Disks/Directory.pm
index 2de
- Adding tests
Relies on the corresponding patch in pve-manager.
Signed-off-by: Dominic Jäger
---
v1->v2:
- Fix typo
- Not only move the function but also improve it
PVE/Diskmanage.pm | 63 ++
test/disklist_test.pm |
Move wipe_disks from PVE::Ceph::Tools to PVE::Diskmanage.
Relies on the corresponding patch in pve-storage.
Signed-off-by: Dominic Jäger
---
v1->v2: Fix syntax
To test this we need an OSD that is not managed by ceph-volume:
- Create a PVE 5 VM
- Install Ceph Luminous
- Create an
On Mon, Jan 27, 2020 at 03:57:19PM +0100, Fabian Grünbichler wrote:
> On January 27, 2020 1:38 pm, Dominic Jäger wrote:
> > Necessary because leftovers on a disk can make partitioning it fail.
>
> shouldn't those leftovers be detected by our "is disk in use" checks?
The default value for "pveceph start" and "pveceph stop" is "ceph.target".
However, omitting the parameter to use the default has been forbidden.
Signed-off-by: Dominic Jäger
---
PVE/CLI/pveceph.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --
To (re)start and stop Ceph services the API calls systemd units using the
function ceph_service_cmd. If unspecified, this function assumes the type
".target" for a unit. By making the unit type suffix in the API optional, it
can make use of this assumption.
Signed-off-by: Dominic Jäger
On Thu, Feb 13, 2020 at 09:12:24AM +0100, Thomas Lamprecht wrote:
> On 12/2/19 12:45 PM, Dominic Jäger wrote:
> > - return data.volid.replace(/^.*:(.*\/)?/,'');
> > + return data.volid.replace(/^.*:[^\/]*\//,'');
>
> what if a volid does not contain
On Wed, Feb 12, 2020 at 11:19:06AM +0100, Thomas Lamprecht wrote:
> On 1/31/20 5:00 PM, Alwin Antreich wrote:
> > --- a/PVE/Storage/Plugin.pm
> > +++ b/PVE/Storage/Plugin.pm
> > @@ -423,7 +423,7 @@ sub parse_volname {
> > return ('vztmpl', $1);
> > } elsif ($volname =~ m!^rootdir/(\d+)$!)
Signed-off-by: Dominic Jäger
---
...12-Remove-failing-actions-from-prerm.patch | 164 ++
patches/series| 1 +
2 files changed, 165 insertions(+)
create mode 100644 patches/0012-Remove-failing-actions-from-prerm.patch
diff --git a/patches/0012
This function is not only required by Ceph.
Signed-off-by: Dominic Jäger
---
PVE/API2/Ceph/OSD.pm | 4 ++--
PVE/Ceph/Tools.pm| 22 --
2 files changed, 2 insertions(+), 24 deletions(-)
diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm
index e1b0d807..53288fec
Signed-off-by: Dominic Jäger
---
PVE/Diskmanage.pm | 24
1 file changed, 24 insertions(+)
diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm
index abb90a7..261082f 100644
--- a/PVE/Diskmanage.pm
+++ b/PVE/Diskmanage.pm
@@ -4,6 +4,7 @@ use strict;
use warnings;
use PVE
Necessary because leftovers on a disk can make partitioning it fail.
Signed-off-by: Dominic Jäger
---
PVE/API2/Disks/Directory.pm | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Disks/Directory.pm b/PVE/API2/Disks/Directory.pm
index 4c74776..8a317d3 100644
This is already implemented in all other storage plugins.
Signed-off-by: Dominic Jäger
---
PVE/Storage/CIFSPlugin.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm
index 582f99b..6115a96 100644
--- a/PVE/Storage/CIFSPlugin.pm
+++ b/PVE
Signed-off-by: Dominic Jäger
---
vzdump.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vzdump.adoc b/vzdump.adoc
index fd7f13f..404ad09 100644
--- a/vzdump.adoc
+++ b/vzdump.adoc
@@ -200,7 +200,7 @@ time, thus we implemented the possibility to set a default
bandwidth
Hi,
the attached test cases show some small problems with uninitialized values.
Please use them only in a test environment. It might destroy pools, VMs or
backup jobs.
On Thu, Dec 12, 2019 at 11:27:44AM +0100, Aaron Lauterer wrote:
> + my $vzconf = cfs_read_file('vzdump.cron');
> + my $j
volumes).
Signed-off-by: Dominic Jäger
---
Thanks to Stefan for the feedback about the tests.
get_file_properties is a mix of parse_volname and what was in get_subdir_files.
We could probably change parse_volname to return subdirectories and replace
get_file_properties with it or (as it was in
iso and vztmpl files can be in subdirectories of a storage's directory.
In this case we must make clear where they are exactly.
Signed-off-by: Dominic Jäger
---
Useless without the patch for pve-storage.
www/manager6/Utils.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
On Wed, Nov 20, 2019 at 09:09:12AM +0100, Fabian Ebner wrote:
> On 11/19/19 12:05 PM, Tim Marx wrote:
> > The bugfix for #2317 introduced a kind of odd api behavior, where each
> > volume
While Tim's patch does indeed fix the API, I agree with Fabian's objections:
> Isn't it necessary to do this
'assigning' could also mean that creating a VM with more cores than physically
available is impossible. However, this is not the case. Using 'starting'
instead is more precise and still easy to understand.
Signed-off-by: Dominic Jäger
---
qm.adoc | 4 ++--
1 file changed
When calling qmrestore a config file is created and locked with a lock
property. The following destroy_vm has been impossible as skiplock has not
been set.
Signed-off-by: Dominic Jäger
---
PVE/QemuServer.pm | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/PVE
Functions like qm importovf can now set the "lock" property in a config file
before calling do_import.
Signed-off-by: Dominic Jäger
---
v1->v2: Edited only the commit message ("parameter lock" -> "lock property")
PVE/CLI/qm.pm| 4 ++--
PVE/Qe
Signed-off-by: Dominic Jäger
---
v1->v2:
- Adapt commit message
- Keep $skiplock for readability
- Squash 3/7 "Remove redundant locks" into here
- Squash 5/7 "Remove useless eval" into here:
Actually the eval is not removed anymore but I added a warning inste
set in the config instead of using flock only.
$param was empty when it was assigned the three values "name", "memory" and
"cores" before being assigned to $conf later on. Assigning those values
directly to $conf avoids confusion about what the two variables contain.
s makes it obsolete
Dominic Jäger (3):
Remove vm_destroy
Add skiplock to do_import
Import OVF: Lock config with "lock" property
PVE/CLI/qm.pm| 67 ++--
PVE/QemuServer.pm| 15
PVE/QemuServer/ImportDisk.pm | 6 ++--
On Fri, Oct 25, 2019 at 11:49:51AM +0200, Thomas Lamprecht wrote:
> On 10/25/19 11:24 AM, Dominic Jäger wrote:
> > As mentioned on the mailing list [0] disks owned by the VM and unused
> > disks should be removed before the config file is removed.
> >
> > [0] https://pv
This function has been used in one place only. Removing it avoids confusion
between vm_destroy and vm_destroy.
Signed-off-by: Dominic Jäger
---
I copied all the checks from vm_destroy even if they were useless.
Removing those useless functions is a follow up patch.$
PVE/CLI/qm.pm | 11
This series cleans up some redundant locks and functions and sets more
appropriate locks instead when importing .ovf and disks.
Dominic Jäger (7):
Move config removal after disk removal
Remove vm_destroy
Remove redundant locks
Remove variable from lock
Remove useless eval
Add skiplock
.
Signed-off-by: Dominic Jäger
---
PVE/CLI/qm.pm | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index 97f0f88..3bf8e81 100755
--- a/PVE/CLI/qm.pm
+++ b/PVE/CLI/qm.pm
@@ -621,14 +621,14 @@ __PACKAGE__->register_met
while
Signed-off-by: Dominic Jäger
---
PVE/CLI/qm.pm | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index 6405b42..c93f78d 100755
--- a/PVE/CLI/qm.pm
+++ b/PVE/CLI/qm.pm
@@ -645,7 +645,6 @@ __PACKAGE__->registe
Functions like importovf can now use a parameter lock in the config.
Signed-off-by: Dominic Jäger
---
PVE/CLI/qm.pm| 4 ++--
PVE/QemuServer/ImportDisk.pm | 6 --
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index a16033c
The destroy_vm in the eval could only die if the VM were a template.
This is not possible here.
Signed-off-by: Dominic Jäger
---
PVE/CLI/qm.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index a378d3d..a16033c 100755
--- a/PVE/CLI/qm.pm
As mentioned on the mailing list [0] disks owned by the VM and unused
disks should be removed before the config file is removed.
[0] https://pve.proxmox.com/pipermail/pve-devel/2019-October/039593.html
Signed-off-by: Dominic Jäger
---
PVE/QemuServer.pm | 12 ++--
1 file changed, 6
The variable was used in one place only. Nesting the code into the
lock_config_full makes clear what code is locked.
Signed-off-by: Dominic Jäger
---
PVE/CLI/qm.pm | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index c93f78d
deletion process to avoid that
other nodes use the ID in the meanwhile.
Co-developed-by: Fabian Grünbichler
Signed-off-by: Dominic Jäger
---
v1->v2: Move unlink to the end of the deletion process
v2->v3: Use skiplock parameter and add error handling for unlink
I'll send a separate pa
On Mon, Oct 14, 2019 at 02:02:26PM +0200, Thomas Lamprecht wrote:
> On 10/14/19 1:10 PM, Dominic Jäger wrote:
> > Between calling vm_destroy and removing the ID from user.cfg
> > (remove_vm_access)
> > creating a new VM with this ID was possible. VMs could go missing fro
deletion process to avoid that
other nodes use the ID in the meanwhile.
Co-developed-by: Fabian Grünbichler
Signed-off-by: Dominic Jäger
---
v1->v2: Move unlink to the end of the deletion process
PVE/API2/Qemu.pm | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/PVE/A
same process.
Signed-off-by: Dominic Jäger
---
PVE/API2/Qemu.pm | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 267a08e..7dd83a9 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -1492,9 +1492,11 @@ __PACKAGE__
false" necessary) and sufficient.
- Align the buttons at the right for visual appeal.
- Use title case for the user name label for consistency.
Signed-off-by: Dominic Jäger
---
www/manager6/window/Settings.js | 48 -
1 file changed, 24 insertions(+),
On 9/4/19 2:29 PM, Thomas Lamprecht wrote:
to ensure fallback is still the same default, replaced with
sp.get('novnc-scaling', 'off')Makes sense. I did not know that this is possible.
2. move the selector to the same line as the "Scaling mode" label, as IMO
it reduces space usage a bit and
On 9/26/19 4:53 PM, Thomas Lamprecht wrote:
Hmm, how about rename the button to "Clear" (or "Reset") only when we move it
up? The association with what gets cleared should be then, well, clear.
Looks good to me. Then I'd to the same for the "Reset Layout" button.
I'd like the button alignmen
As the current versions are Debian Buster and PVE 6 mention them
instead of the old ones in the installation documentation.
Signed-off-by: Dominic Jäger
---
pve-installation.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pve-installation.adoc b/pve-installation.adoc
.
The new section (fieldset) makes adding further options such as
"Local Cursor" easy.
Co-developed-by: Thomas Lamprecht
Signed-off-by: Dominic Jäger
---
Please view with -w option. I did gg=G after moving some elements around.
v1->v2:
- Reference name without hyphen
- radiogroup in
I tested this
On 9/2/19 10:06 AM, Fabian Grünbichler wrote:
> the end result is that you need to (...) do the upgrade with
>
> -o Dpkg::Options::="--force-overwrite"
>
> added to the apt upgrade command
and added it to the the PVE 5 to 6 upgrade guide [0].
Thank you, Fabian!
[0]
https://pve.
Signed-off-by: Dominic Jäger
---
I did not know that we have to run 'make update' when adding a new
language to i18n and have overseen a lot of errors as a consequence [0].
We might want to give (new) developers a hint at some place so that something
like this does not happen anymore.
d7e4458238f921d6af6ec780da965a
[1] https://pve.proxmox.com/wiki/Upgrade_from_5.x_to_6.0
[2] https://bugzilla.proxmox.com/show_bug.cgi?id=2269
On 8/26/19 12:04 PM, Thomas Lamprecht wrote:
On 01.08.19 11:21, Dominic Jäger wrote:
Upgrading from PVE 5 to 6 works only with the Gluster packages from th
Signed-off-by: Dominic Jäger
---
Tested on PVE and PMG.
Utils.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Utils.js b/Utils.js
index 9b62bf6..533272d 100644
--- a/Utils.js
+++ b/Utils.js
@@ -76,7 +76,8 @@ Ext.define('Proxmox.Utils', { utilities: {
On 8/9/19 2:02 PM, Fabian Grünbichler wrote:
it might be worth it to attempt to convince upstream to ship the
"gluster" binary in its own package or move it to glusterfs-common
(since it seems to be a general management CLI akin to Ceph's 'ceph',
and not the actual server part).
On Fedora, fo
As explained in detail in bug 2293 [0] glusterfsscan is not working at the
moment. Our function tries to contact a nfs server that is running inside
gluster servers that does not respond.
There is a command line utility simply called 'gluster' [1] that can solve this
problem in a single line:
'
Signed-off-by: Dominic Jäger
---
Adding an option to My Settings was proposed by Dietmar.
www/manager6/Utils.js | 3 +-
www/manager6/VNCConsole.js | 3 +-
www/manager6/window/Settings.js | 50 -
3 files changed, 53 insertions(+), 3 deletions(-)
di
On PVE 6.0-2 with GlusterFS repository set up installing the patched
pve-qemu-kvm and then glusterfs-common gives conflicts:
root@pve:~# apt update && apt list --upgradeable && dpkg -i
./pve-qemu-kvm_4.0.0-4_amd64.deb && apt update && apt install
glusterfs-common
Hit:1 http://ftp.at.debian.or
Upgrading from PVE 5 to 6 works only with the Gluster packages from the
Debian repository. At least Gluster versions 5.8 to 6.4-1 have conflicts
with our packages.
Signed-off-by: Dominic Jäger
---
Tested on one VM with PVE 5.4 and upstream Gluster (6.4-1) and one
with PVE 5.4 and the Debian
The StdRemoveButton can now pass a delay parameter to the API.
It is set undefined as default so that users of the button
can set the parameter themselves.
Signed-off-by: Dominic Jäger
---
v3->v4: Make the delay undefined/optional
button/Button.js | 7 ++-
1 file changed, 6 inserti
A default of 5 seems like a reasonable delay for removing backups from
the GUI.
Signed-off-by: Dominic Jäger
---
v3->v4: Move default value to users of StdRemoveButton
www/manager6/grid/BackupView.js | 1 +
www/manager6/storage/ContentView.js | 1 +
2 files changed, 2 insertions(+)
d
Previously, the web GUI timed out when removing content (e.g. backup) took
too long. Doing the main part of the API DELETE call in a fork_worker solves
this.
Signed-off-by: Dominic Jäger
---
v3->v4: Unchanged
PVE/API2/Storage/Content.pm | 45 +
1 f
buttons for the backup use the new delay.
Dominic Jäger (1):
Fix #582: Add DELETE delay logic
Fix #582: Add delay parameter to StdRemoveButton
Fix #582: Add default delay for backup removal
PVE/API2/Storage/Content.pm | 45 +
1 file changed, 36 insertions
Hostnames in corosync do work if everything is set up correctly. Thus,
_warning_ users to take care of that is adequate.
Signed-off-by: Dominic Jäger
---
Didn't test this. User "juniper" brought the topic up
https://forum.proxmox.com/threads/proxmox-ve-6-0-beta-released.55670/
an
Previously, the web gui timed out when removing content (backup, iso,
...) took long. Doing the main part of the API DELETE call in a
fork_worker solves this.
Signed-off-by: Dominic Jäger
---
v2->v3:
1. Fix indentation, vicinity of use and add log line
2. In addition to ownervm, add storeid
Using the standard remove button on the GUI now passes a delay of 5 to
to the API. Advanced users can still set the delay on the CLI themselves while
beginners are offered a default that should work for many cases.
Signed-off-by: Dominic Jäger
---
button/Button.js | 4 +++-
1 file changed, 3
Thank you for the feedback!
On 6/28/19 12:22 PM, Thomas Lamprecht wrote:
FYI, this API entry point is for _all_ content removal, not just backups...
I.e., ISOs, disks, templates, backups, snippets..
I really wasn't aware of that.
indentation error above
Fixed
declaration should be in the
Thank you for taking a look! I reordered what you said to group similar
topics together.
On 6/13/19 12:02 PM, Dominik Csapak wrote:
Generally OK, but with some i am not so happy,
comments inline (in german)
On 6/13/19 11:20 AM, Dominic Jäger wrote:
msgid "Active Directory Server&quo
In many cases inserting a hyphen is not only nice to have but required.
In our translation we stumble particularly often upon rule §40 by
Rat für deutsche Rechtschreibung. This rules obliges to insert a hyphen
in compositions with abbreviations.
Signed-off-by: Dominic Jäger
---
de.po | 196
Signed-off-by: Dominic Jäger
---
de.po | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/de.po b/de.po
index df87e76..122e309 100644
--- a/de.po
+++ b/de.po
@@ -8,8 +8,8 @@ msgstr ""
"Project-Id-Version: proxmox translations\n"
"Report
.
Signed-off-by: Dominic Jäger
---
de.po | 164 +-
1 file changed, 82 insertions(+), 82 deletions(-)
diff --git a/de.po b/de.po
index 17b0f0b..6912193 100644
--- a/de.po
+++ b/de.po
@@ -300,7 +300,7 @@ msgstr "Zurück"
#:
On 6/12/19 4:17 PM, Aaron Lauterer wrote:
+* Memory, minimum 2 GB for OS and Proxmox VE services. Plus designated
{pve}
* Firefox, a release from the current year, or the latest Extended
Support Release
-* Chrome, a release from the current year
+* Chrome, a release of the current year
On 6/12/19 4:17 PM, Aaron Lauterer wrote:
+The next page aks for basic configuration options like the
asks
+to be specified. The password must consist of at least 5 character.
characters
+The next step will show a summary of the previously seletected
selected
+wait until it is finished,
On 6/12/19 4:17 PM, Aaron Lauterer wrote:
System Administrators
No capitalization
can be files there should any issues appear
can be filed
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-dev
Looks good to me. I like that you removed the "you"s. Sounds more
professional in my opinion.
On 6/12/19 3:51 PM, Aaron Lauterer wrote:
+controls for manage a cluster.
controls to manage
+restore jobs, live-migration of virtual machines or high availability
No hyphen (see all the references
children of rsync only. The waiting
time was less than a second when I tried it. Afterwards, the existing
remove procedure is carried out.
Co-developed-by: Wolfgang Bumiller
Signed-off-by: Dominic Jäger
---
v2: System call is not a single string anymore
v3: More exhaustive commit message
src/PVE
1 - 100 of 121 matches
Mail list logo
