On 9/4/19 2:29 PM, Thomas Lamprecht wrote:
to ensure fallback is still the same default, replaced with
sp.get('novnc-scaling', 'off')Makes sense. I did not know that this is possible.
2. move the selector to the same line as the "Scaling mode" label, as IMO
it reduces space usage a bit and looks more like the rest of our interface
(I know that Layout and username reset are not like this too, but IMO they
should be)
I found it in the Add Network Device menu only. Nonetheless, makes sense
too, especially with the follow up
6c1eafbe84de9a3f7225910747e35caa1b52c5fe (move reset layout button to
same row as label).
However, now the "Clear User name" button is the only one that is left
below. Screenshots of the current state and my proposal are attached.
We could
1.
1.a move the user name more to the left, such that the distance is the
same as between the label and the radio field in the noVNC settings.
1.b and move the "Clear User name" button to the right, such that it is
aligned with and has same width as the "Reset Layout" button. Apple, for
example, uses the same width in the first screenshot in [0]. They
explicitly suggest consistent widths (as we do it already) for text
fields [1], so I just copied this for the buttons.
2. use title-case: "Clear User name" => "Clear User Name" (as in [0])
Giving the two buttons the same size could be discussed. The material
design recommends variable sizes [2].
This all still leaves a giant gap between the "Layout:" label and its
button, but the buttons would be a bit more consistent.
[0]
https://developer.apple.com/design/human-interface-guidelines/macos/buttons/push-buttons/
[1]
https://developer.apple.com/design/human-interface-guidelines/macos/fields-and-labels/text-fields/
[2] https://material.io/components/buttons/#contained-button
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
