- Rename both buttons to a single word as it is clear where they belong
to. Use "Reset" instead of "Clear" as you can rather "Reset a saved
user name" than "Clear a layout".
- Use container instead of panels as they are simpler (e.g. no "border:
false" necessary) and sufficient.
- Align the buttons at the right for visual appeal.
- Use title case for the user name label for consistency.
Signed-off-by: Dominic Jäger <d.jae...@proxmox.com>
---
www/manager6/window/Settings.js | 48 ++++++++++++++++-----------------
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/www/manager6/window/Settings.js b/www/manager6/window/Settings.js
index 6cef4c38..61eabde3 100644
--- a/www/manager6/window/Settings.js
+++ b/www/manager6/window/Settings.js
@@ -219,45 +219,45 @@ Ext.define('PVE.window.Settings', {
autoEl: { tag: 'hr'}
},
{
- xtype: 'displayfield',
- fieldLabel: gettext('Saved User name'),
- labelAlign: 'left',
- labelWidth: '50%',
- stateId: 'login-username',
- reference: 'savedUserName',
- value: ''
- },
- {
- xtype: 'button',
- cls: 'x-btn-default-toolbar-small proxmox-inline-button',
- text: gettext('Clear User name'),
- width: 'auto',
- name: 'clear-username'
+ xtype: 'container',
+ layout: 'hbox',
+ items: [
+ {
+ xtype: 'displayfield',
+ fieldLabel: gettext('Saved User Name:'),
+ labelWidth: 'auto',
+ stateId: 'login-username',
+ reference: 'savedUserName',
+ flex: 1,
+ value: ''
+ },
+ {
+ xtype: 'button',
+ cls: 'x-btn-default-toolbar-small
proxmox-inline-button',
+ text: gettext('Reset'),
+ name: 'clear-username',
+ },
+ ]
},
{
xtype: 'box',
autoEl: { tag: 'hr'}
},
{
- xtype: 'panel',
- border: false,
- layout: {
- type: 'hbox',
- align: 'stretch'
- },
+ xtype: 'container',
+ layout: 'hbox',
items: [
{
xtype: 'displayfield',
- fieldLabel: gettext('Layout'),
- flex: 2,
+ fieldLabel: gettext('Layout:'),
+ flex: 1,
},
{
xtype: 'button',
cls: 'x-btn-default-toolbar-small
proxmox-inline-button',
- text: gettext('Reset Layout'),
+ text: gettext('Reset'),
tooltip: gettext('Reset all layout changes (for
example, column widths)'),
name: 'reset',
- flex: 1,
},
]
},
--
2.20.1
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
