"Shannon Sterz" writes:
> On Tue Nov 19, 2024 at 12:55 PM CET, Christian Ebner wrote:
>> On 11/19/24 12:48, Maximiliano Sandoval wrote:
>> >
>> > Christian Ebner writes:
>> >
>> >> #: proxmox-widget-toolkit/src/Utils.js:315
>> >> -#, fuzzy
>> >> msgid "static"
>> >> -msgstr "Statico"
>> >>
Am 18.11.24 um 21:31 schrieb Thomas Lamprecht:
> Am 18.11.24 um 09:52 schrieb Fiona Ebner:
>> Regarding the patch "schema: add fleecing-images config property",
>> Fabian off-list suggested using a config section "special:fleecing"
>> instead of a property, so that it is truly internal-only. If we
First of, multi-user.target does not seem to really provide any (strong)
ordering guarantee, it seems.
Instead, let the "fully-up" ordering from the auto-installer depend on
the product-specific API proxy instead.
That way, it is ensured that 1) the system really is fully up and 2)
that users cou
On 11/19/24 12:48, Maximiliano Sandoval wrote:
Christian Ebner writes:
#: proxmox-widget-toolkit/src/Utils.js:315
-#, fuzzy
msgid "static"
-msgstr "Statico"
+msgstr ""
This translation is missing.
--
Maximiliano
___
pve-devel mailing list
Gabriel Goller writes:
> @@ -1066,7 +1061,12 @@ sub update_net {
> if ($have_sdn && $bridge_changed) {
>
> PVE::Network::SDN::Vnets::add_next_free_cidr($newnet->{bridge},
> $conf->{hostname}, $newnet->{hwaddr}, $vmid, undef, 1);
> }
> -
Am 12.11.24 um 16:54 schrieb Stefan Hanreich:
> From: Alexandre Derumier via pve-devel
>
> We add this as advanced option in the UI and also move vlan-aware
> to advanced section.
>
> Signed-off-by: Alexandre Derumier
> [ SH: improve naming and commit msg slightly ]
> Signed-off-by: Stefan Han
Am 19.11.24 um 10:49 schrieb Dominik Csapak:
> adds two buttons to the tree: expand all and collapse all
>
> Signed-off-by: Dominik Csapak
> ---
> changes from v1:
> * use two buttons (negates the need for all the event handling and checking)
> * use plain plus/minus icons -> i have no real prefe
Signed-off-by: Christian Ebner
---
changes since version 1:
- Do not translate system unit states, dropped by [0]
- set message string even if keeping English text
- rephase package update available translation
- rename all occurrences of `etichetta` to `tag` and variants thereof
[0]
https://lor
Am 19.11.24 um 17:19 schrieb Stefan Hanreich:
> Signed-off-by: Stefan Hanreich
> ---
> pvesdn.adoc | 5 +
> 1 file changed, 5 insertions(+)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi
Am 19.11.24 um 16:13 schrieb Christoph Heiss:
> First of, multi-user.target does not seem to really provide any (strong)
> ordering guarantee, it seems.
Note that on a second thought it's really clear, we never ordered _after_
multi-user.target, we just told systemd that we're part of that target
Signed-off-by: Stefan Hanreich
Tested-by: Gabriel Goller
Tested-by: Hannes Dürr
---
www/manager6/form/IPRefSelector.js | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/www/manager6/form/IPRefSelector.js
b/www/manager6/form/IPRefSelector.js
index d41cde5f5..16078e428 1
Am 19.11.24 um 16:56 schrieb Filip Schauer:
> Ensure potentially unsafe characters in the partition label are encoded,
> preventing the installer from failing to find the answer partition when
> the label contains whitespaces or !"$%&'()*,/;<>?[\]^`{|}~
>
> The encoding is done according to `blkid
Am 19.11.24 um 13:12 schrieb Lukas Wagner:
> A previous commit removed the part which sets the bit.
> Without the bit we cannot read the notification config, because
> Postfix invokes forwarding binaries as 'nobody'.
>
> Fixes: 32d813ce44b ("build: properly use cargo wrapper")
> Signed-off-by: Luk
Good catch & thanks for tackeling this!
Also tested it with a simple whitespace character.
Tested-by: Christoph Heiss
Reviewed-by: Christoph Heiss
On Tue, Nov 19, 2024 at 03:59:34PM +0100, Filip Schauer wrote:
> Ensure potentially unsafe characters in the partition label are encoded,
> prevent
adding docs section, unifying wording and adding help button to the
import wizard
pve-docs:
Dominik Csapak (1):
qm: adapt import section to newly added OVA/OVF import
qm.adoc | 35 ---
1 file changed, 28 insertions(+), 7 deletions(-)
qemu-server:
Dominik Csap
Since forward rules only take effect when the nftables firewall is
enabled, show a warning to users that informs them of this.
Signed-off-by: Stefan Hanreich
---
www/manager6/grid/FirewallRules.js | 22 ++
1 file changed, 22 insertions(+)
diff --git a/www/manager6/grid/Firew
Expose the ability to create vnet-level firewalls in the PVE UI
Signed-off-by: Stefan Hanreich
Tested-by: Hannes Dürr
---
www/manager6/Makefile| 2 +
www/manager6/dc/Config.js| 8 +++
www/manager6/sdn/FirewallPanel.js| 50 ++
www/manager6/sdn/Fi
This adds the ability to dynamically configure and change the base_url
for the firewall options. This is needed for the SDN firewall dialog,
that updates the firewall components based on the selected vnet. This
avoids having to reinstantiate the component every time the user
selects a new vnet.
Si
Translating unit states might be counter productive in case of
debugging, opt for not translating them and drop usage of the
translation helper.
Signed-off-by: Christian Ebner
---
src/Utils.js| 12
src/node/ServiceView.js | 10 ++
2 files changed, 2 insertions(+)
I like your changes, but I would adapt the description more to the
bridge manpage [0].
[0] https://www.man7.org/linux/man-pages/man8/bridge.8.html
On 11/18/24 19:52, Stoiko Ivanov wrote:
On Tue, 12 Nov 2024 16:54:25 +0100
Stefan Hanreich wrote:
Signed-off-by: Stefan Hanreich
---
pvesdn.a
Signed-off-by: Stefan Hanreich
---
pvesdn.adoc | 5 +
1 file changed, 5 insertions(+)
diff --git a/pvesdn.adoc b/pvesdn.adoc
index 39de80f..a6f151e 100644
--- a/pvesdn.adoc
+++ b/pvesdn.adoc
@@ -383,6 +383,11 @@ Tag:: The unique VLAN or VXLAN ID
VLAN Aware:: Enables vlan-aware option on the
On 11/19/24 13:30, Thomas Lamprecht wrote:
Am 19.11.24 um 13:09 schrieb Shannon Sterz:
This is intentional since that is the description for the systemd state, not
sure if it makes to translate that in this case?
Maybe, but perhaps then it makes sense to remove the english string? I
mean there
If the hotplug of an interface on a lxc container fails for whatever
reason, the configuration will be broken and needs to manually fixed.
For example when adding a network interface with a bridge to a evpn vnet
(which doesn't support vlans) and we add a vlan tag, the interface will
be created eve
Am 19.11.24 um 16:24 schrieb Gabriel Goller:
> Updated all the tag-related translations to drop the plural "s", which
> doesn't exist in italian. Also fixed some typos included in an earlier
> patch.
>
> Fixes: b87af6f3ccb6 ("update Italian translations")
> Signed-off-by: Gabriel Goller
> ---
>
Am 19.11.24 um 09:39 schrieb Dominik Csapak:
> adding docs section, unifying wording and adding help button to the
> import wizard
>
> pve-docs:
>
> Dominik Csapak (1):
> qm: adapt import section to newly added OVA/OVF import
>
> qm.adoc | 35 ---
> 1 file chan
Am 19.11.24 um 14:30 schrieb Stefan Hanreich:
> We opted for a simple copy of the legacy file to the new location,
> since any other migration path would be too strenuous. The worst-case
> scenario of failures with this approach is losing IPAM / MAC entries
> that are created during the update wind
Am 19.11.24 um 13:22 schrieb Stefan Hanreich:
> pve-firewall:
>
> Stefan Hanreich (3):
> sdn: add vnet firewall configuration
> api: add vnet endpoints
> firewall: move to arrow syntax for calling functions
>
> src/PVE/API2/Firewall/Helpers.pm | 14 ++
> src/PVE/API2/Firewall/Makefile |
On 19/11/2024 16:40, Christoph Heiss wrote:
I think the original, non-encoded partition label should be printed
here.
As it would be somewhat surprising to users/administrators to suddenly
see some partition label being searched that what the specified -- thus
considering this as an internal imp
Signed-off-by: Stefan Hanreich
---
pvesdn.adoc | 92 +
1 file changed, 92 insertions(+)
diff --git a/pvesdn.adoc b/pvesdn.adoc
index 39de80f..c187365 100644
--- a/pvesdn.adoc
+++ b/pvesdn.adoc
@@ -702,6 +702,98 @@ For more information please co
Ensure potentially unsafe characters in the partition label are encoded,
preventing the installer from failing to find the answer partition when
the label contains whitespaces or !"$%&'()*,/;<>?[\]^`{|}~
The encoding is done according to `blkid_encode_string` [0] in the blkid
util, which is used b
Am 19.11.24 um 09:15 schrieb Lukas Wagner:
> On Mon Nov 18, 2024 at 2:53 PM CET, Dominik Csapak wrote:
nothing special, I tested the feature using the Home Assistant .ova from
[1]. Downloaded the OVA to my local storage, pressed "import", did not
change *any* settings apart from tick
On 19.11.2024 14:36, Christian Ebner wrote:
Signed-off-by: Christian Ebner
---
changes since version 1:
- Do not translate system unit states, dropped by [0]
- set message string even if keeping English text
- rephase package update available translation
- rename all occurrences of `etichetta` t
This patch series adds support for autogenerating ipsets for SDN objects. It
autogenerates ipsets for every VNet as follows:
* ipset containing all IP ranges of the VNet
* ipset containing all gateways of the VNet
* ipset containing all IP ranges of the subnet - except gateways
* ipset containing
Signed-off-by: Stefan Hanreich
---
pvesdn.adoc | 92 +
1 file changed, 92 insertions(+)
diff --git a/pvesdn.adoc b/pvesdn.adoc
index 39de80f..c187365 100644
--- a/pvesdn.adoc
+++ b/pvesdn.adoc
@@ -702,6 +702,98 @@ For more information please co
In order for the new SDN ipsets to show up we need to adapt the
existing API endpoints so they read the SDN configuration. We reload
the SDN configuration explicitly, in order to return only the IPSets
the user is allowed to see.
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/Firewall/Cluster.p
This also includes support for parsing rules referencing IPSets in the
new SDN scope and generating those IPSets in the firewall. We always
load the new configuration, since loading the configuration always
includes validating the loaded rules. Validation fails without
including the SDN ipsets, lea
Am 19.11.24 um 15:39 schrieb Christoph Heiss:
> First of, multi-user.target does not seem to really provide any (strong)
> ordering guarantee, it seems.
>
> Instead, let the "fully-up" ordering from the auto-installer depend on
> pveproxy.service instead.
>
> That way, it is ensured that 1) the s
On 19.11.2024 15:46, Christian Ebner wrote:
Unfortunately you were to late, Thomas already applied this patch.
Can you send your suggested changes as followup patch?
yeah sure, I'll send it now.
This is some high-level nitpicking anyway, sorry about that :)
__
On Tue, Nov 19, 2024 at 03:50:47PM +0100, Thomas Lamprecht wrote:
> Am 19.11.24 um 15:39 schrieb Christoph Heiss:
> > [..]
> > diff --git a/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
> > b/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service
> > index d3c798d..4b30e7e 100
Ensure potentially unsafe characters in the partition label are encoded,
preventing the installer from failing to find the answer partition when
the label contains whitespaces or !"$%&'()*,/;<>?[\]^`{|}~
The encoding is done according to `blkid_encode_string` [0] in the blkid
util, which is used b
Am 19.11.24 um 14:36 schrieb Christian Ebner:
> Signed-off-by: Christian Ebner
> ---
> changes since version 1:
> - Do not translate system unit states, dropped by [0]
> - set message string even if keeping English text
> - rephase package update available translation
> - rename all occurrences of
Am 19.11.24 um 14:40 schrieb Shannon Sterz:
> Signed-off-by: Shannon Sterz
> ---
> de.po | 206 +-
> 1 file changed, 87 insertions(+), 119 deletions(-)
>
>
applied this already before Lukas reply came in, but you can always send
a follow-u
Unfortunately you were to late, Thomas already applied this patch.
Can you send your suggested changes as followup patch?
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
First of, multi-user.target does not seem to really provide any (strong)
ordering guarantee, it seems.
Instead, let the "fully-up" ordering from the auto-installer depend on
pveproxy.service instead.
That way, it is ensured that 1) the system really is fully up and 2)
that users could even use th
On Tue Nov 19, 2024 at 2:40 PM CET, Shannon Sterz wrote:
> #: proxmox-widget-toolkit/src/panel/WebhookEditPanel.js:406
> -#, fuzzy
> msgid "Add {0}"
> -msgstr "Modus: {0}"
> +msgstr "Hinzufügen {0}"
Hmmm, I think "{0} hinzufügen" would be better here?
For context, this string is used for a butto
Am 19.11.24 um 14:02 schrieb Christian Ebner:
> Translating unit states might be counter productive in case of
> debugging, opt for not translating them and drop usage of the
> translation helper.
>
> Signed-off-by: Christian Ebner
> ---
> src/Utils.js| 12
> src/node/Se
Signed-off-by: Shannon Sterz
---
de.po | 206 +-
1 file changed, 87 insertions(+), 119 deletions(-)
diff --git a/de.po b/de.po
index c2284c1..5f987e2 100644
--- a/de.po
+++ b/de.po
@@ -8,7 +8,7 @@ msgstr ""
"Project-Id-Version: proxmox tra
Am 19.11.24 um 12:08 schrieb Christoph Heiss:
> We serialize it as an integer for perl compatibility, so we need to also
> deserialize it as such .. the latter is used in proxmox-chroot.
>
> Otherwise, an auto-installation will fail at the end, when a
> post-installation webhook is configured, whi
We opted for a simple copy of the legacy file to the new location,
since any other migration path would be too strenuous. The worst-case
scenario of failures with this approach is losing IPAM / MAC entries
that are created during the update window in the legacy files by nodes
that are not yet updat
Am 19.11.24 um 12:12 schrieb Mira Limbeck:
> If it is set and 0, don't warn.
>
> Signed-off-by: Mira Limbeck
> ---
> v2:
> - added check != 0
> - fixed punctuation in text
>
> Proxmox/Install.pm | 4
> 1 file changed, 4 insertions(+)
>
>
applied, with a bit more context in commit subje
I changed subject prefix to "network config:"
Am 19.11.24 um 12:29 schrieb Gabriel Goller:
> If the hotplug of an interface on a lxc container fails for whatever
> reason, the configuration will be broken and needs to manually fixed.
>
> For example when adding a network interface with a bridge t
On 19.11.2024 13:36, Christian Ebner wrote:
On 11/19/24 13:33, Gabriel Goller wrote:
On 19.11.2024 12:37, Christian Ebner wrote:
Signed-off-by: Christian Ebner
---
it.po | 126 +++---
1 file changed, 41 insertions(+), 85 deletions(-)
diff --g
In order for the new SDN ipsets to show up we need to adapt the
existing API endpoints so they read the SDN configuration. We reload
the SDN configuration explicitly, in order to return only the IPSets
the user is allowed to see.
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/Firewall/Cluster.p
On 11/19/24 13:33, Gabriel Goller wrote:
On 19.11.2024 12:37, Christian Ebner wrote:
Signed-off-by: Christian Ebner
---
it.po | 126 +++---
1 file changed, 41 insertions(+), 85 deletions(-)
diff --git a/it.po b/it.po
index a1a5c48..da5516c 100
This also includes support for parsing rules referencing IPSets in the
new SDN scope and generating those IPSets in the firewall. We always
load the new configuration, since loading the configuration always
includes validating the loaded rules. Validation fails without
including the SDN ipsets, lea
On 2024-11-18 21:22, Thomas Lamprecht wrote:
I now looked into your diff.
Am 18.11.24 um 18:24 schrieb Aaron Lauterer:
On 2024-11-18 16:29, Dominik Csapak wrote:
+ if (!$extraction_scfg->{content}->{images} ||
!$extraction_scfg->{path}) {
I think the if condition her
Added a new direction section, mostly so I can write about the forward
direction and explain its use cases.
Signed-off-by: Stefan Hanreich
---
Makefile | 1 +
gen-pve-firewall-vnet-opts.pl | 12 +
pve-firewall-vnet-opts.adoc | 8 +++
pve-firewall.adoc | 9
Add the configuration options for vnet-level firewalls to the options
component. Additionally add the new policy_forward configuration
option to the datacenter-level firewall as well.
Signed-off-by: Stefan Hanreich
Tested-by: Hannes Dürr
---
www/manager6/grid/FirewallOptions.js | 38 +++
Signed-off-by: Stefan Hanreich
Reviewed-by: Wolfgang Bumiller
---
src/PVE/API2/Network/SDN/Vnets.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/PVE/API2/Network/SDN/Vnets.pm
b/src/PVE/API2/Network/SDN/Vnets.pm
index 05915f6..e48b048 100644
--- a/src/PVE/API2/Network/SDN/Vnets.
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/Firewall/Helpers.pm | 14 +++
src/PVE/API2/Firewall/Makefile | 1 +
src/PVE/API2/Firewall/Rules.pm | 84 +
src/PVE/API2/Firewall/Vnet.pm| 155 +++
src/PVE/Firewall.pm | 10 ++
5 f
Signed-off-by: Stefan Hanreich
Reviewed-by: Wolfgang Bumiller
---
src/PVE/Firewall.pm | 78 ++---
1 file changed, 39 insertions(+), 39 deletions(-)
diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
index 0b9cf65..2ccbda1 100644
--- a/src/PVE/Firewall
Enables us to use the new forward direction as an option when creating
or editing firewall rules. By introducing firewall_type we can switch
between the available directions depending on which ruleset is being
edited.
Signed-off-by: Stefan Hanreich
Tested-by: Hannes Dürr
---
www/manager6/dc/Con
On 11/19/24 13:04, Maximiliano Sandoval wrote:
"Shannon Sterz" writes:
On Tue Nov 19, 2024 at 12:55 PM CET, Christian Ebner wrote:
On 11/19/24 12:48, Maximiliano Sandoval wrote:
Christian Ebner writes:
#: proxmox-widget-toolkit/src/Utils.js:315
-#, fuzzy
msgid "static"
-msgstr "St
Signed-off-by: Stefan Hanreich
Tested-by: Gabriel Goller
Tested-by: Hannes Dürr
---
www/manager6/form/IPRefSelector.js | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/www/manager6/form/IPRefSelector.js
b/www/manager6/form/IPRefSelector.js
index d41cde5f5..16078e428 1
A previous commit removed the part which sets the bit.
Without the bit we cannot read the notification config, because
Postfix invokes forwarding binaries as 'nobody'.
Fixes: 32d813ce44b ("build: properly use cargo wrapper")
Signed-off-by: Lukas Wagner
---
Makefile | 1 +
1 file changed, 1 inser
Christian Ebner writes:
> On 11/19/24 12:48, Maximiliano Sandoval wrote:
>> Christian Ebner writes:
>>
>>> #: proxmox-widget-toolkit/src/Utils.js:315
>>> -#, fuzzy
>>> msgid "static"
>>> -msgstr "Statico"
>>> +msgstr ""
>> This translation is missing.
>> --
>> Maximiliano
>> __
On 11/19/24 12:58, Maximiliano Sandoval wrote:
Christian Ebner writes:
On 11/19/24 12:48, Maximiliano Sandoval wrote:
Christian Ebner writes:
#: proxmox-widget-toolkit/src/Utils.js:315
-#, fuzzy
msgid "static"
-msgstr "Statico"
+msgstr ""
This translation is missing.
--
Maximiliano
On Tue Nov 19, 2024 at 12:58 PM CET, Maximiliano Sandoval wrote:
>
> Christian Ebner writes:
>
> > On 11/19/24 12:48, Maximiliano Sandoval wrote:
> >> Christian Ebner writes:
> >>
> >>> #: proxmox-widget-toolkit/src/Utils.js:315
> >>> -#, fuzzy
> >>> msgid "static"
> >>> -msgstr "Statico"
> >
On Tue Nov 19, 2024 at 12:55 PM CET, Christian Ebner wrote:
> On 11/19/24 12:48, Maximiliano Sandoval wrote:
> >
> > Christian Ebner writes:
> >
> >> #: proxmox-widget-toolkit/src/Utils.js:315
> >> -#, fuzzy
> >> msgid "static"
> >> -msgstr "Statico"
> >> +msgstr ""
> >
> > This translation is
Mira Limbeck writes:
> Signed-off-by: Mira Limbeck
> ---
> Proxmox/Install.pm | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
> index c64e1d4..da8fb55 100644
> --- a/Proxmox/Install.pm
> +++ b/Proxmox/Install.pm
> @@ -555,6 +555,10 @@ sub c
On Mon Nov 11, 2024 at 11:09 PM CET, Thomas Lamprecht wrote:
> Am 08.11.24 um 15:41 schrieb Lukas Wagner:
> > The widgets for editing the headers/secrets were adapted from
> > the 'Tag Edit' dialog from PVE's datacenter options.
> >
> > Apart from that, the new dialog is rather standard. I've deci
Christian Ebner writes:
> #: proxmox-widget-toolkit/src/Utils.js:315
> -#, fuzzy
> msgid "static"
> -msgstr "Statico"
> +msgstr ""
This translation is missing.
--
Maximiliano
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.
Signed-off-by: Christian Ebner
---
it.po | 126 +++---
1 file changed, 41 insertions(+), 85 deletions(-)
diff --git a/it.po b/it.po
index a1a5c48..da5516c 100644
--- a/it.po
+++ b/it.po
@@ -81,9 +81,8 @@ msgid "ACME Directory"
msgstr "URL ACME
We serialize it as an integer for perl compatibility, so we need to also
deserialize it as such .. the latter is used in proxmox-chroot.
Otherwise, an auto-installation will fail at the end, when a
post-installation webhook is configured, while trying to run the
proxmox-chroot tool.
Reported-by:
If it is set and 0, don't warn.
Signed-off-by: Mira Limbeck
---
v2:
- added check != 0
- fixed punctuation in text
Proxmox/Install.pm | 4
1 file changed, 4 insertions(+)
diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index c64e1d4..e278917 100644
--- a/Proxmox/Install.pm
+++ b/Pr
Am 19.11.24 um 12:02 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval
> ---
> es.po | 111 +-
> 1 file changed, 48 insertions(+), 63 deletions(-)
>
>
applied, thanks!
___
pve
the ui and api talks about 'import working storage' but the error here
still said 'for extraction'. Improve the message by unifiying the
wording and adding the storage name to it too.
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
d
Am 19.11.24 um 11:12 schrieb Friedrich Weber:
> The two lists were missing the initial empty line and were
> consequently rendered as inline text, which made them hard to read.
>
> Signed-off-by: Friedrich Weber
> ---
> pveceph.adoc | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks
Am 19.11.24 um 11:30 schrieb Maximiliano Sandoval:
> The sentence is phrased in a way which is not completely clear.
>
> This matches the Backup Server license more closely:
>
> For more information, visit www.proxmox.com
> or the Proxmox Backup Server project page.
>
> Signed-of
On 11/19/24 11:45, Mira Limbeck wrote:
> Signed-off-by: Mira Limbeck
> ---
> Proxmox/Install.pm | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
> index c64e1d4..da8fb55 100644
> --- a/Proxmox/Install.pm
> +++ b/Proxmox/Install.pm
> @@ -555,6 +
Signed-off-by: Mira Limbeck
---
Proxmox/Install.pm | 4
1 file changed, 4 insertions(+)
diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index c64e1d4..da8fb55 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -555,6 +555,10 @@ sub create_lvm_volumes {
my $maxvz = Prox
The sentence is phrased in a way which is not completely clear.
This matches the Backup Server license more closely:
For more information, visit www.proxmox.com
or the Proxmox Backup Server project page.
Signed-off-by: Maximiliano Sandoval
---
Other alternatives:
- Remove the m
On 11/19/24 11:19, Stoiko Ivanov wrote:
On Tue, 19 Nov 2024 11:06:12 +0100
Hannes Dürr wrote:
I like your changes, but I would adapt the description more to the
bridge manpage [0].
[0] https://www.man7.org/linux/man-pages/man8/bridge.8.html
On 11/18/24 19:52, Stoiko Ivanov wrote:
On Tue, 1
On 11/18/24 22:15, Thomas Lamprecht wrote:
Am 18.11.24 um 16:29 schrieb Dominik Csapak:
This series enables importing ova/ovf from directory based storages,
inclusive upload/download via the webui (ova only).
It also improves the ovf importer by parsing the ostype, nics, bootorder
(and firmware
On Tue, 19 Nov 2024 11:06:12 +0100
Hannes Dürr wrote:
> I like your changes, but I would adapt the description more to the
> bridge manpage [0].
>
> [0] https://www.man7.org/linux/man-pages/man8/bridge.8.html
>
> On 11/18/24 19:52, Stoiko Ivanov wrote:
> > On Tue, 12 Nov 2024 16:54:25 +0100
>
The two lists were missing the initial empty line and were
consequently rendered as inline text, which made them hard to read.
Signed-off-by: Friedrich Weber
---
pveceph.adoc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/pveceph.adoc b/pveceph.adoc
index a828834..da39e7f 100644
--- a/pve
adds two buttons to the tree: expand all and collapse all
Signed-off-by: Dominik Csapak
---
changes from v1:
* use two buttons (negates the need for all the event handling and checking)
* use plain plus/minus icons -> i have no real preference here either,
but the plain icons look a bit weird h
Am 19.11.24 um 10:36 schrieb Dominik Csapak:
> On 11/19/24 10:30, Thomas Lamprecht wrote:
>> Am 19.11.24 um 10:22 schrieb Dominik Csapak:
>>> which defaults to expand all, and only if all expanded, collapse all.
>>>
>>> Changes icon dynamically when nodes expand/collapse.
>>>
>>> Signed-off-by: Dom
Am 19.11.24 um 10:41 schrieb Dominik Csapak:
> true, i'll send a v2 with two buttons, icons are ok for you or do you have a
> different
> sugggestion?
>
And don't get me wrong, that's certainly minor, but if the single button
is already not ideal implementation wise it might be worth to try.
An
On 11/19/24 10:39, Thomas Lamprecht wrote:
Am 19.11.24 um 10:36 schrieb Dominik Csapak:
On 11/19/24 10:30, Thomas Lamprecht wrote:
Am 19.11.24 um 10:22 schrieb Dominik Csapak:
which defaults to expand all, and only if all expanded, collapse all.
Changes icon dynamically when nodes expand/coll
On 11/19/24 10:30, Thomas Lamprecht wrote:
Am 19.11.24 um 10:22 schrieb Dominik Csapak:
which defaults to expand all, and only if all expanded, collapse all.
Changes icon dynamically when nodes expand/collapse.
Signed-off-by: Dominik Csapak
---
if we'd find an icon that would fit for both cas
Am 19.11.24 um 10:22 schrieb Dominik Csapak:
> which defaults to expand all, and only if all expanded, collapse all.
>
> Changes icon dynamically when nodes expand/collapse.
>
> Signed-off-by: Dominik Csapak
> ---
> if we'd find an icon that would fit for both cases, we could omit the
> event bu
which defaults to expand all, and only if all expanded, collapse all.
Changes icon dynamically when nodes expand/collapse.
Signed-off-by: Dominik Csapak
---
if we'd find an icon that would fit for both cases, we could omit the
event bubbling probably. If there are many nodes, the 'hasCollapsed'
Signed-off-by: Dominik Csapak
---
www/manager6/window/GuestImport.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/manager6/window/GuestImport.js
b/www/manager6/window/GuestImport.js
index 022e85a3..c242cd3f 100644
--- a/www/manager6/window/GuestImport.js
+++ b/www/manager6/window/Gu
On 11/19/24 09:15, Lukas Wagner wrote:
On Mon Nov 18, 2024 at 2:53 PM CET, Dominik Csapak wrote:
nothing special, I tested the feature using the Home Assistant .ova from
[1]. Downloaded the OVA to my local storage, pressed "import", did not
change *any* settings apart from ticking "live import".
remove reference to future ova support and only esxi as supported.
Add extra OVA/OVF section explaining some caveats.
Signed-off-by: Dominik Csapak
---
qm.adoc | 35 ---
1 file changed, 28 insertions(+), 7 deletions(-)
diff --git a/qm.adoc b/qm.adoc
index bf53e1
'import storage' is a bit amibuous as to whether it's the storage to
import from or to. To fix that, change it to 'source storage'
Signed-off-by: Dominik Csapak
---
www/manager6/window/GuestImport.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/window/GuestImp
On Mon Nov 18, 2024 at 2:53 PM CET, Dominik Csapak wrote:
> >> nothing special, I tested the feature using the Home Assistant .ova from
> >> [1]. Downloaded the OVA to my local storage, pressed "import", did not
> >> change *any* settings apart from ticking "live import".
> >> The import works, but
98 matches
Mail list logo
