ove that? Patch attached.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
diff --git a/src/test/recovery/t/005_replay_delay.pl
b/src/test/recovery/t/005_replay_delay.pl
index 7f177afaed..496fa40fe1 100644
--- a/src/
On 2021/05/19 14:34, Bharath Rupireddy wrote:
On Wed, May 19, 2021 at 8:28 AM Fujii Masao wrote:
I agree with throwing an error for non-numeric junk though.
Allowing that on the grounds of backwards compatibility
seems like too much of a stretch.
+1.
+1.
+1
Thanks all for your
he messages. But this change also seems to get rid of
the information about the data type of the option from the message.
I'm not sure if this is an improvement. Probably isn't it better to
convert "requires a non-negative integer value" to "must be an integer value
greater than zero"?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2021/05/19 19:24, Fujii Masao wrote:
On 2021/05/19 16:43, Kyotaro Horiguchi wrote:
+1 for adding some tests for pg_wal_replay_pause() but the test seems
like checking only that pg_get_wal_replay_pause_state() returns the
expected state value. Don't we need to check that the recove
s would be beyond refactoring,
though.
Isn't it useful to react the interrupts (e.g., shutdown requests)
soon even during waiting for the result of DEALLOCATE ALL?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
s by the commit and
make make_etags work with that ctags? Or, we should support
only Exuberant-type ctags (btw, I'm ok with this) and get rid of
something like the above code?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
sage mentioning make_ctags
(not make_etags). Isn't this confusing?
$ ./src/tools/make_etags -a
Usage: /.../make_ctags [-e][-n]
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
ags
supporting -e option. But does such ctags really exist?
I fixed the above issues and refactored the code.
Attached is the updated version of the patch. Thought?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATIONdiff --git a
" and
return -1 if either of those bits is set?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
;a=commitdiff;h=249b0409b181311bb1c375311e43eb767b5c3bdd
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATIONFrom 74a89cac092969208067143d25743b40ddbfbfb0 Mon Sep 17 00:00:00 2001
From: Fujii Masao
Date: Sat, 1 Oct 2022 12:51:45 +0900
Subject: [PATCH]
!
-
+ printf("fork child process\n");
+ printf(" am_walsender: %d\n", am_walsender);
+ printf(" am_db_walsender: %d\n", am_db_walsender);
The patch seems to include the debug code accidentally.
Except this, the patch looks good to
On 2022/09/30 16:54, bt22nakamorit wrote:
2022-09-21 11:45 に Fujii Masao wrote:
We can execute the shell commands via psql in various ways
other than \! meta-command. For example,
* `command`
* \g | command
* \gx | command
* \o | command
* \w | command
* \copy ... program 'co
On 2022/10/07 18:43, bt22nakamorit wrote:
2022-10-07 16:59 Fujii Masao wrote:
s/subscriber/publisher ?
I did not understand what this means.
Sorry for confusing wording... I was just trying to say that walsender
is connected to a database of the publisher instead of subscriber
On 2021/05/31 17:18, Kyotaro Horiguchi wrote:
Sorry for missing this.
At Mon, 31 May 2021 12:52:54 +0900, Fujii Masao
wrote in
On 2021/05/19 19:24, Fujii Masao wrote:
On 2021/05/19 16:43, Kyotaro Horiguchi wrote:
+1 for adding some tests for pg_wal_replay_pause() but the test seems
anyway?
Thanks for the input, I have applied the patch.
Thanks a lot!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
er" command for
archive_command, or implement something like pg_archivecopy command
into the core (as far as I remember, there was the discussion about
this feature before...)?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
gExplainInterrupt(),
"ProcessLogExplainInterrupt()" should be "ProcessLogCurrentPlanInterrupt()"?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
user);
MarkConnectionModified() should be called also when TRUNCATE on
a foreign table is executed?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
again. I think that's at least 50% of how this feature might end up being
used.
Yes, it would have an effect when the server is automatically restarted
after crash when restart_after_crash is enabled. At least for me +1 to
your proposed change.
Regards,
--
Fujii Masao
Advanced Computi
uot;",
IMO the error message should be "invalid value for integer option..." here
because of the same reason I told above. Thought?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2021/06/30 23:31, Bharath Rupireddy wrote:
On Wed, Jun 30, 2021 at 5:53 PM Fujii Masao wrote:
On 2021/05/20 1:01, Bharath Rupireddy wrote:
Thanks for the comments. I added separate messages, changed the error
code from ERRCODE_SYNTAX_ERROR to ERRCODE_INVALID_PARAMETER_VALUE and
also
On 2021/06/22 11:30, torikoshia wrote:
On Thu, Jun 10, 2021 at 11:09 AM torikoshia wrote:
On 2021-06-09 23:04, Fujii Masao wrote:
> auto_explain can log the plan of even nested statement
> if auto_explain.log_nested_statements is enabled.
> But ISTM that pg_log_current_plan() c
atements entries.
The default value is off.
Only superusers can change this setting.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2021/07/01 13:16, Bharath Rupireddy wrote:
On Thu, Jul 1, 2021 at 8:23 AM Fujii Masao wrote:
The recent commit 61d599ede7 documented that the type of those options is
floating point. But the docs still use "is a numeric value" in the descriptions
of them. Probably it should b
On 2021/07/01 21:41, Bharath Rupireddy wrote:
On Thu, Jul 1, 2021 at 6:07 PM Fujii Masao wrote:
On 2021/07/01 13:16, Bharath Rupireddy wrote:
On Thu, Jul 1, 2021 at 8:23 AM Fujii Masao wrote:
The recent commit 61d599ede7 documented that the type of those options is
floating point. But
On 2021/07/07 18:09, Julien Rouhaud wrote:
On Thu, Jul 1, 2021 at 4:28 PM Fujii Masao wrote:
I'm fine with this. So what about the following diff? I added tag.
pg_stat_statements.track_planning controls whether
planning operations and duration are tracked by the m
should be non-negative. */
Isn't it better to replace this with "Number of workers should be greater than
zero"
rather than removing the comment?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
top and
sub transaction in the differenet layer and to use old and new API for them.
OTOH, I'm afraid that adding new (not-essential) API for foreign subtransaction
might increase the code complexity unnecessarily.
Thought?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research an
uot;timeout\"
must not be negative")));
src/backend/commands/functioncmds.c:
errmsg("COST must be positive")));
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
nk that we should disallow BASE_BACKUP
to run while a backup is already in progress in the *same* session
as we already do this for pg_backup_start(). Thought? I included
the code to disallow that in the attached patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and D
Hi,
I found that there is no index item for MERGE command, in the docs.
Attached is the patch that adds the indexterm for MERGE to merge.sgml.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATIONdiff --git a/doc/src/sgml/ref
still thinking that the patch I posted is simpler and enough.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2022/06/30 18:57, Alvaro Herrera wrote:
On 2022-Jun-30, Fujii Masao wrote:
Hi,
I found that there is no index item for MERGE command, in the docs.
Attached is the patch that adds the indexterm for MERGE to merge.sgml.
+1 LGTM, thanks.
Thanks for the review! Pushed.
Regards
ss in this session")));
I think we can move it to the beginning of SendBaseBackup() so we can
avoid bbsink initialization and cleanup in the error case.
Sounds good idea to me. I updated the patch in that way. Attached.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research
On 2022/07/01 15:41, Michael Paquier wrote:
On Fri, Jul 01, 2022 at 03:32:50PM +0900, Fujii Masao wrote:
Sounds good idea to me. I updated the patch in that way. Attached.
Skimming quickly through the thread, this failure requires a
termination of a backend running BASE_BACKUP. This is
+* updator of these variables.
Isn't it better to add "at this time" or something at the end of the comment
because only we're not always updator of them? No?
Barring any objection, I'm thinking to apply the above small change and commit
the p
e're not always updator of them? No?
Excluding initialization, (I believe) checkpointer is really the only
updator of the variables/members. But I'm fine with the addition.
Ok, so I modified the patch slightly and pushed it. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Techn
to commit it.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2022/07/07 9:09, Michael Paquier wrote:
On Wed, Jul 06, 2022 at 11:27:58PM +0900, Fujii Masao wrote:
For the test, BASE_BACKUP needs to be canceled after it finishes
do_pg_backup_start(), i.e., checkpointing, and before it calls
do_pg_backup_stop(). So the timing to cancel that seems more
y-for-committer,
and will commit it barring any objeciton.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
me except the following thing.
TRUNCATE
—
- Tables
+ Tables and foreign tables
You added "foreign tables" for BEFORE statement-level trigger as the above, but
ISTM that you also needs to do that for AFTER statement-level trigger. No?
Regards,
--
F
On 2022/07/08 0:33, Tom Lane wrote:
Fujii Masao writes:
On 2022/06/30 10:48, Yugo NAGATA wrote:
When a foreign table has handler but doesn't support TRUNCATE,
an error "cannot truncate foreign table xxx" occurs. So, what
about adding a test this message output? We can ad
IP patch to add pg_backup_label function. No tests nor docs
have been added yet, but if we can successfully reach the consensus for adding
the function, I will update the patch.
Thought?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CO
M.
Barring any objection, I will commit the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
. Thanks for the clarification!
So I pushed the v2 patch that Yugo-san posted. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2022/07/14 17:00, Michael Paquier wrote:
On Fri, Jul 08, 2022 at 08:56:14AM -0400, Robert Haas wrote:
On Thu, Jul 7, 2022 at 10:58 AM Fujii Masao wrote:
But if many think that it's worth adding the test, I will give a
try. But even in that case, I think it's better to commit th
on foreign table with file_fdw. So barring any objection, I will
commit the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
et command.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2022/07/15 16:52, Fujii Masao wrote:
On 2022/07/08 17:03, Etsuro Fujita wrote:
Rather than doing so, I'd vote for adding a test case to file_fdw, as
proposed in the patch, because that would be much simpler and much
less expensive.
So ISTM that most agreed to push Nagata-san&#x
e
patches.
Fine by me.
I pushed these bugfix patches at first. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
the log message and
sounds confusing because, as far as I recall correctly, we removed the concept of primary
and secondary checkpoints before.
Therefore I think that it's better to remove "whichChkpt" argument in
ReadCheckpointRecord().
Patch attached. Thought?
Regards,
--
Fujii Masao
On 2022/07/21 10:13, Masahiko Sawada wrote:
Hi,
I realized that standby_desc_running_xacts() in standbydesc.c doesn't
describe subtransaction XIDs. I've attached the patch to improve the
description.
+1
The patch looks good to me.
Regards,
--
Fujii Masao
Advanced Computing
s like data loss, corruption, etc. That is, I'm concerned
about that some users might quickly run pg_resetwal because hint message says
that, without reading the docs nor understanding those risks.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarte
execution was
supported in postgres_fdw.
if (PQsendQuery(fsstate->conn, sql) < 0)
pgfdw_report_error(ERROR, NULL, fsstate->conn, false,
fsstate->query);
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquart
On 2022/07/21 14:54, Kyotaro Horiguchi wrote:
I agree to removing the two parameters. And agree to let
ReadCheckpointRecord not conscious of the location source.
Thanks for the review!
At Thu, 21 Jul 2022 11:45:23 +0900, Fujii Masao
wrote in
Agreed. Attached is the updated version of
On 2022/07/21 23:41, Japin Li wrote:
On Thu, 21 Jul 2022 at 22:22, Fujii Masao wrote:
Hi,
I found that fetch_more_data_begin() in postgres_fdw reports an error when
PQsendQuery() returns the value less than 0 as follows though PQsendQuery() can
return only 1 or 0. I think this is a bug
n from the existing calls to errmsg(). Removing extra
parens can interfere with back-patching of the changes around those errmsg(),
can't it?
Anyway, at first I pushed the 0001 patch that removes useless arguments in
ReadCheckpointRecord().
Regards,
--
Fujii Masao
Advanced Computing Te
) and
pgfdw_finish_pre_subcommit_cleanup()
are no longer necessary and 0003 patch removes them.
[1] https://commitfest.postgresql.org/38/3392/
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATIONFrom aa115d03880968c2e5bab68415e06e17a337a45b Mo
On 2022/07/26 9:42, Kyotaro Horiguchi wrote:
At Sun, 24 Jul 2022 22:40:16 -0400, Tom Lane wrote in
Fujii Masao writes:
On 2022/07/22 17:31, Kyotaro Horiguchi wrote:
I believed that it is recommended to move to the style not having the
outmost parens. That style has been introduced by
ix the annotations for less confusion.
Thanks for the patch! LGTM. I will commit it.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
exposing the information commented on
the top of basic_archive.c.
Anyway, since the patches look good to me, I pushed them. Thanks a lot!
If necessary, we can keep improving the docs later.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
the function are the toplevel-dedicated stuff.
Same as above.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2022/07/26 19:26, Etsuro Fujita wrote:
Thanks for working on this! I'd like to review this after the end of
the current CF.
Thanks!
Could you add this to the next CF?
Yes.
https://commitfest.postgresql.org/39/3782/
Regards,
--
Fujii Masao
Advanced Computing Technology C
On 2022/07/27 1:29, Zhang Mingli wrote:
Thanks!
Pushed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2022/07/27 10:36, Kyotaro Horiguchi wrote:
At Tue, 26 Jul 2022 18:33:04 +0900, Fujii Masao
wrote in
I'm not sure the two are similar with each other. The new function
pgfdw_exec_pre_commit() looks like a merger of two isolated code paths
intended to share a seven-line codelet. I
eed to wake walwriter up here
so that it can call NotifySegmentsReadyForArchive(LogwrtResult.Flush) gain.
Thought?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
onnection delay when -C is not
specified. I attached the updated patch for pg13 as well as one for pg14
which is same as attached before.
Thanks! I pushed the part of the patch, which gets rid of unnecessary
measure of connection delays from pgbench.
Regards,
--
Fujii Masao
Advanced Computing
orted.
Therefore, IMO that the simple approach to fix the issue is to create
an archive notification file if possible at the end of XLogWalRcvWrite().
I implemented this idea. Patch attached.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPOR
le to make the startup
process call XLogArchiveCheckDone() or something whenever it moves
the next segment, rather than make walreceiver do that. Thought?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
-san's latest
patch,
I just modified the comment slightly and ran pgindent. Barring any objection,
I will commit this patch only in master and v14.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
diff --git a/src/bin/pg
tated before you need the info,
and it can be troublesome to find the information at the OS level, if
you're lucky enough to have OS access.
+1
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
seems doable.
Yes.
Does this make sense?
Yes, I think!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
27;ve not found real use case that implementing the feature
in libpq would introduce. So IMO postgres_fdw version is better.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
mple by a
sigkill or a power cut, though.
What happens if the server is promoted before that walreceiver is invoked?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2021/09/01 12:15, Andres Freund wrote:
Hi,
On 2021-09-01 11:34:34 +0900, Fujii Masao wrote:
On 2021/09/01 0:53, Andres Freund wrote:
Of course, we need to be careful to not weaken WAL validity checking too
much. How about the following:
If we're "aborting" a continued
On 2021/09/01 1:10, Fujii Masao wrote:
+1. So we reached the consensus!
Attached is the updated version of the patch. Based on Nagata-san's latest
patch,
I just modified the comment slightly and ran pgindent. Barring any objection,
I will commit this patch only in master and v14.
P
/3282/>
Attached is the updated version of the patch. In this patch, I updated
the description for pg_stat_reset_single_table_counters() in pg_proc.dat.
Barring any objection, I will commit this patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development
On 2021/07/17 2:19, vignesh C wrote:
Thanks for the patch, the changes look good to me.
The patch looks good to me, too. Pushed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
erent records for REFRESH MATERIALIZED VIEW
commands on different views. So ISTM that we can aggregate the information
per view, from pg_stat_statements. No?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
name overrides application_name set in foreign server
object.
Shouldn't this information be documented?
Isn't it better to have the regression test for this feature?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
/* reset any error XLogReaderValidatePageHeader() might
have set */
+ xlogreader->errormsg_buf[0] = '\0';
+ }
goto retry;
+ }
else
return -1;
}
Regards,
--
Fujii Masao
Advanced
On 2021/09/02 13:36, Sadhuprasad Patro wrote:
Yes this update is fine.. Please commit this patch...
Yeah, pushed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
just tries to reset
errormsg_buf whenever XLogPageRead() retries, whatever error happened
before. Also if errormsg_buf is set at that moment, it's reported.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
mplifying this description as follows?
---
Sets the application name to be used on the remote server.
---
+ Configuration Parameters
+
The empty characters just after and before should be removed?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2021/09/02 20:54, houzj.f...@fujitsu.com wrote:
Hi,
When reviewing other patches, I noticed two typos:
Thanks! Both fixes look good to me.
Barring any objection, I will commit the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
Thanks for clarifying this!
Does that makes sense?
Yes, I'm fine with your latest patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
segment
including XLOG_SWITCH record if the notification file has not been created yet.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
diff --git a/src/backend/access/transam/xlog.c
b/src/backend/access/transam/xlog.c
index
without
checking outstanding skipped transactions. Therefore the "issue" that
some skipped transactions are not counted is not one the patch newly introdues.
So that behavior change by the patch would be acceptable.
Is this understanding right?
Regards,
--
Fujii Masao
Advanced Computing
ase. So what about something like
the following?
LOG: could not map anonymous shared memory (%zu bytes) with huge pages enabled
HINT: The server will map anonymous shared memory again with huge pages
disabled.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On 2021/09/03 23:27, Tom Lane wrote:
Fujii Masao writes:
IMO, if the level is promoted to LOG, the message should be updated
so that it follows the error message style guide. But I agree that simpler
message would be better in this case. So what about something like
the following?
LOG
ttached is the updated version of the patch. I removed the test
for case (1). And I arranged the regression tests so that they are based
on debug_discard_caches, to simplify them. Also I added and updated
some comments and docs. Could you review this version?
Regards,
--
Fujii Masao
Advanced Comput
On 2021/09/02 21:47, Fujii Masao wrote:
On 2021/09/02 20:54, houzj.f...@fujitsu.com wrote:
Hi,
When reviewing other patches, I noticed two typos:
Thanks! Both fixes look good to me.
Barring any objection, I will commit the patch.
Pushed. Thanks!
Regards,
--
Fujii Masao
Advanced
On 2021/09/06 10:32, kuroda.hay...@fujitsu.com wrote:
I think we should SELECT ft6 because foreign server 'loopback'
doesn't have application_name server option.
Yes. I forgot to update that... Thanks for the review!
Attached is the updated version of the patch.
Regards,
fferent encodings. How should
pg_stat_activity.application_name and log_line_prefix, etc handle such case?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
?
I think so.
+1
One question is; which version do we want to back-patch to?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
immediately if the page header is not valid. Instead, XLogReadRecord() is
responsible to check the page header.
-
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
and docs related to the patch, I found
these descriptions in pgbench docs. The first description needs to be
updated? Because even database error (e.g., failure of connection for setup)
can result in exit status 1 if it happens before the benchmark actually runs.
Regards,
--
Fujii Masao
Advanced Computi
On 2021/09/07 10:32, kuroda.hay...@fujitsu.com wrote:
Dear Fujii-san,
I confirmed it and I think it's OK.
Other comments should be included in 0002.
Pushed 0001 patch. Thanks!
Could you rebase 0002 patch?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Researc
ause it's self-contained and can be applied separately.
Patch attached.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
diff --git a/src/backend/replication/walreceiver.c
b/src/backend/replication/walreceiver.c
index 9a2bc37
start
the server. Those who don't need huge pages but just use the default
setting might think that such log messages would be noisy.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
901 - 1000 of 1911 matches
Mail list logo
