On 2021/08/26 12:13, Yugo NAGATA wrote:
Ok. That makes sense. The output reports "including connections establishing" and "excluding connections establishing" regardless with -C, so we should measure delays in the same way.
On second thought, it's more reasonable and less confusing not to measure the disconnection delays at all? Since whether the benchmark result should include the disconnection delays or not is not undocumented, probably we cannot say strongly the current behavior (i.e., the disconnection delays are not measured) is a bug. Also since the result has not included the disconnection delays so far, the proposed change might slightly change the benchmark numbers reported, which might confuse the users. ISTM that at least it's unwise to change long-stable branches for this... Thought?
I updated the patch for pg13 to measure disconnection delay when -C is not specified. I attached the updated patch for pg13 as well as one for pg14 which is same as attached before.
Thanks! I pushed the part of the patch, which gets rid of unnecessary measure of connection delays from pgbench. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION
