On 2021/07/01 21:41, Bharath Rupireddy wrote:
On Thu, Jul 1, 2021 at 6:07 PM Fujii Masao <masao.fu...@oss.nttdata.com> wrote:
On 2021/07/01 13:16, Bharath Rupireddy wrote:
On Thu, Jul 1, 2021 at 8:23 AM Fujii Masao <masao.fu...@oss.nttdata.com> wrote:
The recent commit 61d599ede7 documented that the type of those options is
floating point. But the docs still use "is a numeric value" in the descriptions
of them. Probably it should be replaced with "is a floating point value" there.
If we do this, isn't it better to use "floating point" even in the error
message?
Agreed. PSA v5 patch.
Thanks for updating the patch! LGTM.
Barring any objection, I will commit this patch.
Thanks.
One question is; should we back-patch this? This is not a bug fix,
so I'm not sure if it's worth back-patching that to already-released versions.
But it may be better to do that to v14.
IMO, it's a good-to-have fix in v14. But, -1 for backpatching to v13
and lower branches.
Agreed. So I pushed the patch to master and v14. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
