On 2021/07/29 13:23, Yugo NAGATA wrote:
Hello,
On Fri, 18 Jun 2021 15:58:48 +0200 (CEST)
Fabien COELHO <coe...@cri.ensmp.fr> wrote:
Attached Yugo-san patch with some updates discussed in the previous mails,
so as to move things along.
I attached the patch rebased to a change due to 856de3b39cf.
+ pg_log_fatal("connection for initialization failed");
+ pg_log_fatal("setup connection failed");
+ pg_log_fatal("cannot create connection for client
%d",
These fatal messages output when doConnect() fails should be a bit more
consistent each other? For example,
could not create connection for initialization
could not create connection for setup
could not create connection for client %d
I'm not sure, but *if* "xxx failed" is more proper for pgbench, what about
connection for initialization failed
connection for setup failed
connection for client %d failed
Exit status 1 indicates static problems such as invalid command-line options.
Errors during the run such as database errors or problems in the script will
result in exit status 2.
While reading the code and docs related to the patch, I found
these descriptions in pgbench docs. The first description needs to be
updated? Because even database error (e.g., failure of connection for setup)
can result in exit status 1 if it happens before the benchmark actually runs.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
