Hi,
> I have noticed 11 callers of SearchSysCache*() that pass down
> an Oid instead of a Datum.
Good catch.
> I think that we'd better be consistent here, even if there is
> no actual bug.
>
+1
--
Best regards,
Aleksander Alekseev
mindful that your functions will become a target for privilege
escalation, so you should be extra careful with the implementation.
[1]: https://www.postgresql.org/docs/current/sql-createfunction.html
--
Best regards,
Aleksander Alekseev
] https://commitfest.postgresql.org/44/4447/
--
Best regards,
Aleksander Alekseev
v2-0002-Rename-OverrideSearchPath-to-SearchPathMatcher.patch
Description: Binary data
v2-0001-Remove-unused-search_path-override-stack.patch
Description: Binary data
of them. PFA the
updated patch v2.
--
Best regards,
Aleksander Alekseev
v2-0001-Pass-Datum-to-SearchSysCache-instead-of-Oid.patch
Description: Binary data
;t be 100% sure but it looks like that's all of them. PFA the
> updated patch v2.
Added a CF entry, just in case:
https://commitfest.postgresql.org/44/4448/
--
Best regards,
Aleksander Alekseev
n event
trigger for REINDEX so far.
--
Best regards,
Aleksander Alekseev
necessary.
--
Best regards,
Aleksander Alekseev
, etc. I would suggest focusing on delivering this
part, assuming there will be no push-back to the refactorings and
slight test improvements. If 0002 could be further decomposed into
separate iterative improvements this could be helpful.
--
Best regards,
Aleksander Alekseev
rely since its practical
value seems to be debatable.
The patch was added to the nearest commitfest [1].
Thoughts?
[1]: https://commitfest.postgresql.org/44/4451/
--
Best regards,
Aleksander Alekseev
Hi,
Currently InitCatalogCache() has only one Assert() for cacheinfo[]
that checks .reloid. The proposed patch adds sanity checks for the
rest of the fields.
--
Best regards,
Aleksander Alekseev
v1-0001-Check-more-invariants-during-syscache-initializat.patch
Description: Binary data
he community thinks.
[1] https://commitfest.postgresql.org/44/4456/
--
Best regards,
Aleksander Alekseev
oposed new Asserts() make a
huge difference. I merely noticed that InitCatalogCache checks only
cacheinfo[cacheId].reloid. Checking the rest of the values would be
helpful for the developers and will not impact the performance of the
release builds.
--
Best regards,
Aleksander Alekseev
s removing the comment instead.
InvalidateSystemCachesExtended() is an internal function of inval.c. Make it
static.
"""
--
Best regards,
Aleksander Alekseev
v1-0001-Refactor-inval.c-and-inval.h.patch
Description: Binary data
functions" comment, then we're still
> inside a section that starts with the "private support functions"
> comment, which seems even worse to me than the current situation.
Fixed.
--
Best regards,
Aleksander Alekseev
v2-0001-Refactor-inval.c-and-inval.h.patch
Description: Binary data
t. That's correct.
> Still it's hard to miss at compile time. I think that I would remove
> this one.
Fair enough. Here is the updated patch.
--
Best regards,
Aleksander Alekseev
v2-0001-Check-more-invariants-during-syscache-initializat.patch
Description: Binary data
t;alloc_tuple_size = alloc_len;
| ^~
[829/1882] Compiling C object contrib/xml2/pgxml.so.p/xpath.c.o
```
On top of that IMO it doesn't make much sense to keep a one-field
wrapper structure. Perhaps we should get rid of it entirely and just
use HeapTupleData instead.
Thoughts?
--
Best regards,
Aleksander Alekseev
ything in this respect in v2. Feedback from the
community would be much appreciated.
[1]: https://commitfest.postgresql.org/44/4461/
--
Best regards,
Aleksander Alekseev
v2-0001-Remove-unused-fields-in-ReorderBufferTupleBuf.patch
Description: Binary data
o I abandoned that idea for now.
> Alternatively we could convert ReorderBufferTupleBufData macro to an
> inlined function. At least it will add some type safety.
Here is v3 that implements it too as a separate patch.
Apologies for the noise.
--
Best regards,
Aleksander Alekseev
v3-0001-Remo
p/pg_backup_tar.c: if (oid != 0)
> .//src/bin/pg_dump/pg_backup_custom.c: while (oid != 0)
> .//src/bin/pg_dump/pg_backup_custom.c: while (oid != 0)
> ```
> That is another story…I would like provide a patch if it worths.
Good catch. Please do so.
--
Best regards,
Aleksander Alekseev
library and +1 to the properly licensed
C implementation without 3rd party dependencies from me. Especially
considering the fact that the implementation seems to be rather
simple.
--
Best regards,
Aleksander Alekseev
ther files since Zhang
wants to propose the corresponding patch.
--
Best regards,
Aleksander Alekseev
v3-0001-Check-more-invariants-during-syscache-initializat.patch
Description: Binary data
Agree, something goes wrong when using Autotools (but not Meson) on
both Linux and MacOS. I didn't investigate the issue though.
--
Best regards,
Aleksander Alekseev
v2-0001-TODO-FIXME-write-a-proper-commit-message-this-is-.patch
Description: Binary data
y should be reserved for the WAL replay
and perhaps other needs. In the recent case the system should account
for the overcommitment of the OS - cases when a successful malloc()
doesn't necessarily allocate the required amount of *physical* memory,
as it's done on Linux.
--
Best regards,
Aleksander Alekseev
a GUC check hook to do the verification
> instead of coding it in bootstrap.c. This might be overkill, but that
> way the check is in the right place and it becomes more self-documenting.
I reviewed the code and tested it on Linux and MacOS with Autotools
and Meson. The patch LGTM.
--
Best regards,
Aleksander Alekseev
o one asked to do and no one cares
about. Perhaps this function should be refactored too for consistency.
Thoughts?
--
Best regards,
Aleksander Alekseev
pq_putmessage(PqMsg_Close, completionTag, len + 1);
case DestNone:
case DestDebug
```
It should have been PqMsg_CommandComplete.
[1]: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=f4b54e1ed98
--
Best regards,
Aleksander Alekseev
Hi,
> here is a patch - all tests passed
LGTM and added to the nearest CF just in case [1].
[1]: https://commitfest.postgresql.org/44/4523/
--
Best regards,
Aleksander Alekseev
Hi Peter,
> I would like to be the commitfest manager for CF 2023-09.
Many thanks for volunteering! If at some point you will require a bit
of help please let me know.
--
Best regards,
Aleksander Alekseev
Oversight of 0294df2f1f84 [1].
[1]: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=0294df2f1f84
--
Best regards,
Aleksander Alekseev
v1-0001-Replace-constant-3-with-NUM_MERGE_MATCH_KINDS.patch
Description: Binary data
Hi,
> I guess the argument against inserting an enum element at the end is
> that a switch statement on the enum value might generate a compiler
> warning if it didn't have a default clause.
Fair point. PFA the alternative version of the patch.
--
Best regards,
Aleksander Alek
gt; people than use foreign keys. So I suggest something like the
> attached.
I don't mind changing the chapter, but I prefer the wording chosen in
v3. The explanation in v4 is somewhat hard to follow IMO.
--
Best regards,
Aleksander Alekseev
integrity. It is the trigger programmer's
> responsibility to avoid that.
That's perfect!
--
Best regards,
Aleksander Alekseev
Hi,
> > Fair point. PFA the alternative version of the patch.
> >
>
> Thanks. Committed.
Thanks. I see a few pieces of code that use special FOO_NUMBER enum
values instead of a macro. Should we refactor these pieces
accordingly? PFA another patch.
--
Best regards,
Aleksander
bit to
> just fix this).
Indeed, there is no @(box,box) or ~(box,box) in the \dAo output. These
operators were removed by 2f70fdb0644c back in 2020.
I will submit a patch for the documentation shortly. Thanks for reporting.
--
Best regards,
Aleksander Alekseev
out that
> > before I try to submit a patch (also very happy for someone with a
> > committer bit to just fix this).
>
> Indeed, there is no @(box,box) or ~(box,box) in the \dAo output. These
> operators were removed by 2f70fdb0644c back in 2020.
>
> I will submit a patch for the documentation shortly. Thanks for reporting.
Here is the patch.
--
Best regards,
Aleksander Alekseev
v1-0001-Remove-mention-of-and-operators.patch
Description: Binary data
ss and few reverts!
Completely deserved. Congrats!
--
Best regards,
Aleksander Alekseev
integers rather than by 32-bit ones" where the authors are:
Maxim Orlov, Aleksander Alekseev, Alexander Korotkov, Teodor Sigaev,
Nikita Glukhov, Pavel Borisov, Yura Sokolov.
--
Best regards,
Aleksander Alekseev
ense, it can be resurrected (probably with a better
> implementation).
>
> Any objections to fixing this in 17 by removing it? (cc:ing Michael from the
> RMT)
+1 Something that is not documented or used by anyone (apparently) and
is broken should just be removed.
--
Best regards,
Aleksander Alekseev
ast enum items.
Thanks, fixed.
--
Best regards,
Aleksander Alekseev
v2-0001-Use-macro-to-define-the-number-of-enum-values.patch
Description: Binary data
ting the long options with hyphens should generally be
> preferred in documentation.
Thanks for all your great input. Here is the updated patch.
--
Best regards,
Aleksander Alekseev
From 1d55400adba93381d8a08249c95e4e16fb9a5945 Mon Sep 17 00:00:00 2001
From: "David G. Johnston"
Hi,
> Thanks for all your great input. Here is the updated patch.
Here is the patch v4 with fixed typo ("geoq"). Per off-list feedback
from Alvaro - thanks!
--
Best regards,
Aleksander Alekseev
v4-0001-Clarify-error-message-about-specifying-config-fil.patch
Description: Binary data
q.sgml and config.sgml bits
> which are improvements of their own.
Thanks, Michael.
I propose my original v1 patch for correcting the --help output of
'postgres' too. I agree with the above comments that corresponding
changes in v4 became somewhat unwieldy.
--
Best regards,
Ale
of the June - feel free to register anyway.
> If you do not have a ticket to StHighload - we have some speaker entrance
> tickets.
> At the moment we have 4 potential patch authors ready to present.
>
> Please contact me with any questions regarding the event. Thanks!
Great initiative, thanks!
--
Best regards,
Aleksander Alekseev
> I agree that it's not necessary or particularly useful for this hint
> to be exhaustive. I could get behind your suggestion of
> s/You must specify/Specify/, but I also think it's fine to do nothing.
Fair enough, let's leave the help message as is then. I closed the
corresponding CF entry.
--
Best regards,
Aleksander Alekseev
. See also commit 260a1f18 [1] and PostgreSQL documentation [2].
[1]: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=260a1f18
[2]: https://www.postgresql.org/docs/16/xfunc-c.html
--
Best regards,
Aleksander Alekseev
gresql.org/docs/devel/install-meson.html
[2]: https://www.postgresql.org/docs/devel/installation-platform-notes.html
--
Best regards,
Aleksander Alekseev
he buildfarm we seem to use Ninja >= 1.11.1.
However since Meson can use both Ninja and VS as a backend I'm not
certain which section would be most appropriate for naming the minimal
required version of Ninja.
--
Best regards,
Aleksander Alekseev
v1-0001-Meson-is-not-experimental-on-Windows.patch
Description: Binary data
v1-0002-Rename-section-17.7.5-to-Visual-Studio.patch
Description: Binary data
inimal example on GitHub and asking here.
By a quick look I couldn't find an example of implementing a
CustomScan in ./contrib/ or ./src/test/. If you can think of a usage
example of CustomScans, consider contributing a test case.
[1]: https://www.postgresql.org/docs/current/custom-scan.html
[2]: https://github.com/timescale/timescaledb/
--
Best regards,
Aleksander Alekseev
mention of
--backend option from [1] until it will, in order to avoid any
confusion.
[1]: https://www.postgresql.org/docs/devel/install-meson.html
--
Best regards,
Aleksander Alekseev
#x27;t give any
value that would make it worth maintaining.
--
Best regards,
Aleksander Alekseev
most people are going to use, but it shouldn't be difficult to
implement and/or maintain either.
Thoughts?
--
Best regards,
Aleksander Alekseev
;"
I did my best to get rid of any ambiguity. The patch is attached.
[1]: https://www.postgresql.org/docs/current/storage-toast.html
--
Best regards,
Aleksander Alekseev
v1-0001-Clarify-the-comments-about-varlena-header-encodin.patch
Description: Binary data
sed patch fixes this.
--
Best regards,
Aleksander Alekseev
v1-0001-ALTER-TABLE-.-SET-STORAGE-default.patch
Description: Binary data
Hi hackers,
The proposed patch adds the missing tab completion for 'ALTER TABLE
... SET COMPRESSION ...' syntax.
--
Best regards,
Aleksander Alekseev
v1-0001-Tab-completion-for-SET-COMPRESSION.patch
Description: Binary data
that a sub-optimal but consistent syntax
that does the job is better than inconsistent syntax and figuring out
the default storage strategy manually.
But let's see what is others people opinion.
--
Best regards,
Aleksander Alekseev
` branch for the September CF?
--
Best regards,
Aleksander Alekseev
Hi Daniel,
> it seems we can consider retiring them in v16.
Looks good to me. A link to the discussion was added to the patch.
--
Best regards,
Aleksander Alekseev
v2-0001-pgcrypto-Remove-unused-mbuf-code.patch
Description: Binary data
the
CF application in order to play it safe. Let's see what cfbot will
tell us.
--
Best regards,
Aleksander Alekseev
Hi again,
> I'm pretty sure this change is fine too, but I added the patch to the
> CF application in order to play it safe. Let's see what cfbot will
> tell us.
I see a little race condition happen :) Sorry for this.
--
Best regards,
Aleksander Alekseev
ink this should be backported?
--
Best regards,
Aleksander Alekseev
v2-0001-Fix-incorrect-uses-of-Datum-conversion-macros.patch
Description: Binary data
v2-0002-Convert-GetDatum-and-DatumGet-macros-to-inline-fu.patch
Description: Binary data
ime I encounter the
question of ABI compatibility in the context of Postgres, so I would
appreciate it if you could elaborate a bit.
--
Best regards,
Aleksander Alekseev
hash_ctx *) PointerGetDatum(foundres);
+(pg_cryptohash_ctx *) DatumGetPointer(foundres);
```
This being said, personally I don't have a strong opinion here. After
all, the code works and passes the tests. Maybe I'm just being a
perfectionist here.
--
Best regards,
Aleksander Alekseev
Hi hackers,
> Cfbot is making its mind at the moment of writing.
Here is v3 with silenced compiler warnings.
--
Best regards,
Aleksander Alekseev
v3-0002-Convert-GetDatum-and-DatumGet-macros-to-inline-fu.patch
Description: Binary data
v3-0001-Fix-incorrect-uses-of-Datum-convers
Hi hackers,
> Here is v3 with silenced compiler warnings.
Some more warnings were reported by cfbot, so here is v4. Apologies
for the noise.
--
Best regards,
Aleksander Alekseev
v4-0001-Fix-incorrect-uses-of-Datum-conversion-macros.patch
Description: Binary data
v4-0002-Convert-GetDa
l join this
effort as a co-author in order to implement the suggested improvements
(and perhaps some improvements that were not suggested yet). Meanwhile
I'm going to keep the current version of the patch up to date with the
`master` branch.
--
Best regards,
Aleksander Alekseev
v7-0001-Compression-dictionaries-for-JSONB.patch
Description: Binary data
ports a bottleneck for this particular reason.
We can optimize the code when and if this will happen.
--
Best regards,
Aleksander Alekseev
tch is attached.
--
Best regards,
Aleksander Alekseev
v1-0001-Add-psql-tab-compression-for-OF-NOT-OF-with-ALTER.patch
Description: Binary data
ence between the header and
the type tag here will create even more confusion.
> And I don't think the new comments referring to "third case", "first
> two cases", etc make it easier to follow.
Maybe you are right. I'm open to suggestions.
--
Best regards,
Aleksander Alekseev
Hi Shinya,
> A minor modification has been made so that the composite type is also
> completed after "ALTER TABLE OF".
LGTM. Here is v3 created with `git format-path`. Unlike v2 it also
includes the commit message.
--
Best regards,
Aleksander Alekseev
v3-0001-Add-psql-tab-co
e || false) gives us false. An error is reported, although
actually the condition should have been true.
--
Best regards,
Aleksander Alekseev
te the tests
locally. Personally I'm using a little script for this [2].
[1]: http://cfbot.cputube.org/
[2]: https://github.com/afiskon/pgscripts/blob/master/full-build.sh
--
Best regards,
Aleksander Alekseev
lso I suggest checking TransactionIdEquals() first though since it's cheaper.
--
Best regards,
Aleksander Alekseev
me as such a big deal. At
> least until somebody reports a bottleneck for this particular reason.
> We can optimize the code when and if this will happen.
Since the first patch was applied, cfbot now complains that it can't
apply the patchset. Here is the rebased version.
--
Best regards,
ally the sorting is done by pgprocno. Took me some time to
figure this out.
Here is the patch that fixes this. Hopefully this will save some time
for the newcomers.
--
Best regards,
Aleksander Alekseev
v1-0001-Add-a-missing-comment-for-PGPROC.pgprocno.patch
Description: Binary data
ndefined behaviour.
I suggest we focus on saving the memory first and then think about the
performance, if necessary.
--
Best regards,
Aleksander Alekseev
v3-0001-Added-pg_buffercache_summary-function.patch
Description: Binary data
re is the corrected patch.
--
Best regards,
Aleksander Alekseev
v4-0001-Added-pg_buffercache_summary-function.patch
Description: Binary data
ng should be
buffers_used and buffers_unused.
[1]: https://www.postgresql.org/docs/current/monitoring-stats.html
--
Best regards,
Aleksander Alekseev
ke sure the reader will not
misread this as a hex values
* The clarification about the type tag was added
* The references to "first case", "second case", etc were removed
Hopefully it's better now.
--
Best regards,
Aleksander Alekseev
v2-0001-Clarify-the-comments-about-varlena-header-encodin.patch
Description: Binary data
ttps://t.me/pg_sql/62265
[2]: https://www.postgresql.org/docs/current/storage-toast.html
--
Best regards,
Aleksander Alekseev
Hi hackers,
> 1. Forbid setting toast_tuple_target < TOAST_TUPLE_THRESHOLD
Reading my own email I realized that this of course was stupid. For
sure this is not an option. It's getting late in my timezone, sorry :)
--
Best regards,
Aleksander Alekseev
he problem when we
change it and there is no TOAST table yet.
I wonder though if we really need two entities - a "threshold" and a
"target". It seems to me that it should actually be one value, no?
--
Best regards,
Aleksander Alekseev
2/api/securitybaseapi/nf-securitybaseapi-gettokeninformation
--
Best regards,
Aleksander Alekseev
v2-0001-Replace-LocalAlloc-LocalFree-with-HeapAlloc-HeapF.patch
Description: Binary data
sting applications, as the company always did.
--
Best regards,
Aleksander Alekseev
nc() and similar
functions in tablesync.c. However I would like to mention this in case
the committer will be interested in replacing ints with Size's while
on it.
--
Best regards,
Aleksander Alekseev
v4 I elected to initialize both curr_xmax and next_xmin with
InvalidTransactionId for safety and in order to silence the compiler
but still there is no way this condition can succeed.
Please make sure there is no logic missing.
--
Best regards,
Aleksander Alekseev
v4-0001-Implement-HOT-chain-v
t format-patch`.
--
Best regards,
Aleksander Alekseev
> introduce this new function.
OK, here is the updated patchset.
* 0001 replaces int's with Size's in the existing code
* 0002 applies Peter's patch on top of 0001
--
Best regards,
Aleksander Alekseev
v2-0001-Pass-Size-as-a-2nd-argument-for-snprintf-in-table.patch
Descript
er hackers will report any issues.
--
Best regards,
Aleksander Alekseev
v7-0001-Added-pg_buffercache_summary-function.patch
Description: Binary data
Hi hackers,
> Here is a corrected patch v7. To me it seems to be in pretty good
> shape, unless cfbot and/or other hackers will report any issues.
There was a missing empty line in pg_buffercache.out which made the
tests fail. Here is a corrected v8 patch.
--
Best regards,
Aleksander Al
f scope of the
proposed patch.
[1]: https://www.postgresql.org/docs/current/pgbuffercache.html
--
Best regards,
Aleksander Alekseev
Hi Andres,
> All you need to do is to read BufferDesc->state into a local variable and
> then make decisions based on that
You are right, thanks.
Here is the corrected patch.
--
Best regards,
Aleksander Alekseev
v9-0001-Added-pg_buffercache_summary-function.patch
Description: Binary data
45497863cd3c49a3ad0#l178
--
Best regards,
Aleksander Alekseev
the simpler option
Agree. However, I think we will have to add the display of the port
number to "pg_ctl status" too, for the sake of consistency [1].
[1]: https://www.postgresql.org/docs/current/app-pg-ctl.html
--
Best regards,
Aleksander Alekseev
approach.
Also I agree that this particular statement is incorrect:
> This will allow us to extend the pointers indefinitely.
varatt_external is going to be limited to 255. But it seems to be a
reasonable limitation for the nearest 10-20 years or so.
[1]: https://commitfest.postgresql.org/39/3820/
--
Best regards,
Aleksander Alekseev
or less about the same thing?
It doesn't matter what will be used as a sign of presence of a varint
bitmask in the pointer. My initial proposal to use ToastCompressionId
for this is probably redundant since va_tag > 18 will already tell
that.
--
Best regards,
Aleksander Alekseev
vior doesn't contradict the general guarantees
promised by READ COMMITTED.
Perhaps we should update the documentation for this case, or maybe
remove the quoted part of it.
Thoughts?
[1]: https://www.postgresql.org/docs/current/transaction-iso.html
--
Best regards,
Aleksander Alekseev
obtain lock on the current tuple version in each such relation before
executing the recheck.
"""
[1]:
https://github.com/postgres/postgres/blob/master/src/backend/executor/README#L381
--
Best regards,
Aleksander Alekseev
is untouched.
The patch passed all the checks I could come up with.
--
Best regards,
Aleksander Alekseev
tion
and/or familiar with Java.
I think you should address the question to pgsql-general@ mailing list
or StackOverflow.
(If you believe there is a bug in the DBMS core please provide simpler
steps to reproduce, ideally with pgsql utility and maybe bash.)
--
Best regards,
Aleksander Alekseev
rocess memory. This
memory will be inherited from postmaster by child processes and the
overall memory usage is going to be the same due to copy-on-write.
Perhaps we should clarify this.
Thoughts?
[1]: https://www.postgresql.org/docs/15/xfunc-c.html#XFUNC-SHARED-ADDIN
--
Best regards,
Aleksander Alekseev
601 - 700 of 974 matches
Mail list logo
