Hi Peter, > To address this, I converted these macros to inline functions
This is a great change! I encountered passing the wrong arguments to these macros many times, and this is indeed pretty annoying. I wish we could forbid doing other stupid things as well, e.g. comparing two Datum's directly, which for Timestamps works just fine but only on 64-bit platforms. Although this is certainly out of scope of this thread. The patch looks good to me, I merely added a link to the discussion. I added it to the CF application. Cfbot is making its mind at the moment of writing. Do you think this should be backported? -- Best regards, Aleksander Alekseev
v2-0001-Fix-incorrect-uses-of-Datum-conversion-macros.patch
Description: Binary data
v2-0002-Convert-GetDatum-and-DatumGet-macros-to-inline-fu.patch
Description: Binary data
