Re: Set access strategy for parallel vacuum workers

On Thu, Apr 8, 2021 at 11:22 AM Amit Kapila wrote: > Yeah, I will change that before commit unless there are more suggestions. I have no further comments on the patch fix_access_strategy_workers_11.patch, it LGTM. With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com

maximum columns for brin bloom indexes

Hi everyone, When testing brin bloom indexes I noted that we need to reduce the PAGES_PER_RANGE parameter of the index to allow more columns on it. Sadly, this could be a problem if you create the index before the table grows, once it reaches some number of rows (i see the error as early as 1000

Re: Support tab completion for upper character inputs in psql

On 01.04.21 11:40, tanghy.f...@fujitsu.com wrote: On Wednesday, March 31, 2021 4:05 AM, David Zhang wrote 8 postgres=# update tbl SET DATA = 9 10 postgres=# update TBL SET 11 12 postgres=# So, as you can see the difference is between line 8 and 10 in case 2. It looks like the lowe

Re: MultiXact\SLRU buffers configuration

> 8 апр. 2021 г., в 03:30, Thomas Munro написал(а): > > Here's another approach that is a little less exciting than > "tournament RR" (or whatever that should be called; I couldn't find an > established name for it). This version is just our traditional linear > search, except that it stops a

Re: missing documentation for streaming in-progress transactions

On Thu, Apr 8, 2021 at 8:19 AM Peter Smith wrote: > > 1. > I felt that this protocol documentation needs to include something > like a "Since: 2" notation (e.g. see how the javadoc API [1] does it) > otherwise with more message types and more protocol versions it is > quickly going to become too

Add option --drop-cascade for pg_dump/restore

Hello, I'd like to propose adding `--drop-cascade` option for pg_dump/restore Usecase: I'd like to be able to restore an old custom format database dump as a single transaction ( so the current data won't lose if restore fails). The database has added some new constraints after backup so a CASC

Re: Can we remove extra memset in BloomInitPage, GinInitPage and SpGistInitPage when we have it in PageInit?

On Thu, Apr 08, 2021 at 07:45:25AM +0530, Bharath Rupireddy wrote: > On Wed, Apr 7, 2021 at 11:47 AM Bharath Rupireddy > wrote: >> I wanted to comment out p->pd_flags = 0; in PageInit similar to the >> pd_prune_xid just for consistency. >> /* p->pd_prune_xid = InvalidTransactionId;done

Re: SQL-standard function body

On Wed, Apr 07, 2021 at 11:35:14PM -0700, Andres Freund wrote: > On 2021-04-08 01:41:40 -0400, Tom Lane wrote: >> Andres Freund writes: >> FWIW, I think the long-term drift of things is definitely that >> we want to have the querystring available everywhere. Code like >> executor_errposition is f

Re: Can we remove extra memset in BloomInitPage, GinInitPage and SpGistInitPage when we have it in PageInit?

On Thu, Apr 8, 2021 at 1:22 PM Michael Paquier wrote: > > On Thu, Apr 08, 2021 at 07:45:25AM +0530, Bharath Rupireddy wrote: > > On Wed, Apr 7, 2021 at 11:47 AM Bharath Rupireddy > > wrote: > >> I wanted to comment out p->pd_flags = 0; in PageInit similar to the > >> pd_prune_xid just for consist

Re: PATCH: Attempt to make dbsize a bit more consistent

On Wed, Mar 17, 2021 at 02:35:28PM +0900, Michael Paquier wrote: > So we would likely want a separate function. Another possibility, > which I find tempting, would be to push down the calculation logic > relying on physical files down to the table AM themselves with a new > dedicated callback (rel

Re: Support for NSS as a libpq TLS backend

On Mon, Apr 05, 2021 at 11:12:22AM +0900, Michael Paquier wrote: > Please find an updated set, v35, attached, and my apologies for > breaking again your patch set. While testing this patch set and > adjusting the SSL tests with HEAD, I have noticed what looks like a > bug with the DN mapping that

Re: pg_stat_statements oddity with track = all

On Tue, Mar 16, 2021 at 4:34 PM Julien Rouhaud wrote: > > On Tue, Mar 16, 2021 at 12:55:45PM +0100, Magnus Hagander wrote: > > On Tue, Mar 9, 2021 at 3:39 AM Julien Rouhaud wrote: > > > > > > I think that we might be able to handle that without a flag. The only > > > thing > > > that would need

Re: Typo in jsonfuncs.c

On Thu, Apr 08, 2021 at 10:06:56AM +0900, Tatsuro Yamada wrote: > Hi, > > I found a typo in jsonfuncs.c, probably. > s/an an/an/ > Please find attached patch. For the archives' sake, this has been pushed as of 8ffb003591.

Re: CREATE SEQUENCE with RESTART option

On Thu, Apr 8, 2021 at 10:09 AM Amul Sul wrote: > > On Wed, Apr 7, 2021 at 6:52 PM Bharath Rupireddy > wrote: > > > > On Wed, Apr 7, 2021 at 6:04 PM Ashutosh Bapat > > wrote: > > > At best CREATE SEQUENCE START ... RESTART ... can be a shorthand > > > for CREATE SEQUENCE ... START; ALTER SE

Re: Wired if-statement in gen_partprune_steps_internal

On Thu, 8 Apr 2021 at 00:49, Amit Langote wrote: > > Thanks David. Actually, I was busy updating the patch to revert to > gen_partprune_steps_internal() returning a list and was almost done > with it when I saw your message. > > I read through v3 and can say that it certainly looks better than v2

Re: Change JOIN tutorial to focus more on explicit joins

On 15.03.21 09:06, Jürgen Purtz wrote: +1. All proposed changes integrated. committed

Re: Wired if-statement in gen_partprune_steps_internal

On Thu, Apr 8, 2021 at 5:34 PM David Rowley wrote: > On Thu, 8 Apr 2021 at 00:49, Amit Langote wrote: > > > > Thanks David. Actually, I was busy updating the patch to revert to > > gen_partprune_steps_internal() returning a list and was almost done > > with it when I saw your message. > > > > I

Re: TRUNCATE on foreign table

On 2021/04/08 15:48, Kohei KaiGai wrote: 2021年4月8日(木) 15:04 Fujii Masao : On 2021/04/08 13:43, Kohei KaiGai wrote: In case when a local table (with no children) has same contents, TRUNCATE command witll remove the entire table contents. But if there are local child tables that inherit the

Re: A new function to wait for the backend exit after termination

On Mon, Apr 5, 2021 at 5:21 AM Bharath Rupireddy wrote: > > On Fri, Mar 19, 2021 at 11:37 AM Bharath Rupireddy > wrote: > > Attaching v11 patch that removed the wait boolean flag in the > > pg_terminate_backend and timeout 0 indicates "no wait", negative value > > "errors out", positive value "wa

Re: CREATE SEQUENCE with RESTART option

On Thu, Apr 8, 2021 at 2:03 PM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > > > > > The RESTART clause in the CREATE SEQUENCE doesn't make sense > > to me, it should be restricted, IMO. > +1 > > Thanks! Attaching a patch that throws an error if the RESTART option > is sp

Re: Remove page-read callback from XLogReaderState.

I squashed the patch set into one because half of them were fixups, and the two main patches were really parts of the same change and should go in together. I fixed a few compiler warnings (GCC 10.2 reported several uninitialised variables, comparisons that are always true, etc) and some comments.

Re: [PATCH] Add --create-only option to pg_dump/pg_dumpall

On Tue, Mar 30, 2021 at 6:02 PM Michael Banck wrote: > > Hi, > > Am Montag, den 29.03.2021, 17:59 + schrieb Cary Huang: > > I have tried the patch and the new option is able to control the > > contents of pg_dump outputs to include only create db related > > commands. > > Thanks for testing! >

Re: TRUNCATE on foreign table

On 2021/04/08 18:25, Fujii Masao wrote: Anyway, attached is the updated version of the patch. This is still based on the latest Kazutaka-san's patch. That is, extra list for ONLY is still passed to FDW. What about committing this version at first? Then we can continue the discussion and chan

Re: Catalog version access

On Wed, Mar 3, 2021 at 8:16 PM Tom Lane wrote: > > Vik Fearing writes: > > On 3/3/21 6:35 PM, Peter Eisentraut wrote: > >> If what you want to know is whether a given binary can run against a > >> given data directory then CATALOG_VERSION_NO isn't the only thing you > >> need to check. The full

Order dependency in function test

Looking at https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2021-04-08%2009%3A43%3A13 which broke with the patch to add pg_wait_backend_termination(). AFAICT the change is that the order of rows coming back from "SELECT routine_name, sequence_name FROM information_schema.routine_s

Re: Autovacuum on partitioned table (autoanalyze)

On 4/8/21 5:22 AM, Alvaro Herrera wrote: > OK, I bit the bullet and re-did the logic in the way I had proposed > earlier in the thread: do the propagation on the collector's side, by > sending only the list of ancestors: the collector can read the tuple > change count by itself, to add it to eac

Re: maximum columns for brin bloom indexes

On 4/8/21 9:08 AM, Jaime Casanova wrote: > Hi everyone, > > When testing brin bloom indexes I noted that we need to reduce the > PAGES_PER_RANGE parameter of the index to allow more columns on it. > > Sadly, this could be a problem if you create the index before the table > grows, once it reaches

Re: Order dependency in function test

On 08.04.21 12:04, Magnus Hagander wrote: Looking at https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2021-04-08%2009%3A43%3A13 which broke with the patch to add pg_wait_backend_termination(). AFAICT the change is that the order of rows coming back from "SELECT routine_name, seq

Re: Order dependency in function test

On Thu, Apr 8, 2021 at 12:22 PM Peter Eisentraut wrote: > > On 08.04.21 12:04, Magnus Hagander wrote: > > Looking at > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2021-04-08%2009%3A43%3A13 > > which broke with the patch to add pg_wait_backend_termination(). > > > > AFAICT t

Re: Order dependency in function test

On Thu, Apr 8, 2021 at 3:34 PM Magnus Hagander wrote: > > Looking at > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2021-04-08%2009%3A43%3A13 > which broke with the patch to add pg_wait_backend_termination(). > > AFAICT the change is that the order of rows coming back from "SE

Re: Order dependency in function test

On Thu, Apr 8, 2021 at 3:53 PM Bharath Rupireddy wrote: > > On Thu, Apr 8, 2021 at 3:34 PM Magnus Hagander wrote: > > > > Looking at > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2021-04-08%2009%3A43%3A13 > > which broke with the patch to add pg_wait_backend_termination().

Re: Replication slot stats misgivings

On Wed, Apr 7, 2021 at 2:51 PM vignesh C wrote: > @@ -4069,6 +4069,24 @@ pgstat_read_statsfiles(Oid onlydb, bool permanent, bool deep) * slot follows. */ case 'R': + /* + * There is a remote scenario where one of the replication slots + * is dropped and the drop slot statistics message is n

Re: CREATE SEQUENCE with RESTART option

On Thu, Apr 8, 2021 at 3:16 PM Suraj Kharage wrote: >> > The RESTART clause in the CREATE SEQUENCE doesn't make sense >> > to me, it should be restricted, IMO. > > +1 > >> >> Thanks! Attaching a patch that throws an error if the RESTART option >> is specified with CREATE SEQUENCE. Please have a lo

Re: Replication slot stats misgivings

On Thu, Apr 8, 2021 at 4:00 PM Amit Kapila wrote: > > On Wed, Apr 7, 2021 at 2:51 PM vignesh C wrote: > > > > @@ -4069,6 +4069,24 @@ pgstat_read_statsfiles(Oid onlydb, bool > permanent, bool deep) > * slot follows. > */ > case 'R': > + /* > + * There is a remote scenario where one of the re

Re: Wired if-statement in gen_partprune_steps_internal

On Thu, 8 Apr 2021 at 21:04, Amit Langote wrote: > + * These partition pruning steps come in 2 forms; operation steps and combine > + * steps. > > Maybe you meant "operator" steps? IIRC, the reason why we named it > PartitionPruneStepOp is that an op step is built to prune based on the > semantic

Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays

On Thu, 8 Apr 2021 at 18:50, David Rowley wrote: > I've not done any further performance tests yet but will start those now. I ran a set of tests on this: select * from a where a in( < 1 to 10 > ); and select * from a where a in( < 1 to 100 > ); the table "a" is just an empty table with a singl

Re: DETAIL for wrong scram password

On Fri, Mar 26, 2021 at 09:49:00AM +0900, Michael Paquier wrote: > Yes, you are right here. I missed the parts before > mock_scram_secret() gets called and there are comments in the whole > area. Hmm, at the end of the day, I think that would just have > verify_client_proof() fill in logdetail wh

Re: SQL-standard function body

On Thu, Apr 08, 2021 at 04:54:56PM +0900, Michael Paquier wrote: > On Wed, Apr 07, 2021 at 11:35:14PM -0700, Andres Freund wrote: > > On 2021-04-08 01:41:40 -0400, Tom Lane wrote: > >> Andres Freund writes: > >> FWIW, I think the long-term drift of things is definitely that > >> we want to have th

Re: SQL-standard function body

On Thu, Apr 08, 2021 at 02:58:02AM -0400, Tom Lane wrote: > Julien Rouhaud writes: > > On Wed, Apr 07, 2021 at 11:33:20PM -0700, Andres Freund wrote: > >> Nothing special, really. Surprised the BF doesn't see it: > > > Is think this is because the buildfarm client is running installcheck for > >

Re: Truncate in synchronous logical replication failed

On Wed, 07 Apr 2021 at 16:34, tanghy.f...@fujitsu.com wrote: > On Wednesday, April 7, 2021 5:28 PM Amit Kapila > wrote > >>Can you please check if the behavior is the same for PG-13? This is >>just to ensure that we have not introduced any bug in PG-14. > > Yes, same failure happens at PG-13,

Simplify backend terminate and wait logic in postgres_fdw test

Hi, With the recent commit aaf0432572 which introduced a waiting/timeout capability for pg_teriminate_backend function, I would like to do $subject. Attaching a patch, please have a look. With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com v1-0001-Simplify-backend-termina

Re: Race condition in InvalidateObsoleteReplicationSlots()

On Thu, Apr 8, 2021 at 7:39 AM Andres Freund wrote: > > On 2021-04-07 17:10:37 -0700, Andres Freund wrote: > > I think this can be solved in two different ways: > > > > 1) Hold ReplicationSlotAllocationLock with LW_SHARED across most of > >InvalidateObsoleteReplicationSlots(). That way nobody

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

Hi Julien, Bruce, A warning appears on 32 bit systems: In file included from pgstatfuncs.c:15: pgstatfuncs.c: In function 'pg_stat_get_activity': ../../../../src/include/postgres.h:593:29: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 593 | #define DatumGetPoin

Re: WIP: WAL prefetch (another approach)

On Thu, Apr 8, 2021 at 3:27 AM Tomas Vondra wrote: > On 4/7/21 1:24 PM, Thomas Munro wrote: > > I made one other simplifying change: previously, the prefetch module > > would read the WAL up to the "written" LSN (so, allowing itself to > > read data that had been written but not yet flushed to dis

Re: Remove page-read callback from XLogReaderState.

On Thu, Apr 8, 2021 at 9:46 PM Thomas Munro wrote: > I squashed the patch set into one because half of them were fixups, > and the two main patches were really parts of the same change and > should go in together. > > I fixed a few compiler warnings (GCC 10.2 reported several > uninitialised varia

Re: Simplify backend terminate and wait logic in postgres_fdw test

On Thu, Apr 08, 2021 at 04:55:22PM +0530, Bharath Rupireddy wrote: > With the recent commit aaf0432572 which introduced a waiting/timeout > capability for pg_teriminate_backend function, I would like to do > $subject. Attaching a patch, please have a look. +-- Terminate the remote backend having t

Re: Wired if-statement in gen_partprune_steps_internal

On Thu, Apr 8, 2021 at 7:41 PM David Rowley wrote: > On Thu, 8 Apr 2021 at 21:04, Amit Langote wrote: > > Maybe, we should also updated the description of node struct as > > follows to consider that last point: >> > > * PartitionPruneStepOp - Information to prune using a set of mutually ANDed >

Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays

On Thu, 8 Apr 2021 at 22:54, David Rowley wrote: > > I think the changes in the patch are fairly isolated and the test > coverage is now pretty good. I'm planning on looking at the patch > again now and will consider pushing it for PG14. I push this with some minor cleanup from the v6 patch I po

Re: pg_stat_statements oddity with track = all

On Thu, Apr 08, 2021 at 10:30:53AM +0200, Magnus Hagander wrote: > > I agree. If those numbers are indeed representable, it seems like > better to pay that overhead than to pay the overhead of trying to > de-dupe it. > > Let's hope they are :) :) > Looking through ti again my feeling said the t

Re: PostgreSQL 14 Feature Freeze + Release Management Team (RMT)

On Mon, Mar 22, 2021 at 10:17:56AM +0900, Michael Paquier wrote: > The Release Management Team (RMT) for the PostgreSQL 14 is assembled > and has determined that the feature freeze date for the PostgreSQL 11 > release will be April 7, 2021. This means that any feature for the > PostgreSQL 14 relea

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

On Thu, Apr 08, 2021 at 11:36:48PM +1200, Thomas Munro wrote: > Hi Julien, Bruce, > > A warning appears on 32 bit systems: > > In file included from pgstatfuncs.c:15: > pgstatfuncs.c: In function 'pg_stat_get_activity': > ../../../../src/include/postgres.h:593:29: warning: cast to pointer > from

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

On Thu, Apr 8, 2021 at 9:47 AM Julien Rouhaud wrote: > > On Wed, Apr 07, 2021 at 02:12:11PM -0400, Bruce Momjian wrote: > > > > Patch applied. I am ready to adjust this with any improvements people > > might have. Thank you for all the good feedback we got on this, and I > > know many users have

Re: MultiXact\SLRU buffers configuration

On Thu, Apr 8, 2021 at 7:24 PM Andrey Borodin wrote: > I agree that this version of eviction seems much more effective and less > intrusive than RR. And it's still LRU, which is important for subsystem that > is called SLRU. > shared->search_slotno is initialized implicitly with memset(). But th

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

On Thu, Apr 08, 2021 at 05:46:07PM +0530, Amit Kapila wrote: > > @@ -1421,8 +1421,9 @@ ParallelQueryMain(dsm_segment *seg, shm_toc *toc) > /* Setting debug_query_string for individual workers */ > debug_query_string = queryDesc->sourceText; > > - /* Report workers' query for monitoring

Re: WIP: WAL prefetch (another approach)

On 4/8/21 1:46 PM, Thomas Munro wrote: > On Thu, Apr 8, 2021 at 3:27 AM Tomas Vondra > wrote: >> On 4/7/21 1:24 PM, Thomas Munro wrote: >>> I made one other simplifying change: previously, the prefetch module >>> would read the WAL up to the "written" LSN (so, allowing itself to >>> read data t

Re: Simplify backend terminate and wait logic in postgres_fdw test

On Thu, Apr 8, 2021 at 5:28 PM Michael Paquier wrote: > > On Thu, Apr 08, 2021 at 04:55:22PM +0530, Bharath Rupireddy wrote: > > With the recent commit aaf0432572 which introduced a waiting/timeout > > capability for pg_teriminate_backend function, I would like to do > > $subject. Attaching a patc

Re: TRUNCATE on foreign table

2021年4月8日(木) 18:25 Fujii Masao : > > On 2021/04/08 15:48, Kohei KaiGai wrote: > > 2021年4月8日(木) 15:04 Fujii Masao : > >> > >> On 2021/04/08 13:43, Kohei KaiGai wrote: > >>> In case when a local table (with no children) has same contents, > >>> TRUNCATE command > >>> witll remove the entire table con

Re: TRUNCATE on foreign table

On 2021/04/08 22:02, Kohei KaiGai wrote: Anyway, attached is the updated version of the patch. This is still based on the latest Kazutaka-san's patch. That is, extra list for ONLY is still passed to FDW. What about committing this version at first? Then we can continue the discussion and cha

Re: pg_stat_statements oddity with track = all

On Thu, Apr 8, 2021 at 2:04 PM Julien Rouhaud wrote: > > On Thu, Apr 08, 2021 at 10:30:53AM +0200, Magnus Hagander wrote: > > > > I agree. If those numbers are indeed representable, it seems like > > better to pay that overhead than to pay the overhead of trying to > > de-dupe it. > > > > Let's ho

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

On Thu, Apr 08, 2021 at 08:27:20PM +0800, Julien Rouhaud wrote: > On Thu, Apr 08, 2021 at 05:46:07PM +0530, Amit Kapila wrote: > > > > @@ -1421,8 +1421,9 @@ ParallelQueryMain(dsm_segment *seg, shm_toc *toc) > > /* Setting debug_query_string for individual workers */ > > debug_query_string

Re: 2019-03 CF now in progress

On 3/15/21 10:24 AM, David Steele wrote: On 3/1/21 10:30 AM, David Steele wrote: Hackers, The 2019-03 commitfest is now in progress. It's a big one as usual. Needs review: 213. Waiting on Author: 21. Ready for Committer: 28. Committed: 29. Withdrawn: 3. Total: 294. We are now halfway through

Re: 2019-03 CF now in progress

On Thu, 8 Apr 2021 at 15:49, David Steele wrote: > > On 3/15/21 10:24 AM, David Steele wrote: > > On 3/1/21 10:30 AM, David Steele wrote: > >> Hackers, > >> > >> The 2019-03 commitfest is now in progress. It's a big one as usual. > >> > >> Needs review: 213. > >> Waiting on Author: 21. > >> Ready

Re: [PATCH] PREPARE TRANSACTION unexpected behavior with TEMP TABLE

On Wed, Apr 7, 2021 at 12:19 PM Himanshu Upadhyaya wrote: > Please find attached the V2 patch. Hi, This patch is essentially taking the position that calling load_typcache_tupdesc before using that tupdesc for anything is required for correctness. I'm not sure whether that's a good architectural

Re: SQL:2011 PERIODS vs Postgres Ranges?

On 10/27/20 12:34 PM, Paul Jungwirth wrote: On 10/27/20 7:11 AM, Ibrar Ahmed wrote: I have spent some more time on the patch and did a lot of cleanup along with some fixes, compilation errors, and warnings. Thank you for taking a look at this! I've been swamped with ordinary work and haven't

Re: 2019-03 CF now in progress

On 4/8/21 10:12 AM, Matthias van de Meent wrote: I noticed that there is an old patch stuck at 'Needs review' in CF 2020-09. Could you also update the state of that patch, because I don't think I am the right person to do that. Good catch, thanks. I have reset it to RwF. Regards, -- -David da

Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

On 3/15/21 11:11 AM, Mark Dilger wrote: On Mar 2, 2021, at 6:08 AM, Pavel Borisov wrote: I completely agree that checking uniqueness requires looking at the heap, but I don't agree that every caller of bt_index_check on an index wants that particular check to be performed. There are multip

Re: allow partial union-all and improve parallel subquery costing

On 3/15/21 9:09 AM, David Steele wrote: On 12/30/20 8:54 AM, Luc Vlaming wrote: Created a commitfest entry assuming this is the right thing to do so that someone can potentially pick it up during the commitfest. Providing an updated patch based on latest master. Looks like you need anothe

Re: maximum columns for brin bloom indexes

On Thu, Apr 08, 2021 at 12:18:36PM +0200, Tomas Vondra wrote: > On 4/8/21 9:08 AM, Jaime Casanova wrote: > > Hi everyone, > > > > When testing brin bloom indexes I noted that we need to reduce the > > PAGES_PER_RANGE parameter of the index to allow more columns on it. > > > > Sadly, this could be

Re: pg_stat_statements oddity with track = all

On Thu, Apr 08, 2021 at 03:18:09PM +0200, Magnus Hagander wrote: > On Thu, Apr 8, 2021 at 2:04 PM Julien Rouhaud wrote: > > > > If yes, PFA a patch to merge 1.10 in 1.9. > > I actually thought I looked at that, but clearly I was confused one > way or another. > > I think you're right, it's clean

Re: [BUG] orphaned function

On 3/29/21 7:20 AM, Drouvot, Bertrand wrote: This item is classified as a bug-fix in the commitfest, but it doesn't sound like something we can actually back-patch. Since it looks like a new patch is required and this probably should not be classified as a bug fix, marking Returned with Feedb

Re: maximum columns for brin bloom indexes

On 4/8/21 4:49 PM, Jaime Casanova wrote: > On Thu, Apr 08, 2021 at 12:18:36PM +0200, Tomas Vondra wrote: >> On 4/8/21 9:08 AM, Jaime Casanova wrote: >>> Hi everyone, >>> >>> When testing brin bloom indexes I noted that we need to reduce the >>> PAGES_PER_RANGE parameter of the index to allow mor

Re: Performing partition pruning using row value

On 2/16/21 9:07 AM, Anastasia Lubennikova wrote: On 21.07.2020 11:24, kato-...@fujitsu.com wrote: So, after looking at these functions and modifying this patch, I would like to add this patch to the next I updated this patch and registered for the next CF . https://commitfest.postgresql.org/29

Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT

On 3/4/21 6:28 AM, Ibrar Ahmed wrote: This patch set no longer applies http://cfbot.cputube.org/patch_32_1533.log It has been over a year since the last update to this patch and it no longer applies, so marking Returned with Feedback. Please res

Re: Extending range type operators to cope with elements

On 3/4/21 6:11 AM, Ibrar Ahmed wrote: This patch set no longer applies. http://cfbot.cputube.org/patch_32_2747.log Can we get a rebase? I am marking the patch "Waiting on Author" This patch needs updates and a rebase and there has been no new p

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

On Thu, Apr 8, 2021 at 09:31:27PM +0800, Julien Rouhaud wrote: > On Thu, Apr 08, 2021 at 08:27:20PM +0800, Julien Rouhaud wrote: > > On Thu, Apr 08, 2021 at 05:46:07PM +0530, Amit Kapila wrote: > > > > > > @@ -1421,8 +1421,9 @@ ParallelQueryMain(dsm_segment *seg, shm_toc *toc) > > > /* Settin

Re: zstd compression for pg_dump

On 1/3/21 9:53 PM, Justin Pryzby wrote: I rebased so the "typedef struct compression" patch is first and zstd on top of that (say, in case someone wants to bikeshed about which compression algorithm to support). And made a central struct with all the compression-specific info to further isolate

Re: pgsql: autovacuum: handle analyze for partitioned tables

On 2021-Apr-08, Tom Lane wrote: > Alvaro Herrera writes: > > autovacuum: handle analyze for partitioned tables > > Looks like this has issues under EXEC_BACKEND: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=culicidae&dt=2021-04-08%2005%3A50%3A08 Hmm, I couldn't reproduce this un

Re: VACUUM (DISABLE_PAGE_SKIPPING on)

On 3/17/21 4:50 PM, Simon Riggs wrote: On Fri, 12 Mar 2021 at 22:16, Tomas Vondra wrote: On 1/28/21 2:33 PM, Simon Riggs wrote: On Thu, 28 Jan 2021 at 12:53, Masahiko Sawada wrote: This entry has been "Waiting on Author" status and the patch has not been updated since Nov 30. Are you still

Re: TRUNCATE on foreign table

Fujii-san, > >> Anyway, attached is the updated version of the patch. This is still based > >> on the latest Kazutaka-san's patch. That is, extra list for ONLY is still > >> passed to FDW. What about committing this version at first? Then we can > >> continue the discussion and change the behav

Re: Autovacuum on partitioned table (autoanalyze)

On 2021-Apr-08, Tomas Vondra wrote: > On 4/8/21 5:22 AM, Alvaro Herrera wrote: > > However, I just noticed there is a huge problem, which is that the new > > code in relation_needs_vacanalyze() is doing find_all_inheritors(), and > > we don't necessarily have a snapshot that lets us do that. Whi

Re: [HACKERS] Custom compression methods

On 3/30/21 10:30 AM, Tom Lane wrote: Robert Haas writes: On Wed, Mar 24, 2021 at 2:15 PM Tom Lane wrote: But let's ignore the case of pg_upgrade and just consider a dump/restore. I'd still say that unless you give --no-toast-compression then I would expect the dump/restore to preserve the tab

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

On Wed, Apr 7, 2021 at 11:27:04PM -0400, Álvaro Herrera wrote: > On 2021-Apr-07, Bruce Momjian wrote: > > > On Thu, Apr 8, 2021 at 10:38:08AM +0800, Julien Rouhaud wrote: > > > > Thanks! And I agree with using query_id in the new field names while > > > keeping > > > queryid for pg_stat_state

Re: VACUUM (DISABLE_PAGE_SKIPPING on)

On Thu, 8 Apr 2021 at 16:23, David Steele wrote: > > On 3/17/21 4:50 PM, Simon Riggs wrote: > > On Fri, 12 Mar 2021 at 22:16, Tomas Vondra > > wrote: > >> > >> On 1/28/21 2:33 PM, Simon Riggs wrote: > >>> On Thu, 28 Jan 2021 at 12:53, Masahiko Sawada > >>> wrote: > >>> > This entry has bee

Re: Autovacuum on partitioned table (autoanalyze)

On 4/8/21 5:27 PM, Alvaro Herrera wrote: > On 2021-Apr-08, Tomas Vondra wrote: > >> On 4/8/21 5:22 AM, Alvaro Herrera wrote: > >>> However, I just noticed there is a huge problem, which is that the new >>> code in relation_needs_vacanalyze() is doing find_all_inheritors(), and >>> we don't necess

Re: VACUUM (DISABLE_PAGE_SKIPPING on)

On 4/8/21 11:41 AM, Simon Riggs wrote: On Thu, 8 Apr 2021 at 16:23, David Steele wrote: On 3/17/21 4:50 PM, Simon Riggs wrote: On Fri, 12 Mar 2021 at 22:16, Tomas Vondra wrote: On 1/28/21 2:33 PM, Simon Riggs wrote: On Thu, 28 Jan 2021 at 12:53, Masahiko Sawada wrote: This entry has be

Re: Autovacuum on partitioned table (autoanalyze)

On 2021-Apr-08, Tomas Vondra wrote: > On 4/8/21 5:27 PM, Alvaro Herrera wrote: > > > Same as for any other relation: ANALYZE would set it, after it's done > > scanning the table. We would to make sure that nothing resets it to > > empty, though, and that it doesn't cause issues elsewhere. (The p

Re: SQL-standard function body

Julien Rouhaud writes: > On Thu, Apr 08, 2021 at 02:58:02AM -0400, Tom Lane wrote: >> No, because if that were the explanation then we'd be getting no >> buildfarm coverage at all for for pg_stat_statements. Which aside >> from being awful contradicts the results at coverage.postgresql.org. > Is

Re: VACUUM (DISABLE_PAGE_SKIPPING on)

On Thu, 8 Apr 2021 at 16:58, David Steele wrote: > >> It has been five months since this patch was updated, so marking > >> Returned with Feedback. > >> > >> Please resubmit to the next CF when you have a new patch. > > > > There are 2 separate patch-sets on this thread, with separate CF entries.

Re: psql - add SHOW_ALL_RESULTS option

On Thu, Apr 08, 2021 at 01:32:12AM +, shiy.f...@fujitsu.com wrote: > > Attached a patch which attempts to fix this by moving the cancellation > > cancelling request after processing results. > > Thank you for your fixing. I tested and the problem has been solved after > applying your patch.

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

On Thu, Apr 08, 2021 at 11:34:25AM -0400, Bruce Momjian wrote: > > OK, let's get some details. First, pg_stat_statements.queryid already > exists (no underscore), and I don't think anyone wants to change that. > > pg_stat_activity.queryid is new, but I can imagine cases where you would > join p

Re: doc review for v14

Another round of doc review, not yet including all of yesterday's commits. 29c8d614c3 duplicate words diff --git a/src/include/lib/sort_template.h b/src/include/lib/sort_template.h index 771c789ced..24d6d0006c 100644 --- a/src/include/lib/sort_template.h +++ b/src/include/lib/sort_template.h @@ -2

Re: VACUUM (DISABLE_PAGE_SKIPPING on)

On 4/8/21 12:29 PM, Simon Riggs wrote: On Thu, 8 Apr 2021 at 16:58, David Steele wrote: It has been five months since this patch was updated, so marking Returned with Feedback. Please resubmit to the next CF when you have a new patch. There are 2 separate patch-sets on this thread, with sep

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

On Fri, Apr 9, 2021 at 12:38:29AM +0800, Julien Rouhaud wrote: > On Thu, Apr 08, 2021 at 11:34:25AM -0400, Bruce Momjian wrote: > > > > OK, let's get some details. First, pg_stat_statements.queryid already > > exists (no underscore), and I don't think anyone wants to change that. > > > > pg_st

Re: VACUUM (DISABLE_PAGE_SKIPPING on)

On Thu, 8 Apr 2021 at 17:44, David Steele wrote: > > On 4/8/21 12:29 PM, Simon Riggs wrote: > > On Thu, 8 Apr 2021 at 16:58, David Steele wrote: > > > It has been five months since this patch was updated, so marking > Returned with Feedback. > > Please resubmit to the next CF

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

On 2021-Apr-08, Bruce Momjian wrote: > pg_stat_activity.queryid is new, but I can imagine cases where you would > join pg_stat_activity to pg_stat_statements to get an estimate of how > long the query will take --- having one using an underscore and another > one not seems odd. OK. So far, you h

Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays

On Thu, Apr 8, 2021 at 8:01 AM David Rowley wrote: > > On Thu, 8 Apr 2021 at 22:54, David Rowley wrote: > > > > I think the changes in the patch are fairly isolated and the test > > coverage is now pretty good. I'm planning on looking at the patch > > again now and will consider pushing it for P

Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?

On Thu, Apr 8, 2021 at 12:51:06PM -0400, Álvaro Herrera wrote: > On 2021-Apr-08, Bruce Momjian wrote: > > > pg_stat_activity.queryid is new, but I can imagine cases where you would > > join pg_stat_activity to pg_stat_statements to get an estimate of how > > long the query will take --- having on

Re: SQL-standard function body

On 4/8/21 2:40 AM, Julien Rouhaud wrote: > On Wed, Apr 07, 2021 at 11:33:20PM -0700, Andres Freund wrote: >> Hi, >> >> On 2021-04-08 02:05:25 -0400, Tom Lane wrote: >>> So far the buildfarm seems to be turning green after b3ee4c503 ... >>> so I wonder what extra condition is needed to cause the f

Re: psql - add SHOW_ALL_RESULTS option

Bonjour Julien, Attached a patch which attempts to fix this by moving the cancellation cancelling request after processing results. Thank you for your fixing. I tested and the problem has been solved after applying your patch. Thanks for the patch Fabien. I've hit this issue multiple time

Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays

On 2021-Apr-08, James Coleman wrote: > I assume proper procedure for the CF entry is to move it into the > current CF and then mark it as committed, however I don't know how (or > don't have permissions?) to move it into the current CF. How does one > go about doing that? > > Here's the entry: ht

  1   2   >