Another round of doc review, not yet including all of yesterday's commits.
29c8d614c3 duplicate words
diff --git a/src/include/lib/sort_template.h b/src/include/lib/sort_template.h
index 771c789ced..24d6d0006c 100644
--- a/src/include/lib/sort_template.h
+++ b/src/include/lib/sort_template.h
@@ -241,7 +241,7 @@ ST_SCOPE void ST_SORT(ST_ELEMENT_TYPE *first, size_t n
/*
* Find the median of three values. Currently, performance seems to be best
- * if the the comparator is inlined here, but the med3 function is not inlined
+ * if the comparator is inlined here, but the med3 function is not inlined
* in the qsort function.
*/
static pg_noinline ST_ELEMENT_TYPE *
e7c370c7c5 pg_amcheck: remove Double semi-colon
diff --git a/src/bin/pg_amcheck/t/004_verify_heapam.pl
b/src/bin/pg_amcheck/t/004_verify_heapam.pl
index 36607596b1..2171d236a7 100644
--- a/src/bin/pg_amcheck/t/004_verify_heapam.pl
+++ b/src/bin/pg_amcheck/t/004_verify_heapam.pl
@@ -175,7 +175,7 @@ sub write_tuple
seek($fh, $offset, 0)
or BAIL_OUT("seek failed: $!");
defined(syswrite($fh, $buffer, HEAPTUPLE_PACK_LENGTH))
- or BAIL_OUT("syswrite failed: $!");;
+ or BAIL_OUT("syswrite failed: $!");
return;
}
b745e9e60e a statistics objects
diff --git a/src/backend/statistics/extended_stats.c
b/src/backend/statistics/extended_stats.c
index 463d44a68a..4674168ff8 100644
--- a/src/backend/statistics/extended_stats.c
+++ b/src/backend/statistics/extended_stats.c
@@ -254,7 +254,7 @@ BuildRelationExtStatistics(Relation onerel, double
totalrows,
* that would require additional columns.
*
* See statext_compute_stattarget for details about how we compute statistics
- * target for a statistics objects (from the object target, attribute targets
+ * target for a statistics object (from the object target, attribute targets
* and default statistics target).
*/
int
e7d5c5d9dc guc.h: remove mention of "doit"
diff --git a/src/include/utils/guc.h b/src/include/utils/guc.h
index 1892c7927b..1126b34798 100644
--- a/src/include/utils/guc.h
+++ b/src/include/utils/guc.h
@@ -90,8 +90,7 @@ typedef enum
* dividing line between "interactive" and "non-interactive" sources for
* error reporting purposes.
*
- * PGC_S_TEST is used when testing values to be used later ("doit" will always
- * be false, so this never gets stored as the actual source of any value).
+ * PGC_S_TEST is used when testing values to be used later.
* For example, ALTER DATABASE/ROLE tests proposed per-database or per-user
* defaults this way, and CREATE FUNCTION tests proposed function SET clauses
* this way. This is an interactive case, but it needs its own source value
ad5f9a2023 Caller
diff --git a/src/backend/utils/adt/jsonfuncs.c
b/src/backend/utils/adt/jsonfuncs.c
index 9961d27df4..09fcff6729 100644
--- a/src/backend/utils/adt/jsonfuncs.c
+++ b/src/backend/utils/adt/jsonfuncs.c
@@ -1651,7 +1651,7 @@ push_null_elements(JsonbParseState **ps, int num)
* this path. E.g. the path [a][0][b] with the new value 1 will produce the
* structure {a: [{b: 1}]}.
*
- * Called is responsible to make sure such path does not exist yet.
+ * Caller is responsible to make sure such path does not exist yet.
*/
static void
push_path(JsonbParseState **st, int level, Datum *path_elems,
@@ -4887,7 +4887,7 @@ IteratorConcat(JsonbIterator **it1, JsonbIterator **it2,
* than just one last element, this flag will instruct to create the whole
* chain of corresponding objects and insert the value.
*
- * JB_PATH_CONSISTENT_POSITION for an array indicates that the called wants to
+ * JB_PATH_CONSISTENT_POSITION for an array indicates that the caller wants to
* keep values with fixed indices. Indices for existing elements could be
* changed (shifted forward) in case if the array is prepended with a new value
* and a negative index out of the range, so this behavior will be prevented
9acedbd4af as
diff --git a/src/backend/commands/copyfrom.c b/src/backend/commands/copyfrom.c
index 20e7d57d41..40a54ad0bd 100644
--- a/src/backend/commands/copyfrom.c
+++ b/src/backend/commands/copyfrom.c
@@ -410,7 +410,7 @@ CopyMultiInsertBufferCleanup(CopyMultiInsertInfo *miinfo,
* Once flushed we also trim the tracked buffers list down to size by removing
* the buffers created earliest first.
*
- * Callers should pass 'curr_rri' is the ResultRelInfo that's currently being
+ * Callers should pass 'curr_rri' as the ResultRelInfo that's currently being
* used. When cleaning up old buffers we'll never remove the one for
* 'curr_rri'.
*/
9f78de5042 exist
diff --git a/src/backend/commands/analyze.c b/src/backend/commands/analyze.c
index 5bdaceefd5..182a133033 100644
--- a/src/backend/commands/analyze.c
+++ b/src/backend/commands/analyze.c
@@ -617,7 +617,7 @@ do_analyze_rel(Relation onerel, VacuumParams *params,
*
* We assume that VACUUM hasn't set pg_class.reltuples already, even
* during a VACUUM ANALYZE. Although VACUUM often updates pg_class,
- * exceptions exists. A "VACUUM (ANALYZE, INDEX_CLEANUP OFF)" command
+ * exceptions exist. A "VACUUM (ANALYZE, INDEX_CLEANUP OFF)" command
* will never update pg_class entries for index relations. It's also
* possible that an individual index's pg_class entry won't be updated
* during VACUUM if the index AM returns NULL from its amvacuumcleanup()
a45af383ae rebuilt
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 096a06f7b3..6487a9e3fc 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -1422,7 +1422,7 @@ finish_heap_swap(Oid OIDOldHeap, Oid OIDNewHeap,
PROGRESS_CLUSTER_PHASE_FINAL_CLEANUP);
/*
- * If the relation being rebuild is pg_class, swap_relation_files()
+ * If the relation being rebuilt is pg_class, swap_relation_files()
* couldn't update pg_class's own pg_class entry (check comments in
* swap_relation_files()), thus relfrozenxid was not updated. That's
* annoying because a potential reason for doing a VACUUM FULL is a
f24c2c1075 docs review: logical replication
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index a382258aee..bc4a8b2279 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -4137,7 +4137,7 @@ restore_command = 'copy "C:\\server\\archivedir\\%f"
"%p"' # Windows
On the subscriber side, specifies how many replication origins (see
<xref linkend="replication-origins"/>) can be tracked simultaneously,
effectively limiting how many logical replication subscriptions can
- be created on the server. Setting it a lower value than the current
+ be created on the server. Setting it to a lower value than the current
number of tracked replication origins (reflected in
<link
linkend="view-pg-replication-origin-status">pg_replication_origin_status</link>,
not <link
linkend="catalog-pg-replication-origin">pg_replication_origin</link>)
diff --git a/doc/src/sgml/logical-replication.sgml
b/doc/src/sgml/logical-replication.sgml
index 3fad5f34e6..7645ee032c 100644
--- a/doc/src/sgml/logical-replication.sgml
+++ b/doc/src/sgml/logical-replication.sgml
@@ -602,13 +602,12 @@
</para>
<para>
- The subscriber also requires the <varname>max_replication_slots</varname>
- be set to configure how many replication origins can be tracked. In this
- case it should be set to at least the number of subscriptions that will be
- added to the subscriber, plus some reserve for table synchronization.
- <varname>max_logical_replication_workers</varname> must be set to at least
- the number of subscriptions, again plus some reserve for the table
- synchronization. Additionally the <varname>max_worker_processes</varname>
+ <varname>max_replication_slots</varname> must also be set on the subscriber.
+ It should be set to at least the number of
+ subscriptions that will be added to the subscriber, plus some reserve for
+ table synchronization. <varname>max_logical_replication_workers</varname>
+ must be set to at least the number of subscriptions, again plus some reserve
+ for the table synchronization. Additionally the
<varname>max_worker_processes</varname>
may need to be adjusted to accommodate for replication workers, at least
(<varname>max_logical_replication_workers</varname>
+ <literal>1</literal>). Note that some extensions and parallel queries
83f9954468 accessmtd
diff --git a/src/backend/catalog/heap.c b/src/backend/catalog/heap.c
index 9f6303266f..ba03e8aa8f 100644
--- a/src/backend/catalog/heap.c
+++ b/src/backend/catalog/heap.c
@@ -1119,6 +1119,7 @@ AddNewRelationType(const char *typeName,
* reltypeid: OID to assign to rel's rowtype, or InvalidOid to select one
* reloftypeid: if a typed table, OID of underlying type; else InvalidOid
* ownerid: OID of new rel's owner
+ * accessmtd: OID of new rel's access method
* tupdesc: tuple descriptor (source of column definitions)
* cooked_constraints: list of precooked check constraints and defaults
* relkind: relkind for new rel
573eeb8666 language fixen
diff --git a/doc/src/sgml/maintenance.sgml b/doc/src/sgml/maintenance.sgml
index 3bbae6dd91..4adb34a21b 100644
--- a/doc/src/sgml/maintenance.sgml
+++ b/doc/src/sgml/maintenance.sgml
@@ -185,7 +185,7 @@
never issue <command>VACUUM FULL</command>. In this approach, the idea
is not to keep tables at their minimum size, but to maintain steady-state
usage of disk space: each table occupies space equivalent to its
- minimum size plus however much space gets used up between vacuumings.
+ minimum size plus however much space gets used up between vacuum runs.
Although <command>VACUUM FULL</command> can be used to shrink a table back
to its minimum size and return the disk space to the operating system,
there is not much point in this if the table will just grow again in the
diff --git a/doc/src/sgml/perform.sgml b/doc/src/sgml/perform.sgml
index d1af624f44..89ff58338e 100644
--- a/doc/src/sgml/perform.sgml
+++ b/doc/src/sgml/perform.sgml
@@ -1899,7 +1899,7 @@ SELECT * FROM x, y, a, b, c WHERE something AND
somethingelse;
much faster. The following are configuration changes you can make
to improve performance in such cases. Except as noted below, durability
is still guaranteed in case of a crash of the database software;
- only abrupt operating system stoppage creates a risk of data loss
+ only an abrupt operating system crash creates a risk of data loss
or corruption when these settings are used.
<itemizedlist>
diff --git a/doc/src/sgml/ref/createuser.sgml b/doc/src/sgml/ref/createuser.sgml
index 4d60dc2cda..17579e50af 100644
--- a/doc/src/sgml/ref/createuser.sgml
+++ b/doc/src/sgml/ref/createuser.sgml
@@ -44,7 +44,7 @@ PostgreSQL documentation
If you wish to create a new superuser, you must connect as a
superuser, not merely with <literal>CREATEROLE</literal> privilege.
Being a superuser implies the ability to bypass all access permission
- checks within the database, so superuserdom should not be granted lightly.
+ checks within the database, so superuser access should not be granted
lightly.
</para>
<para>
d37a8a04f7 wal_compression
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index cf4e82e8b5..a382258aee 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -3098,7 +3098,7 @@ include_dir 'conf.d'
<listitem>
<para>
When this parameter is <literal>on</literal>, the
<productname>PostgreSQL</productname>
- server compresses a full page image written to WAL when
+ server compresses full page images written to WAL when
<xref linkend="guc-full-page-writes"/> is on or during a base backup.
A compressed page image will be decompressed during WAL replay.
The default value is <literal>off</literal>.
e6025e2e81 amcheck
diff --git a/doc/src/sgml/amcheck.sgml b/doc/src/sgml/amcheck.sgml
index a2571d33ae..30fcb033e3 100644
--- a/doc/src/sgml/amcheck.sgml
+++ b/doc/src/sgml/amcheck.sgml
@@ -457,14 +457,13 @@ SET client_min_messages = DEBUG1;
</listitem>
<listitem>
<para>
- File system or storage subsystem faults where checksums happen to
- simply not be enabled.
+ File system or storage subsystem faults where checksums are
+ not enabled.
</para>
<para>
- Note that <filename>amcheck</filename> examines a page as represented in
some
- shared memory buffer at the time of verification if there is only a
- shared buffer hit when accessing the block. Consequently,
- <filename>amcheck</filename> does not necessarily examine data read from
the
+ Note that <filename>amcheck</filename> examines a page as represented in a
+ shared memory buffer at the time of verification. If the page is cached,
+ <filename>amcheck</filename> will not examine data read from the
file system at the time of verification. Note that when checksums are
enabled, <filename>amcheck</filename> may raise an error due to a checksum
failure when a corrupt block is read into a buffer.
d987f0505e spell: vacuum
diff --git a/doc/src/sgml/ref/create_table.sgml
b/doc/src/sgml/ref/create_table.sgml
index 44e50620fd..d7fffddbce 100644
--- a/doc/src/sgml/ref/create_table.sgml
+++ b/doc/src/sgml/ref/create_table.sgml
@@ -1520,7 +1520,7 @@ WITH ( MODULUS <replaceable
class="parameter">numeric_literal</replaceable>, REM
</listitem>
</varlistentry>
- <varlistentry id="reloption-autovacuum-vauum-scale-factor"
xreflabel="autovacuum_vacuum_scale_factor">
+ <varlistentry id="reloption-autovacuum-vacuum-scale-factor"
xreflabel="autovacuum_vacuum_scale_factor">
<term><literal>autovacuum_vacuum_scale_factor</literal>,
<literal>toast.autovacuum_vacuum_scale_factor</literal> (<type>floating
point</type>)
<indexterm>
<primary><varname>autovacuum_vacuum_scale_factor</varname> </primary>
@@ -1610,7 +1610,7 @@ WITH ( MODULUS <replaceable
class="parameter">numeric_literal</replaceable>, REM
</listitem>
</varlistentry>
- <varlistentry id="reloption-autovacuum-vauum-cost-limit"
xreflabel="autovacuum_vacuum_cost_limit">
+ <varlistentry id="reloption-autovacuum-vacuum-cost-limit"
xreflabel="autovacuum_vacuum_cost_limit">
<term><literal>autovacuum_vacuum_cost_limit</literal>,
<literal>toast.autovacuum_vacuum_cost_limit</literal> (<type>integer</type>)
<indexterm>
<primary><varname>autovacuum_vacuum_cost_limit</varname></primary>
69e597176b doc review: Fix use of cursor sensitivity terminology
diff --git a/doc/src/sgml/ref/declare.sgml b/doc/src/sgml/ref/declare.sgml
index 8a2b8cc892..aa3d1d1fa1 100644
--- a/doc/src/sgml/ref/declare.sgml
+++ b/doc/src/sgml/ref/declare.sgml
@@ -335,7 +335,7 @@ DECLARE liahona CURSOR FOR SELECT * FROM films;
<para>
According to the SQL standard, changes made to insensitive cursors by
<literal>UPDATE ... WHERE CURRENT OF</literal> and <literal>DELETE
- ... WHERE CURRENT OF</literal> statements are visibible in that same
+ ... WHERE CURRENT OF</literal> statements are visible in that same
cursor. <productname>PostgreSQL</productname> treats these statements like
all other data changing statements in that they are not visible in
insensitive cursors.
3399caf133 doc review: Make use of in-core query id added by commit 5fd9dfa5f5
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 04712769ca..cf4e82e8b5 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -7732,7 +7732,7 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH
csv;
The <xref linkend="pgstatstatements"/> extension also requires a query
identifier to be computed. Note that an external module can
alternatively be used if the in-core query identifier computation
- specification isn't acceptable. In this case, in-core computation
+ method isn't acceptable. In this case, in-core computation
must be disabled. The default is <literal>off</literal>.
</para>
<note>
567b33c755 doc review: Move pg_stat_statements query jumbling to core.
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index ae1a38b8bc..04712769ca 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -7737,7 +7737,7 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH
csv;
</para>
<note>
<para>
- To ensure that a only one query identifier is calculated and
+ To ensure that only one query identifier is calculated and
displayed, extensions that calculate query identifiers should
throw an error if a query identifier has already been computed.
</para>
diff --git a/doc/src/sgml/pgstatstatements.sgml
b/doc/src/sgml/pgstatstatements.sgml
index 5ad4f0aed2..e235504e9a 100644
--- a/doc/src/sgml/pgstatstatements.sgml
+++ b/doc/src/sgml/pgstatstatements.sgml
@@ -406,7 +406,7 @@
<note>
<para>
The following details about constant replacement and
- <structfield>queryid</structfield> only applies when <xref
+ <structfield>queryid</structfield> only apply when <xref
linkend="guc-compute-query-id"/> is enabled. If you use an external
module instead to compute <structfield>queryid</structfield>, you
should refer to its documentation for details.
e292ee3e35 doc review: Add function to log the memory contexts of specified
backend process.
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index be22f4b61b..679738f615 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -24926,12 +24926,12 @@ SELECT collation for ('foo' COLLATE "de_DE");
<returnvalue>boolean</returnvalue>
</para>
<para>
- Requests to log the memory contexts whose backend process has
- the specified process ID. These memory contexts will be logged at
+ Requests to log the memory contexts of the backend with the
+ specified process ID. These memory contexts will be logged at
<literal>LOG</literal> message level. They will appear in
the server log based on the log configuration set
(See <xref linkend="runtime-config-logging"/> for more information),
- but will not be sent to the client whatever the setting of
+ but will not be sent to the client regardless of
<xref linkend="guc-client-min-messages"/>.
Only superusers can request to log the memory contexts.
</para></entry>
@@ -25037,9 +25037,9 @@ SELECT collation for ('foo' COLLATE "de_DE");
<para>
<function>pg_log_backend_memory_contexts</function> can be used
- to log the memory contexts of the backend process. For example,
+ to log the memory contexts of a backend process. For example,
<programlisting>
-postgres=# SELECT pg_log_backend_memory_contexts(pg_backend_pid());
+postgres=# SELECT pg_log_backend_memory_contexts(pg_backend_pid()); -- XXX
pg_log_backend_memory_contexts
--------------------------------
t
@@ -25061,8 +25061,8 @@ LOG: level: 1; TransactionAbortContext: 32768 total in
1 blocks; 32504 free (0
LOG: level: 1; ErrorContext: 8192 total in 1 blocks; 7928 free (3 chunks);
264 used
LOG: Grand total: 1651920 bytes in 201 blocks; 622360 free (88 chunks);
1029560 used
</screen>
- For more than 100 child contexts under the same parent one,
- 100 child contexts and a summary of the remaining ones will be logged.
+ If there are more than 100 child contexts under the same parent, the first
+ 100 child contexts are logged, along with a summary of the remaining
contexts.
Note that frequent calls to this function could incur significant overhead,
because it may generate a large number of log messages.
</para>
85330eeda7 doc review: Stop archive recovery if WAL generated with
wal_level=minimal is found.
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 26628f3e6d..ae1a38b8bc 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -2723,7 +2723,7 @@ include_dir 'conf.d'
Note that changing <varname>wal_level</varname> to
<literal>minimal</literal> makes any base backups taken before
unavailable for archive recovery and standby server, which may
- lead to database loss.
+ lead to data loss.
</para>
<para>
In <literal>logical</literal> level, the same information is logged as
diff --git a/doc/src/sgml/perform.sgml b/doc/src/sgml/perform.sgml
index e0d3f246e9..d1af624f44 100644
--- a/doc/src/sgml/perform.sgml
+++ b/doc/src/sgml/perform.sgml
@@ -1747,7 +1747,7 @@ SELECT * FROM x, y, a, b, c WHERE something AND
somethingelse;
<xref linkend="guc-max-wal-senders"/> to zero.
But note that changing these settings requires a server restart,
and makes any base backups taken before unavailable for archive
- recovery and standby server, which may lead to database loss.
+ recovery and standby server, which may lead to data loss.
</para>
<para>
dfdae1597d doc review: Add unistr function
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 7b75e0bca2..be22f4b61b 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -3560,7 +3560,7 @@ repeat('Pg', 4) <returnvalue>PgPgPgPg</returnvalue>
<returnvalue>text</returnvalue>
</para>
<para>
- Evaluate escaped Unicode characters in argument. Unicode characters
+ Evaluate escaped Unicode characters in the argument. Unicode
characters
can be specified as
<literal>\<replaceable>XXXX</replaceable></literal> (4 hexadecimal
digits), <literal>\+<replaceable>XXXXXX</replaceable></literal> (6
491445e3c9 doc review: postgres_fdw: Add option to control whether to keep
connections open.
diff --git a/doc/src/sgml/postgres-fdw.sgml b/doc/src/sgml/postgres-fdw.sgml
index fd34956936..e8cb679164 100644
--- a/doc/src/sgml/postgres-fdw.sgml
+++ b/doc/src/sgml/postgres-fdw.sgml
@@ -551,8 +551,8 @@ OPTIONS (ADD password_required 'false');
<title>Connection Management Options</title>
<para>
- By default all the open connections that <filename>postgres_fdw</filename>
- established to the foreign servers are kept in local session for re-use.
+ By default, all connections that <filename>postgres_fdw</filename>
+ establishes to foreign servers are kept open for re-use in the local
session.
</para>
<variablelist>
@@ -562,11 +562,11 @@ OPTIONS (ADD password_required 'false');
<listitem>
<para>
This option controls whether <filename>postgres_fdw</filename> keeps
- the connections to the foreign server open so that the subsequent
+ the connections to the foreign server open so that subsequent
queries can re-use them. It can only be specified for a foreign server.
The default is <literal>on</literal>. If set to <literal>off</literal>,
all connections to this foreign server will be discarded at the end of
- transaction.
+ each transaction.
</para>
</listitem>
</varlistentry>
95a43e5c2d doc review: BRIN minmax-multi indexes
diff --git a/doc/src/sgml/brin.sgml b/doc/src/sgml/brin.sgml
index d2476481af..ce7c210575 100644
--- a/doc/src/sgml/brin.sgml
+++ b/doc/src/sgml/brin.sgml
@@ -730,7 +730,7 @@ LOG: request for BRIN range summarization for index
"brin_wi_idx" page 128 was
for <xref linkend="sql-altertable"/>. When set to a positive value,
each block range is assumed to contain this number of distinct non-null
values. When set to a negative value, which must be greater than or
- equal to -1, the number of distinct non-null is assumed linear with
+ equal to -1, the number of distinct non-null values is assumed to grow
linearly with
the maximum possible number of tuples in the block range (about 290
rows per block). The default value is <literal>-0.1</literal>, and
the minimum number of distinct non-null values is <literal>16</literal>.
@@ -1214,7 +1214,7 @@ typedef struct BrinOpcInfo
<para>
The minmax-multi operator class is also intended for data types implementing
- a totally ordered sets, and may be seen as a simple extension of the minmax
+ a totally ordered set, and may be seen as a simple extension of the minmax
operator class. While minmax operator class summarizes values from each block
range into a single contiguous interval, minmax-multi allows summarization
into multiple smaller intervals to improve handling of outlier values.
e53ac30d44 doc review: Track total amounts of times spent writing and syncing
WAL data to disk.
diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml
index 0f13c43095..24cf567ee2 100644
--- a/doc/src/sgml/wal.sgml
+++ b/doc/src/sgml/wal.sgml
@@ -797,7 +797,7 @@
<literal>fsync</literal>, or <literal>fsync_writethrough</literal>,
the write operation moves WAL buffers to kernel cache and
<function>issue_xlog_fsync</function> syncs them to disk. Regardless
- of the setting of <varname>track_wal_io_timing</varname>, the numbers
+ of the setting of <varname>track_wal_io_timing</varname>, the number
of times <function>XLogWrite</function> writes and
<function>issue_xlog_fsync</function> syncs WAL data to disk are also
counted as <literal>wal_write</literal> and <literal>wal_sync</literal>
6e0c552d1c doc review: Be clear about whether a recovery pause has taken effect.
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 0606b6a9aa..7b75e0bca2 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -25576,7 +25576,7 @@ postgres=# SELECT * FROM
pg_walfile_name_offset(pg_stop_backup());
Returns recovery pause state. The return values are <literal>
not paused</literal> if pause is not requested, <literal>
pause requested</literal> if pause is requested but recovery is
- not yet paused and, <literal>paused</literal> if the recovery is
+ not yet paused, and <literal>paused</literal> if the recovery is
actually paused.
</para></entry>
</row>
4bbf35a579 doc review: Add pg_amcheck, a CLI for contrib/amcheck.
diff --git a/doc/src/sgml/ref/pg_amcheck.sgml b/doc/src/sgml/ref/pg_amcheck.sgml
index fcc96b430a..d01e26faa8 100644
--- a/doc/src/sgml/ref/pg_amcheck.sgml
+++ b/doc/src/sgml/ref/pg_amcheck.sgml
@@ -460,7 +460,7 @@ PostgreSQL documentation
<term><option>--skip=<replaceable
class="parameter">option</replaceable></option></term>
<listitem>
<para>
- If <literal>"all-frozen"</literal> is given, table corruption checks
+ If <literal>all-frozen</literal> is given, table corruption checks
will skip over pages in all tables that are marked as all frozen.
</para>
<para>
c7bf0bcc61 doc review: Pass all scan keys to BRIN consistent function at once
diff --git a/doc/src/sgml/brin.sgml b/doc/src/sgml/brin.sgml
index d2f12bb605..d2476481af 100644
--- a/doc/src/sgml/brin.sgml
+++ b/doc/src/sgml/brin.sgml
@@ -833,7 +833,7 @@ typedef struct BrinOpcInfo
Returns whether all the ScanKey entries are consistent with the given
indexed values for a range.
The attribute number to use is passed as part of the scan key.
- Multiple scan keys for the same attribute may be passed at once, the
+ Multiple scan keys for the same attribute may be passed at once; the
number of entries is determined by the <literal>nkeys</literal>
parameter.
</para>
</listitem>
50454d9cf5 doc review: Add support for PROVE_TESTS and PROVE_FLAGS in MSVC
scripts
diff --git a/doc/src/sgml/install-windows.sgml
b/doc/src/sgml/install-windows.sgml
index 64687b12e6..cb6bb05dc5 100644
--- a/doc/src/sgml/install-windows.sgml
+++ b/doc/src/sgml/install-windows.sgml
@@ -499,8 +499,8 @@ $ENV{PERL5LIB}=$ENV{PERL5LIB} . ';c:\IPC-Run-0.94\lib';
<para>
The TAP tests run with <command>vcregress</command> support the
- environment variables <varname>PROVE_TESTS</varname>, that is expanded
- automatically using the name patterns given, and
+ environment variables <varname>PROVE_TESTS</varname>, which is
+ expanded as a glob pattern, and
<varname>PROVE_FLAGS</varname>. These can be set on a Windows terminal,
before running <command>vcregress</command>:
<programlisting>
633e7a3b54 doc review: VACUUM (PROCESS_TOAST)
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index 6a0028a514..949ca23797 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -219,7 +219,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [
<replaceable class="paramet
corresponding <literal>TOAST</literal> table for each relation, if one
exists. This is normally the desired behavior and is the default.
Setting this option to false may be useful when it is only necessary to
- vacuum the main relation. This option is required when the
+ vacuum the main relation. This option may not be disabled when the
<literal>FULL</literal> option is used.
</para>
</listitem>
7e84a06724 doc review: Multiple xacts during table sync in logical replication
diff --git a/doc/src/sgml/logical-replication.sgml
b/doc/src/sgml/logical-replication.sgml
index e95d446dac..3fad5f34e6 100644
--- a/doc/src/sgml/logical-replication.sgml
+++ b/doc/src/sgml/logical-replication.sgml
@@ -490,9 +490,9 @@
any changes that happened during the initial data copy using standard
logical replication. During this synchronization phase, the changes
are applied and committed in the same order as they happened on the
- publisher. Once the synchronization is done, the control of the
+ publisher. Once synchronization is done, control of the
replication of the table is given back to the main apply process where
- the replication continues as normal.
+ replication continues as normal.
</para>
</sect2>
</sect1>
8259924473 doc review: pg_stat_progress_create_index
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index f637fe0415..8287587f61 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -5890,7 +5890,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
</para>
<para>
When creating an index on a partitioned table, this column is set to
- the number of partitions on which the index has been completed.
+ the number of partitions on which the index has been created.
This field is <literal>0</literal> during a <literal>REINDEX</literal>.
</para></entry>
</row>
576580e6c3 doc review: piecemeal construction of partitioned indexes
diff --git a/doc/src/sgml/ddl.sgml b/doc/src/sgml/ddl.sgml
index 30e4170963..354f9e57bd 100644
--- a/doc/src/sgml/ddl.sgml
+++ b/doc/src/sgml/ddl.sgml
@@ -3957,8 +3957,8 @@ ALTER TABLE measurement ATTACH PARTITION
measurement_y2008m02
As explained above, it is possible to create indexes on partitioned tables
so that they are applied automatically to the entire hierarchy.
This is very
- convenient, as not only will the existing partitions become indexed, but
- also any partitions that are created in the future will. One limitation
is
+ convenient, as not only the existing partitions will be indexed, but
+ so will any partitions that are created in the future. One limitation is
that it's not possible to use the <literal>CONCURRENTLY</literal>
qualifier when creating such a partitioned index. To avoid long lock
times, it is possible to use <command>CREATE INDEX ON ONLY</command>
1384db4053 doc review: psql \dX
diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml
index ddb7043362..a3cfd3b557 100644
--- a/doc/src/sgml/ref/psql-ref.sgml
+++ b/doc/src/sgml/ref/psql-ref.sgml
@@ -1927,9 +1927,10 @@ testdb=>
</para>
<para>
- The column of the kind of extended stats (e.g. Ndistinct) shows its
status.
- NULL means that it doesn't exists. "defined" means that it was
requested
- when creating the statistics.
+ The status of each kind of extended statistics is shown in a column
+ named after its statistic kind (e.g. Ndistinct).
+ "defined" means that it was requested when creating the statistics,
+ and NULL means it wasn't requested.
You can use pg_stats_ext if you'd like to know whether <link
linkend="sql-analyze">
<command>ANALYZE</command></link> was run and statistics are available
to the
planner.
>From 1384db4053a3eea6bf8fef05ee6a961ba8d2a6b0 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Wed, 20 Jan 2021 16:10:49 -0600
Subject: [PATCH 01/32] doc review: psql \dX
ad600bba0422dde4b73fbd61049ff2a3847b068a
---
doc/src/sgml/ref/psql-ref.sgml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml
index ddb7043362..a3cfd3b557 100644
--- a/doc/src/sgml/ref/psql-ref.sgml
+++ b/doc/src/sgml/ref/psql-ref.sgml
@@ -1927,9 +1927,10 @@ testdb=>
</para>
<para>
- The column of the kind of extended stats (e.g. Ndistinct) shows its status.
- NULL means that it doesn't exists. "defined" means that it was requested
- when creating the statistics.
+ The status of each kind of extended statistics is shown in a column
+ named after its statistic kind (e.g. Ndistinct).
+ "defined" means that it was requested when creating the statistics,
+ and NULL means it wasn't requested.
You can use pg_stats_ext if you'd like to know whether <link linkend="sql-analyze">
<command>ANALYZE</command></link> was run and statistics are available to the
planner.
--
2.17.0
>From 576580e6c3e2eb432b845fd3b0f494ec388e2ee0 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Wed, 3 Feb 2021 00:51:25 -0600
Subject: [PATCH 02/32] doc review: piecemeal construction of partitioned
indexes
5efd604ec0a3bdde98fe19d8cada69ab4ef80db3
backpatch to v11
---
doc/src/sgml/ddl.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/ddl.sgml b/doc/src/sgml/ddl.sgml
index 30e4170963..354f9e57bd 100644
--- a/doc/src/sgml/ddl.sgml
+++ b/doc/src/sgml/ddl.sgml
@@ -3957,8 +3957,8 @@ ALTER TABLE measurement ATTACH PARTITION measurement_y2008m02
As explained above, it is possible to create indexes on partitioned tables
so that they are applied automatically to the entire hierarchy.
This is very
- convenient, as not only will the existing partitions become indexed, but
- also any partitions that are created in the future will. One limitation is
+ convenient, as not only the existing partitions will be indexed, but
+ so will any partitions that are created in the future. One limitation is
that it's not possible to use the <literal>CONCURRENTLY</literal>
qualifier when creating such a partitioned index. To avoid long lock
times, it is possible to use <command>CREATE INDEX ON ONLY</command>
--
2.17.0
>From 8259924473598523890fd3dd556f1053e3906861 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Wed, 10 Feb 2021 17:19:51 -0600
Subject: [PATCH 03/32] doc review: pg_stat_progress_create_index
ab0dfc961b6a821f23d9c40c723d11380ce195a6
should backpatch to v13
---
doc/src/sgml/monitoring.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index f637fe0415..8287587f61 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -5890,7 +5890,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
</para>
<para>
When creating an index on a partitioned table, this column is set to
- the number of partitions on which the index has been completed.
+ the number of partitions on which the index has been created.
This field is <literal>0</literal> during a <literal>REINDEX</literal>.
</para></entry>
</row>
--
2.17.0
>From 7e84a06724c1fd7ec582823106956a0056e58e00 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Thu, 18 Feb 2021 10:08:27 -0600
Subject: [PATCH 04/32] doc review: Multiple xacts during table sync in logical
replication
ce0fdbfe9722867b7fad4d3ede9b6a6bfc51fb4e
---
doc/src/sgml/logical-replication.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml
index e95d446dac..3fad5f34e6 100644
--- a/doc/src/sgml/logical-replication.sgml
+++ b/doc/src/sgml/logical-replication.sgml
@@ -490,9 +490,9 @@
any changes that happened during the initial data copy using standard
logical replication. During this synchronization phase, the changes
are applied and committed in the same order as they happened on the
- publisher. Once the synchronization is done, the control of the
+ publisher. Once synchronization is done, control of the
replication of the table is given back to the main apply process where
- the replication continues as normal.
+ replication continues as normal.
</para>
</sect2>
</sect1>
--
2.17.0
>From 633e7a3b54abaf6fe78eadd621dd8e027cbbb403 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Thu, 18 Feb 2021 10:13:15 -0600
Subject: [PATCH 05/32] doc review: VACUUM (PROCESS_TOAST)
7cb3048f38e26b39dd5fd412ed8a4981b6809b35
---
doc/src/sgml/ref/vacuum.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
index 6a0028a514..949ca23797 100644
--- a/doc/src/sgml/ref/vacuum.sgml
+++ b/doc/src/sgml/ref/vacuum.sgml
@@ -219,7 +219,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
corresponding <literal>TOAST</literal> table for each relation, if one
exists. This is normally the desired behavior and is the default.
Setting this option to false may be useful when it is only necessary to
- vacuum the main relation. This option is required when the
+ vacuum the main relation. This option may not be disabled when the
<literal>FULL</literal> option is used.
</para>
</listitem>
--
2.17.0
>From 50454d9cf5199b6a248a71167525c2356da25886 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Thu, 4 Mar 2021 19:32:05 -0600
Subject: [PATCH 06/32] doc review: Add support for PROVE_TESTS and PROVE_FLAGS
in MSVC scripts
5bca69a76b3046a85c60c48271c1831fd5affa51
---
doc/src/sgml/install-windows.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/install-windows.sgml b/doc/src/sgml/install-windows.sgml
index 64687b12e6..cb6bb05dc5 100644
--- a/doc/src/sgml/install-windows.sgml
+++ b/doc/src/sgml/install-windows.sgml
@@ -499,8 +499,8 @@ $ENV{PERL5LIB}=$ENV{PERL5LIB} . ';c:\IPC-Run-0.94\lib';
<para>
The TAP tests run with <command>vcregress</command> support the
- environment variables <varname>PROVE_TESTS</varname>, that is expanded
- automatically using the name patterns given, and
+ environment variables <varname>PROVE_TESTS</varname>, which is
+ expanded as a glob pattern, and
<varname>PROVE_FLAGS</varname>. These can be set on a Windows terminal,
before running <command>vcregress</command>:
<programlisting>
--
2.17.0
>From c7bf0bcc61647c47f163e009a878a69163e532fb Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Tue, 23 Mar 2021 13:39:36 -0500
Subject: [PATCH 07/32] doc review: Pass all scan keys to BRIN consistent
function at once
commit a1c649d889bdf6e74e9382e1e28574d7071568de
---
doc/src/sgml/brin.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/brin.sgml b/doc/src/sgml/brin.sgml
index d2f12bb605..d2476481af 100644
--- a/doc/src/sgml/brin.sgml
+++ b/doc/src/sgml/brin.sgml
@@ -833,7 +833,7 @@ typedef struct BrinOpcInfo
Returns whether all the ScanKey entries are consistent with the given
indexed values for a range.
The attribute number to use is passed as part of the scan key.
- Multiple scan keys for the same attribute may be passed at once, the
+ Multiple scan keys for the same attribute may be passed at once; the
number of entries is determined by the <literal>nkeys</literal> parameter.
</para>
</listitem>
--
2.17.0
>From 4bbf35a579035c0e8dd1531f47631eb784d40347 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Tue, 23 Mar 2021 14:03:28 -0500
Subject: [PATCH 08/32] doc review: Add pg_amcheck, a CLI for contrib/amcheck.
9706092839db2c8c93860674e426a917635438c3
---
doc/src/sgml/ref/pg_amcheck.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/ref/pg_amcheck.sgml b/doc/src/sgml/ref/pg_amcheck.sgml
index fcc96b430a..d01e26faa8 100644
--- a/doc/src/sgml/ref/pg_amcheck.sgml
+++ b/doc/src/sgml/ref/pg_amcheck.sgml
@@ -460,7 +460,7 @@ PostgreSQL documentation
<term><option>--skip=<replaceable class="parameter">option</replaceable></option></term>
<listitem>
<para>
- If <literal>"all-frozen"</literal> is given, table corruption checks
+ If <literal>all-frozen</literal> is given, table corruption checks
will skip over pages in all tables that are marked as all frozen.
</para>
<para>
--
2.17.0
>From 6e0c552d1c7ad649f90335cd014746238485afe5 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Tue, 23 Mar 2021 14:20:31 -0500
Subject: [PATCH 09/32] doc review: Be clear about whether a recovery pause has
taken effect.
32fd2b57d7f64948e649fc205c43f007762ecaac
---
doc/src/sgml/func.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 0606b6a9aa..7b75e0bca2 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -25576,7 +25576,7 @@ postgres=# SELECT * FROM pg_walfile_name_offset(pg_stop_backup());
Returns recovery pause state. The return values are <literal>
not paused</literal> if pause is not requested, <literal>
pause requested</literal> if pause is requested but recovery is
- not yet paused and, <literal>paused</literal> if the recovery is
+ not yet paused, and <literal>paused</literal> if the recovery is
actually paused.
</para></entry>
</row>
--
2.17.0
>From e53ac30d44f66466bbf351ddc2c01f46c836433c Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Tue, 23 Mar 2021 14:25:33 -0500
Subject: [PATCH 10/32] doc review: Track total amounts of times spent writing
and syncing WAL data to disk.
ff99918c625a84c91e7391db9032112ec8653623
---
doc/src/sgml/wal.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml
index 0f13c43095..24cf567ee2 100644
--- a/doc/src/sgml/wal.sgml
+++ b/doc/src/sgml/wal.sgml
@@ -797,7 +797,7 @@
<literal>fsync</literal>, or <literal>fsync_writethrough</literal>,
the write operation moves WAL buffers to kernel cache and
<function>issue_xlog_fsync</function> syncs them to disk. Regardless
- of the setting of <varname>track_wal_io_timing</varname>, the numbers
+ of the setting of <varname>track_wal_io_timing</varname>, the number
of times <function>XLogWrite</function> writes and
<function>issue_xlog_fsync</function> syncs WAL data to disk are also
counted as <literal>wal_write</literal> and <literal>wal_sync</literal>
--
2.17.0
>From 95a43e5c2d7106f220823f679c36ce4c79e4be47 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Fri, 26 Mar 2021 23:14:57 -0500
Subject: [PATCH 11/32] doc review: BRIN minmax-multi indexes
ab596105b55f1d7fbd5a66b66f65227d210b047d
---
doc/src/sgml/brin.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/brin.sgml b/doc/src/sgml/brin.sgml
index d2476481af..ce7c210575 100644
--- a/doc/src/sgml/brin.sgml
+++ b/doc/src/sgml/brin.sgml
@@ -730,7 +730,7 @@ LOG: request for BRIN range summarization for index "brin_wi_idx" page 128 was
for <xref linkend="sql-altertable"/>. When set to a positive value,
each block range is assumed to contain this number of distinct non-null
values. When set to a negative value, which must be greater than or
- equal to -1, the number of distinct non-null is assumed linear with
+ equal to -1, the number of distinct non-null values is assumed to grow linearly with
the maximum possible number of tuples in the block range (about 290
rows per block). The default value is <literal>-0.1</literal>, and
the minimum number of distinct non-null values is <literal>16</literal>.
@@ -1214,7 +1214,7 @@ typedef struct BrinOpcInfo
<para>
The minmax-multi operator class is also intended for data types implementing
- a totally ordered sets, and may be seen as a simple extension of the minmax
+ a totally ordered set, and may be seen as a simple extension of the minmax
operator class. While minmax operator class summarizes values from each block
range into a single contiguous interval, minmax-multi allows summarization
into multiple smaller intervals to improve handling of outlier values.
--
2.17.0
>From 491445e3c9eb9812fa4635051159082550b6820c Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Fri, 2 Apr 2021 09:03:45 -0500
Subject: [PATCH 12/32] doc review: postgres_fdw: Add option to control whether
to keep connections open.
b1be3074ac719ce8073fba35d4c8b52fb4ddd0c3
---
doc/src/sgml/postgres-fdw.sgml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/doc/src/sgml/postgres-fdw.sgml b/doc/src/sgml/postgres-fdw.sgml
index fd34956936..e8cb679164 100644
--- a/doc/src/sgml/postgres-fdw.sgml
+++ b/doc/src/sgml/postgres-fdw.sgml
@@ -551,8 +551,8 @@ OPTIONS (ADD password_required 'false');
<title>Connection Management Options</title>
<para>
- By default all the open connections that <filename>postgres_fdw</filename>
- established to the foreign servers are kept in local session for re-use.
+ By default, all connections that <filename>postgres_fdw</filename>
+ establishes to foreign servers are kept open for re-use in the local session.
</para>
<variablelist>
@@ -562,11 +562,11 @@ OPTIONS (ADD password_required 'false');
<listitem>
<para>
This option controls whether <filename>postgres_fdw</filename> keeps
- the connections to the foreign server open so that the subsequent
+ the connections to the foreign server open so that subsequent
queries can re-use them. It can only be specified for a foreign server.
The default is <literal>on</literal>. If set to <literal>off</literal>,
all connections to this foreign server will be discarded at the end of
- transaction.
+ each transaction.
</para>
</listitem>
</varlistentry>
--
2.17.0
>From dfdae1597d1af5de54a644e6097efa5dd3d7790f Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Fri, 2 Apr 2021 09:30:58 -0500
Subject: [PATCH 13/32] doc review: Add unistr function
commit f37fec837ce8bf7af408ba66d32099e5a0182402
---
doc/src/sgml/func.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 7b75e0bca2..be22f4b61b 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -3560,7 +3560,7 @@ repeat('Pg', 4) <returnvalue>PgPgPgPg</returnvalue>
<returnvalue>text</returnvalue>
</para>
<para>
- Evaluate escaped Unicode characters in argument. Unicode characters
+ Evaluate escaped Unicode characters in the argument. Unicode characters
can be specified as
<literal>\<replaceable>XXXX</replaceable></literal> (4 hexadecimal
digits), <literal>\+<replaceable>XXXXXX</replaceable></literal> (6
--
2.17.0
>From 85330eeda727a0fe151e459970652e30b10c4ca6 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Tue, 6 Apr 2021 10:22:35 -0500
Subject: [PATCH 14/32] doc review: Stop archive recovery if WAL generated with
wal_level=minimal is found.
9de9294b0c4dac77edb80f029648afca79d14653
---
doc/src/sgml/config.sgml | 2 +-
doc/src/sgml/perform.sgml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 26628f3e6d..ae1a38b8bc 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -2723,7 +2723,7 @@ include_dir 'conf.d'
Note that changing <varname>wal_level</varname> to
<literal>minimal</literal> makes any base backups taken before
unavailable for archive recovery and standby server, which may
- lead to database loss.
+ lead to data loss.
</para>
<para>
In <literal>logical</literal> level, the same information is logged as
diff --git a/doc/src/sgml/perform.sgml b/doc/src/sgml/perform.sgml
index e0d3f246e9..d1af624f44 100644
--- a/doc/src/sgml/perform.sgml
+++ b/doc/src/sgml/perform.sgml
@@ -1747,7 +1747,7 @@ SELECT * FROM x, y, a, b, c WHERE something AND somethingelse;
<xref linkend="guc-max-wal-senders"/> to zero.
But note that changing these settings requires a server restart,
and makes any base backups taken before unavailable for archive
- recovery and standby server, which may lead to database loss.
+ recovery and standby server, which may lead to data loss.
</para>
<para>
--
2.17.0
>From e292ee3e350732ea37b98040774123bc61754e08 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Tue, 6 Apr 2021 10:27:46 -0500
Subject: [PATCH 15/32] doc review: Add function to log the memory contexts of
specified backend process.
commit 43620e328617c1f41a2a54c8cee01723064e3ffa
---
doc/src/sgml/func.sgml | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index be22f4b61b..679738f615 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -24926,12 +24926,12 @@ SELECT collation for ('foo' COLLATE "de_DE");
<returnvalue>boolean</returnvalue>
</para>
<para>
- Requests to log the memory contexts whose backend process has
- the specified process ID. These memory contexts will be logged at
+ Requests to log the memory contexts of the backend with the
+ specified process ID. These memory contexts will be logged at
<literal>LOG</literal> message level. They will appear in
the server log based on the log configuration set
(See <xref linkend="runtime-config-logging"/> for more information),
- but will not be sent to the client whatever the setting of
+ but will not be sent to the client regardless of
<xref linkend="guc-client-min-messages"/>.
Only superusers can request to log the memory contexts.
</para></entry>
@@ -25037,9 +25037,9 @@ SELECT collation for ('foo' COLLATE "de_DE");
<para>
<function>pg_log_backend_memory_contexts</function> can be used
- to log the memory contexts of the backend process. For example,
+ to log the memory contexts of a backend process. For example,
<programlisting>
-postgres=# SELECT pg_log_backend_memory_contexts(pg_backend_pid());
+postgres=# SELECT pg_log_backend_memory_contexts(pg_backend_pid()); -- XXX
pg_log_backend_memory_contexts
--------------------------------
t
@@ -25061,8 +25061,8 @@ LOG: level: 1; TransactionAbortContext: 32768 total in 1 blocks; 32504 free (0
LOG: level: 1; ErrorContext: 8192 total in 1 blocks; 7928 free (3 chunks); 264 used
LOG: Grand total: 1651920 bytes in 201 blocks; 622360 free (88 chunks); 1029560 used
</screen>
- For more than 100 child contexts under the same parent one,
- 100 child contexts and a summary of the remaining ones will be logged.
+ If there are more than 100 child contexts under the same parent, the first
+ 100 child contexts are logged, along with a summary of the remaining contexts.
Note that frequent calls to this function could incur significant overhead,
because it may generate a large number of log messages.
</para>
--
2.17.0
>From 567b33c755ad551858fa014eca868c5ca82e4a5a Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Wed, 7 Apr 2021 23:12:50 -0500
Subject: [PATCH 16/32] doc review: Move pg_stat_statements query jumbling to
core.
5fd9dfa5f50e4906c35133a414ebec5b6d518493
---
doc/src/sgml/config.sgml | 2 +-
doc/src/sgml/pgstatstatements.sgml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index ae1a38b8bc..04712769ca 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -7737,7 +7737,7 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
</para>
<note>
<para>
- To ensure that a only one query identifier is calculated and
+ To ensure that only one query identifier is calculated and
displayed, extensions that calculate query identifiers should
throw an error if a query identifier has already been computed.
</para>
diff --git a/doc/src/sgml/pgstatstatements.sgml b/doc/src/sgml/pgstatstatements.sgml
index 5ad4f0aed2..e235504e9a 100644
--- a/doc/src/sgml/pgstatstatements.sgml
+++ b/doc/src/sgml/pgstatstatements.sgml
@@ -406,7 +406,7 @@
<note>
<para>
The following details about constant replacement and
- <structfield>queryid</structfield> only applies when <xref
+ <structfield>queryid</structfield> only apply when <xref
linkend="guc-compute-query-id"/> is enabled. If you use an external
module instead to compute <structfield>queryid</structfield>, you
should refer to its documentation for details.
--
2.17.0
>From 3399caf1335e9ba70d2130599772922a42e4065b Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Wed, 7 Apr 2021 23:15:37 -0500
Subject: [PATCH 17/32] doc review: Make use of in-core query id added by
commit 5fd9dfa5f5
4f0b0966c866ae9f0e15d7cc73ccf7ce4e1af84b
---
doc/src/sgml/config.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 04712769ca..cf4e82e8b5 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -7732,7 +7732,7 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
The <xref linkend="pgstatstatements"/> extension also requires a query
identifier to be computed. Note that an external module can
alternatively be used if the in-core query identifier computation
- specification isn't acceptable. In this case, in-core computation
+ method isn't acceptable. In this case, in-core computation
must be disabled. The default is <literal>off</literal>.
</para>
<note>
--
2.17.0
>From 69e597176bade9c1a5612d70b8a429f38c3c91e2 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Wed, 7 Apr 2021 23:19:22 -0500
Subject: [PATCH 18/32] doc review: Fix use of cursor sensitivity terminology
dd13ad9d39a1ba41cf329b6fe408b49be57c7b88
---
doc/src/sgml/ref/declare.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/ref/declare.sgml b/doc/src/sgml/ref/declare.sgml
index 8a2b8cc892..aa3d1d1fa1 100644
--- a/doc/src/sgml/ref/declare.sgml
+++ b/doc/src/sgml/ref/declare.sgml
@@ -335,7 +335,7 @@ DECLARE liahona CURSOR FOR SELECT * FROM films;
<para>
According to the SQL standard, changes made to insensitive cursors by
<literal>UPDATE ... WHERE CURRENT OF</literal> and <literal>DELETE
- ... WHERE CURRENT OF</literal> statements are visibible in that same
+ ... WHERE CURRENT OF</literal> statements are visible in that same
cursor. <productname>PostgreSQL</productname> treats these statements like
all other data changing statements in that they are not visible in
insensitive cursors.
--
2.17.0
>From d987f0505e3e3323a7077692d0ae0fff7b3395dd Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Fri, 26 Feb 2021 20:47:28 -0600
Subject: [PATCH 19/32] spell: vacuum
c8e0f6bbdb5ff0f235246af5b567b21dcfc1d22a
---
doc/src/sgml/ref/create_table.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml
index 44e50620fd..d7fffddbce 100644
--- a/doc/src/sgml/ref/create_table.sgml
+++ b/doc/src/sgml/ref/create_table.sgml
@@ -1520,7 +1520,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
</listitem>
</varlistentry>
- <varlistentry id="reloption-autovacuum-vauum-scale-factor" xreflabel="autovacuum_vacuum_scale_factor">
+ <varlistentry id="reloption-autovacuum-vacuum-scale-factor" xreflabel="autovacuum_vacuum_scale_factor">
<term><literal>autovacuum_vacuum_scale_factor</literal>, <literal>toast.autovacuum_vacuum_scale_factor</literal> (<type>floating point</type>)
<indexterm>
<primary><varname>autovacuum_vacuum_scale_factor</varname> </primary>
@@ -1610,7 +1610,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
</listitem>
</varlistentry>
- <varlistentry id="reloption-autovacuum-vauum-cost-limit" xreflabel="autovacuum_vacuum_cost_limit">
+ <varlistentry id="reloption-autovacuum-vacuum-cost-limit" xreflabel="autovacuum_vacuum_cost_limit">
<term><literal>autovacuum_vacuum_cost_limit</literal>, <literal>toast.autovacuum_vacuum_cost_limit</literal> (<type>integer</type>)
<indexterm>
<primary><varname>autovacuum_vacuum_cost_limit</varname></primary>
--
2.17.0
>From e6025e2e8163bd045422cd41403722268f6063b1 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Thu, 11 Feb 2021 22:34:47 -0600
Subject: [PATCH 20/32] amcheck
---
doc/src/sgml/amcheck.sgml | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/amcheck.sgml b/doc/src/sgml/amcheck.sgml
index a2571d33ae..30fcb033e3 100644
--- a/doc/src/sgml/amcheck.sgml
+++ b/doc/src/sgml/amcheck.sgml
@@ -457,14 +457,13 @@ SET client_min_messages = DEBUG1;
</listitem>
<listitem>
<para>
- File system or storage subsystem faults where checksums happen to
- simply not be enabled.
+ File system or storage subsystem faults where checksums are
+ not enabled.
</para>
<para>
- Note that <filename>amcheck</filename> examines a page as represented in some
- shared memory buffer at the time of verification if there is only a
- shared buffer hit when accessing the block. Consequently,
- <filename>amcheck</filename> does not necessarily examine data read from the
+ Note that <filename>amcheck</filename> examines a page as represented in a
+ shared memory buffer at the time of verification. If the page is cached,
+ <filename>amcheck</filename> will not examine data read from the
file system at the time of verification. Note that when checksums are
enabled, <filename>amcheck</filename> may raise an error due to a checksum
failure when a corrupt block is read into a buffer.
--
2.17.0
>From d37a8a04f708bbc2f5db5c68a63bedb59992b0f0 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Sun, 14 Mar 2021 21:00:20 -0500
Subject: [PATCH 21/32] wal_compression
57aa5b2bb11a4dbfdfc0f92370e0742ae5aa367b
maybe backpatch to 9.6?
---
doc/src/sgml/config.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index cf4e82e8b5..a382258aee 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -3098,7 +3098,7 @@ include_dir 'conf.d'
<listitem>
<para>
When this parameter is <literal>on</literal>, the <productname>PostgreSQL</productname>
- server compresses a full page image written to WAL when
+ server compresses full page images written to WAL when
<xref linkend="guc-full-page-writes"/> is on or during a base backup.
A compressed page image will be decompressed during WAL replay.
The default value is <literal>off</literal>.
--
2.17.0
>From 573eeb8666ebfde31b47f7bd2f39c270a2b07c16 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Sun, 28 Feb 2021 18:24:09 -0600
Subject: [PATCH 22/32] language fixen
---
doc/src/sgml/maintenance.sgml | 2 +-
doc/src/sgml/perform.sgml | 2 +-
doc/src/sgml/ref/createuser.sgml | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/src/sgml/maintenance.sgml b/doc/src/sgml/maintenance.sgml
index 3bbae6dd91..4adb34a21b 100644
--- a/doc/src/sgml/maintenance.sgml
+++ b/doc/src/sgml/maintenance.sgml
@@ -185,7 +185,7 @@
never issue <command>VACUUM FULL</command>. In this approach, the idea
is not to keep tables at their minimum size, but to maintain steady-state
usage of disk space: each table occupies space equivalent to its
- minimum size plus however much space gets used up between vacuumings.
+ minimum size plus however much space gets used up between vacuum runs.
Although <command>VACUUM FULL</command> can be used to shrink a table back
to its minimum size and return the disk space to the operating system,
there is not much point in this if the table will just grow again in the
diff --git a/doc/src/sgml/perform.sgml b/doc/src/sgml/perform.sgml
index d1af624f44..89ff58338e 100644
--- a/doc/src/sgml/perform.sgml
+++ b/doc/src/sgml/perform.sgml
@@ -1899,7 +1899,7 @@ SELECT * FROM x, y, a, b, c WHERE something AND somethingelse;
much faster. The following are configuration changes you can make
to improve performance in such cases. Except as noted below, durability
is still guaranteed in case of a crash of the database software;
- only abrupt operating system stoppage creates a risk of data loss
+ only an abrupt operating system crash creates a risk of data loss
or corruption when these settings are used.
<itemizedlist>
diff --git a/doc/src/sgml/ref/createuser.sgml b/doc/src/sgml/ref/createuser.sgml
index 4d60dc2cda..17579e50af 100644
--- a/doc/src/sgml/ref/createuser.sgml
+++ b/doc/src/sgml/ref/createuser.sgml
@@ -44,7 +44,7 @@ PostgreSQL documentation
If you wish to create a new superuser, you must connect as a
superuser, not merely with <literal>CREATEROLE</literal> privilege.
Being a superuser implies the ability to bypass all access permission
- checks within the database, so superuserdom should not be granted lightly.
+ checks within the database, so superuser access should not be granted lightly.
</para>
<para>
--
2.17.0
>From 83f9954468815f66096a57ad6b2cdb1bba556c1b Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Sat, 27 Feb 2021 22:59:45 -0600
Subject: [PATCH 23/32] accessmtd
---
src/backend/catalog/heap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/backend/catalog/heap.c b/src/backend/catalog/heap.c
index 9f6303266f..ba03e8aa8f 100644
--- a/src/backend/catalog/heap.c
+++ b/src/backend/catalog/heap.c
@@ -1119,6 +1119,7 @@ AddNewRelationType(const char *typeName,
* reltypeid: OID to assign to rel's rowtype, or InvalidOid to select one
* reloftypeid: if a typed table, OID of underlying type; else InvalidOid
* ownerid: OID of new rel's owner
+ * accessmtd: OID of new rel's access method
* tupdesc: tuple descriptor (source of column definitions)
* cooked_constraints: list of precooked check constraints and defaults
* relkind: relkind for new rel
--
2.17.0
>From f24c2c1075706680a64bc7ccaab43b51f98bf66a Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Sun, 28 Feb 2021 21:07:23 -0600
Subject: [PATCH 24/32] docs review: logical replication
665d1fad99e7b11678b0d5fa24d2898424243cd6
8af3c233e423e106a5121000ecd92abf57c11704
---
doc/src/sgml/config.sgml | 2 +-
doc/src/sgml/logical-replication.sgml | 13 ++++++-------
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index a382258aee..bc4a8b2279 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -4137,7 +4137,7 @@ restore_command = 'copy "C:\\server\\archivedir\\%f" "%p"' # Windows
On the subscriber side, specifies how many replication origins (see
<xref linkend="replication-origins"/>) can be tracked simultaneously,
effectively limiting how many logical replication subscriptions can
- be created on the server. Setting it a lower value than the current
+ be created on the server. Setting it to a lower value than the current
number of tracked replication origins (reflected in
<link linkend="view-pg-replication-origin-status">pg_replication_origin_status</link>,
not <link linkend="catalog-pg-replication-origin">pg_replication_origin</link>)
diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml
index 3fad5f34e6..7645ee032c 100644
--- a/doc/src/sgml/logical-replication.sgml
+++ b/doc/src/sgml/logical-replication.sgml
@@ -602,13 +602,12 @@
</para>
<para>
- The subscriber also requires the <varname>max_replication_slots</varname>
- be set to configure how many replication origins can be tracked. In this
- case it should be set to at least the number of subscriptions that will be
- added to the subscriber, plus some reserve for table synchronization.
- <varname>max_logical_replication_workers</varname> must be set to at least
- the number of subscriptions, again plus some reserve for the table
- synchronization. Additionally the <varname>max_worker_processes</varname>
+ <varname>max_replication_slots</varname> must also be set on the subscriber.
+ It should be set to at least the number of
+ subscriptions that will be added to the subscriber, plus some reserve for
+ table synchronization. <varname>max_logical_replication_workers</varname>
+ must be set to at least the number of subscriptions, again plus some reserve
+ for the table synchronization. Additionally the <varname>max_worker_processes</varname>
may need to be adjusted to accommodate for replication workers, at least
(<varname>max_logical_replication_workers</varname>
+ <literal>1</literal>). Note that some extensions and parallel queries
--
2.17.0
>From a45af383aeb7fb7e19125abd316fb0307eedc349 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Mon, 8 Mar 2021 01:40:45 -0600
Subject: [PATCH 25/32] rebuilt
af2543e884db06c0beb75010218cd88680203b86
---
src/backend/commands/cluster.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 096a06f7b3..6487a9e3fc 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -1422,7 +1422,7 @@ finish_heap_swap(Oid OIDOldHeap, Oid OIDNewHeap,
PROGRESS_CLUSTER_PHASE_FINAL_CLEANUP);
/*
- * If the relation being rebuild is pg_class, swap_relation_files()
+ * If the relation being rebuilt is pg_class, swap_relation_files()
* couldn't update pg_class's own pg_class entry (check comments in
* swap_relation_files()), thus relfrozenxid was not updated. That's
* annoying because a potential reason for doing a VACUUM FULL is a
--
2.17.0
>From 9f78de50426c6ea37f19de001fddc1967c175ba7 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Sat, 13 Mar 2021 19:36:23 -0600
Subject: [PATCH 26/32] exist
5f8727f5a679452f7bbdd6966a1586934dcaa84f
---
src/backend/commands/analyze.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/commands/analyze.c b/src/backend/commands/analyze.c
index 5bdaceefd5..182a133033 100644
--- a/src/backend/commands/analyze.c
+++ b/src/backend/commands/analyze.c
@@ -617,7 +617,7 @@ do_analyze_rel(Relation onerel, VacuumParams *params,
*
* We assume that VACUUM hasn't set pg_class.reltuples already, even
* during a VACUUM ANALYZE. Although VACUUM often updates pg_class,
- * exceptions exists. A "VACUUM (ANALYZE, INDEX_CLEANUP OFF)" command
+ * exceptions exist. A "VACUUM (ANALYZE, INDEX_CLEANUP OFF)" command
* will never update pg_class entries for index relations. It's also
* possible that an individual index's pg_class entry won't be updated
* during VACUUM if the index AM returns NULL from its amvacuumcleanup()
--
2.17.0
>From 9acedbd4af513ad1a985ff1a33be480f96ccbc4c Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Sun, 14 Mar 2021 14:02:26 -0500
Subject: [PATCH 27/32] as
86b85044e823a304d2a265abc030254d39efe7df
---
src/backend/commands/copyfrom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/commands/copyfrom.c b/src/backend/commands/copyfrom.c
index 20e7d57d41..40a54ad0bd 100644
--- a/src/backend/commands/copyfrom.c
+++ b/src/backend/commands/copyfrom.c
@@ -410,7 +410,7 @@ CopyMultiInsertBufferCleanup(CopyMultiInsertInfo *miinfo,
* Once flushed we also trim the tracked buffers list down to size by removing
* the buffers created earliest first.
*
- * Callers should pass 'curr_rri' is the ResultRelInfo that's currently being
+ * Callers should pass 'curr_rri' as the ResultRelInfo that's currently being
* used. When cleaning up old buffers we'll never remove the one for
* 'curr_rri'.
*/
--
2.17.0
>From ad5f9a20232741e9d091df2e7968084bf4fc6a20 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Sun, 14 Mar 2021 13:16:00 -0500
Subject: [PATCH 28/32] Caller
81fcc72e66222357f9bccce3eeda62eb2cb29849
---
src/backend/utils/adt/jsonfuncs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backend/utils/adt/jsonfuncs.c b/src/backend/utils/adt/jsonfuncs.c
index 9961d27df4..09fcff6729 100644
--- a/src/backend/utils/adt/jsonfuncs.c
+++ b/src/backend/utils/adt/jsonfuncs.c
@@ -1651,7 +1651,7 @@ push_null_elements(JsonbParseState **ps, int num)
* this path. E.g. the path [a][0][b] with the new value 1 will produce the
* structure {a: [{b: 1}]}.
*
- * Called is responsible to make sure such path does not exist yet.
+ * Caller is responsible to make sure such path does not exist yet.
*/
static void
push_path(JsonbParseState **st, int level, Datum *path_elems,
@@ -4887,7 +4887,7 @@ IteratorConcat(JsonbIterator **it1, JsonbIterator **it2,
* than just one last element, this flag will instruct to create the whole
* chain of corresponding objects and insert the value.
*
- * JB_PATH_CONSISTENT_POSITION for an array indicates that the called wants to
+ * JB_PATH_CONSISTENT_POSITION for an array indicates that the caller wants to
* keep values with fixed indices. Indices for existing elements could be
* changed (shifted forward) in case if the array is prepended with a new value
* and a negative index out of the range, so this behavior will be prevented
--
2.17.0
>From e7d5c5d9dc60b1b7ebed9d4d4cb0f24ce4049354 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Sat, 20 Mar 2021 17:25:01 -0500
Subject: [PATCH 29/32] guc.h: remove mention of "doit"
Gone since 10 years.
2594cf0e8c04406ffff19b1651c5a406d376657c
---
src/include/utils/guc.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/include/utils/guc.h b/src/include/utils/guc.h
index 1892c7927b..1126b34798 100644
--- a/src/include/utils/guc.h
+++ b/src/include/utils/guc.h
@@ -90,8 +90,7 @@ typedef enum
* dividing line between "interactive" and "non-interactive" sources for
* error reporting purposes.
*
- * PGC_S_TEST is used when testing values to be used later ("doit" will always
- * be false, so this never gets stored as the actual source of any value).
+ * PGC_S_TEST is used when testing values to be used later.
* For example, ALTER DATABASE/ROLE tests proposed per-database or per-user
* defaults this way, and CREATE FUNCTION tests proposed function SET clauses
* this way. This is an interactive case, but it needs its own source value
--
2.17.0
>From b745e9e60e3360c3927ced177f445ec883aa8e64 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Wed, 24 Mar 2021 18:42:00 -0500
Subject: [PATCH 30/32] a statistics objects
commit d06215d03b50c264a0f31e335b895ee1b6753e68
---
src/backend/statistics/extended_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/statistics/extended_stats.c b/src/backend/statistics/extended_stats.c
index 463d44a68a..4674168ff8 100644
--- a/src/backend/statistics/extended_stats.c
+++ b/src/backend/statistics/extended_stats.c
@@ -254,7 +254,7 @@ BuildRelationExtStatistics(Relation onerel, double totalrows,
* that would require additional columns.
*
* See statext_compute_stattarget for details about how we compute statistics
- * target for a statistics objects (from the object target, attribute targets
+ * target for a statistics object (from the object target, attribute targets
* and default statistics target).
*/
int
--
2.17.0
>From e7c370c7c511d73150eca489bf6d8c43a2ffc471 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Tue, 30 Mar 2021 23:37:08 -0500
Subject: [PATCH 31/32] pg_amcheck: remove Double semi-colon
commit 9706092839db2c8c93860674e426a917635438c3
Reminicent of 13cb5bd84, 37c99d304
---
src/bin/pg_amcheck/t/004_verify_heapam.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/pg_amcheck/t/004_verify_heapam.pl b/src/bin/pg_amcheck/t/004_verify_heapam.pl
index 36607596b1..2171d236a7 100644
--- a/src/bin/pg_amcheck/t/004_verify_heapam.pl
+++ b/src/bin/pg_amcheck/t/004_verify_heapam.pl
@@ -175,7 +175,7 @@ sub write_tuple
seek($fh, $offset, 0)
or BAIL_OUT("seek failed: $!");
defined(syswrite($fh, $buffer, HEAPTUPLE_PACK_LENGTH))
- or BAIL_OUT("syswrite failed: $!");;
+ or BAIL_OUT("syswrite failed: $!");
return;
}
--
2.17.0
>From 29c8d614c386691154f1a4db6bebbe0fa7063916 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryz...@telsasoft.com>
Date: Sun, 4 Apr 2021 13:36:07 -0500
Subject: [PATCH 32/32] duplicate words
0a1f1d3cac6baaa3744b89336673caba702f7628
---
src/include/lib/sort_template.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/include/lib/sort_template.h b/src/include/lib/sort_template.h
index 771c789ced..24d6d0006c 100644
--- a/src/include/lib/sort_template.h
+++ b/src/include/lib/sort_template.h
@@ -241,7 +241,7 @@ ST_SCOPE void ST_SORT(ST_ELEMENT_TYPE *first, size_t n
/*
* Find the median of three values. Currently, performance seems to be best
- * if the the comparator is inlined here, but the med3 function is not inlined
+ * if the comparator is inlined here, but the med3 function is not inlined
* in the qsort function.
*/
static pg_noinline ST_ELEMENT_TYPE *
--
2.17.0
