On Tue, Mar 30, 2021 at 6:02 PM Michael Banck <michael.ba...@credativ.de> wrote: > > Hi, > > Am Montag, den 29.03.2021, 17:59 +0000 schrieb Cary Huang: > > I have tried the patch and the new option is able to control the > > contents of pg_dump outputs to include only create db related > > commands. > > Thanks for testing! > > > I also agree that the option name is a little misleading to the user > > so I would suggest instead of using "create-only", you can say > > something maybe like "createdb-only" because this option only applies > > to CREATE DATABASE related commands, not CREATE TABLE or other > > objects. In the help menu, you can then elaborate more that this > > option "dump only the commands related to create database like ALTER, > > GRANT..etc" > > Well I have to say I agree with Peter that the option name I came up > with is pretty confusing, not sure createdb-only is much better as it > also includes GRANTs etc. > > I think from a technical POV it's useful as it closes a gap between > pg_dumpall -g and pg_dump -Fc $DATABASE in my opinion, without having to > potentially schema-dump and filter out a large number of database > objects. > > Anybody else have some opinions on what to call this best? Maybe just a > short option and some explanatory text in --help along with it?
Maybe --database-globals or something like that? Other than the name (which might be influenced by this), shouldn't this functionality be in pg_restore as well? That is, if I make a pg_dump in custom format, I would want to be able to extract that information from the dump as well? -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/
