On Thu, Apr 8, 2021 at 7:24 PM Andrey Borodin <x4...@yandex-team.ru> wrote: > I agree that this version of eviction seems much more effective and less > intrusive than RR. And it's still LRU, which is important for subsystem that > is called SLRU. > shared->search_slotno is initialized implicitly with memset(). But this seems > like a common practice. > Also comment above "max_search = Min(shared->num_slots, > MAX_REPLACEMENT_SEARCH);" does not reflect changes. > > Besides this patch looks good to me.
Thanks! I chickened out of committing a buffer replacement algorithm patch written 11 hours before the feature freeze, but I also didn't really want to commit the GUC patch without that. Ahh, if only we'd latched onto the real problems here just a little sooner, but there is always PostgreSQL 15, I heard it's going to be amazing. Moved to next CF.
