On Fri, Apr 25, 2025 at 4:42 AM Amit Kapila wrote:
>
> On Fri, Apr 25, 2025 at 10:46 AM Masahiko Sawada
> wrote:
> >
> > What I'm concerned about is the back branches. With this approach all
> > back branches will have such degradations and it doesn&#x
cal path, this might not be a high-priority change.
> But if my understanding is correct, I'm a bit tempted to apply it as a
> refactoring.
I agree with these changes.
I think that while the changes for (2) should be for v19, the changes
for (1) might be treated as a bug fix?
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
eaprel = rel;
We should set pvs->indallsummarizing to indallsummarizing, not
nindexes, but ISTM we don't use pvs->indallsummazing anywhere in
vacuumparallel.c. Do we need to pass indallsummarizing to
parallel_vacuum_init() in the first place?
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Fri, Apr 25, 2025 at 3:43 AM Amit Kapila wrote:
>
> On Fri, Apr 25, 2025 at 6:02 AM Masahiko Sawada wrote:
> >
> > I realized that users who create a logical slot using
> > pg_create_logical_replication_slot() would not be able to enable both
> > options at slot
On Thu, Apr 24, 2025 at 9:56 PM Amit Kapila wrote:
>
> On Fri, Apr 25, 2025 at 8:14 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> > On Fri, Apr 25, 2025 at 5:44 AM Masahiko Sawada wrote:
> > > On Tue, Apr 22, 2025 at 12:06 AM Zhijie Hou (Fujitsu)
> > > wrote:
&
On Thu, Apr 24, 2025 at 10:48 AM Masahiko Sawada wrote:
>
> On Thu, Apr 24, 2025 at 2:24 AM Nisha Moond wrote:
> >
> > On Thu, Apr 24, 2025 at 12:28 PM Amit Kapila
> > wrote:
> > >
> > > On Wed, Apr 23, 2025 at 11:04 PM Masahiko Sawada
> > &g
transaction even during fast_forward
mode, which could lead to overheads. I think that 4% degradation is
something that we want to avoid.
Regards
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Thu, Apr 24, 2025 at 2:24 AM Nisha Moond wrote:
>
> On Thu, Apr 24, 2025 at 12:28 PM Amit Kapila wrote:
> >
> > On Wed, Apr 23, 2025 at 11:04 PM Masahiko Sawada
> > wrote:
> > >
> > > On Tue, Apr 22, 2025 at 3:00 AM Amit Kapila
> > > wro
On Thu, Apr 24, 2025 at 5:30 AM Amit Kapila wrote:
>
> On Wed, Apr 23, 2025 at 9:35 PM Masahiko Sawada wrote:
> >
> > On Wed, Apr 23, 2025 at 5:46 AM Amit Kapila wrote:
> > >
> > > BTW, did we consider the idea to automatically transition to 'logi
On Fri, Apr 4, 2025 at 1:38 AM Sutou Kouhei wrote:
>
> Hi,
>
> In
> "Re: Make COPY format extendable: Extract COPY TO format implementations"
> on Mon, 31 Mar 2025 12:35:23 -0700,
> Masahiko Sawada wrote:
>
> > Most of the queries under test_copy_fo
On Tue, Apr 22, 2025 at 3:00 AM Amit Kapila wrote:
>
> On Mon, Apr 21, 2025 at 8:44 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> > On Sat, Apr 19, 2025 at 2:19 AM Masahiko Sawada wrote:
> > >
> > > On Tue, Apr 8, 2025 at 10:
On Tue, Apr 22, 2025 at 11:31 PM Amit Kapila wrote:
>
> On Tue, Apr 22, 2025 at 10:57 PM Masahiko Sawada
> wrote:
> >
> > On Tue, Mar 18, 2025 at 2:55 AM Amit Kapila wrote:
> > >
> > > On Mon, Mar 17, 2025 at 4:56 PM Hayato Kuroda (Fujitsu)
> > &
On Wed, Apr 23, 2025 at 5:46 AM Amit Kapila wrote:
>
> On Mon, Apr 21, 2025 at 11:01 PM Masahiko Sawada
> wrote:
> >
> > I would like to discuss behavioral and user interface considerations.
> >
> > Upon further analysis of this patch regarding the conver
ed here, do you have any suggestions on
> this matter?
Sorry for the late response.
I agree with just 0001 for v13 as 0002 seems invasive. Given that v13
would have only a few releases until EOL and 0001 can deal with some
cases in question, I'd like to avoid such invasive changes in v13. It
would not be advisable to change the ReorderBufferChange format in
minor release even though it would not change the struct size.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Thu, Feb 20, 2025 at 10:05 AM Masahiko Sawada wrote:
>
> On Wed, Feb 19, 2025 at 1:56 AM Bertrand Drouvot
> wrote:
> >
> > Hi,
>
> Thank you for looking at the patches.
>
> >
> > On Mon, Feb 17, 2025 at 12:07:56PM -0800, Masahiko Sawada wrote:
>
hile the slot is created. But if I understand the problem correctly,
while the initial table sync is performing, the slot's two_phase is
still false, so we need to deal with the transactions that are
prepared during the initial table sync too. What do you think?
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Sun, Apr 6, 2025 at 7:19 PM Zhijie Hou (Fujitsu)
wrote:
>
> On Sat, Apr 5, 2025 at 1:45 AM Masahiko Sawada wrote:
>
> Hi,
>
> > Thank you for updating the patch! Pushed with small cosmetic changes.
>
> Thanks for pushing the feature !
>
> I noticed one typo in
On Sat, Apr 5, 2025 at 1:31 AM jian he wrote:
>
> On Sat, Apr 5, 2025 at 5:33 AM Masahiko Sawada wrote:
> >
> > On Fri, Apr 4, 2025 at 4:55 AM jian he wrote:
> > >
> > > On Tue, Mar 25, 2025 at 2:31 PM vignesh C wrote:
> > > >
> > &
On Mon, Apr 7, 2025 at 8:30 AM Melanie Plageman
wrote:
>
> On Fri, Apr 4, 2025 at 6:07 PM Masahiko Sawada wrote:
> >
> > I'm going to push this fix up to HEAD and v17 early next week, unless
> > there is no objection.
>
> I started studying this again looking b
On Sat, Apr 5, 2025 at 1:32 PM Andres Freund wrote:
>
> Hi,
>
> On 2025-04-04 14:34:53 -0700, Masahiko Sawada wrote:
> > On Fri, Apr 4, 2025 at 11:05 AM Melanie Plageman
> > wrote:
> > >
> > > On Tue, Apr 1, 2025 at 5:30 PM Masahiko Sawada
> > &g
COPY_SOURCE_XXX and COPY_DEST_XXX accordingly.
> (Same as 1. in your suggestion)
> 0002: Support custom format for both COPY TO and COPY FROM.
> (Same as 2. in your suggestion)
> 0003: Expose necessary helper functions such as CopySendEndOfRow()
> and add CopyFromSkipErrorRow().
> (3. + 4. in your suggestion)
> 0004: Define handler functions for built-in formats.
> (Not included in your suggestion)
> 0005: Documentation. (WIP)
> (Same as 5. in your suggestion)
Can we merge 0002 and 0004?
> We can merge 0001 quickly, right?
I don't think it makes sense to push only 0001 as it's a completely
preliminary patch for subsequent patches. It would be prudent to push
it once other patches are ready too.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Thu, Mar 27, 2025 at 10:31 PM Masahiko Sawada wrote:
>
> On Wed, Mar 26, 2025 at 12:32 PM Andrei Borodin wrote:
> >
> >
> >
> > 26.03.2025, 21:06, "Masahiko Sawada" :
> >
> > Agreed. I've done this in the attached patch.
> >
>
On Mon, Mar 31, 2025 at 3:46 PM Tom Lane wrote:
>
> Masahiko Sawada writes:
> > tzdata 2025b has been released on 3/22[1]. Do we need to update the
> > tzdata.zi file on HEAD and backbranches?
>
> Yup, eventually, but I don't normally worry about it until we are
On Thu, Mar 20, 2025 at 8:38 PM Amit Kapila wrote:
>
> On Thu, Mar 20, 2025 at 10:37 PM Masahiko Sawada
> wrote:
> >
> > On Wed, Mar 19, 2025 at 8:15 PM Amit Kapila wrote:
> > >
> > > On Wed, Mar 19, 2025 at 10:43 AM Masahiko Sawada
> > >
On Sat, Mar 29, 2025 at 1:57 AM Sutou Kouhei wrote:
>
> Hi,
>
> In
> "Re: Make COPY format extendable: Extract COPY TO format implementations"
> on Fri, 28 Mar 2025 22:37:03 -0700,
> Masahiko Sawada wrote:
>
> >> I've added the following tes
On Mon, Mar 31, 2025 at 3:29 PM Masahiko Sawada wrote:
>
> On Mon, Mar 31, 2025 at 3:12 PM Melanie Plageman
> wrote:
> >
> > On Mon, Mar 31, 2025 at 6:03 PM Masahiko Sawada
> > wrote:
> > >
> > > With commit c120550edb86, If we got the cleanup lo
rt that decision.
But I think it makes more sense that if we agree with "unqualified
internal format names ignore search_path" the original commit includes
that decision and describes it in the commit message. If we want to
change that design based on the discussion later on, we can
On Fri, Apr 4, 2025 at 11:05 AM Melanie Plageman
wrote:
>
> On Tue, Apr 1, 2025 at 5:30 PM Masahiko Sawada wrote:
> >
> >
> > I've attached the new version patch. There are no major changes; I
> > fixed some typos, improved the comment, and removed duplicate
---
+else
+ereport(ERROR,
+
errcode(ERRCODE_NOT_NULL_VIOLATION),
+errmsg("domain %s does
not allow null values", format_type_be(typioparams[m])),
+ errd
only be
> > +specified with --create-slot.
>
> Fixed. The description in usage() is adjusted based on this.
>
> > Also, the descriptions of pg_recvlogical options are written in
> > alphabetical order. Please put the description for --failover option
> > after -
On Wed, Apr 2, 2025 at 2:58 PM Masahiko Sawada wrote:
>
> On Tue, Mar 18, 2025 at 2:28 AM Shlok Kyal wrote:
> >
> > On Mon, 17 Mar 2025 at 22:57, Masahiko Sawada wrote:
> > >
> > > On Sun, Mar 9, 2025 at 11:16 PM Shlok Kyal
> > > wrote:
>
T_XINFO_HAS_INVALS flag. If yes, we probably should change only
xact_decode() to check the commit records even in BUILDING_SNAPSHOT.
Otherwise, we would need to change mostly all paths where we mark the
transaction as catalog-change as the patch does.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
ter -E/--endpos.
The rest looks good to me.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Wed, Apr 2, 2025 at 7:58 PM Amit Kapila wrote:
>
> On Thu, Apr 3, 2025 at 7:50 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> > On Thu, Apr 3, 2025 at 3:30 AM Masahiko Sawada wrote:
> >
> > >
> > > On Wed, Apr 2, 2025 at 6:33 AM Zhijie Hou (Fujitsu
On Tue, Mar 18, 2025 at 2:28 AM Shlok Kyal wrote:
>
> On Mon, 17 Mar 2025 at 22:57, Masahiko Sawada wrote:
> >
> > On Sun, Mar 9, 2025 at 11:16 PM Shlok Kyal wrote:
> > >
> > > On Fri, 28 Feb 2025 at 08:56, Amit Kapila wrote:
> > > >
> &g
On Wed, Apr 2, 2025 at 6:33 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Wed, Apr 2, 2025 at 3:45 PM Masahiko Sawada wrote:
>
> Hi,
>
> >
> > On Mon, Mar 31, 2025 at 4:3 AM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > On Thu, Mar 27, 2025 at 2:29 PM A
lsn which is greater than the prepared transaction.
> - stop the primary and promote the standby.
> - commit the prepared transaction on standby, the following error will be
> reported on subscriber:
It seems to require elaborate steps to reproduce this issue in v17. I
wonder if we could somehow narrow down the cases that we want to
prohibit. The patch for v17 disallows CREATE SUBSCRIPTION to enable
both two_phase and failover, but I guess that it's still safe if it
also creates the replication slot (e.g., create_slot is true). If my
understanding is right, we can allow users to specify both fields if
CRETE SUBSCRIPTION creates the slot, and we don't need to disallow
that in ReplicationSlotCreate().
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
Hi all,
tzdata 2025b has been released on 3/22[1]. Do we need to update the
tzdata.zi file on HEAD and backbranches?
Regards,
[1] https://data.iana.org/time-zones/tzdb/NEWS
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Mon, Mar 31, 2025 at 3:12 PM Melanie Plageman
wrote:
>
> On Mon, Mar 31, 2025 at 6:03 PM Masahiko Sawada wrote:
> >
> > With commit c120550edb86, If we got the cleanup lock on the page,
> > lazy_scan_prune() marks dead item IDs directly to LP_UNUSED. So the
I've attached a patch to fix it.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Fri, Mar 28, 2025 at 9:32 AM Peter Eisentraut wrote:
>
> On 28.03.25 17:14, Masahiko Sawada wrote:
> > On Fri, Mar 28, 2025 at 8:30 AM Peter Eisentraut
> > wrote:
> >>
> >> On 09.02.25 08:32, Peter Eisentraut wrote:
> >>> Checking the status
the same 'undefined reference to symbol
error' locally when building test_json_parser.
Regards,
[0]
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=snakefly&dt=2025-03-28%2015%3A29%3A04
[1]
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jackdaw&dt=2025-03-28%2015%3A30%3A44
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Wed, Mar 26, 2025 at 12:32 PM Andrei Borodin wrote:
>
>
>
> 26.03.2025, 21:06, "Masahiko Sawada" :
>
> Agreed. I've done this in the attached patch.
>
> Great! The patch looks good to me.
Thank you for reviewing it. I'm going to push the fix
On Wed, Mar 26, 2025 at 1:00 PM Melanie Plageman
wrote:
>
> On Mon, Mar 24, 2025 at 7:58 PM Masahiko Sawada wrote:
> >
> > You're right. I've studied the read stream code and figured out how to
> > use it. In the attached patch, we end the read stream at the
On Wed, Mar 26, 2025 at 6:00 AM Andrey Borodin wrote:
>
>
>
> > On 26 Mar 2025, at 08:32, Masahiko Sawada wrote:
> >
> > Please review it.
>
> The patch looks good to me except one nit.
> +WITH uuidts AS (
> + SELECT y, ts as ts, lag(ts) OVER (ORDER
On Thu, Mar 13, 2025 at 1:37 AM Steven Niu wrote:
>
>
>
> 在 2025/3/12 6:31, Masahiko Sawada 写道:
> > On Mon, Mar 10, 2025 at 3:08 AM Steven Niu wrote:
> >>
> >>
> >>
> >> Hi, Masahiko
> >>
> >> Thanks for your comments! I u
On Sun, Feb 9, 2025 at 9:07 AM Andrey Borodin wrote:
>
> I've took into account note from Sergey that "offset" is better name for
> uuidv7() argument than "shift".
>
> > On 5 Feb 2025, at 03:02, Masahiko Sawada wrote:
> >
> >&
he destination, extensions
should write the data to cstate->fe_msgbuf. We expose
CopyToStateFlush() but not for any functions to write data there such
as CopySendString(). It was a bit inconvenient to me but I managed to
write the data directly there by #include'ing copyto_internal.h.
Regards,
[1] https://github.com/MasahikoSawada/pg_copy_jsonlines
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Sun, Mar 23, 2025 at 10:13 AM Andres Freund wrote:
>
> Hi,
>
> On 2025-03-23 01:45:35 -0700, Masahiko Sawada wrote:
> > Another idea is that parallel workers don't exit phase 1 until it
> > consumes all pinned buffers in the queue, even if the memory usage of
&
On Sat, Mar 22, 2025 at 7:16 AM Melanie Plageman
wrote:
>
> On Thu, Mar 20, 2025 at 4:36 AM Masahiko Sawada wrote:
> >
> > When testing the multi passes of table vacuuming, I found an issue.
> > With the current patch, both leader and parallel workers process stop
> &
or custom format implementation */
+void *opaque; /* private space */
How about renaming 'private'?
---
I've not reviewed the documentation patch yet but I think the patch
seems to miss the updates to the description of the FORMAT option in
the COPY command section.
---
I think we can reorganize the patch set as follows:
1. Create copyto_internal.h and change COPY_XXX to COPY_SOURCE_XXX and
COPY_DEST_XXX accordingly.
2. Support custom format for both COPY TO and COPY FROM.
3. Expose necessary helper functions such as CopySendEndOfRow().
4. Add CopyFromSkipErrorRow().
5. Documentation.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Fri, Mar 21, 2025 at 5:32 PM David G. Johnston
wrote:
>
> On Tue, Mar 18, 2025 at 7:56 PM Sutou Kouhei wrote:
>>
>> Hi,
>>
>> In
>> "Re: Make COPY format extendable: Extract COPY TO format implementations"
>> on Mon, 17 Mar 2025 13:50:03
On Wed, Mar 19, 2025 at 8:15 PM Amit Kapila wrote:
>
> On Wed, Mar 19, 2025 at 10:43 AM Masahiko Sawada
> wrote:
> >
> > On Mon, Mar 17, 2025 at 6:05 PM Euler Taveira wrote:
> > >
> > > On Mon, Mar 17, 2025, at 8:44 PM, Masahiko Sawada wrote:
>
On Wed, Mar 19, 2025 at 2:58 AM Peter Eisentraut wrote:
>
> On 21.02.25 20:39, Masahiko Sawada wrote:
> >>>> I have one question about the 0001 patch; since we add
> >>>> 'default_char_signedness' field to ControlFileData do we need to bump
>
On Mon, Mar 17, 2025 at 7:06 PM David Rowley wrote:
>
> On Tue, 18 Mar 2025 at 05:49, Masahiko Sawada wrote:
> > I've attached the patch. I added the minimum regression tests for that.
>
> I think the change to vacuumlazy.c is ok. The new test you've added
> crea
On Mon, Mar 17, 2025 at 6:05 PM Euler Taveira wrote:
>
> On Mon, Mar 17, 2025, at 8:44 PM, Masahiko Sawada wrote:
>
> I would suggest putting the new max_active_replication_origins after
> max_parallel_apply_workers_per_subscription as both
> max_sync_workers_pe
On Mon, Mar 17, 2025 at 11:54 PM David Rowley wrote:
>
> On Tue, 18 Mar 2025 at 19:34, Masahiko Sawada wrote:
> > I've attached the updated patch.
>
> Looks good to me.
Thank you for reviewing the patch. Pushed (backpatched to v17).
Regards,
--
Masahiko Sawada
Ama
On Mon, Mar 17, 2025 at 8:02 PM Robert Haas wrote:
>
> On Mon, Mar 17, 2025 at 6:02 PM Masahiko Sawada wrote:
> > I've confirmed the issue and attached a patch to fix it.
>
> Cool. The commit message refers to 003_char_signedness, but the test
> name is 005, not 003.
T
would suggest putting the new max_active_replication_origins after
max_parallel_apply_workers_per_subscription as both
max_sync_workers_per_subscription and
max_parallel_apply_workers_per_subscription are related to
max_logical_replication_workers.
The rest looks good to me.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Mon, Mar 17, 2025 at 10:20 AM Robert Haas wrote:
>
> On Fri, Feb 21, 2025 at 1:20 PM Masahiko Sawada
> wrote:
> > pg_upgrade: Preserve default char signedness value from old cluster.
>
> Hi,
>
> I noticed that after running 'meson test --suite setup
On Tue, Mar 4, 2025 at 4:06 PM Sutou Kouhei wrote:
>
> Hi,
>
> In
> "Re: Make COPY format extendable: Extract COPY TO format implementations"
> on Mon, 3 Mar 2025 11:06:39 -0800,
> Masahiko Sawada wrote:
>
> > I agree with the fix and the patch looks
On Sun, Mar 9, 2025 at 11:16 PM Shlok Kyal wrote:
>
> On Fri, 28 Feb 2025 at 08:56, Amit Kapila wrote:
> >
> > On Fri, Feb 28, 2025 at 5:10 AM Masahiko Sawada
> > wrote:
> > >
> > > On Thu, Feb 27, 2025 at 12:52 AM Amit Kapila
> > > wrot
t;
> Is it an intentional for external projects? Or it can be removed like
> attached?
I think we can keep it as all RBTXN_xxx flags have the corresponding
macro and the comments of these macros somewhat help understand what
the flag indicates.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Mon, Mar 10, 2025 at 2:53 AM David Rowley wrote:
>
> On Mon, 10 Mar 2025 at 17:22, Masahiko Sawada wrote:
> > Regarding that patch, we need to note that the lpdead_items is a
> > counter that is not reset in the entire vacuum. Therefore, with
> > maintenance_work_mem
On Thu, Mar 13, 2025 at 6:20 PM Euler Taveira wrote:
>
> On Tue, Mar 11, 2025, at 7:34 PM, Masahiko Sawada wrote:
>
> Pushed.
>
>
> pgindent is saying this commit included some extra tabs.
>
> git diff
> diff --git a/contrib/pg_logicalinspect/pg_logicalinspect.c
On Sun, Mar 9, 2025 at 11:12 PM Amit Kapila wrote:
>
> On Wed, Mar 5, 2025 at 6:25 AM Masahiko Sawada wrote:
> >
> > On Mon, Mar 3, 2025 at 3:24 PM Masahiko Sawada
> > wrote:
> > >
> > >
> > > Another performance regression I can see in the
On Wed, Mar 12, 2025 at 3:05 AM Amit Kapila wrote:
>
> On Wed, Mar 12, 2025 at 3:12 AM Masahiko Sawada wrote:
> >
> > On Tue, Mar 11, 2025 at 6:00 AM Amit Kapila wrote:
> > >
> > > On Mon, Mar 10, 2025 at 11:57 PM Masahiko Sawada
> > > wrote:
&g
On Tue, Mar 11, 2025 at 4:26 PM Masahiko Sawada wrote:
>
> On Tue, Feb 11, 2025 at 9:36 PM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Dear Sawada-san,
> >
> > Thanks for updating the patch!
> >
> > > I've attached the updated patch. I addr
this
> change?
I'm also afraid of backpatching it so I guess it would be better to
push it to only HEAD. I think if users have encountered and we see
reported the issue we can consider backpatching again. If regression
tests on backbranches continue to fail intermittently, probably we can
consider adding waits as the patch Osumi-san proposed[1]?
Regards,
[1]
https://www.postgresql.org/message-id/TYCPR01MB83737A68CD5D554EA82BD7B9EDD39%40TYCPR01MB8373.jpnprd01.prod.outlook.com
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
lcome.
>
> I considered your idea that adding new API, but it seemed for me to have less
> benefit. Also, I do not know better place for the declaration now. Overall,
> the
> patch looks good to me.
>
I'm going to push the v2 patch, barring any objections and further comments.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
dclose().
Given that the patched codes doesn't do exactly the same things as
before (e.g, smgrdounlinkall() would end up resetting
reln->smgr_cached_nblocks[forknum] too), I think we need some reasons
for legitimating this change.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Fri, Mar 7, 2025 at 11:58 PM Bertrand Drouvot
wrote:
>
> Hi,
>
> On Fri, Mar 07, 2025 at 12:09:35PM -0800, Masahiko Sawada wrote:
> > Thank you for updating the patch. It looks mostly good to me. I've
> > made some cosmetic changes and attached the updated versi
On Tue, Mar 11, 2025 at 5:51 AM Amit Kapila wrote:
>
> On Tue, Mar 11, 2025 at 5:00 AM Masahiko Sawada wrote:
> >
> > On Sun, Mar 9, 2025 at 11:28 PM Amit Kapila wrote:
> > >
> > >
> > > Does phase 3 also use parallelism? If so, can we try to divi
On Tue, Mar 11, 2025 at 6:00 AM Amit Kapila wrote:
>
> On Mon, Mar 10, 2025 at 11:57 PM Masahiko Sawada
> wrote:
> >
> > On Sun, Mar 9, 2025 at 11:12 PM Amit Kapila wrote:
> > >
> > >
> > > > However, in the heap vacuum phase, the leader proc
On Mon, Mar 10, 2025 at 5:03 PM Melanie Plageman
wrote:
>
> On Sat, Mar 8, 2025 at 1:42 AM Masahiko Sawada wrote:
> >
> >
> > I've attached the updated version patches.
>
> I've started trying to review this and realized that, while I'm
> fam
On Mon, Mar 10, 2025 at 2:53 AM David Rowley wrote:
>
> On Mon, 10 Mar 2025 at 17:22, Masahiko Sawada wrote:
> > Regarding that patch, we need to note that the lpdead_items is a
> > counter that is not reset in the entire vacuum. Therefore, with
> > maintenance_work_mem
On Sun, Mar 9, 2025 at 11:28 PM Amit Kapila wrote:
>
> On Fri, Mar 7, 2025 at 11:06 PM Masahiko Sawada wrote:
> >
> > Discussing with Amit offlist, I've run another benchmark test where no
> > data is loaded on the shared buffer. In the previous test, I loaded
> &
acuum. Therefore, with
maintenance_work_mem = 64kB, once we collect at least one lpdead item,
we perform a cycle of index vacuuming and heap vacuuming for every
subsequent block even if they don't have a lpdead item. I think we
should use vacrel->dead_items_info->num_items instead.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
7;s unlikely that existing v17 users are using less than 1MB
maintenance_work_mem (the release note doesn't mention the fact that
we lowered the minimum value).
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
re, Tom also looked at it and
> agreed that we don't have much choice to avoid skipping non-existent
> publications [5]. But we never concluded as to whether skipping should
> be a default behavior or an optional one. So, we need more opinions on
> it.
I'm leaning toward making the skipping behavior a default as I could
not find a good benefit for the current behavior (i.e., stopping
logical replication due to missing publications).
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
guess it's ok not setting the InvalidBlockNumber?
> >
> > I did a quick seach of smgrdounlinkall usage, SMgrRelation seems
> > not needed after the calling of smgrdounlinkall.
> >
>
> After a second look, I realize I'm wrong, it's that the pointers to
> SMgrRelation
> are freed, not the SMgrRelation itself.
>
> So I agree with you that we would end up missing some operations with
> this patch.
Right. Also, I'm concerned that even if we could remove these
smgrclose() calls the benefit of removing these calls here would be
very small compared to the risk of changing the code.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
ent should match the comment in the fwd declaration of this function.
>
> ~~~
>
> 6.
> +/*
> + * Perform a parallel vacuums scan to collect dead items.
> + */
>
> 6a.
> "Perform" or "Execute"?
> The comment should match the one in the fwd declaration of this function.
>
> 6b.
> Typo "vacuums"
>
Thank you for reviewing the patch. I'll address these comments and
submit the updated version patches soon.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
> Kirill Reshke
> >>>
> >>>
> >>>
> >>> --
> >>> Regards
> >>> Junwang Zhao
>
> Hi!
> Looks like discussion on the subject is completed, and no open items
> left, so I will try to mark commitfest [1] entry as Ready For
> Committer.
>
I've looked at the patch and have some comments:
The patch removes smgrclose() calls following smgrdounlinkall(), for example:
--- a/src/backend/catalog/storage.c
+++ b/src/backend/catalog/storage.c
@@ -686,9 +686,6 @@ smgrDoPendingDeletes(bool isCommit)
{
smgrdounlinkall(srels, nrels, false);
- for (int i = 0; i < nrels; i++)
- smgrclose(srels[i]);
-
pfree(srels);
}
}
While smgrdounlinkall() close the relation at smgr level as follow:
/* Close the forks at smgr level */
for (forknum = 0; forknum <= MAX_FORKNUM; forknum++)
smgrsw[which].smgr_close(rels[i], forknum);
smgrrelease(), called by smgrclose(), also does the same thing but
does more things as follow:
void
smgrrelease(SMgrRelation reln)
{
for (ForkNumber forknum = 0; forknum <= MAX_FORKNUM; forknum++)
{
smgrsw[reln->smgr_which].smgr_close(reln, forknum);
reln->smgr_cached_nblocks[forknum] = InvalidBlockNumber;
}
reln->smgr_targblock = InvalidBlockNumber;
}
Therefore, if we move such smgrclose() calls, we would end up missing
some operations that are done in smgrrelease() but not in
smgrdounlinkall(), no?
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Fri, Mar 7, 2025 at 2:42 AM Bertrand Drouvot
wrote:
>
> Hi,
>
> On Fri, Mar 07, 2025 at 10:26:23AM +0530, Amit Kapila wrote:
> > On Fri, Mar 7, 2025 at 3:19 AM Masahiko Sawada
> > wrote:
> > >
> > > On Wed, Mar 5, 2025 at 4:05 AM Bertran
On Mon, Mar 3, 2025 at 3:24 PM Masahiko Sawada wrote:
>
> On Mon, Mar 3, 2025 at 1:28 AM Masahiko Sawada wrote:
> >
> > On Tue, Feb 25, 2025 at 4:49 PM Masahiko Sawada
> > wrote:
> > >
> > > On Tue, Feb 25, 2025 at 2:44 PM Melanie Plageman
> > &
a check
commit
In this test case, we would have at least one serialized snapshot that
has both cat-changes and committed txns. What do you think?
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
1]
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=tayra&dt=2025-03-05%2001%3A22%3A07
[2]
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=tayra&dt=2025-03-05%2013%3A42%3A17
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Tue, Mar 4, 2025 at 10:42 PM Amit Kapila wrote:
>
> On Wed, Mar 5, 2025 at 6:24 AM Euler Taveira wrote:
> >
> > On Sat, Mar 1, 2025, at 10:08 AM, Amit Kapila wrote:
> >
> > On Thu, Feb 13, 2025 at 6:48 AM Masahiko Sawada
> > wrote:
> > >
>
On Tue, Mar 4, 2025 at 1:56 PM Andres Freund wrote:
>
> Hi,
>
> On 2024-10-14 18:08:10 -0700, Masahiko Sawada wrote:
> > I fixed a compiler warning by -Wtypedef-redefinition related to the
> > declaration of SnapBuild struct, then pushed both patches.
>
> This
On Mon, Mar 3, 2025 at 3:24 PM Masahiko Sawada wrote:
>
>
> Another performance regression I can see in the results is that heap
> vacuum phase (phase III) got slower with the patch. It's weired to me
> since I don't touch the code of heap vacuum phase. I'm still
On Wed, Feb 26, 2025 at 3:12 AM Dagfinn Ilmari Mannsåker
wrote:
>
> Masahiko Sawada writes:
>
> > On Tue, Feb 25, 2025 at 3:03 PM Dagfinn Ilmari Mannsåker
> > wrote:
> >>
> >> Hi,
> >>
> >> While working on another round of the long op
On Fri, Feb 28, 2025 at 1:44 PM Andy Alsup wrote:
>
> Masahiko,
>
> I like the change you've made.
Pushed.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
On Mon, Mar 3, 2025 at 1:28 AM Masahiko Sawada wrote:
>
> On Tue, Feb 25, 2025 at 4:49 PM Masahiko Sawada wrote:
> >
> > On Tue, Feb 25, 2025 at 2:44 PM Melanie Plageman
> > wrote:
> > >
> > > On Tue, Feb 25, 2025 at 5:14 PM Masahiko Sawada
> >
ed patch set and
> >> found Sutou has already fixed this issue.
> >
> > +1, except I'd suggest declaring the parameters as
> > "const CopyFormatOptions *opts".
>
> Thanks for pointing out this (and sorry for missing this in
> our reviews...)!
>
>
On Fri, Feb 28, 2025 at 1:58 PM Sutou Kouhei wrote:
>
> Hi,
>
> In
> "Re: Make COPY format extendable: Extract COPY TO format implementations"
> on Fri, 28 Feb 2025 11:50:39 -0800,
> Masahiko Sawada wrote:
>
> > I initially thought it would be acce
On Thu, Feb 27, 2025 at 7:26 PM Amit Kapila wrote:
>
> On Fri, Feb 28, 2025 at 5:10 AM Masahiko Sawada wrote:
> >
> > On Thu, Feb 27, 2025 at 12:52 AM Amit Kapila
> > wrote:
> > >
> > > On Thu, Feb 27, 2025 at 10:47 AM Masahiko Sawada
> > &g
On Thu, Feb 27, 2025 at 7:57 PM Sutou Kouhei wrote:
>
> Hi,
>
> In
> "Re: Make COPY format extendable: Extract COPY TO format implementations"
> on Thu, 27 Feb 2025 15:24:26 -0800,
> Masahiko Sawada wrote:
>
> > Pushed the 0001 patch.
>
> Than
e
uuid in PostgreSQL.
I've attached the updated patch that incorporates the above change,
and updated the commit message too.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
0001-doc-Convert-UUID-functions-list-to-table-format.patch
Description: Binary data
On Thu, Feb 27, 2025 at 12:14 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Monday, February 24, 2025 5:50 PM Amit Kapila
> wrote:
> >
> > On Wed, Dec 11, 2024 at 12:37 PM Masahiko Sawada
> > wrote:
> > >
> > > I confirmed that the proposed patch fixes thes
On Thu, Feb 27, 2025 at 12:52 AM Amit Kapila wrote:
>
> On Thu, Feb 27, 2025 at 10:47 AM Masahiko Sawada
> wrote:
> >
> > On Tue, Feb 25, 2025 at 7:33 PM Amit Kapila wrote:
> > >
> > > AFAICU, InvalidateObsoleteReplicationSlots() is not serialized
1 - 100 of 1729 matches
Mail list logo
