On Thu, Apr 3, 2025 at 8:28 PM Hayato Kuroda (Fujitsu) <kuroda.hay...@fujitsu.com> wrote: > > Dear Sawada-san, > > > Thank you for updating the patch. Here are some minor comments: > > > > The <option>--two-phase</option> can be specified with > > <option>--create-slot</option> to enable decoding of prepared > > transactions. > > + Also, <option>--falover</option> can be specified with > > + <option>--create-slot</option> to create replication slot which can > > be > > + synchronized to the standby. > > > > How about rewording the whole sentence like: > > > > + The <option>--two-phase</option> and > > <option>--failover</option> options > > + can be specified with <option>--create-slot</option>. > > > > Explaining both options here seems redundant to me. > > Fixed. > > > --- > > + <para> > > + Allows created replication slot to be synchronized to the standbys. > > + This option may only be specified with > > <option>--create-slot</option>. > > + </para> > > > > How about slightly rewording to like: > > > > + Enables the slot to be synchronized to the standbys. This > > option may only be > > + specified with <option>--create-slot</option>. > > Fixed. The description in usage() is adjusted based on this. > > > Also, the descriptions of pg_recvlogical options are written in > > alphabetical order. Please put the description for --failover option > > after -E/--endpos. > > Right. I put because it had short-term '-o' in old version, but it was > removed. > Fixed.
Thank you for updating the patch! Pushed with small cosmetic changes. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
