On Tue, Feb 11, 2025 at 9:36 PM Hayato Kuroda (Fujitsu) <kuroda.hay...@fujitsu.com> wrote: > > Dear Sawada-san, > > Thanks for updating the patch! > > > I've attached the updated patch. I address all comments I got so far > > and added a small regression test. > > > > It makes sense to me that we move GetDbnameFromConnectionOptions() to > > recovery_gen.c since this function is currently used only with > > GenerateRecoveryConfig() which is defined in the same file. If we find > > a more appropriate place, we can move it later. Feedback is very > > welcome. > > I considered your idea that adding new API, but it seemed for me to have less > benefit. Also, I do not know better place for the declaration now. Overall, > the > patch looks good to me. >
I'm going to push the v2 patch, barring any objections and further comments. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
