ranslatable, at least into
Japanese. In addition, the file name should be quoted.
The attached patch modifies the message to use %s for XLOG_CONTROL_FILE,
making it properly translatable.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 793131e1a75821531f0aff61e0ef244229cb
ot;map.dat file"
explicitly.
I noticed that there are other messages in other files that refer to
file names without quotes as well, but I'm not addressing those here.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 9752e745322f7c8d2be68aa982546aaac8074f75 Mon Sep
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From a4aa43c6b4a0d069a0869853275931c8afcda299 Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi
Date: Mon, 7 Apr 2025 13:21:59 +0900
Subject: [PATCH] Fix verb agreement in count message
Correct a plural verb used by mistake.
---
src/bin/pg_dump/
h VS2022, and they
indeed use %lld.
Just wanted to share this in case it’s helpful.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
7;t think it's worth bothering with those in developer tools (0004).
Please find the attached patches.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 408e4b89f7457dba3f96732addea2ee03a09ae5f Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi
Date: Fri, 4 Apr 2025 11:3
If it’s
already clear enough, please feel free to disregard this.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 523d624f0b3efe94f58934a3c4508c4cc39735bd Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi
Date: Wed, 26 Mar 2025 11:58:37 +0900
Subject: [PATCH] Minor rewording
ty".
Therefore, I believe the newly introduced message should follow the
same wording for consistency.
Please find the attached patch that updates the inconsistent message.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 01db29ea295ec4541a870ed2dbbcd63184f03bef Mon Sep 17 00:00:00 2001
Hello,
The recent commit 1aab6805919 introduced a help description that was
split into two printf() commands, making it untranslatable.
The attached patch merges them into a single message.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>F
written
without "The value of" at the beginning. In addition, all existing
messages following the "%s must be set to" pattern omit this phrase.
Therefore, I believe the initial part of the new message should be
removed for consistency. The attached patch makes this adjustment.
ch makes the
message consistent with the typical wording.
While making this fix, I also noticed four other descriptions written
as "Enable xxx". The attached second patch corrects them for
consistency.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 3ae7a0dad80952567feea
versions 11 to 14, and the third
patch applies the same fix to version 15 and later, purely for
consistency with the first patch. These two patches are designed so
that the differences between the code after applying each of them
remain small.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software
A bit out of the blue, but I remembered the reason why I could make
that change I previously agreed seemed off. Just thought I’d let you
know.
At Tue, 05 Nov 2024 13:25:26 +0900 (JST), Kyotaro Horiguchi
wrote in
me> > the commit process to keep the window as small as possible, but if
Thank you for the quick comments.
At Thu, 31 Oct 2024 23:24:36 +0200, Heikki Linnakangas wrote
in
> On 31/10/2024 10:01, Kyotaro Horiguchi wrote:
> > After some delays, here’s the new version. In this update, UNDO logs
> > are WAL-logged and processed in memory under most con
live with two different code paths. But perhaps my gut feeling is
> just wrong reading your paragraph.
I believe this statement is valid, so I’m not in a hurry to do this.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Hello.
Thank you for the response.
At Sun, 1 Sep 2024 22:15:00 +0300, Heikki Linnakangas wrote
in
> On 31/08/2024 19:09, Kyotaro Horiguchi wrote:
> > - UNDO log(0002): This handles file deletion during transaction aborts,
> >which was previously managed, in part, by the com
At Wed, 4 Sep 2024 15:04:09 +0900, Michael Paquier wrote
in
> On Wed, Sep 04, 2024 at 02:15:43PM +0900, Kyotaro Horiguchi wrote:
> > The name "init_backend" makes it sound like the function initializes
> > the backend. backend_init might be a better choice, but I
At Wed, 4 Sep 2024 15:12:37 +0900, Michael Paquier wrote
in
> On Wed, Sep 04, 2024 at 05:28:56AM +, Bertrand Drouvot wrote:
> > On Wed, Sep 04, 2024 at 02:05:46PM +0900, Kyotaro Horiguchi wrote:
> >> The generalization sounds good to me, and hiding the private flags in
&
appears that enum RecoveryTargetAction was
inadvertently left behind in that commit.
Please find the attached patch, which addresses this oversight.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 4c938f473164d75761001b31fa85e5dc215fbd9a Mon Sep 17 00:00:00 2001
From: Kyot
whether they find the first
patch worthwhile. If it’s not considered worthwhile, then I believe
having postmaster include xlog_internal.h would be the best approach.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 22b71830ff601717d01dc66be95bafb930b1a0ea Mon Sep 17 00:00:00
use "the time" as the subject. For example,
would "The time this slot was inactivated" be acceptable? However,
this loses the sense of continuation up to that point, so if that's
crucial, the current proposal might be better.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
static backend state.
>
> I think the proposal makes sense and I can see the use cases too, so +1.
+1, too.
The name "init_backend" makes it sound like the function initializes
the backend. backend_init might be a better choice, but I'm not sure.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
ch could solve the issue without adding
complexity. What do you think?
regard.
--
Kyotaro Horiguchi
NTT Open Source Software Center
At Tue, 03 Sep 2024 15:37:49 +0900 (JST), Kyotaro Horiguchi
wrote in
> When I first looked at this patch, my initial thought was whether we
> should let these stats stay "fixed." The reason why the current
> PGSTAT_KIND_IO is fixed is that there is only one global statistic
he frequent creation and deletion of stats
entries caused by high turnover of backends.
Just to be clear, the above comments are not meant to oppose the
current implementation approach. They are purely for the sake of
discussing comparisons with other possible approaches.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
ails, and postmaster.c doesn't seem to
fit that category. If the macro is used more broadly, it might be
better to move it to a more public location. However, following the
current discussion, if we decide to keep the macro's name as it is, it
would make more sense to keep it in its current location.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Hello.
After a recent commit f80b09bac8, make update-po fails with "missing
required files". The commit moved some files to fe_utils but this
change was not reflected in pg_basebackup's nls.mk. The attached patch
fixes this issue.
regards.
--
Kyotaro Horiguchi
NTT Open Source
ld be able to return soon.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From ede9fecf6a042e87c5cf92ed34d6b1991646577b Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi
Date: Fri, 2 Aug 2024 11:33:52 +0900
Subject: [PATCH] Fix NLS file reference in pg_createsubscriber
pg_create
;XLogCtl->info_lck);
> RefreshXLogWriteResult(LogwrtResult);
> }
The code, which exists has existed for a long time, ensures that
GetInsertRecPtr() returns the accurate end of a record when it spanns
over page boundaries. This would need to be written in the new comment
if we use GetInsertRecPtr().
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
after extension preloading finishes?
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
f the patch the mentioned race condition
refers to). However, I imagine it is difficult to reliably reproduce
this condition. In that regard, in the latest patch, the coherence
between the inHeap flag and the pairing heap is protected by LWLock,
so I believe we no longer need that test.
regards.
> Links.
> 1.
> https://www.postgresql.org/message-id/flat/CAPpHfdvGRssjqwX1%2Bidm5Tu-eWsTcx6DthB2LhGqA1tZ29jJaw%40mail.gmail.com#557900e860457a9e24256c93a2ad4920
--
Kyotaro Horiguchi
NTT Open Source Software Center
Cygwin seems to have its own strtok_r, but I haven't
checked how that fact affects the build.
> [0]:
> https://www.postgresql.org/message-id/856e5ec3-879f-42ee-8258-8bcc6ec9b...@eisentraut.org
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
revised the comment on the modified section to
make its intention clearer.
> > I'll consider this direction for a while.
> >
>
> Okay, thanks.
The attached patch is it. It's only for the master.
I decided not to create a new function because the simple code has
o
At Tue, 11 Jun 2024 14:27:28 +0530, Amit Kapila wrote
in
> On Tue, Jun 11, 2024 at 12:34 PM Kyotaro Horiguchi
> wrote:
> >
> > At Tue, 11 Jun 2024 11:32:12 +0530, Amit Kapila
> > wrote in
> > > Sorry, it is not clear to me why we failed to flush the last
>
At Tue, 11 Jun 2024 09:27:20 +0900, Michael Paquier wrote
in
> On Thu, Jun 06, 2024 at 03:19:20PM +0900, Kyotaro Horiguchi wrote:
> > So, I believe the attached small patch fixes the behavior. I haven't
> > come up with a good test script for this i
t?
It seems that, it uses XLogBackgroundFlush(), which does not guarantee
flushing WAL until the end.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
s certainly strange that bufmgr is aware of
relation kinds, but introducing relfilenode stats to avoid this skew
doesn't seem to be the best way, as it invites inconclusive arguments
like the one raised above. The fact that we transfer counters from old
relfilenodes to new ones indicates that we are not really interested
in counts by relfilenode. If that's the case, wouldn't it be simpler
to call pgstat_count_relation_buffer_read() from bufmgr.c and then
branch according to relkind within that function? If you're concerned
about the additional branch, some ingenuity may be needed.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
効期限' = '
無限'") also sounds awkward. Maybe that's the same in English. I guess
that 'unbounded' or 'indefinite' sounds better, and their Japanese
translation '無期限' also sounds natural. However, I'm not sure we
want to go to that extent in transforming the table.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
At Thu, 06 Jun 2024 17:15:15 +0900 (JST), Kyotaro Horiguchi
wrote in
> At Thu, 06 Jun 2024 16:45:00 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > I have been thinking about this since then. At first, I thought it
> > referred to FindFirstChangeNotification() and frien
At Thu, 06 Jun 2024 16:45:00 +0900 (JST), Kyotaro Horiguchi
wrote in
> I have been thinking about this since then. At first, I thought it
> referred to FindFirstChangeNotification() and friends, and inotify on
> Linux. However, I haven't found a way to simplify the specified cod
rst, I thought it
referred to FindFirstChangeNotification() and friends, and inotify on
Linux. However, I haven't found a way to simplify the specified code
area using those APIs.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
out significant changes.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 99cad7bd53a94b4b90937fb1eb2f37f2ebcadf6a Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi
Date: Thu, 6 Jun 2024 14:56:53 +0900
Subject: [PATCH] Fix infinite loop in walsender during publisher shutdown
When a
ary and can be avoided by setting stats_fetch_consistency to
> none.
It seems to me that this description already implies such an
incongruity in the functions' behavior from the "stable" behavior, but
we might want to explicitly mention that incongruity.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
() unless
compiler actually issues a false warning for it.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
behavior by exiting in the middle of the loop. It seems
we didn't want to bother collecting errors for every failed file in
that part.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
OKEN_NUBMER cases. Even if this is not the case, the ownership
transition apperas quite callenging to follow.
It might be safer or clearer to pstrdup the token in jsonb_in_scalar()
and avoid NULLifying scalar_val after calling callbacks, or to let
jsonb_in_sclar() NULLify the pointer.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Rebased.
Along with rebasing, I changed the interface of XLogFsyncFile() to
return a boolean instead of an error message.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From bed74e638643d7491bbd86fe640c33db1e16f0e5 Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi
Date: Mon,
el" = "minimal" (but not use quotes for numeric values), as it
seems to be the most common practice. Anyway, we might want to unify
them.
Likewise, I saw two different versions of values with units.
> "max_stack_depth" must not exceed %ldkB.
> "vacuum_buffer_usa
ts.
+ errmsg("cannot change NO INHERIT status of NOT NULL constraint \"%s\" on
relation \"%s\"",
===
+ errmsg("cannot change NO INHERIT status of NOT NULL constraint \"%s\" in
relation \"%s\"",
I think we usually use on in this case.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
n a dsm segment, shmem_exit
should have detached the region for the CV. CV cleanup code should be
invoked via before_shmem_exit.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
At Tue, 9 Apr 2024 15:00:27 +0900, Michael Paquier wrote
in
> I've checked the whole tree, and the two you are pointing at are the
> only incorrect paths. So applied, thanks!
Thank you for cross-checking and committing!
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
At Mon, 08 Apr 2024 16:27:02 +0900 (JST), Kyotaro Horiguchi
wrote in
> Hello.
>
> I noticed that NLS doesn't work for pg_combinebackup. The cause is
> that the tool forgets to call set_pglocale_pgservice().
>
> This issue is fixed by the following chage.
&g
OMAIN("pg_combinebackup"));
handle_help_version_opts(argc, argv, progname, help);
memset(&opt, 0, sizeof(opt));
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
At Fri, 22 Mar 2024 11:44:08 +0900, Amit Langote
wrote in
> Thanks for the heads up.
>
> My bad, will push a fix shortly.
No problem. Thank you for the prompt correction.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
literal, not split into multiple parts, for better
grep'ability.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Thank you for looking this.
At Tue, 19 Mar 2024 10:50:23 +0100, Peter Eisentraut
wrote in
> On 15.03.24 08:20, Kyotaro Horiguchi wrote:
> > diff --git a/src/backend/access/transam/twophase.c
> > b/src/backend/access/transam/twophase.c
> > @@ -1369,8 +1369,8 @@ ReadTwoPh
information
to the primary messages. The objective of the precedent for the use of
relname_only was somewhat different, but this use also seems legit.
In short, I think the distribution between message types (primary and
context) is fine as it is in the latest patch.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
At Fri, 15 Mar 2024 16:20:27 +0900 (JST), Kyotaro Horiguchi
wrote in
> I checked for that kind of msgids in a bit more intensive way. The
> numbers are the line numbers in ja.po of backend. I didn't check the
> same for other modules.
>
> > ###: invalid timeline %
At Fri, 15 Mar 2024 16:01:28 +1300, David Rowley wrote
in
> On Fri, 15 Mar 2024 at 15:27, Kyotaro Horiguchi
> wrote:
> > I have considered only the two messages. Actually, buffile.c and md.c
> > are already like that. The attached aligns the messages in
> >
At Thu, 14 Mar 2024 11:23:38 +0530, Amit Kapila wrote
in
> On Thu, Mar 14, 2024 at 9:58 AM Kyotaro Horiguchi
> wrote:
> >
> > While examining reorderbuffer.c, I found several typos. I'm not sure
> > if fixing them is worthwhile, but I've attached a fix just
d only the two messages. Actually, buffile.c and md.c
are already like that. The attached aligns the messages in
pg_combinebackup.c and reconstruct.c with the precedents.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
diff --git a/src/bin/pg_combinebackup/pg_combinebackup.c b/src
Hello.
While examining reorderbuffer.c, I found several typos. I'm not sure
if fixing them is worthwhile, but I've attached a fix just in case.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/r
t read file \"%s\": read only %d of
%d bytes",
+ pg_fatal("could not read file \"%s\": read only %d of
%u bytes",
rf->filename, rb, length);
I'd be happy if the two messages kept consistency. I suggest aligning
types ins
At Mon, 11 Mar 2024 16:43:32 +0900 (JST), Kyotaro Horiguchi
wrote in
> Oh, I once saw the fix work, but seems not to be working after some
> point. The new issue was a corruption of received WAL records on the
> first standby, and it may be related to the setting.
I identified the cau
;re welcome, but I aplogize for the delay in the work..
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
and with the change above, I saw that the behavior was
fixed. However, for reasons unclear to me, it shows another issue, and
I am running out of time and need more caffeine. I'll continue
investigating this tomorrow.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
gt; track of it.
> >
> > Thanks for doing that, because the cfbot pointed out a problem:
> > I should have written pg_strncasecmp not strncasecmp. If this
> > version tests cleanly, I'll push it.
>
> +1, LGTM.
Thank you for fixing this, Tom!
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
At Fri, 01 Mar 2024 12:37:55 +0900 (JST), Kyotaro Horiguchi
wrote in
> Anyway, our current policy here is to avoid record-rereads beyond
> source switches. However, fixing this seems to require that source
> switches cause record rereads unless some additional information is
> avail
At Fri, 01 Mar 2024 12:04:31 +0900 (JST), Kyotaro Horiguchi
wrote in
> At Fri, 01 Mar 2024 10:29:12 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > After reading this, I came up with a possibility that walreceiver
> > recovers more quickly than the c
At Fri, 01 Mar 2024 10:29:12 +0900 (JST), Kyotaro Horiguchi
wrote in
> After reading this, I came up with a possibility that walreceiver
> recovers more quickly than the calling interval to
> WaitForWALtoBecomeAvailable(). If walreceiver disconnects after a call
> to the functio
At Fri, 1 Mar 2024 08:17:04 +0900, Michael Paquier wrote
in
> On Thu, Feb 29, 2024 at 05:44:25PM +0100, Alexander Kukushkin wrote:
> > On Thu, 29 Feb 2024 at 08:18, Kyotaro Horiguchi
> > wrote:
> >> In the first place, it's important to note that we do not guarant
daries, before we introduced
the XLP_FIRST_IS_OVERWRITE_CONTRECORD flag, which prevents overwriting
a WAL file that is already archived. However, in this case, the second
standby won't see the broken record because it cannot be in a
non-partial segment in the archive, and the new primary strea
Some of them, commit_timestamp_buffers, transaction_buffers,
subtransaction_buffers use 0 to mean auto-tuning based on
shared-buffer size. I think it's worth adding an extra_desc such as "0
to automatically determine this value based on the shared buffer
size".
regards.
--
Kyot
fore spreading more uses of CVs.
[1]
https://www.postgresql.org/message-id/20240227.150709.1766217736683815840.horikyota.ntt%40gmail.com
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
oth as logical publisher and physical
primary.
Regardless of this issue, I think we should provide separate waitlink
members for condition variables that can possibly be used
simultaneously.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
this.
Thanks for the explanation. I'm fine with that.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
At Thu, 22 Feb 2024 09:36:43 +0900 (JST), Kyotaro Horiguchi
wrote in
> Yes, I'm happy with all of the changes. The proposed patch appears to
> cover all instances related to slotsync.c, and it looks fine to
> me. Thanks!
I'd like to raise another potential issue outside t
it is a separate issue.
./logical.c 122:errmsg("logical decoding requires wal_level >=
logical")));
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
ation_slots(). If it is true,
couldn't we make the SQL function require a database name to make a
connection, instead of requiring it in physical-replication conninfo?
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
diff --git a/src/bin/pg_basebackup/streamutil.c
b/src/bin/pg_
ad already sent the mail.. No harm done:p
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
At Mon, 19 Feb 2024 10:31:33 +0530, Robert Haas wrote
in
> On Mon, Feb 19, 2024 at 10:10 AM Kyotaro Horiguchi
> wrote:
> > A recent commit (7a424ece48) added the following message:
> >
> > > could not sync slot information as remote slot precedes local slot:
> &g
have a separator between
"catalog xmin (%u)" and "local slot:", it is somewhat cluttered. Don't
we need something, for example a semicolon there to improve
readability and reduce clutter?
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
At Mon, 19 Feb 2024 11:56:22 +0900 (JST), Kyotaro Horiguchi
wrote in
> Yeah, perhaps I was overly concerned. The removed comment made me
> think that someone could add code relying on the incorrect assumption
> that the remaining bytes beyond the returned count are cleared out. On
&
At Fri, 16 Feb 2024 19:50:00 +0530, Bharath Rupireddy
wrote in
> On Fri, Feb 16, 2024 at 7:10 AM Kyotaro Horiguchi
> wrote:
> > 1. It's useless to copy the whole page regardless of the 'count'. It's
> > enough to copy only up to the 'count&
o be incorrect when reading WAL from WAL buffers
> using WALReadFromBuffers -
> https://www.postgresql.org/message-id/CALj2ACV=C1GZT9XQRm4iN1NV1T=hla_hsgwnx2y5-g+mswd...@mail.gmail.com.
>
> If we have no reason, can the WALRead() callers just read how much
> they want like walsender f
equires translation with minimal background
information. In this case, a translator needs to know which values
wal_level can take. It's relatively easy in this case, but I'm not
sure if this is always the case. Therefore, I would be slightly
happier if "logical" were double-quoted.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
At Wed, 14 Feb 2024 16:26:52 +0900 (JST), Kyotaro Horiguchi
wrote in
> > "wal_level" must be >= logical.
..
> > wal_level must be set to "replica" or "logical" at server start.
..
> I suggest making the quoting policy consistent.
Just aft
e already have the following message:
> wal_level must be set to "replica" or "logical" at server start.
This has the conflicting policy about quotation of variable names and
enum values.
I suggest making the quoting policy consistent.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
already exists.
> STATEMENT: CREATE USER u;
This seems to be another instance of a similar thinko.
I vaguely think that we should just regard the absence as a concurrent
drop and either adjust or remove the message, then fix the
comment. The situation is slightly different for the duplicatio
lessly until the first segment installation. That
being said, we could avoid it by initializing
last_known_installed_segno properly.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
e. Although I'm not sure we are actually
going to do whole-tuple replacement, the action name in this example
has the suffix '-column'.
COPY (on_error 'replace-colomn', replacement 'null') ..
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Sorry for a minor correction, but..
At Thu, 01 Feb 2024 14:53:57 +0900 (JST), Kyotaro Horiguchi
wrote in
> Ah.. Understood. "NaN or Infinity" cannot be used in those
> cases. Additionally, for jpiBoolean and jpiBigint, we lack the text
> representation of the value.
This
At Thu, 1 Feb 2024 09:22:22 +0530, Jeevan Chalke
wrote in
> On Thu, Feb 1, 2024 at 7:24 AM Kyotaro Horiguchi
> wrote:
>
> > At Thu, 01 Feb 2024 10:49:57 +0900 (JST), Kyotaro Horiguchi <
> > horikyota@gmail.com> wrote in
> > > By the way, while play
e into int2 using numeric_int[248]().
jsonb_float[48]() converts it into float4 using numeric_float[48]().
Given these facts, it seems more efficient for jbvNumber to retain the
original scalar value, converting it only when necessary. If needed,
we could also add a numeric struct member as a cache for better
performance. I'm not sure we refer the values more than once, though.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
At Thu, 01 Feb 2024 10:49:57 +0900 (JST), Kyotaro Horiguchi
wrote in
> By the way, while playing with this feature, I noticed the following
> error message:
>
> > select jsonb_path_query('1.1' , '$.boolean()');
> > ERROR: numeric argument of jsonpa
Thank you for the fix!
At Tue, 30 Jan 2024 13:46:17 +0530, Jeevan Chalke
wrote in
> On Mon, Jan 29, 2024 at 11:03 AM Tom Lane wrote:
>
> > Kyotaro Horiguchi writes:
> > > Having said that, I'm a bit concerned about the case where an overly
> > >
+ gcc 11.4
=> build failure regarding LTO
Given these issues, it seems there might be some issues with including
fat objects in the -devel package.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
re now, or whether it
would be better to introduce a variable that causes CFI to ignore
ProcDiePending, is a matter I think is open to discussion.
Attached patches are the rebased version of v3 (0003 is updated) and
additional 0005 that makes use of die() instead of walreceiver's
custom function.
re
At Sun, 28 Jan 2024 22:47:02 -0500, Tom Lane
wrote in
Kyotaro Horiguchi writes:
> They seem to be suggesting that PostgreSQL has the types
"decimal" and
> "number". I know of the former, but I don't think PostgreSQL has
the
> latter type. Perhaps the
t;%s"
> time_tz format is not recognized: "%s"
> timestamp format is not recognized: "%s"
> timestamp_tz format is not recognized: "%s"
I believe that the first line was intended to cover all the others:p
They are attached to this message separately.
r
n, like while we're holding a spinlock. Instead, the
And I think we should keep the considerations it suggests. The patch
removes the comment itself, but it does so because it implements our
standard process exit procedure, which incorporates points suggested
by the now-removed commen
1 - 100 of 1242 matches
Mail list logo
