Hello.
I found that a recent commit (fc069a3a631) introduced an inconsistent
description for a new GUC variable, enable_self_join_elimination. It
is written as "Enable removal of unique self-joins.", whereas similar
variables use "Enables xxx". The attached first patch makes the
message consistent with the typical wording.
While making this fix, I also noticed four other descriptions written
as "Enable xxx". The attached second patch corrects them for
consistency.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 3ae7a0dad80952567feea2fc650f1713ed71ceaf Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horikyota....@gmail.com>
Date: Tue, 18 Feb 2025 10:06:10 +0900
Subject: [PATCH 1/2] Make GUC descriptions consistent 1
A recent commit introduced a new variable
"enable_self_join_elimination", but its description is written as
"Enable removal of ...", whereas existing variables typically use
"Enables removal of ...". Adjust the description of the new variable
to match the style of existing ones.
---
src/backend/utils/misc/guc_tables.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c
index cce73314609..3b488b4a559 100644
--- a/src/backend/utils/misc/guc_tables.c
+++ b/src/backend/utils/misc/guc_tables.c
@@ -990,7 +990,7 @@ struct config_bool ConfigureNamesBool[] =
},
{
{"enable_self_join_elimination", PGC_USERSET, QUERY_TUNING_METHOD,
- gettext_noop("Enable removal of unique self-joins."),
+ gettext_noop("Enables removal of unique self-joins."),
NULL,
GUC_EXPLAIN | GUC_NOT_IN_SAMPLE
},
--
2.43.5
>From cf60efc5bec27f05cb73811ab1969cef6f2ea14c Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horikyota....@gmail.com>
Date: Tue, 18 Feb 2025 10:14:43 +0900
Subject: [PATCH 2/2] Make GUC descriptions consistent 2
A few existing GUC descriptions were using "Enable xxx" instead of the
more common "Enables xxx" style. Update these descriptions to maintain
consistency across all variables.
---
src/backend/utils/misc/guc_tables.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c
index 3b488b4a559..aac91a6e31f 100644
--- a/src/backend/utils/misc/guc_tables.c
+++ b/src/backend/utils/misc/guc_tables.c
@@ -1667,7 +1667,7 @@ struct config_bool ConfigureNamesBool[] =
},
{
{"row_security", PGC_USERSET, CLIENT_CONN_STATEMENT,
- gettext_noop("Enable row security."),
+ gettext_noop("Enables row security."),
gettext_noop("When enabled, row security will be applied to all users.")
},
&row_security,
@@ -1685,7 +1685,7 @@ struct config_bool ConfigureNamesBool[] =
},
{
{"array_nulls", PGC_USERSET, COMPAT_OPTIONS_PREVIOUS,
- gettext_noop("Enable input of NULL elements in arrays."),
+ gettext_noop("Enables input of NULL elements in arrays."),
gettext_noop("When turned on, unquoted NULL in an array input "
"value means a null value; "
"otherwise it is taken literally.")
@@ -1759,7 +1759,7 @@ struct config_bool ConfigureNamesBool[] =
{
{
"optimize_bounded_sort", PGC_USERSET, QUERY_TUNING_METHOD,
- gettext_noop("Enable bounded sorting using heap sort."),
+ gettext_noop("Enables bounded sorting using heap sort."),
NULL,
GUC_NOT_IN_SAMPLE | GUC_EXPLAIN
},
@@ -1836,7 +1836,7 @@ struct config_bool ConfigureNamesBool[] =
{
{"synchronize_seqscans", PGC_USERSET, COMPAT_OPTIONS_PREVIOUS,
- gettext_noop("Enable synchronized sequential scans."),
+ gettext_noop("Enables synchronized sequential scans."),
NULL
},
&synchronize_seqscans,
--
2.43.5
