>I think one more small change...
> A standby server can also be used for read-only queries, in which case
>- it is called a Hot Standby server. See for
>+ it is called a hot standby server. See for
> more information.
> A standby server can also be used for read-only queries, in w
On Tuesday, March 8, 2022 10:23 PM Amit Kapila wrote:
> On Tue, Mar 8, 2022 at 1:37 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > Kindly have a look at v30.
> >
>
> Review comments:
Thank you for checking !
> ===
> 1.
> + ereport(LOG,
> + errmsg("logical replication subscription
On Wednesday, March 9, 2022 9:58 AM Masahiko Sawada
wrote:
> On Tue, Mar 8, 2022 at 5:07 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > Kindly have a look at v30.
>
> Thank you for updating the patch. Here are some comments:
Hi, thank you for your review !
> + /*
> +* Allocate the orig
On Wednesday, March 9, 2022 1:29 PM Amit Kapila wrote:
> On Tue, Mar 8, 2022 at 6:53 PM Amit Kapila wrote:
> >
> > On Tue, Mar 8, 2022 at 1:37 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > Kindly have a look at v30.
> > >
> >
> > Review comments:
> > ===
Thank you for reviewi
On Wednesday, March 9, 2022 3:02 PM Amit Kapila wrote:
> On Wed, Mar 9, 2022 at 11:22 AM Masahiko Sawada
> wrote:
> >
> > On Wed, Mar 9, 2022 at 12:37 PM Amit Kapila
> wrote:
> > >
> > > On Wed, Mar 9, 2022 at 6:29 AM Masahiko Sawada
> wrote:
> > > >
> > > > ---
> > > > It might have already be
Hi,
On Tue, Mar 08, 2022 at 06:15:43PM +1300, Thomas Munro wrote:
> On Wed, Dec 29, 2021 at 5:29 PM Thomas Munro wrote:
> > https://github.com/macdice/postgres/tree/recovery-prefetch-ii
>
> Here's a rebase. This mostly involved moving hunks over to the new
> xlogrecovery.c file. One thing that
On Wed, Mar 9, 2022 at 11:26 AM wangw.f...@fujitsu.com
wrote:
>
> On Tue, Mar 8, 2022 at 3:52 PM Masahiko Sawada wrote:
> > I've looked at the patch and have a question:
> Thanks for your review and comments.
>
> > +void
> > +SendKeepaliveIfNecessary(LogicalDecodingContext *ctx, bool skipped) {
>
On Wed, Mar 9, 2022 at 11:22 AM Masahiko Sawada wrote:
>
> On Wed, Mar 9, 2022 at 12:37 PM Amit Kapila wrote:
> >
> > On Wed, Mar 9, 2022 at 6:29 AM Masahiko Sawada
> > wrote:
> > >
> > > ---
> > > It might have already been discussed but the worker disables the
> > > subscription on an error b
On Wed, Mar 9, 2022 at 12:37 PM Amit Kapila wrote:
>
> On Wed, Mar 9, 2022 at 6:29 AM Masahiko Sawada wrote:
> >
> > ---
> > It might have already been discussed but the worker disables the
> > subscription on an error but doesn't work for a fatal. Is that
> > expected or should we handle that to
On Tue, Mar 8, 2022 at 6:53 PM Amit Kapila wrote:
>
> On Tue, Mar 8, 2022 at 1:37 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > Kindly have a look at v30.
> >
>
> Review comments:
> ===
>
Few comments on test script:
===
1.
+# This tests the uniqueness violation
Dear Wang,
Thank you for updating!
> > Do we need adding a test for them? I think it can be added to 100_bugs.pl.
> > Actually I tried to send PoC, but it does not finish to implement that.
> > I'll send if it is done.
> I'm not sure if it is worth it.
> Because the reproduced test of this bug mi
On Wed, Mar 9, 2022 at 6:29 AM Masahiko Sawada wrote:
>
> ---
> It might have already been discussed but the worker disables the
> subscription on an error but doesn't work for a fatal. Is that
> expected or should we handle that too?
>
I am not too sure about handling FATALs with this feature be
On Tue, Mar 8, 2022 at 7:32 PM Andres Freund wrote:
> we need a descriptive term / shorthand that
> describes the type of statistics we currently send to the stats collector.
>
> "cumulative stats subsystem"?
>
>
I'm growing fond of "cumulative". It is more precise (and restrictive)
than "metric
On Wed, Mar 9, 2022 at 11:35 AM Imseih (AWS), Sami wrote:
>
> >Indeed.
>
> >It might have already been discussed but other than using a new shmem
> >hash for parallel vacuum, I wonder if we can allow workers to change
> >the leader’s progress information. It would break the assumpt
>Indeed.
>It might have already been discussed but other than using a new shmem
>hash for parallel vacuum, I wonder if we can allow workers to change
>the leader’s progress information. It would break the assumption that
>the backend status entry is modified by its own backend,
Hi,
On 2022-03-08 19:13:45 -0700, David G. Johnston wrote:
> On Tue, Mar 8, 2022 at 6:50 PM Andres Freund wrote:
>
> > On 2022-03-08 15:55:04 -0700, David G. Johnston wrote:
> > > On Tue, Mar 8, 2022 at 1:54 PM Andres Freund wrote:
> > > > One thing I'm not yet happy around the shared memory sta
On Tue, Mar 8, 2022 at 4:48 PM Kuroda, Hayato/黒田 隼人
wrote:
> Thank you for updating the patch! Good self-reviewing.
Thanks for your comments.
> > And I looked into the function WalSndUpdateProgress. I found function
> > WalSndUpdateProgress try to record the time of some message(by
> > function
On Tue, Mar 8, 2022 at 3:52 PM Masahiko Sawada wrote:
> I've looked at the patch and have a question:
Thanks for your review and comments.
> +void
> +SendKeepaliveIfNecessary(LogicalDecodingContext *ctx, bool skipped) {
> +static int skipped_changes_count = 0;
> +
> +/*
> +
On Tues, Mar 8, 2022 at 11:54 PM Ajin Cherian wrote:
> Some comments.
Thanks for your comments.
> 1. The comment on top of SendKeepaliveIfNecessary
>
> Try to send a keepalive message if too many changes was skipped.
>
> change to
>
> Try to send a keepalive message if too many changes wer s
On Tue, Mar 8, 2022 at 6:50 PM Andres Freund wrote:
> On 2022-03-08 15:55:04 -0700, David G. Johnston wrote:
> > On Tue, Mar 8, 2022 at 1:54 PM Andres Freund wrote:
> > > One thing I'm not yet happy around the shared memory stats patch is
> > > naming. Currently a lot of comments say things like
Hi,
On 2022-03-06 12:27:52 +0530, Bharath Rupireddy wrote:
> On Sun, Mar 6, 2022 at 1:57 AM Andres Freund wrote:
> >
> > Hi,
> >
> > On 2022-03-05 14:14:54 +0530, Bharath Rupireddy wrote:
> > > I understand. Even if we use the SyncRepWaitForLSN approach, the async
> > > walsenders will have to do
On Wed, Mar 9, 2022 at 12:41 AM Imseih (AWS), Sami wrote:
>
> ++/*
> ++ * vacuum_worker_init --- initialize this module's shared memory hash
> ++ * to track the progress of a vacuum worker
> ++ */
> ++void
> ++vacuum_worker_init(void)
> ++{
> ++ HASHCTL in
On 2022-03-08 15:55:04 -0700, David G. Johnston wrote:
> On Tue, Mar 8, 2022 at 1:54 PM Andres Freund wrote:
> > One thing I'm not yet happy around the shared memory stats patch is
> > naming. Currently a lot of comments say things like:
> >
> > * [...] We convert to
> > * microseconds in PgSt
At Tue, 8 Mar 2022 15:55:04 -0700, "David G. Johnston"
wrote in
> On Tue, Mar 8, 2022 at 1:54 PM Andres Freund wrote:
> > the immediate question for the patch is what to replace "collector" with.
> >
> >
> Not really following the broader context here so this came out of nowhere
> for me. What
On 03/08/22 17:12, Nathan Bossart wrote:
> I spent some time trying to come up with a workable script to replace the
> existing one. I think the main problem is that you need to write out both
> the backup label file and the tablespace map file, but I didn't find an
> easy way to write the differe
Hi,
> Replication never got the memo, so power consumption on an
> idle server is not very effective on standby or logical subscribers.
> The code and timing for hibernation is also different for each worker,
> which is confusing.
Agree, this patch makes it easier to understand the hibernation
be
On Tue, Mar 8, 2022 at 5:07 PM osumi.takami...@fujitsu.com
wrote:
>
> Kindly have a look at v30.
Thank you for updating the patch. Here are some comments:
+ /*
+* Allocate the origin name in long-lived context for error context
+* message.
+*/
+ ReplicationOriginNameForTablesync(
On Tue, Mar 8, 2022 at 7:56 PM Amit Kapila wrote:
>
> On Mon, Mar 7, 2022 at 10:06 AM Amit Kapila wrote:
> >
> > On Mon, Mar 7, 2022 at 6:36 AM Masahiko Sawada
> > wrote:
> > >
> > > Thank you for the comment. +1.
> > >
> > > I've attached updated patches.
> > >
> >
> > Pushed the first patch.
On Thu, 2022-01-13 at 14:51 +, Jelte Fennema wrote:
> Attached is an updated patch which I believe fixes windows and the other test
> failures.
> At least on my machine make check-world passes now when compiled with
> --enable-tap-tests
>
> I also included a second patch which adds some basi
On Mon, Mar 7, 2022 at 11:06 AM Daniel Westermann (DWE)
wrote:
>
> >>> Thanks for having a look. Are you suggesting to change it like this?
> >>> -Hot Standby is the term used to describe the ability to connect to
> >>> +Hot standby is the term used to describe the ability to connect to
>
On Tue, Mar 8, 2022 at 1:54 PM Andres Freund wrote:
>
> One thing I'm not yet happy around the shared memory stats patch is
> naming. Currently a lot of comments say things like:
>
> * [...] We convert to
> * microseconds in PgStat_Counter format when transmitting to the
> collector.
>
> or
>
On 3/7/22 22:11, Tomas Vondra wrote:
>
>
> On 3/7/22 17:39, Tomas Vondra wrote:
>>
>>
>> On 3/1/22 12:53, Amit Kapila wrote:
>>> On Mon, Feb 28, 2022 at 5:16 PM Amit Kapila wrote:
On Sat, Feb 12, 2022 at 6:04 AM Tomas Vondra
wrote:
>
> On 2/10/22 19:17, Tomas Vondra wrote
On Tue, Mar 08, 2022 at 03:09:50PM -0600, David Steele wrote:
> On 3/8/22 14:01, Nathan Bossart wrote:
>> On Wed, Mar 02, 2022 at 02:23:51PM -0500, Chapman Flack wrote:
>> > I did not notice this earlier (sorry), but there seems to remain in
>> > backup.sgml a programlisting example that shows a ps
On Thu, Mar 3, 2022 at 11:22 AM Dilip Kumar wrote:
> The new version of the patch fixes these 2 comments pointed by Ashutosh and
> also splits the GetRelListFromPage() function as suggested by Robert and uses
> the latest snapshot for scanning the pg_class instead of active snapshot as
> pointe
Hi,
On 2022-03-08 18:15:43 +1300, Thomas Munro wrote:
> I'm now starting to think about committing this soon.
+1
Are you thinking of committing both patches at once, or with a bit of
distance?
I think something in the regression tests ought to enable
recovery_prefetch. 027_stream_regress or 001
On 3/8/22 14:01, Nathan Bossart wrote:
On Wed, Mar 02, 2022 at 02:23:51PM -0500, Chapman Flack wrote:
I did not notice this earlier (sorry), but there seems to remain in
backup.sgml a programlisting example that shows a psql invocation
for pg_backup_start, then a tar command, then another psql i
Hi,
One thing I'm not yet happy around the shared memory stats patch is
naming. Currently a lot of comments say things like:
* [...] We convert to
* microseconds in PgStat_Counter format when transmitting to the collector.
or
# - Query and Index Statistics Collector -
or
/* --
*
Greetings,
* Jeff Davis (pg...@j-davis.com) wrote:
> On Wed, 2022-03-02 at 10:54 -0500, Stephen Frost wrote:
> > It's our decision what we want to support and maintain in the code
> > base
> > and what we don't.
>
> That might be an argument in favor of custom auth methods, because we
> could mov
Hi,
On 2022-03-08 10:42:31 -0800, Andres Freund wrote:
> > crake also failed. Looks like plpy_plpymodule.h needs to include
> > plpython.h. A
> > pre-existing issue that just didn't happen to cause problems...
>
> Fixed that.
Hm. Now crake failed in XversionUpgrade-REL9_2_STABLE-HEAD:
https://b
On Wed, Mar 02, 2022 at 02:23:51PM -0500, Chapman Flack wrote:
> I did not notice this earlier (sorry), but there seems to remain in
> backup.sgml a programlisting example that shows a psql invocation
> for pg_backup_start, then a tar command, then another psql invocation
> for pg_backup_stop.
>
>
Hi,
On 2022-03-08 13:49:15 -0500, Tom Lane wrote:
> Andres Freund writes:
> > A bit depressing to have a 500 line alternative output file for a one line
> > diff :(.
>
> Yeah. How badly do we need that particular test case?
A bit hard to tell. The test was introduced in
commit 2bd78eb8d51cc9ee
Hi,
I was looking at commit db632fbca and noticed that,
in create_list_bounds(), if index is added to boundinfo->interleaved_parts
in the first if statement, there is no need to perform the second check
involving call to partition_bound_accepts_nulls().
Here is a short patch.
Cheers
list-bound-
Hi,
On 2022-03-08 13:46:36 -0500, Tom Lane wrote:
> Andres Freund writes:
> > When running cpluspluscheck I get many many complaints like
> > /tmp/pg-test-repo/src/include/port/atomics/arch-x86.h:143:23: warning: ISO
> > C++17 does not allow ‘register’ storage class specifier [-Wregister]
>
> In
Andres Freund writes:
> A bit depressing to have a 500 line alternative output file for a one line
> diff :(.
Yeah. How badly do we need that particular test case?
regards, tom lane
Andres Freund writes:
> When running cpluspluscheck I get many many complaints like
> /tmp/pg-test-repo/src/include/port/atomics/arch-x86.h:143:23: warning: ISO
> C++17 does not allow ‘register’ storage class specifier [-Wregister]
Interesting, I don't see that here.
> It seems we should just r
Hi,
On 2022-03-07 20:59:16 -0800, Andres Freund wrote:
> On 2022-03-07 23:39:39 -0500, Tom Lane wrote:
> > Andres Freund writes:
> > wrasse says you were too quick to drop plpython_error_5.out.
>
> Does look like it. I'll try to find a distribution with an old python...
debian 8 did the trick.
Am 04.01.22 um 12:29 schrieb Gunnar "Nick" Bluth:
> Am 03.01.22 um 22:23 schrieb Alvaro Herrera:
>> Overall I think this is a good feature to have; assessing the need for
>> compression is important for tuning, so +1 for the goal of the patch.
>
> Much appreciated!
>
>
>> I didn't look into the
On 3/7/22 22:25, Tomas Vondra wrote:
>
>
> On 3/7/22 17:53, Tomas Vondra wrote:
>> On 2/28/22 12:46, Amit Kapila wrote:
>>> On Sat, Feb 12, 2022 at 6:04 AM Tomas Vondra
>>> wrote:
On 2/10/22 19:17, Tomas Vondra wrote:
> I've polished & pushed the first part adding sequence decod
Hi,
When running cpluspluscheck I get many many complaints like
In file included from /tmp/pg-test-repo/src/include/port/atomics.h:70,
from /tmp/pg-test-repo/src/include/utils/dsa.h:17,
from /tmp/pg-test-repo/src/include/nodes/tidbitmap.h:26,
fro
On Mon, Mar 7, 2022 at 5:51 PM Tom Lane wrote:
> Magnus Hagander writes:
> > But taking a step back, who is the actual audience for this? Do we
> > *need* a link pointing directly there, or is it enough to just point
> > to "use the docs on the web"? We can't link to the incorrect version,
> > bu
On 3/2/22 11:10, Dean Rasheed wrote:
For my part, I find myself more and more convinced that
"security_invoker" is the right name, because it matches the
terminology used for functions, and in other database systems. I think
the parallels between security invoker functions and security invoker
vi
ok got it. Thanks for your insights.
Regards,
Jeevan Ladhe
On Tue, 8 Mar 2022 at 22:23, Robert Haas wrote:
> On Tue, Mar 8, 2022 at 11:32 AM Jeevan Ladhe
> wrote:
> > I reviewed the patch, and it seems to be capturing and replacing all the
> > places of HAVE_LIB* with USE_* correctly.
> > Just
On Tue, Mar 8, 2022 at 11:32 AM Jeevan Ladhe wrote:
> I reviewed the patch, and it seems to be capturing and replacing all the
> places of HAVE_LIB* with USE_* correctly.
> Just curious, apart from consistency, do you see other problems as well
> when testing one vs the other?
So, the kind of pro
On Fri, Mar 4, 2022 at 12:37 AM Dilip Kumar wrote:
> In this version I have fixed both of these issues.
Here's a bit of review for these patches:
- The whole relnode vs. relfilenode thing is really confusing. I
realize that there is some precedent for calling the number that
pertains to the file
>
> OK, committed all that stuff.
>
Thanks for the commit Robert.
> I think we also need to fix one other thing. Right now, for LZ4
> support we test HAVE_LIBLZ4, but TOAST and XLOG compression are
> testing USE_LZ4, so I think we should be doing the same here. And
> similarly I think we should
Dong Wook Lee writes:
> [ 0001_add_test_pg_fsm.patch ]
I think having some coverage here would be great, but I'm concerned that
this patch doesn't look very portable. Aren't the numbers liable to
change on 32-bit machines, in particular?
regards, tom lane
On Mon, Feb 28, 2022 at 3:22 PM davinder singh
wrote:
>
> Hi,
>
> For Toast storage [1] in PostgreSQL, first, the attribute value is compressed
> and then divided into chunks. The problem with storing compressed value is,
> if we
> are not saving enough space such that it reduces the #chunks then
++/*
++ * vacuum_worker_init --- initialize this module's shared memory hash
++ * to track the progress of a vacuum worker
++ */
++void
++vacuum_worker_init(void)
++{
++ HASHCTL info;
++ longmax_table_size = GetMaxBackends();
++
++
On Tue, Mar 8, 2022 at 4:49 AM Jeevan Ladhe wrote:
> I agree with your patch. The patch looks good to me.
> Yes, the LZ4 flush check should also be fixed. Please find the attached
> patch to fix the LZ4 code.
OK, committed all that stuff.
I think we also need to fix one other thing. Right now, f
> > > > > As mentioned upthread, there can be multiple backends that request a
> > > > > checkpoint, so unless we want to store an array of pid we should
> > > > > store a number
> > > > > of backend that are waiting for a new checkpoint.
> >
> > It's a good metric to show in the view but the info
> > [local]:5432 ashu@postgres=# select * from pg_stat_progress_checkpoint;
> > -[ RECORD 1 ]-+-
> > pid | 22043
> > type | checkpoint
> > kind | immediate force wait requested time
> >
> > I think the output in the kin
> > 11) Can you be specific what are those "some operations" that forced a
> > checkpoint? May be like, basebackup, createdb or something?
> > + The checkpoint is started because some operation forced a
> > checkpoint.
> >
> I will take care in the next patch.
I feel mentioning/listing the
That's right, so I attached the correct file again.
2022년 3월 8일 (화) 오후 11:45, Justin Pryzby 님이 작성:
> On Tue, Mar 08, 2022 at 11:39:08PM +0900, Dong Wook Lee wrote:
> > Hi,
> > I just added some tests for the pg_freespacemap extension because the
> test
> > coverage was 0 percent.
> > But I don't
On Mon, Mar 7, 2022 at 9:57 PM vignesh C wrote:
>
> On Mon, Mar 7, 2022 at 5:51 PM Amit Kapila wrote:
> >
> > On Mon, Mar 7, 2022 at 5:01 PM Ashutosh Bapat
> > wrote:
> > >
> > > Hi Vignesh,
> > > I agree with Peter's comment that the changes to
> > > FilterRemoteOriginData() should be part of F
On Tue, Mar 08, 2022 at 11:39:08PM +0900, Dong Wook Lee wrote:
> Hi,
> I just added some tests for the pg_freespacemap extension because the test
> coverage was 0 percent.
> But I don't know if I did it correctly.
The patch only touches doc/*.sgml.
I suppose you forgot to use "git add".
--
Justi
I'm sorry for attaching the wrong patch file.
2022년 3월 8일 (화) 오후 11:39, Dong Wook Lee 님이 작성:
> Hi,
> I just added some tests for the pg_freespacemap extension because the test
> coverage was 0 percent.
> But I don't know if I did it correctly.
>
> ---
> Regards
> Lee Dong Wook
>
0001_add_test_p
Hi,
I just added some tests for the pg_freespacemap extension because the test
coverage was 0 percent.
But I don't know if I did it correctly.
---
Regards
Lee Dong Wook
0001_add_link_fsm.patch
Description: Binary data
On Mon, Mar 7, 2022 at 2:28 PM Peter Smith wrote:
>
> Hi Vignesh,
>
> Here are some review comments for patch v2.
>
> ==
>
> 1. Question about syntax
>
> I already posted some questions about why the syntax is on the CREATE
> SUBSCRCRIBER side.
> IMO "local_only" is a publisher option, so it s
On 3/8/22 06:15, Thomas Munro wrote:
> On Wed, Dec 29, 2021 at 5:29 PM Thomas Munro wrote:
>> https://github.com/macdice/postgres/tree/recovery-prefetch-ii
>
> Here's a rebase. This mostly involved moving hunks over to the new
> xlogrecovery.c file. One thing that seemed a little strange to
On Tue, Mar 8, 2022 at 1:37 PM osumi.takami...@fujitsu.com
wrote:
>
> Kindly have a look at v30.
>
Review comments:
===
1.
+ ereport(LOG,
+ errmsg("logical replication subscription \"%s\" has been be disabled
due to an error",
Typo.
/been be/been
2. Is there a reason the patch doesn
Stephen Frost wrote:
> * Antonin Houska (a...@cybertec.at) wrote:
> > Here I'm starting a new thread to discuss a topic that's related to the
> > Transparent Data Encryption (TDE), but could be useful even without that.
> > The
> > problem has been addressed somehow in the Cybertec TDE fork, an
On Mon, Mar 7, 2022 at 10:06 AM Amit Kapila wrote:
>
> On Mon, Mar 7, 2022 at 6:36 AM Masahiko Sawada wrote:
> >
> > Thank you for the comment. +1.
> >
> > I've attached updated patches.
> >
>
> Pushed the first patch. Fixed one typo in the second patch and
> slightly changed the commit message,
Hi Robert,
My proposed changes are largely cosmetic, but one thing that isn't is
> revising the size - pos <= bound tests to instead check size - pos <
> bound. My reasoning for that change is: if the number of bytes
> remaining in the buffer is exactly equal to the maximum number we can
> write,
Dear Wang,
Thank you for updating the patch! Good self-reviewing.
> And I looked into the function WalSndUpdateProgress. I found function
> WalSndUpdateProgress try to record the time of some message(by function
> LagTrackerWrite) sent to subscriber, such as in function pgoutput_commit_txn.
Yeah
On Tuesday, March 8, 2022 1:07 PM Peter Smith wrote:
> Please find below some review comments for v29.
Thank you for your comments !
> ==
>
> 1. src/backend/replication/logical/worker.c - worker_post_error_processing
>
> +/*
> + * Abort and cleanup the current transaction, then do post-e
On Tuesday, March 8, 2022 2:52 PM Amit Kapila wrote:
> On Tue, Mar 8, 2022 at 9:37 AM Peter Smith wrote:
> >
> > Please find below some review comments for v29.
> >
> > ==
> >
> > 1. src/backend/replication/logical/worker.c -
> > worker_post_error_processing
> >
> > +/*
> > + * Abort and clea
76 matches
Mail list logo
