On Tue, Mar 8, 2022 at 11:32 AM Jeevan Ladhe <jeevanladhe...@gmail.com> wrote: > I reviewed the patch, and it seems to be capturing and replacing all the > places of HAVE_LIB* with USE_* correctly. > Just curious, apart from consistency, do you see other problems as well > when testing one vs the other?
So, the kind of problem you would worry about in a case like this is: suppose that configure detects LIBLZ4, but the user specifies --without-lz4. Then maybe there is some way for HAVE_LIBLZ4 to be true, while USE_LIBLZ4 is false, and therefore we should not be compiling code that uses LZ4 but do anyway. As configure.ac is currently coded, I think that's impossible, because we only search for liblz4 if the user says --with-lz4, and if they do that, then USE_LZ4 will be set. Therefore, I don't think there is a live problem here, just an inconsistency. Probably still best to clean it up before an angry Andres chases me down, since I know he's working on the build system... -- Robert Haas EDB: http://www.enterprisedb.com
