On Tues, Mar 8, 2022 at 11:54 PM Ajin Cherian <itsa...@gmail.com> wrote: > Some comments. Thanks for your comments.
> 1. The comment on top of SendKeepaliveIfNecessary > > Try to send a keepalive message if too many changes was skipped. > > change to > > Try to send a keepalive message if too many changes wer skipped. Fixed. Change 'was' to 'were'. > 2. In pgoutput_change: > > + /* Reset the counter for skipped changes. */ > + SendKeepaliveIfNecessary(ctx, false); > + > > This reset is called too early, this function might go on to skip > changes because of the row filter, so this > reset fits better once we know for sure that a change is sent out. You > will also need to send keep alive > when the change is skipped due to the row filter. Fixed. Add a flag 'is_send' to record whether the change is sent, then reset the counter or try to send a keepalive message based on the flag 'is_send'. Attach the new patch. 1. Fix typo in comment on top of SendKeepaliveIfNecessary.[suggestion by Ajin.] 2. Add handling of cases filtered out by row filter.[suggestion by Ajin.] Regards, Wang wei
v2-0001-Fix-the-timeout-of-subscriber-in-long-transaction.patch
Description: v2-0001-Fix-the-timeout-of-subscriber-in-long-transaction.patch
