Re: [PATCH] uqmi: fix network registration loop

2021-04-21 Thread Florian Eckert
On 2021-04-20 08:20, Florian Eckert wrote: On 2021-04-19 19:46, thomas.rich...@kontron.com wrote: From: Thomas Richard Instrumenting qmi.sh script with following patch, some errors are visible. --- a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh +++ b/package/network/utils

Re: [PATCH v2] uqmi: fix network registration loop

2021-04-21 Thread Florian Eckert
(9213): + sleep 1 netifd: wan (9213): + uqmi -s -d /dev/cdc-wdm0 --get-serving-system netifd: wan (9213): + grep '"searching"' netifd: wan (9213): + uqmi -s -d /dev/cdc-wdm0 --get-serving-system netifd: wan (9213): + registration='{"regist

Re: [PATCH] package: openssl: Enable built engines per default

2021-04-22 Thread Florian Eckert
Hello Daniel, Hello Eneas, On 2021-04-23 01:36, Eneas U de Queiroz wrote: On Thu, Apr 22, 2021 at 3:55 AM Daniel Danzberger wrote: Automatically enable an engine in the openssl.cnf if it has been build. Before this change, /etc/openssl.cnf had to be edited manually on the system to enable t

Re: [PATCH] package: openssl: Enable built engines per default

2021-04-26 Thread Florian Eckert
Hello Eneas How about if we create a uci default script and check on the running system what is installed? And then we could generate a file and add or remove an include line form the openssl.cnf [1]? Hi Florian, Daniel I think we can manage something like that. The .include option can loa

Re: [PATCH 3/3] openssl: configure engines with uci

2021-04-28 Thread Florian Eckert
Hello Eneas, Nice work. My remarks or suggestions see inline. define Package/libopenssl-conf/conffiles /etc/ssl/openssl.cnf -/etc/ssl/engines.cnf.d/engines.cnf $(if CONFIG_OPENSSL_ENGINE_BUILTIN_DEVCRYPTO,/etc/ssl/engines.cnf.d/devcrypto.cnf) $(if CONFIG_OPENSSL_ENGINE_BUILTIN_PADLOCK,/et

Re: [PATCH 0/3] Engine configuration series

2021-04-28 Thread Florian Eckert
Hello Eneas, On 2021-04-28 14:17, Eneas U de Queiroz wrote: This series builds upon what was first started by Daniel Danzberger, with some suggestions by Florian Eckert to enable the engines when they are installed. The series split is subject to discussion: - the first commit does a patch

Re: [PATCH v2] uqmi: fix network registration loop

2021-05-09 Thread Florian Eckert
On 2021-05-08 12:33, Baptiste Jonglez wrote: Applied, thanks. Does this need to be backported to 21.02 or even 19.07? yes that would not be bad at least for openwrt-21.02 On openwrt-19.07 there are additional commits needed. Thanks for take care Baptiste On 20-04-21, thomas.rich...@kon

grub2-editenv: does depend since recently on liblzma

2021-05-20 Thread Florian Eckert
Hello Dirk, I have build a fresh master branch recently, Since your last change [1] on grub2, I have now a new dependency on liblzma for the install package grub2-editenv. root@st-dev-07 /usr/lib # ldd /root/grub-editenv /lib/ld-musl-x86_64.so.1 (0x7f684b088000) liblzma.so.5 =>

[PATCH] target/x86: add grub2-bios-setup to DEFAULT_PACKAGES

2021-08-11 Thread Florian Eckert
. Signed-off-by: Florian Eckert --- target/linux/x86/Makefile | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/linux/x86/Makefile b/target/linux/x86/Makefile index 0ab322d8bc..b1891de0ce 100644 --- a/target/linux/x86/Makefile +++ b/target/linux/x86/Makefile @@ -17,7

[PATCH 1/4] target/imagebuilder: add depends target to show all package that gets installed

2021-08-19 Thread Florian Eckert
This commits adds the makefile targets `package_depends` this wrapper is a call to `opkg depends`. This command shows what install dependencies exist when the package is installed into the image Signed-off-by: Florian Eckert --- target/imagebuilder/files/Makefile | 18 +- 1 file

[PATCH 3/4] target/imagebuilder: update help text for manifest target

2021-08-19 Thread Florian Eckert
Add missing help text for manifest makefile target in the quick overview help output. Also unify the help text for the manifest makefile target, so that it looks uniform like the other help texts. Signed-off-by: Florian Eckert --- target/imagebuilder/files/Makefile | 3 ++- 1 file changed, 2

[PATCH 4/4] target/imagebuilder: add help text and rename whatdepends to package_whatdepens

2021-08-19 Thread Florian Eckert
Add the missing help text for the package_whatdepends makefile target. Signed-off-by: Florian Eckert --- target/imagebuilder/files/Makefile | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/target/imagebuilder/files/Makefile b/target/imagebuilder/files/Makefile

[PATCH 2/4] target/imagebuilder: change help text for image build

2021-08-19 Thread Florian Eckert
Unify the help text for the image makefile target. That it looks unifrom as with the otheer help texts. Signed-off-by: Florian Eckert --- target/imagebuilder/files/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/imagebuilder/files/Makefile b/target

[PATCH] kernel/modules: prevent bonding driver to create default bond0 interface

2021-09-08 Thread Florian Eckert
this module, because they are not used anyway. Signed-off-by: Florian Eckert --- package/kernel/linux/modules/netsupport.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/package/kernel/linux/modules/netsupport.mk b/package/kernel/linux/modules/netsupport.mk index 62d79db51e..166172dbf3 100644 -

[PATCH] base-files: make os-release symbolic link absolute

2021-09-08 Thread Florian Eckert
s-release`. Signed-off-by: Florian Eckert --- package/base-files/files/etc/os-release | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/base-files/files/etc/os-release b/package/base-files/files/etc/os-release index c4c75b419c..d98fc7a7ac 12 --- a/package/base-files/fil

Re: [PATCH] base-files: make os-release symbolic link absolute

2021-09-09 Thread Florian Eckert
* resolv.conf -> /tmp/resolv.conf * /tmp/TZmtab -> /proc/mounts For consistency, this should also apply to `/usr/lib/os-release`. Is there any other reason than consistency to change this? Yes, I have to elaborate on that. I have a small script that boots the system into a called it "sandbox"

uci: unnecessary write accesses

2021-09-21 Thread Florian Eckert
I have written a small shell script, to track write access to the '/etc/config' directory. For this task I am using the inotify-tool package [1]. I am using the inotifywait tool to add the watchers [2] with a small shell script and log them to the syslog. If I change a 'uci' option with the

Re: uci: unnecessary write accesses

2021-09-21 Thread Florian Eckert
Thanks for your feedback I have written a small shell script, to track write access to the '/etc/config' directory. For this task I am using the inotify-tool package [1]. I am using the inotifywait tool to add the watchers [2] with a small shell script and log them to the syslog. If I change a

initramfs for ACPI tables on x86

2021-09-30 Thread Florian Eckert
Since the update of kernel from 5.4 to 5.10 in the openwrt master branch [1], I have problems with additional hardware on the I2C (SMBus) of my APU3. The Linux upstream removed the platform data support for my I2C IO-Expander mcp23s08 [3]. Because of this change I could not use my own written p

[PATCH] buildsystem: add CONFIG_SECCOMP

2021-10-13 Thread Florian Eckert
build. Signed-off-by: Florian Eckert --- config/Config-build.in| 11 +++ include/target.mk | 2 +- package/system/procd/Makefile | 3 +-- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/config/Config-build.in b/config/Config-build.in index f0e1aaa695

[PATCH v2] buildsystem: add CONFIG_SECCOMP

2021-10-15 Thread Florian Eckert
KERNEL_SECCOMP is enabled for this build. Signed-off-by: Florian Eckert --- v2: Enable CONFIG_SECCOMP by default config/Config-build.in| 12 include/target.mk | 2 +- package/system/procd/Makefile | 3 +-- 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a

Re: RFC: toolchain for building eBPF modules within the OpenWrt build system

2021-10-18 Thread Florian Eckert
I'd suggest to require a preinstalled host toolchain for the time being. How about requiring a preinstalled host toolchain by default, but building it from source on buildbot? I wouldn't make it dependent on whether openwrt compiles on the buildbot or not. I am not using this build option

[PATCH] vti: squash vtiv4 and vtiv6 packages into vti

2021-10-27 Thread Florian Eckert
This change adds the same package behaviour as gre package. Signed-off-by: Florian Eckert --- package/network/config/vti/Makefile | 43 + 1 file changed, 7 insertions(+), 36 deletions(-) diff --git a/package/network/config/vti/Makefile b/package/network/config/vti

[PATCH procd 1/1] system: add diskfree infos to ubus

2021-11-17 Thread Florian Eckert
This change adds the missing information about how much space is available on the root directory and in the temp directory. I took this implementation from the luci2 repository and adapted it for the procd service. Signed-off-by: Florian Eckert --- system.c | 30

[PATCH] firewall3: fix locking issue

2021-11-19 Thread Florian Eckert
for fw3. Signed-off-by: Florian Eckert --- utils.c | 1 - 1 file changed, 1 deletion(-) diff --git a/utils.c b/utils.c index 17d5bf9..92e966c 100644 --- a/utils.c +++ b/utils.c @@ -397,7 +397,6 @@ fw3_unlock_path(int *fd, const char *lockpath) warn("Cannot release exclusive

Re: [PATCH] firewall3: fix locking issue

2021-11-24 Thread Florian Eckert
Hello I found an interesting article about this topic on stackoverflow. https://stackoverflow.com/questions/17708885/flock-removing-locked-file-without-race-condition Beset regards Florian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.or

Re: [PATCH 0/1] build: scripts/config - update to kconfig-v5.14

2021-11-25 Thread Florian Eckert
Hello Eneas, On 2021-11-24 22:25, Eneas U de Queiroz wrote: I'm updating the Kconfig programs in scripts/config, from Linux 5.6 to 5.14. The changes are not crytical to openwrt, but regular updates ease the transition to an eventual newer version with more desirable features. I've been looki

[PATCH] netifd: system-linux: add dev_type info for ubus network.device status

2021-12-06 Thread Florian Eckert
ype": "ETHER", ... } Signed-off-by: Florian Eckert --- system-linux.c | 21 + system.h | 36 2 files changed, 57 insertions(+) diff --git a/system-linux.c b/system-linux.c index e768853..4ac34cc 100644 --- a/syste

[PATCH v2] netifd: system-linux: add dev_type info for ubus network.device status

2021-12-06 Thread Florian Eckert
ype": "ETHER", ... } Signed-off-by: Florian Eckert --- v2: remove debug log output system-linux.c | 20 system.h | 36 2 files changed, 56 insertions(+) diff --git a/system-linux.c b/system-linux.c index e768853

Re: [PATCH] netifd: system-linux: add dev_type info for ubus network.device status

2021-12-07 Thread Florian Eckert
Hello Jo imho these types are not that useful in practice (e.g. tap devices etc. are all reported as "ethernet". Maybe expose /sys/class/net/$devname/uevent DEVTYP= instead. I have now taken a look at your suggestion. Unfortunately, I found that not all network interfaces have set the DEVTYP

[PATCH v3] netifd: add devtype to ubus call

2021-12-09 Thread Florian Eckert
all network.device status Output: { "eth0": { "devtype": "ethernet", Signed-off-by: Florian Eckert --- v2: - Remove debug log output v3: - Use the information mainly from file 'uevnet'. - If 'uevent' does not provide the informa

CPU_TYPE "xxx" doesn't correspond to a known type

2021-12-16 Thread Florian Eckert
Hello, If I execute the following command in the openwrt project: ./scripts/dump-target-info.pl targets I get the this output! I don't know if this is a mistake or if it is intentional. The warning was added by this commit https://gitlab.dev.tdt.de/dev/sys6/upstream/openwrt/-/commit/d3bc11857a

Re: CPU_TYPE "xxx" doesn't correspond to a known type

2021-12-16 Thread Florian Eckert
Hello Philip Yeah, it's intentional. It was meant to be a sentinel for bitrot. I was already aware that this warning was intentional. I have expressed that incorrectly sorry. You don't want to have an empty expansion of CPU_CLFAGS_* as these are usually important platform-specific values th

Re: [PATCH v3] netifd: add devtype to ubus call

2022-01-10 Thread Florian Eckert
Hello Hans, thanks for you review. +--- a/system.h b/system.h +@@ -23,6 +23,42 @@ + #include "iprule.h" + #include "utils.h" + ++static const unsigned short netdev_type_number[] = { ++ ARPHRD_NETROM, ARPHRD_ETHER, ARPHRD_EETHER, ARPHRD_AX25, ++ ARPHRD_PRONET, ARPHRD_CHAOS, ARPHRD

libubus-lua: Wrong conversion for negative numbers on 64bit systems

2022-01-11 Thread Florian Eckert
Hello, The commit [1] added a regression for negative numbers in the ubus lua binding on 64bit systems. This is was also backported to openwrt-19.07 branch with this commit [2]. I have noticed this on my Apu3 x86_64 system and I do not see this error on my 32 bit system. I assume that this

[PATCH v4 1/1] netifd: add devtype to ubus call

2022-01-11 Thread Florian Eckert
e status Output: { "eth0": { "devtype": "ethernet", Signed-off-by: Florian Eckert --- v2: - Remove debug log output v3: - Use the information mainly from file 'uevent'. - If 'uevent' does not pro

Re: Switch issues and CI to GitHub

2022-01-20 Thread Florian Eckert
I have now been persuaded to share my thoughts on the subject as well. Since this is a major change. In itself, I think it is good that thought is being given to unification. Github was the first web-based source code management tool. So I think it's just that most of user are also on github.

Re: [PATCH 7/7] lantiq: add renesas USB3 support

2022-02-02 Thread Florian Eckert
On 2022-02-02 11:39, Torsten Duwe wrote: Enable the USB_XHCI_PCI_RENESAS config option on lantiq and note the usb3 dependency. The XHCI host controller requires a firmware blob, see https://forum.openwrt.org/t/2071 Signed-off-by: Torsten Duwe --- package/kernel/linux/modules/usb.mk | 1 + t

[PATCH] x86: geode: fix package nameing kmod-crypto-ebc does not exist

2022-02-22 Thread Florian Eckert
This commit fixes the package naming that was added by commit: e1e4cbde5ceb228e60fff1fc752cb90d9a7df2ab Signed-off-by: Florian Eckert --- target/linux/x86/image/geode.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/x86/image/geode.mk b/target/linux/x86/image

[PATCH] ipset: update to 7.15

2022-02-25 Thread Florian Eckert
Update to the latest upstream version. In this version there is a new tool with which you we convert ipsets into nftables sets. Since we are now using nftables as default firewall, this could be a useful tool for porting ipsets to nftables sets. Signed-off-by: Florian Eckert --- package/network

[PATCH] base-files: add uci section name for application led trigger handling

2022-03-16 Thread Florian Eckert
In order to read out additional options from the uci section in the called led trigger script, this section must also be add as a argument to the application led trigger script. Signed-off-by: Florian Eckert --- package/base-files/files/etc/init.d/led | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 2/2] mac80211: add ath10k ledtrigger abstraction

2022-03-17 Thread Florian Eckert
ue to work. With this change it is now easier to create a LUCI configuration page without Javascript magic. Signed-off-by: Florian Eckert --- package/kernel/mac80211/ath.mk| 8 +++ .../files/usr/libexec/led-trigger/ath10k | 24 +++ 2 files changed, 32

[PATCH 1/2] base-files: add uci section name for application led trigger handling

2022-03-17 Thread Florian Eckert
In order to read out additional options from the uci section in the called led trigger script, this section must also be add as a argument to the application led trigger script. Signed-off-by: Florian Eckert --- package/base-files/files/etc/init.d/led | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 2/2] build: add Uninstall for host build

2022-04-04 Thread Florian Eckert
uninstall target. Signed-off-by: Florian Eckert --- include/host-build.mk | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/include/host-build.mk b/include/host-build.mk index b31bf93b30..d0f1a3eda5 100644 --- a/include/host-build.mk +++ b/include/host

[PATCH 1/2] build: add logging output for host build

2022-04-04 Thread Florian Eckert
-by: Florian Eckert --- include/host-build.mk | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/include/host-build.mk b/include/host-build.mk index 7f76eb1a2f..b31bf93b30 100644 --- a/include/host-build.mk +++ b/include/host-build.mk @@ -82,6 +82,7 @@ ifeq ($(HOST_OS

[PATCH firewall4] ruleset: add missing pre_* chains

2022-05-18 Thread Florian Eckert
hooked into this, which are then processed in the context of the fw4 and are thus allowed through by the fw4 in the event of an accept. Signed-off-by: Florian Eckert (cherry picked from commit 596f9f7973560210a8ccf386d7017aaa07ea77d2) --- root/usr/share/firewall4/templates/ruleset.uc | 15

Re: [PATCH firewall4] ruleset: add missing pre_* chains

2022-05-19 Thread Florian Eckert
Hi, can't you do the same by dropping a snippet into /etc/nftables.d/ which simply registers chain with lower priority hooks? In fact there already is an example [1]. Specifically, it's about the firewall rules that the strongswan sets with the updown plugin on a connection SA up/down. Cu

Re: [PATCH firewall4] ruleset: add missing pre_* chains

2022-05-24 Thread Florian Eckert
Hello Jo-Philipp I found the following summary that describes my problem. See my link [1]. And why me need this pre_* hooks in fw4 as I suggested. I have found the following description about priority and accept. This is the paragraph: Base chain priority: Each nftables base chain is assigne

[PATCH firewall4] fw4: add support for include.d dir

2022-06-27 Thread Florian Eckert
option chain 'output' config include option path '/tmp/strongswan/nftables.d/pre-forward.nft' option type 'nftables' option position 'chain-pre' option chain 'forward'includes Signed-off-by: Florian Eckert ---

[PATCH] kernel/crypto: fix crypto-lib-curve25519 x86_64 build

2022-07-21 Thread Florian Eckert
The crypto-lib-curve25519 dependency for x86_64 could not be met, because the package for for the architecture x86_64 was not added to crypto-lib-curve package. Also the package arch definition for x86/64 does not exist. It musst be change to x86_64 to get added. Signed-off-by: Florian Eckert

Re: [PATCH] kernel/crypto: fix crypto-lib-curve25519 x86_64 build

2022-07-22 Thread Florian Eckert
On 2022-07-21 17:10, Stijn Tintel wrote: On 21/07/2022 15:17, Florian Eckert wrote: The crypto-lib-curve25519 dependency for x86_64 could not be met, because the package for for the architecture x86_64 was not added to crypto-lib-curve package. Also the package arch definition for x86/64 does

[PATCH] fstools: add uci fstab section to conffiles for package block-mount

2022-08-03 Thread Florian Eckert
The command 'opkg search /etc/config/fstab' does not return a package name for this config file. In order to know to which package this config file belongs to, a 'conffiles' entry was made for this file to package 'block-mount'. Signed-off-by: Florian Eckert --- p

Re: [PATCH firewall4] fw4: add support for include.d dir

2022-08-11 Thread Florian Eckert
Hi, Sorry for the late reply instead of introducing uci includes that configure nft includes, why not encode the chain/position etc. values directly into the path/filename and directly include the file if it exists at the expected location? I was just wondering why not use the new feature y

[PATCH procd] ubus: add state measurement

2022-10-26 Thread Florian Eckert
"active": false, "duration": 123.176279 }, "running": { "active": true, "duration": 226.491805 }, "shutdown": {

[PATCH] procd: add procd_unlock wrapper

2022-12-20 Thread Florian Eckert
Extend the procd shell wrapper lib with the missing funktion procd_unlock. This could be used in scripts to unlock a previously locked section. Signed-off-by: Florian Eckert --- package/system/procd/files/procd.sh | 4 1 file changed, 4 insertions(+) diff --git a/package/system/procd

[PATCH] netifd: add debug options to uci

2023-01-10 Thread Florian Eckert
ppear in the syslog, the output of the stderr must be redirected by the netifd. Option 'level': * L_CRIT = 0 * L_WARNING = 1 * L_NOTICE = 2 * L_INFO = 3 * L_DEBUG = 4 With this option the loglevel of the netifd can be changed. If nothing is specified, the level is set to 'notice

RFC: Add initrd generation to load SSDT tables via ACPI

2023-01-13 Thread Florian Eckert
Hello, I have an APU3. This has an I2C bus (SMBUS) to which additional devices can be connected. On my APU3 board, an IO expander mcp23s08 [1] is connected there. This IO expander provides additional GPIOs. This additional GPIOs are connected to LEDs. The whole thing worked until kernel versio

[PATCH] kernel/x86: fix type

2023-01-13 Thread Florian Eckert
Fix typo for KernelPackage w83627hf-wdt. Signed-off-by: Florian Eckert --- target/linux/x86/modules.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/x86/modules.mk b/target/linux/x86/modules.mk index 3173cf9e84..e0c3b4174f 100644 --- a/target/linux/x86

Re: RFC: Add initrd generation to load SSDT tables via ACPI

2023-01-15 Thread Florian Eckert
Hi Florian. What is it you're asking for from me? I have seen that you also have a APUx board. So I thought you may also have the need to add an ACPI SSDT during boot via an initrd to use additional I2C devives via SMB bus. Does apica-unix need to be bumped? I already did this https://githu

[PATCH] x86: use mkfs.fat, sed, mmd and mcopy from staging_dir

2023-01-20 Thread Florian Eckert
During image generation, the host tools should not be used but the tools from the staging_dir. - mkfs.fat - sed - mmd - mcopy Signed-off-by: Florian Eckert --- target/linux/x86/image/Makefile | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/target/linux/x86/image

Re: [PATCH] x86: use mkfs.fat, sed, mmd and mcopy from staging_dir

2023-01-20 Thread Florian Eckert
Hello Felix, During image generation, the host tools should not be used but the tools from the staging_dir. - mkfs.fat - sed - mmd - mcopy Why is this necessary? $STAGING_DIR_HOST/bin should already be in $PATH before the host system parts. I only noticed that the prefix $(STAGING_DIR_HOS

Re: [PATCH] x86: use mkfs.fat, sed, mmd and mcopy from staging_dir

2023-01-20 Thread Florian Eckert
On 2023-01-20 12:49, Felix Fietkau wrote: On 20.01.23 12:42, Florian Eckert wrote: Hello Felix, During image generation, the host tools should not be used but the tools from the staging_dir. - mkfs.fat - sed - mmd - mcopy Why is this necessary? $STAGING_DIR_HOST/bin should already be

Re: [OpenWrt-Devel] Security implications for consideration [Was: Re: [openwrt/openwrt] rpcd: add respawn param]

2020-03-04 Thread Florian Eckert
Hi Petr thanks for your investigation I simply would like to bring one important aspect for consideration. By respawning any network facing service indefinitely we're giving adversary infinite attempts for figuring out the way in, decreasing the purpose of (expensive) ASLR etc. See "Remotel

Re: [OpenWrt-Devel] Security implications for consideration [Was: Re: [openwrt/openwrt] rpcd: add respawn param]

2020-03-04 Thread Florian Eckert
> > procd_open_instance > > procd_set_param command "$PROG" ${socket:+-s "$socket"} > > ${timeout:+-t "$timeout"} > > + procd_set_param respawn ${respawn_retry:-0} > > > > IMHO this is probably not correct as well, that respawn param is > "array" of > [threshold, timeout, retry] params, so this

[OpenWrt-Devel] [PATCH 1/1] netifd: add pre-up/down post-up/down callback handling

2020-03-19 Thread Florian Eckert
config flag so that the connection should really disconnected. And so does not restart on a failed connetion tracking again because the uci config flag is not set. Signed-off-by: Florian Eckert --- package/network/config/netifd/files/sbin/ifup | 2 ++ 1 file changed, 2 insertions(+) diff --git a

Re: [OpenWrt-Devel] [PATCH 1/1] netifd: add pre-up/down post-up/down callback handling

2020-03-20 Thread Florian Eckert
flag is not set. Signed-off-by: Florian Eckert netifd already tracks for every interface if the user requested it to be enabled or not via the 'autostart' flag, which you can query via ubus. I know this is done wit the uci option auto for this interface. But if I disable this fla

Re: [OpenWrt-Devel] [PATCH 1/1] netifd: add pre-up/down post-up/down callback handling

2020-03-23 Thread Florian Eckert
I know this is done wit the uci option auto for this interface. But if I disable this flag, then on the next boot this interface does not start on boot anymore. I have to start this manual. So I think this is not an option. No, I'm talking about the internal per-interface 'autostart' variabl

[OpenWrt-Devel] [PATCH] base-files: add enabled commands to service rc.common

2020-04-07 Thread Florian Eckert
Add missing enbaled command help output. Signed-off-by: Florian Eckert --- package/base-files/Makefile| 2 +- package/base-files/files/etc/rc.common | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/package/base-files/Makefile b/package/base-files/Makefile index

[OpenWrt-Devel] [PATCH] kernel: add gpio-it87

2020-04-29 Thread Florian Eckert
the nonsensical message and the loading of the module I have added this as a package, so that it can be installed later or during image building. Signed-off-by: Florian Eckert --- package/kernel/linux/modules/other.mk | 18 ++ target/linux/x86/64/config-4.19 | 2 +- tar

[OpenWrt-Devel] [PATCH] kernel: add kmod-ledtrig-mtd as a kernel module

2020-05-04 Thread Florian Eckert
Not every target needs this LED trigger. Therefore this trigger can be installed as kernel module. Signed-off-by: Florian Eckert --- This is a followup patch form the discussion: https://patchwork.ozlabs.org/project/openwrt/patch/20181129132538.20179-3...@dev.tdt.de/#2043062 package/kernel

[OpenWrt-Devel] [PATCH] wireguard-tools: fix version indicator

2020-05-11 Thread Florian Eckert
v1.0.20200319 - https://git.zx2c4.com/wireguard-tools/` This had already led to confusion! To fix this the versions string from the wireguard source include file `src/version.h` is now used by removeing the version string generation from the wireguard-tools makefile. Signed-off-by: Florian Eckert

[OpenWrt-Devel] [PATCH v2] wireguard-tools: fix version indicator

2020-05-11 Thread Florian Eckert
d. Signed-off-by: Florian Eckert --- v2: Update commit message package/network/utils/wireguard-tools/Makefile | 2 +- .../patches/0001-wireguard-tools-fix-version.patch | 13 + 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 package/network/utils/wireg

[OpenWrt-Devel] [PATCH v3] wireguard-tools: fix version indicator

2020-05-12 Thread Florian Eckert
d. Signed-off-by: Florian Eckert --- v2: Update commit message v3: Suggest a different solution with GIT_DIR .../patches/0001-wireguard-tools-fix-version.patch| 11 +++ 1 file changed, 11 insertions(+) create mode 100644 package/network/utils/wireguard-tools/patches/0001-wireguard

Re: [OpenWrt-Devel] [PATCH v2] wireguard-tools: fix version indicator

2020-05-12 Thread Florian Eckert
Hello Paul Thank you for your thoughts. ok, but I fail to see why this patch should be maintained by OpenWrt, this looks like it should be fixed upstream. Thanks. I think this is not possible every project does have his own rules. I only noticed this with wireguard so I will send the changes

Re: [OpenWrt-Devel] [PATCH v3] wireguard-tools: fix version indicator

2020-05-12 Thread Florian Eckert
Is this a patch you'd like to send upstream to wiregu...@lists.zx2c4.com? Yes this would be the fix for the version problem in Openwrt. This would be nice if this gets applied into the wireguard repository. ___ openwrt-devel mailing list openwrt-devel@

[OpenWrt-Devel] Conversion issue in lua ubus binding

2020-06-10 Thread Florian Eckert
Hello Community, I have recently discovered that there is a conversion problem with the ubus lua binding. I think it is due to the following commit [1] from the ubus project. Can anyone confirm this? I have a lua program that loads the json object from ubus and extracts a value. On a 32 bit s

[OpenWrt-Devel] [PATCH] lantiq: add dsl line_state mapping

2020-06-16 Thread Florian Eckert
collectd and gravana backend. Signed-off-by: Florian Eckert --- .../base-files/lib/functions/lantiq_dsl.sh| 82 +-- 1 file changed, 55 insertions(+), 27 deletions(-) diff --git a/target/linux/lantiq/base-files/lib/functions/lantiq_dsl.sh b/target/linux/lantiq/base-files/lib

Re: [OpenWrt-Devel] Conversion issue in lua ubus binding

2020-06-16 Thread Florian Eckert
I have recently discovered that there is a conversion problem with the ubus lua binding. I think it is due to the following commit [1] from the ubus project. Can anyone confirm this? I removed the suspicious commit [1] from my build and did a custom image for x86_64. Now the value is displayed

Re: [OpenWrt-Devel] [PATCH] lantiq: add dsl line_state mapping

2020-06-16 Thread Florian Eckert
Hi Adrian, thanks for your comment - "0xd00") s="resync" ;; - "0x3c0") s="short init entry" ;; - "") s="not running daemon"; ls="0xfff" ;; - *) s="unknown" ;; + "0x0")s="not in

Re: [OpenWrt-Devel] [PATCH] lantiq: add dsl line_state mapping

2020-06-17 Thread Florian Eckert
Hi Adrian, The line_state of the DSL connection is described in the system via a hexadecimal variable. With this change the hexadecimal is mapped to a decimal value. With this change it is now possible to store this value in a database, so that it can be easily evaluated. Interesting file th

Re: [PATCH] wireless-regdb: add country selection

2020-07-14 Thread Florian Eckert
What's the use case for this? As much as I remember there was the problem in 2017 that you can't change the country code or have to restrict it. https://ec.europa.eu/growth/sectors/electrical-engineering/red-directive_de Of course this change can't fulfill with this patch, but it wouldn't be

[PATCH v2 1/1] wireless-regdb: add country selection

2020-07-16 Thread Florian Eckert
blacklist or whitelist the countries must be entered in a comma separated list. So abbreviation for the countries are entered in IS03166 ALPHA-2 notation. If this option is not activated, then all countries in the regdb are taken over as before. Signed-off-by: Florian Eckert --- package/firmware

Re: [RFC] Policy for PKG_RELEASE bumps

2020-08-18 Thread Florian Eckert
Hi team, * When anything inside the packages ipk file changes Includes patch and so called "cosmetic" changes outside the Makefile, e.g. replace tabs with spaces. PKG_VERSION: This is the upstream version of the Project and this is the upstream version we build. PKG_RELEASE: This is th

Re: ddns-scripts is broken since last major update

2020-09-25 Thread Florian Eckert
Hello Hartmut since last update, ddns-scripts doesn't work any more. The log files contains the following output: The current handling of the large file service and service6 with all services was complicated. Therefore I have outsourced the information of every service into different JSON fi

hostapd: add additional network section to wpa_supplicant

2020-10-12 Thread Florian Eckert
Hello Community, I have a openwrt system in mobile use. That means I have a hostapd running as an access point for clients and at the same time a wpa_supplicant running to another access point as uplink. So the router is client and access point at the same time on one radio. My problem is that

Re: hostapd: add additional network section to wpa_supplicant

2020-10-13 Thread Florian Eckert
Hello Daniel, thanks for your feedback :+1: Or where do I have to start? This could be done by introducing a new type of UCI section, 'wifi-credential' which can be listed in the 'wifi-iface' section of a station interface. The way I see it, we have to hook into here [1] for the sta mode.

Re: [OpenWrt-Devel] [PATCH] wireguard: fix reload config on peer change

2023-03-14 Thread Florian Eckert
Hello Rafał, corresponding interface. The wireguard configuration is rewritten and reconfigured by the netif proto handler. Signed-off-by: Florian Eckert What has happened to this patch? It's marked as Superseded but I didn't see V2 or anything. It seems to be dealing with iss

Re: [OpenWrt-Devel] [PATCH] wireguard: fix reload config on peer change

2023-03-14 Thread Florian Eckert
On 2023-03-14 16:17, Rafał Miłecki wrote: On 14.03.2023 16:12, Florian Eckert wrote: Hello Rafał, corresponding interface. The wireguard configuration is rewritten and reconfigured by the netif proto handler. Signed-off-by: Florian Eckert What has happened to this patch? It's mark

Re: [PATCH procd] ubus: add state measurement

2023-03-22 Thread Florian Eckert
Hello Christian I wonder if this kind of thing should be under a config flag? I do not see under system, with the command 'ubus -v list system' a section 'config'. I do not wanted to add a new section, so I decided to implement it under 'info' because this are runtime information as 'load', '

Re: [PATCH procd] ubus: add state measurement

2023-03-22 Thread Florian Eckert
Hello Oldrich, + +void procd_state_event(struct blob_buf *b) +{ + void *c, *s; + struct timespec *ts_start; + struct timespec *ts_stop; + struct timespec ts_active; + struct timespec ts_res; + double duration; + + c = blobmsg_open_table(b, "state"); + +

Re: mwan3 memory usage

2023-06-15 Thread Florian Eckert
Hello, Hi,     We have enabled mwan3 (version 2.11.4) functionality with OpenWRT version 22.03 and we see that four mwan3rtmon processes are running, two each for IPv4 and IPv6. We made the change with the following commit: https://github.com/openwrt/packages/commit/566293d228a48d21a04ecbc815a

Re: [PATCH 1/3] target.mk: silence CPU_TYPE doesn't correspond to a known type

2023-06-15 Thread Florian Eckert
Hello Petr On 2023-06-15 16:11, Petr Štetiar wrote: Following command: $ ./scripts/dump-target-info.pl targets currently generates bunch of following warnings: include/target.mk:269: CPU_TYPE "cortex-a15" doesn't correspond to a known type I've noticed that too. Could you please explain

[PATCH] .gitignore: ignore link if target is included from feed

2023-07-19 Thread Florian Eckert
If an out of tree target is included via a feed, then there is a link with the name 'feed' in the target directory. Do not show this link in git. Signed-off-by: Florian Eckert --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index a80cdbbea3..

[PATCH] system-notification: initial checkin

2023-07-19 Thread Florian Eckert
be updated. remove: The command removes a notification from the ubus backend. ubus call system.notification remove '{"uuid": ""}' list: The command dumps all staged notification from the ubus backend. ubus call system.notification list flush: The command removes all st

Re: [PATCH] system-notification: initial checkin

2023-07-20 Thread Florian Eckert
And - di I miss it or you can not actually create a notification from the user-facing script? Why not implement that as well? I have deliberately not implemented this, because I am not sure how to do it, as the message can become relatively long. The creation of the notification will probably be the

[PATCH] build: replace SourceName with PKG_NAME

2023-07-25 Thread Florian Eckert
an-charon-cmd (after): Package: strongswan-charon-cmd Version: 5.9.11-1 ... SourceName: strongswan License: GPL-2.0-or-later Section: net Signed-off-by: Florian Eckert --- include/package-ipkg.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/package-ipkg.mk b

[PATCH] build: replace SourceName with PKG_NAME

2023-07-25 Thread Florian Eckert
r strongswan-charon-cmd (after): Package: strongswan-charon-cmd Version: 5.9.11-1 ... SourceName: strongswan License: GPL-2.0-or-later Section: net Signed-off-by: Florian Eckert --- include/package-ipkg.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inc

firewall4: loopback device is ACCEPTED before include chain-prepend input

2023-09-06 Thread Florian Eckert
Hello, I have a use case, where I want to add rules via the firewall include feature, because this could not be modulated via the fw4 feature set. That could be done, if we add the rules into the directory `usr/share/nftables.d/chain-pre/input/` [1], because I need this rules in the input ch

[PATCH] firewall4: ruleset: also evaluate the custom includes for the loopback interface

2023-09-07 Thread Florian Eckert
for the input and output chain before the accept rule of the loopback interface. User defined rules for the input and output chain are now always evaluated for the entire traffic. Signed-off-by: Florian Eckert --- root/usr/share/firewall4/templates/ruleset.uc | 4 ++-- 1 file changed, 2 insertions

[PATCH] build: replace SourceName with PKG_NAME compile unit name

2023-09-08 Thread Florian Eckert
27; is the compile unit from which the package was build from. This must be the same for all installable packages built from the same compile unit. This commit fixes that. Signed-off-by: Florian Eckert --- include/package-ipkg.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

<    1   2   3   >