Hello Paul

Thank you for your thoughts.

ok, but I fail to see why this patch should be maintained by OpenWrt, this
looks like it should be fixed upstream. Thanks.

I think this is not possible every project does have his own rules.
I only noticed this with wireguard so I will send the changes upstream to wireguard.

Probably the right way to solve this would be to have means to
override the default git describe behaviour (and force specific
version string instead) by a configure (or similar) flag. That would
require collaboration with upstream but will also need some additional
tweaks to the OpenWrt package Makefile.

My v3 patch does fix this in the wireguard-tools,
but I think we could export this variable during building of an package on Openwrt. For example `export GIT_DIR="$(PKG_BUILD_DIR)/.git" in "include/package.mk" to pin the git dir for this package.

Regards

Florian


_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to