RE: [PATCH] arc770: Remove arc770 target

2022-01-23 Thread Adrian Schmutzler
when using glibc. > > Currently no one is working on fixing this problem, remove the target > instead. This target also does not have many users we are aware of. > > If someone wants to have this target back, feel free to add a fixed version of > this target again. >

RE: Switch issues and CI to GitHub

2022-01-23 Thread Adrian Schmutzler
wards. From the aspect of pure usability, I'd favor GitHub, as so many other projects do. Best Adrian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

RE: [PATCH v2] kernel/5.10: remove CONFIG_DEVTMPFS{, _MOUNT} from kconfigs

2022-01-20 Thread Adrian Schmutzler
Hi, just a nitpick: Commit title prefix should be "kernel: 5.10: ...". Best Adrian > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Rui Salvaterra > Sent: Sonntag, 16. Januar 2022 20:46 > To: openwrt-dev

RE: [PATCH] ramips: add support for Wavlink WL-WN576A2

2021-10-30 Thread Adrian Schmutzler
_leds > b/target/linux/ramips/mt76x8/base-files/etc/board.d/01_leds > index e2fb44c81e..a426715dab 100644 > --- a/target/linux/ramips/mt76x8/base-files/etc/board.d/01_leds > +++ b/target/linux/ramips/mt76x8/base-files/etc/board.d/01_leds > @@ -129,6 +129,9 @@ wavlink,wl-wn575a3) > uci

RE: [RFT 5/5] realtek: support Trendnet TPE-082WS V1

2021-10-09 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Paul Fertser > Sent: Dienstag, 5. Oktober 2021 21:40 > To: openwrt-devel@lists.openwrt.org > Cc: Paul Fertser > Subject: [RFT 5/5] realtek: support Trendnet TPE-082WS V1 > > Acc

RE: [RFT 4/5] realtek: support D-Link DGS-1210-10P H/W:R1

2021-10-09 Thread Adrian Schmutzler
arget/linux/realtek/base-files/etc/board.d/02_network > @@ -48,6 +48,13 @@ done > [ -n "$label_mac" ] && ucidef_set_label_macaddr $label_mac > > case $board in > +d-link,dgs-1210-10p-f1|\ > +d-link,dgs-1210-10p-r1) F1 should be added with F1 support here, u

RE: [RFT 3/5] realtek: add non-PoE version of DGS-1210-10 F1

2021-10-09 Thread Adrian Schmutzler
rive only from nodes that are not a device themselves. In the specific case, it's probably best to just have the few variables twice and derive from dgs-1210. Best Adrian >SUPPORTED_DEVICES += d-link,dgs-1210-10p >DEVICE_PACKAGES += lua-rs232 > endef > -- > 2.17.

RE: [RFT 1/5] realtek: split DGS-1210-10P DTS

2021-10-09 Thread Adrian Schmutzler
DEVICE_VENDOR := D-Link > endef > > -define Device/d-link_dgs-1210-10p > +define Device/d-link_dgs-1210-10p-f1 >$(Device/d-link_dgs-1210) > + SOC := rtl8380 Please, don't overwrite SOC on different levels. If these devices have different SOC, it shoul

RE: [RFT 1/5] realtek: split DGS-1210-10P DTS

2021-10-09 Thread Adrian Schmutzler
I'd say the device rename is way more important than the DTS split. It should be covered in the commit title. Personally, I'd split these two changes (one for rename, one for shared DTSI and device recipe). Best Adrian > > Signed-off-by: Paul Ferts

RE: [PATCH 4/4] zynq: switch to kernel 5.10

2021-10-05 Thread Adrian Schmutzler
ackage/kernel/mac80211/compile#6.14#1.71#13.27 ERROR: package/kernel/mac80211 failed to build. make[2]: *** [package/Makefile:116: package/kernel/mac80211/compile] Error 1 make[2]: Leaving directory '/data/openwrt' make[1]: *** [package/Makefile:110: /data/openwrt/staging_dir/target-arm_cortex

RE: Suggestion: Explicitly warn to not use GitHub web UI for patches

2021-10-05 Thread Adrian Schmutzler
s/troubleshooting-required-status-checks > > which looks for any commit containing: > > > Committer: "GitHub " > > > > Accepting "drive-by" PRs is overall a good thing, even if it is a bumpy path. Is it still when getting it done means not ac

Suggestion: Explicitly warn to not use GitHub web UI for patches

2021-10-03 Thread Adrian Schmutzler
there any (other) opinions out there? Do we require a vote for that or is it enough if there are no objections after a certain waiting time? Best Adrian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

RE: mediatek: fix NETDEV WATCHDOG: eth0 (mtk_SOC_eth): Transmit queue 0 timed out

2021-10-03 Thread Adrian Schmutzler
gt; queue 0 timed out > > Use flow control or BQL maybe lead to bug. > Iperf3 was usedfor 24 hours, Transmit Queue 0 timed out may occur. > example: >Server: iperf3 -s >Client: iperf3 -c 172.16.10.20 > > Signed-off-by: daxiong Is this your (full) real name? Best

RE: [PATCH-21.02] fix bug: NETDEV WATCHDOG: eth0 (mtk_SOC_eth): Transmit Queue 0 timed out Use flow control or BQL maybe lead to bug. Iperf3 was used for 24 hours, Transmit Queue 0 timed out may occur

2021-10-03 Thread Adrian Schmutzler
e your real name for Signed-off-by. https://openwrt.org/submitting-patches Apart from that, note that changes should be submitted to master first. Best Adrian > > Signed-off-by: daxiong > --- > ...iatek-ethernet-transmit-queue-timeout-bug.patch | 113 > +

RE: Removing 5.4 support for bcm27xx and bcm53xx

2021-10-02 Thread Adrian Schmutzler
> -Original Message- > From: Rafał Miłecki [mailto:ra...@milecki.pl] > Sent: Samstag, 2. Oktober 2021 19:28 > To: Adrian Schmutzler > Cc: 'Álvaro Fernández Rojas' ; openwrt- > de...@lists.openwrt.org > Subject: Re: Removing 5.4 support for bcm27xx and b

RE: [PATCH v3] realtek: ensure output drivers are enabled in RTL8231

2021-10-02 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Paul Fertser > Sent: Samstag, 2. Oktober 2021 18:51 > To: Adrian Schmutzler > Cc: openwrt-devel@lists.openwrt.org; 'Sander Vanheule' > > Subje

RE: [PATCH] nftables: install libnftables to staging dir

2021-10-02 Thread Adrian Schmutzler
CH] nftables: install libnftables to staging dir > > Makes libnftables library and headers available for other packages. Please bump PKG_RELEASE or use $(AUTORELEASE) instead. Best Adrian > > Signed-off-by: Daniel Danzberger > --- > package/network/utils/nftables/M

Removing 5.4 support for bcm27xx and bcm53xx

2021-10-02 Thread Adrian Schmutzler
Hi, both bcm27xx and bcm53xx have kernel 5.10 by default for more than one month. I'd like to remove 5.4 patches etc. there, so we don't have to bother with 5.4 for new patches (like stintel had to when adding config symbols recently). Any objections? Be

RE: [PATCH v3] realtek: ensure output drivers are enabled in RTL8231

2021-10-02 Thread Adrian Schmutzler
in case the bootloader left direction and data > registers in an inconsistent state (e.g. pulling SoC's reset to 0) reconfigure > everything as input. > > Reviewed-by: Sander Vanheule > Signed-off-by: Paul Fertser I added Fixes: 16ae56b4f9ec ("realtek: fix RTL8231 gpio exp

RE: [PATCH] ramips: switch to kernel 5.10

2021-09-26 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Stijn Segers > Sent: Donnerstag, 9. September 2021 14:26 > To: openwrt-devel@lists.openwrt.org; Paweł Dembicki > ; Rui Salvaterra > Cc: OpenWrt Deve

RE: [PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-25 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Rui Salvaterra > Sent: Samstag, 25. September 2021 20:32 > To: Adrian Schmutzler > Cc: openwrt-devel@lists.openwrt.org; ros...@gmail.com > Subject: Re:

RE: [PATCH v4 1/6] at91: kernel: bump to 5.10

2021-09-24 Thread Adrian Schmutzler
SoCs (AT91RM9200, AT91SAM9, > SAM9X60) has been enabled such that sam9x SoCs to be able to boot. I've just compared our "old" version of wb45n and wb50n DTS files to the ones in the 5.10 kernel. They look very different. Has this been investigated or do we just not car

RE: [PATCH] realtek: add support for D-Link DGS-1210-10P H/W:R1

2021-09-24 Thread Adrian Schmutzler
+ }; > + }; > +}; > + > +&switch0 { > + ports { > + port@24 { > + sfp = <&sfp0>; > + }; > + > + port@26 { > + sfp = <&sfp1>; > + };

RE: [PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-24 Thread Adrian Schmutzler
h79/ag71xx: rearrange ag71xx structs to remove holes Commit title prefix should be "ath79: ag71xx:" or just "ath79:". Apart from that, I can contribute nothing useful :-( Best Adrian > > From: Rosen Penev > > Remove cacheline_aligned attribute to ring structs.

Drop support for mtd-mac-address

2021-09-24 Thread Adrian Schmutzler
eviewed-by/Acked-by here. Best Adrian openpgp-digital-signature.asc Description: PGP signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

RE: [PATCH] ath79: add old JT-OR750i name to supported devices

2021-09-24 Thread Adrian Schmutzler
sentially there is no way we can say it's "supported"). SUPPORTED_DEVICES should be limited to what "we" have had in the tree. The only exception IMO is when the vendor uses OpenWrt, and direct sysupgrade is possible. Marking this as "rejected". Best Adrian &g

RE: Build issues gcc10

2021-09-16 Thread Adrian Schmutzler
Hi again, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Rui Salvaterra > Sent: Dienstag, 14. September 2021 00:29 > To: Adrian Schmutzler > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: Build issues

RE: Build issues gcc10

2021-09-13 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Rui Salvaterra > Sent: Sonntag, 12. September 2021 19:12 > To: Adrian Schmutzler > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: Build issues gcc10 >

RE: Build issues gcc10

2021-09-13 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Stefan Lippers-Hollmann > Sent: Montag, 13. September 2021 00:30 > To: Adrian Schmutzler > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: Build issues

RE: Build issues gcc10

2021-09-12 Thread Adrian Schmutzler
> -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Ansuel Smith > Sent: Sonntag, 12. September 2021 19:50 > To: Adrian Schmutzler > Cc: Rui Salvaterra ; OpenWrt Development List > > Subject

RE: Build issues gcc10

2021-09-12 Thread Adrian Schmutzler
> -Original Message- > From: Ansuel Smith [mailto:ansuels...@gmail.com] > Sent: Sonntag, 12. September 2021 19:18 > To: Rui Salvaterra > Cc: Adrian Schmutzler ; OpenWrt Development > List > Subject: Re: Build issues gcc10 > > Il giorno dom 12 set 2021 alle ore

Build issues gcc10

2021-09-12 Thread Adrian Schmutzler
+neon-vfpv4_gcc-10.3.0_musl_ eabi/gcc-10.3.0-final' make[2]: *** [Makefile:91: /data/openwrt/build_dir/toolchain-arm_cortex-a7+neon-vfpv4_gcc-10.3.0_musl_e abi/gcc-10.3.0-final/.built] Error 2 make[2]: Leaving directory '/data/openwrt/toolchain/gcc/final' time: toolc

RE: [PATCH] mvebu/kernel: promote 5.10 to stable

2021-09-11 Thread Adrian Schmutzler
to have it removed. In any case, lines are directly next to each other, so nobody should have a problem with finding out that both are the same if it's kept. Since there have been different opinions expressed by committers (e.g. I prefer to keep it), we would technically need a vote on this. Ho

RE: [PATCH] base-files: reduce `mkdir` and `sed` calls

2021-09-11 Thread Adrian Schmutzler
during multi-arg mkdir, e.g. mkdir -p dir1 dir2 dir3 Actually, if dir2 triggers an error, dir3 will still be created. Thus, this patch is also cosmetic in terms of error handling. You might want to add that information to the commit message (or just ignore it, if that's obvious to anybody exc

RE: Question about qca8k dsa driver and path to follow

2021-09-11 Thread Adrian Schmutzler
ent" due to other changes, there is nothing to say against it. But experience tells it's hard enough to properly support one configuration, so we definitely should not invest work in providing a choice here just for its own sake (always referring to different drivers on a single device, of c

RE: [PATCH] sunxi: bring up DSA b53 switch on Lamobo R1

2021-09-11 Thread Adrian Schmutzler
://github.com/openwrt/openwrt/commit/494f12c52df6767ec0fabf2b2fac8f4533 23a4c5 For a single device, you would probably not need the separate Device/dsa-migration definition, though, but could just add the two variables to the device. Best Adrian >SOC := sun7i-a20 > endef > TAR

RE: [PATCH v3 4/6] at91: add support for sama5d27-wlsom1-ek board

2021-09-11 Thread Adrian Schmutzler
ped, this value is generated by default. Best Adrian > + KERNEL_SIZE := 6144k > + $(Device/evaluation-sdimage) > +endef > +TARGET_DEVICES += microchip_sama5d27-wlsom1-ek > + > define Device/microchip_sama5d2-ptc-ek >$(Device/evaluation-dtb) >

RE: [PATCH v3 3/6] at91: add support for sama5d2 icp board

2021-09-11 Thread Adrian Schmutzler
the global default. Best Adrian > + KERNEL_SIZE := 6144k > + $(Device/evaluation-sdimage) > +endef > +TARGET_DEVICES += microchip_sama5d2-icp > + > define Device/microchip_sama5d2-xplained >$(Device/evaluation-dtb) >

RE: [PATCH] ath79: add support for TP-Link TL-WA1201 v2

2021-09-05 Thread Adrian Schmutzler
mdio2: mdio { > + compatible = "virtual,mdio-gpio"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + gpios = <&gpio 3 GPIO_ACTIVE_HIGH>, /* MDC */ > + <&gpio 4 G

[PATCH] ubus/lua: avoid changing key type to string

2021-08-31 Thread adrian . frances
From: Adrian Frances According to the lua man page for lua_next, it is not advised to call lua_tolstring when iterating through a table with lua_next. When iterating a table in ubus_lua_format_blob_array, we end up calling lua_tostring, which inside calls lua_tolstring, converting all non

[PATCH v2] ubusd: fix disconnection when sending invalid fd

2021-08-31 Thread adrian . frances
From: Adrian Frances According to man 7 unix, sendmsg returns EBADF when sending an invalid file descriptor as ancillary data. The patch avois ubus disconnecting the client when EBADF is received for the mentioned case. Signed-off-by: Adrian Frances --- ubusd_main.c | 7 +++ 1 file

RE: OpenWrt 21.02 status

2021-08-29 Thread Adrian Schmutzler
release with this as a known problem? Although my opinion should not be given much weight in this context, I'd also prefer a "quick" release, for about the same reasons as Hannu has given in his e-mail. As I understand it, disabling offloading will give you a working device, so it

Kernel 5.10: Current targets' state

2021-08-24 Thread Adrian Schmutzler
realtek - https://github.com/openwrt/openwrt/pull/4448 sunxi - https://github.com/openwrt/openwrt/pull/3953 uml zynq Best Adrian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

RE: [PATCH 6/6] qoriq: add support for WatchGuard Firebox M300

2021-08-24 Thread Adrian Schmutzler
ter still "correct" for this device? > + DEVICE_PACKAGES := \ > + kmod-hwmon-w83793 kmod-ptp-qoriq kmod-rtc-rs5c372a > +kmod-tpm-i2c-atmel We typically use (just) one tab for hanging indent in image/*.mk files. (I.e. remove the additional spaces before kmod-hwmon... Best Ad

RE: [PATCH 6/6] qoriq: add support for WatchGuard Firebox M300

2021-08-24 Thread Adrian Schmutzler
<>___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

RE: [PATCH] firmware-utils: seama.h replace LGPL-2.1-or-later boilerplate with SPDX

2021-08-22 Thread Adrian Schmutzler
t;library" in the main part of the > licensing info. It also used "The GNU C Library" instead of the standard "This > library" in 2nd and 3rd paragraphs. > > The first paragraph clearly mentions LGPL-2.1-or-later and the use of "file" > instead

RE: [PATCH] base-files: add option to make /var persistent

2021-08-22 Thread Adrian Schmutzler
here as well, just add something like "(/var/run will still be linked to /tmp/run)" ... Otherwise, the description would be misleading. Best Adrian > endmenu > diff --git a/package/base-files/Makefile b/package/base-files/Makefile index > 5f816a0d1b..687fbc5f78 100644 > ---

RE: [PATCH v6 3/3] mvebu: backport CN9130 dts files changes to 5.4

2021-08-22 Thread Adrian Schmutzler
dts files changes to 5.4 This patch lacks a commit message. What is it good for? Best Adrian > > From: Ian Chang > > Signed-off-by: Ian Chang > --- > ...l-Add-support-for-Marvell-CN9130-SoC.patch | 60 + > ...64-dts-marvell-Add-support-for-CP115.patch | 35 + >

RE: [PATCH v6 1/3] mvebu: add support for iEi Puzzle-M901/Puzzle-M902

2021-08-22 Thread Adrian Schmutzler
fter this commit. The fact that 2/3 is not really meaningful is also evidenced by the lack of a proper commit message. Best Adrian > --- > .../base-files/etc/board.d/02_network | 6 > .../cortexa72/base-files/lib/upgrade/emmc.sh | 36 +++ > .../ba

RE: OpenWrt 21.02.0 Fourth release candidate

2021-08-22 Thread Adrian Schmutzler
> Hi Arınç, > > Thanks for working on a swconfig to DSA migration script. > I would prefer not to delay the final 21.02 release further. We should fix the > IPv6 flow offload problems and then do the final 21.02 release. +1 > Such a migration script also needs testing, user will have all sorts o

RE: [PATCH v3] ath79: add support for onion omega

2021-08-22 Thread Adrian Schmutzler
t; + > + macaddr_uboot_1fc00: macaddr@1fc00 { > + reg = <0x1fc00 0x6>; > + }; > + }; It's common practice at the moment to put a separate block for defining the

RE: [PATCH 8/8] at91: add support for sam9x60-ek board

2021-08-22 Thread Adrian Schmutzler
Hi, > @@ -112,6 +112,15 @@ define Device/atmel_at91sam9x35ek endef > TARGET_DEVICES += atmel_at91sam9x35ek > > +define Device/microchip_sam9x60ek Please move device definition block according to alphabetic sorting. Best Adrian > + $(Device/evaluation-dtb) > + DEVICE_V

RE: [PATCH 2/8] at91: add support for sama5d2 icp board

2021-08-22 Thread Adrian Schmutzler
TED_DEVICES can be dropped here, the value matches the global default calculated from the device node name according to: https://github.com/openwrt/openwrt/blob/master/include/image.mk#L407 This possibly also applies to the other devices submitted, I won't resend for them if that'

RE: [PATCH 6/6] qoriq: add support for WatchGuard Firebox M300

2021-08-22 Thread Adrian Schmutzler
}; > + hwmon@2d { > + compatible = "winbond,w83793"; > + reg = <0x2d>; > + }; > + rtc@32 { > + compatible = "ricoh,rs5c372a"; > + reg =

RE: [PATCH 3/6] openssl: add ppc64 support

2021-08-22 Thread Adrian Schmutzler
the linux64v2 perlasm scheme. This will probably break the combination > ppc64 with glibc, but as we really only want to support musl, this shouldn't > be > a problem. Looks like openssl still needs a PKG_RELEASE bump ... Best Adrian > > Signed-off-by: Stijn Tintel

[PATCH] ubusd: fix disconnection when sending invalid fd

2021-08-17 Thread adrian . frances
From: Adrian Frances According to man 7 unix, sendmsg returns EBADF when sending an invalid file descriptor as ancillary data. The patch avois ubus disconnecting the client when EBADF is received for the mentioned case. Signed-off-by: Adrian Frances --- ubusd_main.c | 6 ++ 1 file changed

[PATCH] ubus/lua: add support for custom timeout parameter on call

2021-08-17 Thread adrian . frances
From: Adrian Frances Allows for setting different timeouts per call, using the general timeout for the ubus connection as the fallback. Signed-off-by: Adrian Frances --- lua/ubus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lua/ubus.c b/lua/ubus.c index e2bb081

RE: convert mtd-mac-address to nvmem implementation

2021-07-20 Thread Adrian Schmutzler
s and partition layout looks fine. I'd say it's desirable not to distribute the partitioning across too many files. But this case here is an exception anyway, as many/most examples will depend on art partitions that are not on the beginning and might have different offset

RE: convert mtd-mac-address to nvmem implementation

2021-07-20 Thread Adrian Schmutzler
; hi, > some dtsi still use the old implementation as they have to be manually I thought we should not delay updating the majority of devices with this problem. I will take care of the remaining ones as soon as I can, and try to work out a sensible setup for the DTSI/DTS rearrangements. Bes

RE: OpenWrt 21.02 status

2021-07-19 Thread Adrian Schmutzler
will define which state we are in. There is a reason why nobody provided a DSA migration script (or even tried AFAIK). This horse is dead. (Doing -f without -n is a real world problem. They might pseudo-brick their devices. However, we have no better solution about that at the moment.) Best

RE: OpenWrt 21.02 status

2021-07-19 Thread Adrian Schmutzler
> -Original Message- > From: Daniel Golle [mailto:dan...@makrotopia.org] > Sent: Montag, 19. Juli 2021 10:13 > To: Adrian Schmutzler > Cc: 'Luiz Angelo Daros de Luca'; 'Hauke Mehrtens'; 'Rich Brown'; 'OpenWrt > Development List';

RE: OpenWrt 21.02 status

2021-07-18 Thread Adrian Schmutzler
re everything but skipping or renaming DSA relevant files (nework, > wifi?) DSA) with a suffix like '.pre-dsa'. We had a very long delay due to DSA and nobody was even slightly interested in creating a migration script. For partial migration, I suspect that implementing something here th

RE: [PATCH 3/3] at91: add support for sama5d27-wlsom1-ek board

2021-07-17 Thread Adrian Schmutzler
, > ++ ; > ++bias-pull-up; > ++}; > ++}; > ++ > +--- /dev/null > b/arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dts Please don't add empty lines at EOF. Just a new line. Best Adrian openpgp-digital-signature.asc Description: PG

RE: [PATCH 2/3] at91: add support for sama5d2 icp board

2021-07-17 Thread Adrian Schmutzler
b) > + DEVICE_VENDOR := Microchip > + DEVICE_MODEL := SAMA5D2 ICP > + DEVICE_DTS := at91-sama5d2_icp > + SUPPORTED_DEVICES := microchip,sama5d2-icp SUPPORTED_DEVICES can be dropped in this specific case, since it matches the global default: Device node name with "_" -> &quo

RE: [PATCH v4] mvebu: add support for iEi Puzzle-M901/Puzzle-M902

2021-07-17 Thread Adrian Schmutzler
e 100644 > index 00..d010b7cc0b > --- /dev/null > +++ b/target/linux/mvebu/files/arch/arm64/boot/dts/marvell/cn9131- > puzzle > +++ -m901.dts > @@ -0,0 +1,326 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) (GPL-2.0-or-later OR MIT) Same for the other DTS f

RE: [PATCH v7 2/2] dnsmasq: add config option for connmark DNS filtering

2021-07-10 Thread Adrian Schmutzler
> -Original Message- > From: Etan Kissling [mailto:etan.kissl...@gmail.com] > Sent: Sonntag, 11. Juli 2021 00:48 > To: Adrian Schmutzler ; openwrt- > de...@lists.openwrt.org > Cc: 'Kevin Darbyshire-Bryant' ; 'Simon Kelley' > > Subject: Re: [

RE: [PATCH v7 2/2] dnsmasq: add config option for connmark DNS filtering

2021-07-10 Thread Adrian Schmutzler
tan Kissling is there a special reason why you repeatedly post with multiple Signed-off-by? Best Adrian > --- > v2: Bundle with patch to update dnsmasq. > > package/network/services/dnsmasq/files/dnsmasq.init | 12 > 1 file changed, 12 insertions(+) > >

RE: [PATCH 19.07 4/4] treewide: mark selected packages nonshared

2021-07-09 Thread Adrian Schmutzler
> -Original Message- > From: Giovanni Giacobbi [mailto:giova...@giacobbi.net] > Sent: Freitag, 9. Juli 2021 09:37 > To: Adrian Schmutzler ; 'Paul Spooren' > ; 'Petr Štetiar' ; openwrt- > de...@lists.openwrt.org > Cc: 'Hannu Nyman' >

RE: [PATCH] gemini: Add hdparm setting

2021-07-04 Thread Adrian Schmutzler
tifier instead. > +# Spin down drives after one minute if inactive > + > +which hdparm > /dev/null I think using which has been discouraged lately in favor of command -v ... > +if [ ! $? -eq 0 ] ; then "$?" != 0 ? > + exit 0 > +fi > + > +DISKS=`fi

RE: [PATCH v3] cn913x: add support for iEi Puzzle-M901/Puzzle-M902

2021-07-04 Thread Adrian Schmutzler
> + compatible = "ethernet-phy-ieee802.3-c45"; > + reg = <0>; > + }; > + phy2: ethernet-phy@2 { > + compatible = "ethernet-phy-ieee802.3-c45"; > + reg = <8>; > + }; > +}; > + > +&

RE: [PATCH 19.07 4/4] treewide: mark selected packages nonshared

2021-07-04 Thread Adrian Schmutzler
that you immediately see up to which version the changes are shared with master, and when it starts to deviate. Best Adrian openpgp-digital-signature.asc Description: PGP signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https

RE: [PATCH] This patch adds supports for GL-B2200-EMMC.

2021-07-04 Thread Adrian Schmutzler
reg = <0x 0 0 0 0>; > + #address-cells = <3>; > + #size-cells = <2>; > + ranges; > + > + wifi2: wifi@1,0 { > + status = "okay"; > + compatible

[PATCH] treewide: call check-size before append-metadata

2021-06-20 Thread Adrian Schmutzler
sysupgrade metadata is not flashed to the device, so check-size should be called _before_ adding metadata to the image. While at it, do some obvious wrapping improvements. Signed-off-by: Adrian Schmutzler --- target/linux/ath79/image/Makefile | 2 +- target/linux/ath79/image/common

RE: [PATCH] kernel: bpi-r2 uses kmod-ata-ahci for block access

2021-06-15 Thread Adrian Schmutzler
ahci for block access > this is target-specific, so the commit title prefix should be "mediatek:" Best Adrian > Fixes accessing block devices. > kmod-ata-ahci-mtk is used only on R64 board. > > Signed-off-by: Pablo Pita > --- > target/linux/mediatek/image/m

RE: [PATCH 3/3] ath79: add support for MikroTik RouterBOARD 912UAG-2HPnD

2021-06-14 Thread Adrian Schmutzler
everywhere else? > + > + flash@0 { > + compatible = "jedec,spi-nor"; > + reg = <0>; > + spi-max-frequency = <8000>; Typically, speeds > 50 MHz require m25p,fast-read? Best Adrian openpgp-digital-signature.asc Description: PGP signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

RE: [PATCH 21.02 00/11] ramips: mt7621: backport support for 9 devices

2021-06-08 Thread Adrian Schmutzler
Hi again, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Adrian Schmutzler > Sent: Dienstag, 8. Juni 2021 21:25 > To: 'Petr Štetiar' ; openwrt-devel@lists.openwrt.org > Subject: RE: [PATCH 21.02 00/

RE: [PATCH 21.02 00/11] ramips: mt7621: backport support for 9 devices

2021-06-08 Thread Adrian Schmutzler
. Note that I only checked config-/DTS-related patches, I don't know if there are any driver- or kernel-related changes that would cause problems. Best Adrian > > 1. https://github.com/openwrt/openwrt/pull/4236 > 2. https://gitlab.com/ynezz/openwrt/-/jobs/1326795722 > 3

RE: [PATCH] cn913x: add support for iEi Puzzle-M901/Puzzle-M902

2021-06-06 Thread Adrian Schmutzler
zzle-m901-cn9131-db > + $(call Device/Default-arm64) > + DEVICE_VENDOR := iEi > + DEVICE_MODEL := Puzzle-M901 > + DEVICE_DTS := puzzle-m901-cn9131-db Please name the DTS file properly so the default DEVICE_DTS can be used (and the one in device definition dropped).

RE: Inconsistencies in include/image.mk

2021-06-03 Thread Adrian Schmutzler
FIX is a target-based, device-independent variable, so it should not be set based on a device-dependent PROFILE_something variable. Best Adrian > > The first part is how IMG_PREFIX is derived: > > IMG_PREFIX_EXTRA:=$(if $(EXTRA_IMAGE_NAME),$(call > sanitize,$(EXTRA_IMAGE_NAME)

RE: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-30 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Koen Vandeputte > Sent: Donnerstag, 27. Mai 2021 13:52 > To: Adrian Schmutzler ; 'Denis Kalashnikov' > ; openwrt-devel@lists.openwrt.org > Cc: &

RE: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-30 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Sergey Ryazanov > Sent: Montag, 24. Mai 2021 01:07 > To: Adrian Schmutzler ; Denis Kalashnikov > > Cc: OpenWrt Development List ; Gabor > Juhos ; Koen

RE: [PATCH v2] ath79: add support for Ubiquiti PowerBeam M (XW)

2021-05-27 Thread Adrian Schmutzler
r. I'm not sure whether we apply antenna gain for ath79 Ubiquiti _at all_ by default. (From what I remember we don't). So, I tend to not care about this for this particular PR. Best Adrian > > Best, > > Vincent > > > > On 5/23/21 1:59 PM, Russell Se

RE: [PATCH 2/2] octeon: add EdgeRouter Lite specific network config

2021-05-23 Thread Adrian Schmutzler
Hi again, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Adrian Schmutzler > Sent: Sonntag, 23. Mai 2021 12:05 > To: 'Stijn Segers' > Cc: openwrt-devel@lists.openwrt.org > Subject: RE: [PATCH 2

RE: [PATCH 2/2] octeon: add EdgeRouter Lite specific network config

2021-05-23 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Stijn Segers > Sent: Freitag, 8. Januar 2021 17:30 > To: Adrian Schmutzler > Cc: openwrt-devel@lists.openwrt.org > Subject: RE: [PATCH 2/2] octeon: add Edg

RE: [PATCH v2] octeon: rename erlite to ubnt,edgerouter-lite

2021-05-23 Thread Adrian Schmutzler
mage/Makefile > +++ b/target/linux/octeon/image/Makefile > @@ -71,6 +71,7 @@ define Device/ubnt_edgerouter-lite >DEVICE_MODEL := EdgeRouter Lite >BOARD_NAME := erlite >CMDLINE := $(ERLITE_CMDLINE) > +SUPPORTED_DEVICES := erlite ubnt,edgerouter-lite This can be simp

RE: [PATCH v3 2/2] ramips: mt7621: Add support for ZyXEL LTE3301-Plus

2021-05-23 Thread Adrian Schmutzler
/ramips/mt7621/base- > files/etc/board.d/03_gpio_switches b/target/linux/ramips/mt7621/base- > files/etc/board.d/03_gpio_switches > index ed728b07c4..4bf2aa37e0 100644 > --- a/target/linux/ramips/mt7621/base-files/etc/board.d/03_gpio_switches > +++ b/target/l

RE: [PATCH] ath79/zyxel_nbg6716: resize kernel partition to 6MiB and reenable again

2021-05-23 Thread Adrian Schmutzler
bg6716: resize kernel partition to 6MiB and > reenable again proper commit title requires just "ath79:" prefix, e.g. "ath79: increase ZyXEL NBG6716 kernel to 6M" ... Best Adrian > > The bootloader happily accepts this. > But devices need a fresh reinstall beca

RE: [PATCH] base-files: migrate old UCI network sections defining bridges

2021-05-23 Thread Adrian Schmutzler
he uci-defaults script are by design meant to be run only once and then deleted. We should either choose a "big" number for the uci-defaults file name, so the script is run _after_ the others and deals with custom config, or use some init.d/rc.d-based script instead that runs for ev

RE: Resize of ath79 / ZyXEL NBG6716 kernel partition

2021-05-23 Thread Adrian Schmutzler
there anything special about this device (or probably ath79/nand) that causes bigger kernel? Best Adrian > > But I'm afraid users will brick their device when doing a sysupgrade to the > new flash layout. > First time / in upgrade case it must be installed via manufacturer

RE: [RFC v2 3/3] ath79: add support for Mikrotik RouterBoard 912G

2021-05-23 Thread Adrian Schmutzler
compatible = "fairchild,74hc595"; > + gpio-controller; > + #gpio-cells = <2>; > + registers-number = <1>; > + reg = <1>; > + spi-max-frequency = <5000>; > + }; > +}; >

RE: [PATCH] ath79: add support for Ubiquiti PowerBeam M (XW)

2021-05-23 Thread Adrian Schmutzler
st place, so I don't count "There is no 'xm' powerbeam" as an argument :-) Best Adrian > > Specifications: > - Atheros AR9342 SoC > - 64 MB RAM > - 8 MB SPI flash > - 1x 10/100 Mbps Ethernet port, 24 Vdc PoE-in > - Power and LAN green LEDs > -

RE: [PATCH] ath79/zyxel_nbg6716: resize kernel partition to 6MiB and reenable again

2021-05-23 Thread Adrian Schmutzler
Hi again, >KERNEL := kernel-bin | append-dtb | uImage none | zyxel-buildkerneljffs | > \ > - check-size 4096k > - IMAGES := sysupgrade.tar sysupgrade-4M-Kernel.bin factory.bin > + check-size 6144k One should use (KERNEL_SIZE) here instead of a literal value

RE: [PATCH] ath79/zyxel_nbg6716: resize kernel partition to 6MiB and reenable again

2021-05-22 Thread Adrian Schmutzler
work, you will need to also set the compat_version _on device_ either with board.d or uci-default. In case of fresh install typically the uci-defaults method provides a better experience. Examples: board.d: https://github.com/openwrt/openwrt/blob/master/target/linux/kirkwood/base-files/etc/board.d/

RE: [PATCH 2/2] ramips: mt7621: Add support for ZyXEL LTE3301-Plus

2021-05-17 Thread Adrian Schmutzler
> the two settings. > I've got some questions here. > Personnally I use a special scripts for this modem, taking use of the > lte_power line. > I.E., reset the modem if it does not work anymore. > > So I do not want to set the GPIO alway to on. It should default to on, but

RE: [PATCH 2/2] ramips: mt7621: Add support for ZyXEL LTE3301-Plus

2021-05-15 Thread Adrian Schmutzler
ucidef_set_led_netdev "internet" "INTERNET" "green:wan" "wan" > ;; > +zyxel,lte3301-plus) > +ucidef_set_led_netdev "internet" "internet" > "$boardname:white:internet" "wwan0&qu

RE: [PATCH 4/4] ath79: add support of Mikrotik RouterBoard 91xG series

2021-05-08 Thread Adrian Schmutzler
Hi, nitpick, but if this is only for 912G, it should also say that in the commit title. Other comments below. > .../dts/ar9342_mikrotik_routerboard-912g.dts | 314 ++ > target/linux/ath79/image/mikrotik.mk | 9 + > .../base-files/etc/board.d/02_network | 2

RE: [PATCH] ipq40xx: add support for GL.iNet GL-B2200-EMMC

2021-05-08 Thread Adrian Schmutzler
[ -n "$BOOTLOADER" ]; then > + printf "Writing bootloader: " > + dd of="$OUTFILE" if="$BOOTLOADER" bs=512 seek=1 conv=notrunc > 2>/dev/null > + printf "Done\n&

RE: [PATCH 3/4] ath79: add NAND driver for Mikrotik RB91xG

2021-05-08 Thread Adrian Schmutzler
it > + * under the terms of the GNU General Public License version 2 as > +published > + * by the Free Software Foundation. > + */ If you create new files, please use SPDX license identifiers instead of this "long-but-incomplete" license plate. This of course also applies to the

RE: [PATCH 1/4] ath79: add MFD driver (NAND and GPIO) for Mikrotik RB91xG

2021-05-08 Thread Adrian Schmutzler
inux/ath79/files/drivers/mfd/rb91x-ngl.c > create mode 100644 target/linux/ath79/files/include/mfd/rb91x-ngl.h > create mode 100644 target/linux/ath79/patches-5.4/939-mikrotik- > rb91x.patch Please also take care of 5.10. Best Adrian > > diff --git a/target/linux/ath79/files/dri

RE: [PATCH] ipq806x: fix product_name of TP-Link AD7200

2021-05-03 Thread Adrian Schmutzler
accept firmware with "Talon" in the name. Please add the following line here: Fixes: 1a775a4fd033 ("ipq806x: add support for TP-Link Talon AD7200") Best Adrian > > Signed-off-by: Alex Henrie > --- > tools/firmware-utils/src/tplink-safeloader.c | 2 +- > 1 file ch

  1   2   3   4   5   6   7   8   9   10   >