Hi, > -----Original Message----- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Paul Fertser > Sent: Dienstag, 5. Oktober 2021 21:40 > To: openwrt-devel@lists.openwrt.org > Cc: Paul Fertser <fercer...@gmail.com> > Subject: [RFT 3/5] realtek: add non-PoE version of DGS-1210-10 F1
missing commit message, probably since it's RFT ... One remark below. > > Signed-off-by: Paul Fertser <fercer...@gmail.com> > --- > .../rtl8380_d-link_dgs-1210-10-f1.dts | 8 +++ > .../rtl8380_d-link_dgs-1210-10-f1.dtsi | 61 +++++++++++++++++++ > .../rtl8380_d-link_dgs-1210-10p-f1.dts | 60 +----------------- > target/linux/realtek/image/Makefile | 10 ++- > 4 files changed, 78 insertions(+), 61 deletions(-) create mode 100644 > target/linux/realtek/dts-5.10/rtl8380_d-link_dgs-1210-10-f1.dts > create mode 100644 target/linux/realtek/dts-5.10/rtl8380_d-link_dgs-1210- > 10-f1.dtsi > [...] > diff --git a/target/linux/realtek/image/Makefile > b/target/linux/realtek/image/Makefile > index c1e47f719f3a..903ad3815690 100644 > --- a/target/linux/realtek/image/Makefile > +++ b/target/linux/realtek/image/Makefile > @@ -53,11 +53,17 @@ define Device/d-link_dgs-1210 > DEVICE_VENDOR := D-Link > endef > > -define Device/d-link_dgs-1210-10p-f1 > +define Device/d-link_dgs-1210-10-f1 > $(Device/d-link_dgs-1210) > SOC := rtl8380 > - DEVICE_MODEL := DGS-1210-10P > + DEVICE_MODEL := DGS-1210-10 > DEVICE_VARIANT := F1 > +endef > +TARGET_DEVICES += d-link_dgs-1210-10-f1 > + > +define Device/d-link_dgs-1210-10p-f1 > + $(Device/d-link_dgs-1210-10-f1) > + DEVICE_MODEL := DGS-1210-10P Please do not derive one device from another. Derive only from nodes that are not a device themselves. In the specific case, it's probably best to just have the few variables twice and derive from dgs-1210. Best Adrian > SUPPORTED_DEVICES += d-link,dgs-1210-10p > DEVICE_PACKAGES += lua-rs232 > endef > -- > 2.17.1 > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel