Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic

2015-12-14 Thread Gert Doering
Hi, On Sun, Dec 13, 2015 at 04:20:03PM -0800, Fish Wang wrote: > Will do. However, I???m by no means a license expert. Based on Licensing > Terms page on MinGW???s website ([1], win32api), I believe the code I > stripped out of MinGW should be fine as long as a copy of the notice and its > lice

Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic

2015-12-14 Thread Fish Wang
, December 13, 2015 5:09 PM To: Fish Wang Cc: openvpn-devel@lists.sourceforge.net Subject: Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic Hi, On Sun, Dec 13, 2015 at 7:20 PM, Fish Wang mailto:fish.t...@gmail.com> > wrote: Will do. However, I’m by no means a lic

Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic

2015-12-14 Thread Selva Nair
Hi, On Sun, Dec 13, 2015 at 7:20 PM, Fish Wang wrote: > Will do. However, I’m by no means a license expert. Based on Licensing > Terms page on MinGW’s website ([1], win32api), I believe the code I > stripped out of MinGW should be fine as long as a copy of the notice and > its license [2] is inc

Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic

2015-12-14 Thread Fish Wang
ValdikSS's DNS leak fix platform agnostic Hi, On Thu, Dec 10, 2015 at 7:46 PM, Fish mailto:fish.t...@gmail.com> > wrote: Based on release/2.3 branch and ValdikSS's v9 patch, this patch is cross-compiled on Linux and tested on Windows XP/10. The VC project file is left untouched - you m

Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic

2015-12-13 Thread Selva Nair
Hi, On Thu, Dec 10, 2015 at 7:46 PM, Fish wrote: > Based on release/2.3 branch and ValdikSS's v9 patch, this patch is > cross-compiled on Linux and tested on Windows XP/10. The VC project file is > left untouched - you might want to add rpcrt4.lib to compile and link it > under > MSVC. > Builds

[Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic

2015-12-11 Thread Fish
Based on release/2.3 branch and ValdikSS's v9 patch, this patch is cross-compiled on Linux and tested on Windows XP/10. The VC project file is left untouched - you might want to add rpcrt4.lib to compile and link it under MSVC. Take ValdikSS's patch for "block-outside-dns" option and make it Windo

Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic

2015-12-11 Thread Selva Nair
Hi, The patch is mangled by mailer (added linebreaks etc.). Could you please resend using git send-email? While at it, one thing I noticed: On Thu, Dec 10, 2015 at 6:48 PM, Fish Wang wrote: > -#if _WIN32_WINNT >= 0x0600 >else if (streq (p[0], "block-outside-dns") && !p[1]) > { >

[Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic

2015-12-10 Thread Fish Wang
Based on release/2.3 branch and ValdikSS's v9 patch, this patch is cross-compiled on Linux and tested on Windows XP/10. The VC project file is left untouched - you might want to add rpcrt4.lib to compile and link it under MSVC. Take ValdikSS's patch for "block-outside-dns" option and make it Windo

Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic

2015-12-10 Thread Fish Wang
Hi Gert, A new patch will follow. Best, Fish -Original Message- From: Gert Doering [mailto:g...@greenie.muc.de] Sent: Thursday, December 10, 2015 12:56 AM To: Fish Wang Cc: openvpn-devel ; i...@valdikss.org.ru Subject: Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix pla

Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic

2015-12-10 Thread Gert Doering
Hi, On Wed, Dec 09, 2015 at 05:30:14PM -0800, Fish Wang wrote: > Based on release/2.3 branch, this patch is cross-compiled in MinGW and > tested on Windows XP/10. The VC project file is left untouched - you might > want to add rpcrt4.lib to compile and link it under MSVC. > > Also, I didn't figur

[Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic

2015-12-10 Thread Fish Wang
Based on release/2.3 branch, this patch is cross-compiled in MinGW and tested on Windows XP/10. The VC project file is left untouched - you might want to add rpcrt4.lib to compile and link it under MSVC. Also, I didn't figure out how to keep ValdikSS's authorship of his code in the patch (sorry :-