Hi, On Wed, Dec 09, 2015 at 05:30:14PM -0800, Fish Wang wrote: > Based on release/2.3 branch, this patch is cross-compiled in MinGW and > tested on Windows XP/10. The VC project file is left untouched - you might > want to add rpcrt4.lib to compile and link it under MSVC. > > Also, I didn't figure out how to keep ValdikSS's authorship of his code in > the patch (sorry :-( ). Definitely no expert in git... Maybe I should > generate a patch on top of his latest patch?
The latter is much better. Use git release/2.3, apply ValdikSS' v8 patch on
top of that, and then do your changes - that way, proper author attribution
is there, and we can see much easier what you changed. Right now this is
a long piece of code that differs only in a vew lines from "one of the
8 different patch versions from ValdikSS". Hard to review.
thanks,
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
