Hi all,
A minor suggestion: All those prototypes taken from mingw (32 or -w64?) may be better placed in new header file to be included only from win32.c -- -- preferably with a license matching the source (PD or ZPL?). Makes win32.c less cluttered as well. Will do. However, I’m by no means a license expert. Based on Licensing Terms page on MinGW’s website ([1], win32api), I believe the code I stripped out of MinGW should be fine as long as a copy of the notice and its license [2] is included. Please correct me if I’m wrong. Best, Fish [1] http://www.mingw.org/license [2] http://sourceforge.net/p/mingw/mingw-org-wsl/ci/21762bb4a1bd0c88c38eead03f59e8d994349e83/tree/LICENSE From: Selva Nair [mailto:selva.n...@gmail.com] Sent: Sunday, December 13, 2015 1:14 PM To: Fish <fish.t...@gmail.com> Cc: openvpn-devel@lists.sourceforge.net Subject: Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic Hi, On Thu, Dec 10, 2015 at 7:46 PM, Fish <fish.t...@gmail.com <mailto:fish.t...@gmail.com> > wrote: Based on release/2.3 branch and ValdikSS's v9 patch, this patch is cross-compiled on Linux and tested on Windows XP/10. The VC project file is left untouched - you might want to add rpcrt4.lib to compile and link it under MSVC. Builds on 2.3 out of the box (i.e., target WINXP). The implementation looks fine, and works on win7 and 10, but I've no XP machines for the crucial test. A minor suggestion: All those prototypes taken from mingw (32 or -w64?) may be better placed in new header file to be included only from win32.c -- -- preferably with a license matching the source (PD or ZPL?). Makes win32.c less cluttered as well. I'm not familiar with the policy of OpenVPN on license-related matters, though. Selva
