You are absolutely right, the code I grabbed is indeed from mingw-w64, not MinGW. Let me send out another patch with mingw-w64’s disclaimer soon. I’ll see what core people says about this patch.
Thanks! Best, Fish From: Selva Nair [mailto:selva.n...@gmail.com] Sent: Sunday, December 13, 2015 5:09 PM To: Fish Wang <fish.t...@gmail.com> Cc: openvpn-devel@lists.sourceforge.net Subject: Re: [Openvpn-devel] [PATCH] Make ValdikSS's DNS leak fix platform agnostic Hi, On Sun, Dec 13, 2015 at 7:20 PM, Fish Wang <fish.t...@gmail.com <mailto:fish.t...@gmail.com> > wrote: Will do. However, I’m by no means a license expert. Based on Licensing Terms page on MinGW’s website ([1], win32api), I believe the code I stripped out of MinGW should be fine as long as a copy of the notice and its license [2] is included. Please correct me if I’m wrong. I thought those headers are from the mingw-w64 (a different code base from mingw32).. Anyway, I did not mean to imply any licensing issues with extracting parts from mingw32 or mingw-w64 --- both have permissive licenses so there is no clash. However, some GPL projects have clear guidelines of how to incorporate code from other licenses. Personally I prefer to keep public domain code (and minor edits to it) in a separate file which clearly indicates its in PD with the original notice so that one wouldn't slap on a GPL header on it later. While some projects want all their additions to be GPL keeping the original in PD etc..(Fro example, see various practices disscussed in https://www.softwarefreedom.org/resources/2007/gpl-non-gpl-collaboration.pdf). Better wait for a core developer to comment on this.. Selva
