[Openvpn-devel] [XS] Change in openvpn[master]: Log setting DNS via NRPT

2025-08-01 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1126?usp=email to review the following change. Change subject: Log setting DNS via NRPT ..

[Openvpn-devel] [XS] Change in openvpn[master]: Fix wrong byte order of --dns server

2025-07-31 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1125?usp=email to review the following change. Change subject: Fix wrong byte order of --dns server ..

[Openvpn-devel] [XS] Change in openvpn[master]: Fix --dns options for TAP adapter

2025-07-31 Thread stipa (Code Review)
stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1120?usp=email ) Change subject: Fix --dns options for TAP adapter .. Patch Set 3: (1 comment) File src/openvpn/options.c: http://gerrit.openv

[Openvpn-devel] [S] Change in openvpn[master]: Fix DNS options duplication on PUSH_UPDATE

2025-07-31 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1121?usp=email to look at the new patch set (#3). Change subject: Fix DNS options duplication on PUSH

[Openvpn-devel] [S] Change in openvpn[master]: Fix DNS options duplication on PUSH_UPDATE

2025-07-31 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1121?usp=email ) Change subject: Fix DNS options duplication on PUSH_UPDATE

[Openvpn-devel] [S] Change in openvpn[master]: Fix DNS options duplication on PUSH_UPDATE

2025-07-31 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1121?usp=email to look at the new patch set (#2). Change subject: Fix DNS options duplication on PUSH_UPDATE

[Openvpn-devel] [S] Change in openvpn[master]: Fix DNS options duplication on PUSH_UPDATE

2025-07-31 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1121?usp=email to review the following change. Change subject: Fix DNS options duplication on PUSH_UPDATE

[Openvpn-devel] [XS] Change in openvpn[master]: Fix --dns options for TAP adapter

2025-07-31 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1120?usp=email to look at the new patch set (#2). The following approvals got outdated a

[Openvpn-devel] [XS] Change in openvpn[master]: Fix --dns options for TAP adapter

2025-07-31 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1120?usp=email to review the following change. Change subject: Fix --dns options for TAP adapter .

[Openvpn-devel] [S] Change in openvpn[master]: dco: only pass struct context to init function

2025-07-23 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1094?usp=email ) Change subject: dco: only pass struct context to init function .

[Openvpn-devel] [S] Change in openvpn[master]: Fix broken DHCP options

2025-07-18 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1090?usp=email to review the following change. Change subject: Fix broken DHCP options ...

[Openvpn-devel] [M] Change in openvpn[master]: dco: Add support for float notifications

2025-07-16 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos, ralf_lici. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email ) Change subject: dco: Add support for float notifications ..

[Openvpn-devel] [M] Change in openvpn[master]: dco: Add support for float notifications

2025-07-16 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos, ralf_lici. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email ) Change subject: dco: Add support for float notifications ...

[Openvpn-devel] [M] Change in openvpn[master]: dco: Add support for float notifications

2025-07-16 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos, ralf_lici. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email ) Change subject: dco: Add support for float notifications ...

[Openvpn-devel] [M] Change in openvpn[master]: dco: Add support for float notifications

2025-07-15 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos, ralf_lici. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email ) Change subject: dco: Add support for float notifications ..

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE message sender: enabling the server to send PUSH_UPDATE c...

2025-07-03 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, mrbff, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/869?usp=email ) Change subject: PUSH_UPDATE message sender: enabling the server to send PUSH_UPDATE control messages ...

[Openvpn-devel] [XS] Change in openvpn[master]: dns: create NRPT registry key if it doesn't exist

2025-06-26 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1069?usp=email ) Change subject: dns: create NRPT registry key if it doesn't exist .

[Openvpn-devel] [XS] Change in openvpn[master]: dns: create NRPT registry key if it doesn't exist

2025-06-26 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1069?usp=email ) Change subject: dns: create NRPT registry key if it doesn't exist .

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added update_option() function.

2025-06-15 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, mrbff, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/810?usp=email ) Change subject: PUSH_UPDATE: Added update_option() function. ...

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-27 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email ) Change subject: Changes.rst: Collect, fix, and improve entries for 2.7 release

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-27 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email ) Change subject: Changes.rst: Collect, fix, and improve entries for 2.7 release

[Openvpn-devel] [M] Change in openvpn[master]: Changes.rst: Collect, fix, and improve entries for 2.7 release

2025-05-27 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1032?usp=email ) Change subject: Changes.rst: Collect, fix, and improve entries for 2.7 release

[Openvpn-devel] [M] Change in openvpn[master]: win: match search domains when creating exclude rules

2025-05-20 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/905?usp=email ) Change subject: win: match search domains when creating exclude rules ..

[Openvpn-devel] [S] Change in openvpn[master]: win: fix collecting DNS exclude data

2025-05-20 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1028?usp=email ) Change subject: win: fix collecting DNS exclude data .. P

[Openvpn-devel] [M] Change in openvpn[master]: win: match search domains when creating exclude rules

2025-05-19 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/905?usp=email ) Change subject: win: match search domains when creating exclude rules ..

[Openvpn-devel] [L] Change in openvpn[master]: win: remove Wintun support

2025-05-13 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1021?usp=email ) Change subject: win: remove Wintun support .. Patch Set 2

[Openvpn-devel] [L] Change in openvpn[master]: win: remove Wintun support

2025-05-12 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1021?usp=email to review the following change. Change subject: win: remove Wintun support

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-05-01 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/904?usp=email ) Change subject: dns: deal with --dhcp-options when --dns is active .

[Openvpn-devel] [M] Change in openvpn[master]: win: create adapter on demand

2025-04-24 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos, selvanair. Hello flichtenheld, plaisthos, selvanair, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/943?usp=email to look at the new patch set (#3). Change subject: win: create adapter o

[Openvpn-devel] [M] Change in openvpn[master]: win: create adapter on demand

2025-04-24 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos, selvanair. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/943?usp=email ) Change subject: win: create adapter on demand .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: win: create adapter on demand

2025-04-24 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos, selvanair. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/943?usp=email ) Change subject: win: create adapter on demand .. Patch

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-04-23 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/904?usp=email ) Change subject: dns: deal with --dhcp-options when --dns is active .

[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

2025-04-23 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/904?usp=email ) Change subject: dns: deal with --dhcp-options when --dns is active .

[Openvpn-devel] [M] Change in openvpn[master]: win: refactor get_windows_version()

2025-04-18 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/944?usp=email to look at the new patch set (#3). Change subject: win: refactor get_windows_version() ...

[Openvpn-devel] [M] Change in openvpn[master]: win: refactor get_windows_version()

2025-04-18 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/944?usp=email to look at the new patch set (#2). Change subject: win: refactor get_windows_version() ...

[Openvpn-devel] [M] Change in openvpn[master]: win: refactor get_windows_version()

2025-04-18 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/944?usp=email to review the following change. Change subject: win: refactor get_windows_version()

[Openvpn-devel] [M] Change in openvpn[master]: win: create adapter on demand

2025-04-18 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/943?usp=email to look at the new patch set (#2). Change subject: win: create adapter on demand .

[Openvpn-devel] [M] Change in openvpn[master]: win: create adapter on demand

2025-04-18 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/943?usp=email to review the following change. Change subject: win: create adapter on demand ..

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/942?usp=email ) Change subject: ssl_openssl.c: Prevent potential double-free ...

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos, stipa. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/942?usp=email to look at the new patch set (#4). The following approvals got outdated an

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos, stipa. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/942?usp=email to look at the new patch set (#3). Change subject: ssl_openssl.c: Prevent

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos, stipa. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/942?usp=email to look at the new patch set (#2). The following approvals got outdated an

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/942?usp=email ) Change subject: ssl_openssl.c: Prevent potential double-free ...

[Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c: Prevent potential double-free

2025-04-17 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/942?usp=email to review the following change. Change subject: ssl_openssl.c: Prevent potential double-free ...

[Openvpn-devel] [S] Change in openvpn[master]: win: allow OpenVPN service account to use any command-line options

2025-04-15 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/906?usp=email to look at the new patch set (#3). Change subject: win: allow OpenVPN service account to use a

[Openvpn-devel] [XS] Change in openvpn[master]: Remove UINT8_MAX definition

2025-04-15 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/940?usp=email to review the following change. Change subject: Remove UINT8_MAX definition

[Openvpn-devel] [S] Change in openvpn[master]: win: allow OpenVPN service account to use any command-line options

2025-04-15 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/906?usp=email to look at the new patch set (#4). Change subject: win: allow OpenVPN service account to use a

[Openvpn-devel] [S] Change in openvpn[master]: win: allow OpenVPN service account to use any command-line options

2025-04-15 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/906?usp=email to look at the new patch set (#2). Change subject: win: allow OpenVPN service account to use a

[Openvpn-devel] [S] Change in openvpn[master]: Fix dco_win and multisocket interaction

2025-04-10 Thread stipa (Code Review)
Attention is currently required from: its_Giaan, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/935?usp=email ) Change subject: Fix dco_win and multisocket interaction .. Patch Set

[Openvpn-devel] [S] Change in openvpn[master]: Fix dco_win and multisocket interaction

2025-04-09 Thread stipa (Code Review)
Attention is currently required from: its_Giaan, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/935?usp=email ) Change subject: Fix dco_win and multisocket interaction .. Patch Set

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT

2025-04-09 Thread stipa (Code Review)
Attention is currently required from: d12fk, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support with NRPT .. Patch S

[Openvpn-devel] [S] Change in openvpn[master]: Fix dco_win and multisocket interaction

2025-04-09 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/935?usp=email ) Change subject: Fix dco_win and multisocket interaction

[Openvpn-devel] [S] Change in openvpn[master]: Fix dco_win and multisocket interaction

2025-04-09 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/935?usp=email ) Change subject: Fix dco_win and multisocket interaction

[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco-win: Ensure correct OVERLAPPED scope

2025-04-05 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/933?usp=email to review the following change. Change subject: dco-win: Ensure correct OVERLAPPED scope ...

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-04-05 Thread stipa (Code Review)
Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/840?usp=email ) Change subject: dns: don't publish env vars to non-dns scripts ..

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: Fix crash when cancelling pending operation

2025-04-01 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/928?usp=email to review the following change. Change subject: dco-win: Fix crash when cancelling pending opera

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT

2025-03-27 Thread stipa (Code Review)
Attention is currently required from: d12fk, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support with NRPT .. Patch S

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT

2025-03-26 Thread stipa (Code Review)
Attention is currently required from: d12fk, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support with NRPT .. Patch S

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT

2025-03-21 Thread stipa (Code Review)
Attention is currently required from: d12fk, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support with NRPT .. Patch S

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT

2025-03-19 Thread stipa (Code Review)
Attention is currently required from: d12fk, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support with NRPT .. Patch S

[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Clean up use of TEXT() from DNS patches

2025-03-18 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/910?usp=email ) Change subject: openvpnserv: Clean up use of TEXT() from DNS patches ..

[Openvpn-devel] [S] Change in openvpn[master]: win: allow OpenVPN service account to use any command-line options

2025-03-12 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/906?usp=email to review the following change. Change subject: win: allow OpenVPN service account to use any co

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2025-03-09 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [M] Change in openvpn[master]: Make recursive routing check more fine-grained

2025-03-07 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/903?usp=email ) Change subject: Make recursive routing check more fine-grained .

[Openvpn-devel] [M] Change in openvpn[master]: Make recursive routing check more fine-grained

2025-03-06 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/903?usp=email to look at the new patch set (#2). Change subject: Make recursive routing check

[Openvpn-devel] [M] Change in openvpn[master]: Make recursive routing check more fine-grained

2025-03-06 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/903?usp=email ) Change subject: Make recursive routing check more fine-grained .

[Openvpn-devel] [M] Change in openvpn[master]: Make recursive routing check more fine-grained

2025-03-06 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/903?usp=email to review the following change. Change subject: Make recursive routing check more fine-grained .

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2025-03-05 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: kernel notifications

2025-02-20 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/816?usp=email ) Change subject: dco-win: kernel notifications .. Patch Set

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: kernel notifications

2025-02-20 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/816?usp=email to look at the new patch set (#21). The following approvals got outdated a

[Openvpn-devel] [XS] Change in openvpn[master]: dco-win: simplify control packets prepend code

2025-02-19 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/900?usp=email to review the following change. Change subject: dco-win: simplify control packets prepend code .

[Openvpn-devel] [L] Change in openvpn[master]: dco-win: multipeer support

2025-02-19 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/815?usp=email ) Change subject: dco-win: multipeer support .. Patch Set 20

[Openvpn-devel] [M] Change in openvpn[master]: Implement override-username

2025-02-17 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/872?usp=email ) Change subject: Implement override-username .. Patch Set 5: (1 c

[Openvpn-devel] [M] Change in openvpn[master]: Implement override-username

2025-02-13 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/872?usp=email ) Change subject: Implement override-username .. Patch Set 5: (2 c

[Openvpn-devel] [L] Change in openvpn[master]: dco-win: multipeer support

2025-02-13 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/815?usp=email to look at the new patch set (#20). Change subject: dco-win: multipeer support .

[Openvpn-devel] [L] Change in openvpn[master]: dco-win: multipeer support

2025-02-06 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/815?usp=email ) Change subject: dco-win: multipeer support .. Patch Set 19

[Openvpn-devel] [L] Change in openvpn[master]: dco-win: multipeer support

2025-02-06 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/815?usp=email to look at the new patch set (#19). The following approvals got outdated a

[Openvpn-devel] [L] Change in openvpn[master]: dco-win: multipeer support

2025-02-06 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/815?usp=email ) Change subject: dco-win: multipeer support .. Patch Set 19

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: kernel notifications

2025-02-06 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/816?usp=email to look at the new patch set (#19). Change subject: dco-win: kernel notifications

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: disable dco in server mode if multiple --local options defined

2025-02-05 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/885?usp=email to look at the new patch set (#2). The following approvals got outdated an

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: disable dco in server mode if multiple --local options defined

2025-02-05 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/885?usp=email to review the following change. Change subject: dco-win: disable dco in server mode if multiple

[Openvpn-devel] [M] Change in openvpn[master]: route.c: improve get_default_gateway() logic on Windows

2025-01-31 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/879?usp=email to look at the new patch set (#5). Change subject: route.c: improve get_default_

[Openvpn-devel] [M] Change in openvpn[master]: route.c: improve get_default_gateway() logic on Windows

2025-01-31 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/879?usp=email to look at the new patch set (#4). Change subject: route.c: improve get_default_

[Openvpn-devel] [M] Change in openvpn[master]: route.c: improve get_default_gateway() logic on Windows

2025-01-31 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/879?usp=email ) Change subject: route.c: improve get_default_gateway() logic on Windows

[Openvpn-devel] [M] Change in openvpn[master]: route.c: improve get_default_gateway() logic on Windows

2025-01-31 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/879?usp=email to look at the new patch set (#3). The following approvals got outdated an

[Openvpn-devel] [XS] Change in openvpn[master]: mudp.c: keep offset value when resetting buffer

2025-01-30 Thread stipa (Code Review)
Attention is currently required from: ordex, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/814?usp=email ) Change subject: mudp.c: keep offset value when resetting buffer .. Patch

[Openvpn-devel] [XS] Change in openvpn[master]: mudp.c: keep offset value when resetting buffer

2025-01-30 Thread stipa (Code Review)
Attention is currently required from: plaisthos, stipa. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/814?usp=email to look at the new patch set (#12). The change is no longer submittable: checks~ChecksSubmitRule is un

[Openvpn-devel] [S] Change in openvpn[master]: options: add IPv4 support to '--show-gateway '

2025-01-29 Thread stipa (Code Review)
Attention is currently required from: cron2, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/881?usp=email ) Change subject: options: add IPv4 support to '--show-gateway ' .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: route.c: improve get_default_gateway() logic on Windows

2025-01-29 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/879?usp=email to look at the new patch set (#2). Change subject: route.c: improve get_default_gateway() logi

[Openvpn-devel] [S] Change in openvpn[master]: options: add IPv4 support to '--show-gateway '

2025-01-29 Thread stipa (Code Review)
Attention is currently required from: cron2, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/881?usp=email ) Change subject: options: add IPv4 support to '--show-gateway ' .. Patch

[Openvpn-devel] [S] Change in openvpn[master]: options: add IPv4 support to '--show-gateway '

2025-01-29 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/881?usp=email ) Change subject: options: add IPv4 support to '--show-gateway ' .

[Openvpn-devel] [S] Change in openvpn[master]: route.c: change the signature of get_default_gateway()

2025-01-28 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/878?usp=email to review the following change. Change subject: route.c: change the signature of get_default_gat

[Openvpn-devel] [M] Change in openvpn[master]: route.c: improve get_default_gateway() logic on Windows

2025-01-28 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/879?usp=email to review the following change. Change subject: route.c: improve get_default_gateway() logic on

[Openvpn-devel] [XS] Change in openvpn[master]: mudp.c: keep offset value when resetting buffer

2025-01-27 Thread stipa (Code Review)
Attention is currently required from: plaisthos, stipa. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/814?usp=email to look at the new patch set (#11). The change is no longer submittable: checks~ChecksSubmitRule is un

[Openvpn-devel] [L] Change in openvpn[master]: Apply text-removal.sh script to Windows codebase

2025-01-27 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/853?usp=email ) Change subject: Apply text-removal.sh script to Windows codebase ..

[Openvpn-devel] [M] Change in openvpn[master]: Post tchar.h removal cleanup

2025-01-27 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/854?usp=email ) Change subject: Post tchar.h removal cleanup .. Patch Set 2: Code

[Openvpn-devel] [S] Change in openvpn[master]: openvpnserv: Fix some inconsistent usages of TEXT()

2025-01-27 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/851?usp=email ) Change subject: openvpnserv: Fix some inconsistent usages of TEXT() ...

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: add SET_MODE ioctl call

2025-01-23 Thread stipa (Code Review)
stipa has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/734?usp=email ) Change subject: dco-win: add SET_MODE ioctl call .. Abandoned -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/734?usp=email To uns

[Openvpn-devel] [M] Change in openvpn[master]: dco-win: support for data_v3 features

2025-01-23 Thread stipa (Code Review)
stipa has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/725?usp=email ) Change subject: dco-win: support for data_v3 features .. Abandoned -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/725?usp=email T

[Openvpn-devel] [L] Change in openvpn[master]: dco-win: multipeer support

2025-01-23 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/815?usp=email to look at the new patch set (#12). Change subject: dco-win: multipeer support ...

  1   2   3   >