Attention is currently required from: flichtenheld, plaisthos, selvanair. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/943?usp=email )
Change subject: win: create adapter on demand ...................................................................... Patch Set 2: (2 comments) File src/openvpn/tun.c: http://gerrit.openvpn.net/c/openvpn/+/943/comment/4f2d37c4_06eedd41 : PS2, Line 6656: struct device_instance_id_interface *device_instance_id_interface = get_device_instance_id_interface(gc); > right, the data is const, but not the pointer. Acknowledged http://gerrit.openvpn.net/c/openvpn/+/943/comment/9ce6ddd6_a5306ffa : PS2, Line 6707: if (adapter_created || (h && !do_create_adapter_service(h, tt->backend_driver))) > I think we need not limit this using the adapter_created flag. […] Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/943?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I621d44ec6b0facc524875c15ddfd11ec47b06c15 Gerrit-Change-Number: 943 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: selvanair <selva.n...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: selvanair <selva.n...@gmail.com> Gerrit-Comment-Date: Thu, 24 Apr 2025 06:58:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: selvanair <selva.n...@gmail.com> Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel