Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1021?usp=email )
Change subject: win: remove Wintun support ...................................................................... Patch Set 2: (3 comments) File include/openvpn-msg.h: http://gerrit.openvpn.net/c/openvpn/+/1021/comment/8f9f9442_c5569e1b : PS2, Line 47: msg_register_ring_buffers, > I am a bit worried about taking out message number enums, leading to testing > challenges when having […] Done File src/openvpn/forward.h: http://gerrit.openvpn.net/c/openvpn/+/1021/comment/0d807ff9_8c3bd023 : PS2, Line 406: } > is that related to wintun? ("it does not say so, and I'm not aware of the > origins of this code") Yes, this is from "wintun: ring buffers based I/O" patch https://github.com/OpenVPN/openvpn/commit/d5fc4bd41616ee01816df873cb6b6567872a29e2#diff-b955244e0fcf190f9a22548de16381cac34b6efaad20300d7a04c5691cd1017aR382-R412 File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/1021/comment/ab5875dc_3a7846ca : PS2, Line 2230: } > this is similar to the thing in `forward. […] This is from "wintun: ring buffers based I/O" patch https://github.com/OpenVPN/openvpn/commit/d5fc4bd41616ee01816df873cb6b6567872a29e2#diff-b955244e0fcf190f9a22548de16381cac34b6efaad20300d7a04c5691cd1017aL406 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1021?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I43ec390040bffeec05270271ea7fb54fb219c536 Gerrit-Change-Number: 1021 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 13 May 2025 14:25:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
