Attention is currently required from: d12fk, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email )
Change subject: win: implement --dns option support with NRPT ...................................................................... Patch Set 14: -Code-Review (3 comments) Patchset: PS14: Is split-dns already supposed to work? In my server config I have push "dns server 1 resolve-domains fi" push "dns server 1 address 1.1.1.1" push "dns server 2 resolve-domains io" push "dns server 2 address 8.8.8.8" so I would expect .fi go to 1.1.1.1 and .io to 8.8.8.8, but instead only one registry entry .fi is created with 1.1.1.1. Also, with that push "dns server 1 resolve-domains fi" push "dns server 1 address 1.1.1.1" in addition to NRPT we set 1.1.1.1 on VPN adapter and many DNS requests not directed to .fi domains also resolved via 1.1.1.1. This contradicts to what documentation says: "where only the given domains are resolved by the server". File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/837/comment/8e6ebec0_a562e6ce : PS14, Line 2259: MsgToEventLog(M_SYSERR, TEXT("IsInterfaceConnected: " At least on my machine I have 6 "real" network adapters (according to Get-NetAdapter | Format-List Name, InterfaceGuid) and 12 registry keys, apparently those are disabled/hidden etc. Because of that I got lots of scary "IsInterfaceConnected: could not convert interface {F2D72071-CB76-4D6F-9DC8-EDAA3AC6B387} GUID to LUID" messages. Let's don't display this error message - at least if ConvertInterfaceGuidToLuid returns ERROR_INVALID_PARAMETER. http://gerrit.openvpn.net/c/openvpn/+/837/comment/427ad111_8562738a : PS14, Line 2510: for (int i = 0; i < _countof(data); ++i) Does it really make sense to create keys for all adapters, even if there are no domains/servers defined? Could we do it only if there are adapter-specific domains defined? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/837?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5adbebaaf209cc Gerrit-Change-Number: 837 Gerrit-PatchSet: 14 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Fri, 21 Mar 2025 14:09:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
