Attention is currently required from: d12fk, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email )
Change subject: win: implement --dns option support with NRPT ...................................................................... Patch Set 14: (2 comments) File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/837/comment/b879805b_55fa9a7f : PS14, Line 2259: MsgToEventLog(M_SYSERR, TEXT("IsInterfaceConnected: " > Hm, I do not have adapters I can reproduce this on my system. […] Sure. In my case it is probably Hyper-V virtual adapters. https://gist.github.com/lstipakov/b30a662ab8001d4a07ddda7406808eb5 Again, I think it is fine just to omit error message in this error case. http://gerrit.openvpn.net/c/openvpn/+/837/comment/a11626e1_0dcbd6ed : PS14, Line 2510: for (int i = 0; i < _countof(data); ++i) > Yeah, if no domains or nameservers are defined the adapters are not added as > exclude data, so there […] But there are: https://usercontent.irccloud-cdn.com/file/eJy2zlR6/image.png -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/837?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5adbebaaf209cc Gerrit-Change-Number: 837 Gerrit-PatchSet: 14 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Wed, 26 Mar 2025 08:55:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: d12fk <he...@openvpn.net> Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
