[Openvpn-devel] [S] Change in openvpn[master]: Use mbedtls_ssl_export_keying_material()

2025-05-27 Thread MaxF (Code Review)
Attention is currently required from: MaxF, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1041?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed

[Openvpn-devel] [S] Change in openvpn[master]: mbedtls: Allow TLS 1.3 if available

2025-05-27 Thread MaxF (Code Review)
Attention is currently required from: MaxF, flichtenheld. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1042?usp=email to look at the new patch set (#3). Change subject: mbedtls: Allow TLS 1.3 if available ...

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-27 Thread MaxF (Code Review)
Attention is currently required from: MaxF, cron2, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email to look at the new patch set (#3). Change subject: Remove HAVE_EXPORT_KEYING_MATERIAL m

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-23 Thread MaxF (Code Review)
Attention is currently required from: MaxF, cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email to look at the new patch set (#2). The following approvals got outdated an

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-23 Thread MaxF (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email ) Change subject: Remove HAVE_EXPORT_KEYING_MATERIAL macro ..

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-23 Thread MaxF (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email ) Change subject: Remove HAVE_EXPORT_KEYING_MATERIAL macro ..

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-22 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email to review the following change. Change subject: Remove HAVE_EXPORT_KEYING_MATERIAL macro ..

[Openvpn-devel] [M] Change in openvpn[master]: Use mbedtls_ssl_export_keying_material()

2025-05-22 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1041?usp=email ) Change subject: Use mbedtls_ssl_export_keying_material() .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: Use mbedtls_ssl_export_keying_material()

2025-05-21 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1041?usp=email to look at the new patch set (#2). Change subject: Use mbedtls_ssl_export_keying_material() .

[Openvpn-devel] [S] Change in openvpn[master]: mbedtls: Allow TLS 1.3 if available

2025-05-21 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1042?usp=email to look at the new patch set (#2). Change subject: mbedtls: Allow TLS 1.3 if available ..

[Openvpn-devel] [S] Change in openvpn[master]: mbedtls: Allow TLS 1.3 if available

2025-05-20 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1042?usp=email to review the following change. Change subject: mbedtls: Allow TLS 1.3 if available ...

[Openvpn-devel] [M] Change in openvpn[master]: Use mbedtls_ssl_export_keying_material()

2025-05-20 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1041?usp=email to review the following change. Change subject: Use mbedtls_ssl_export_keying_material() ..

[Openvpn-devel] [XS] Change in openvpn[master]: Fix compatibility with mbedTLS 2.28.10+ and 3.6.3+

2025-04-05 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/918?usp=email ) Change subject: Fix compatibility with mbedTLS 2.28.10+ and 3.6.3+ .. Patch S

[Openvpn-devel] [XS] Change in openvpn[master]: Fix mbed TLS key exporter functionality in 3.6.x and cmake

2025-03-27 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/920?usp=email ) Change subject: Fix mbed TLS key exporter functionality in 3.6.x and cmake .

[Openvpn-devel] [XS] Change in openvpn[master]: Fix mbed TLS key exporter functionality in 3.6.x and cmake

2025-03-27 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/920?usp=email ) Change subject: Fix mbed TLS key exporter functionality in 3.6.x and cmake .

[Openvpn-devel] [S] Change in openvpn[master]: Do not leave half-initialised key wrap struct when dynamic tls-crypt ...

2025-03-27 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/921?usp=email ) Change subject: Do not leave half-initialised key wrap struct when dynamic tls-crypt fails

[Openvpn-devel] [XS] Change in openvpn[master]: Fix compatibility with mbedTLS 2.28.10+ and 3.6.3+

2025-03-27 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/918?usp=email ) Change subject: Fix compatibility with mbedTLS 2.28.10+ and 3.6.3+ .

[Openvpn-devel] [XS] Change in openvpn[master]: Fix compatibility with mbedTLS 2.28.10+ and 3.6.3+

2025-03-26 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/918?usp=email ) Change subject: Fix compatibility with mbedTLS 2.28.10+ and 3.6.3+ .. Patch S

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down script with privsep

2025-03-05 Thread MaxF (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/839?usp=email ) Change subject: dns: support running up/down script with privsep

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down script with privsep

2025-03-04 Thread MaxF (Code Review)
Attention is currently required from: d12fk, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/839?usp=email ) Change subject: dns: support running up/down script with privsep .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: Extend the unit test for data channel packets with aead limit tests

2025-02-13 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/868?usp=email ) Change subject: Extend the unit test for data channel packets with aead limit tests ...

[Openvpn-devel] [L] Change in openvpn[master]: Implement epoch key data format

2025-02-12 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/806?usp=email ) Change subject: Implement epoch key data format .. Patch Set 19: C

[Openvpn-devel] [L] Change in openvpn[master]: Implement epoch key data format

2025-02-05 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/806?usp=email ) Change subject: Implement epoch key data format .. Patch Set 18:

[Openvpn-devel] [M] Change in openvpn[master]: Extend the unit test for data channel packets with aead limit tests

2025-01-29 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/868?usp=email ) Change subject: Extend the unit test for data channel packets with aead limit tests ...

[Openvpn-devel] [S] Change in openvpn[master]: Rename aead-tag-at-end to aead-epoch

2025-01-09 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/805?usp=email ) Change subject: Rename aead-tag-at-end to aead-epoch .. Patch Set

[Openvpn-devel] [M] Change in openvpn[master]: Add methods to read/write packet ids for epoch data

2025-01-09 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/803?usp=email ) Change subject: Add methods to read/write packet ids for epoch data .

[Openvpn-devel] [S] Change in openvpn[master]: Do not attempt to decrypt packets anymore after 2**36 failed decryptions

2025-01-09 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/843?usp=email ) Change subject: Do not attempt to decrypt packets anymore after 2**36 failed decryptions ..

[Openvpn-devel] [L] Change in openvpn[master]: Implement methods to generate and manage OpenVPN Epoch keys

2025-01-09 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/804?usp=email ) Change subject: Implement methods to generate and manage OpenVPN Epoch keys

[Openvpn-devel] [L] Change in openvpn[master]: Implement methods to generate and manage OpenVPN Epoch keys

2024-12-28 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/804?usp=email ) Change subject: Implement methods to generate and manage OpenVPN Epoch keys

[Openvpn-devel] [L] Change in openvpn[master]: Implement methods to generate and manage OpenVPN Epoch keys

2024-12-28 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/804?usp=email ) Change subject: Implement methods to generate and manage OpenVPN Epoch keys

[Openvpn-devel] [S] Change in openvpn[master]: Do not attempt to decrypt packets anymore after 2**36 failed decryptions

2024-12-27 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/843?usp=email ) Change subject: Do not attempt to decrypt packets anymore after 2**36 failed decryptions ..

[Openvpn-devel] [S] Change in openvpn[master]: Do not attempt to decrypt packets anymore after 2**36 failed decryptions

2024-12-27 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/843?usp=email ) Change subject: Do not attempt to decrypt packets anymore after 2**36 failed decryptions ..

[Openvpn-devel] [M] Change in openvpn[master]: Add methods to read/write packet ids for epoch data

2024-12-27 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/803?usp=email ) Change subject: Add methods to read/write packet ids for epoch data .

[Openvpn-devel] [M] Change in openvpn[master]: Add methods to read/write packet ids for epoch data

2024-12-27 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/803?usp=email ) Change subject: Add methods to read/write packet ids for epoch data .

[Openvpn-devel] [M] Change in openvpn[master]: Use XOR instead of concatenation for calculation of IV from implicit IV

2024-12-11 Thread MaxF (Code Review)
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/797?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Use XOR instead of concatenation for

[Openvpn-devel] [M] Change in openvpn[master]: Use XOR instead of concatenation for calculation of IV from implicit IV

2024-12-09 Thread MaxF (Code Review)
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/797?usp=email ) Change subject: Use XOR instead of concatenation for calculation of IV from implicit IV

[Openvpn-devel] [M] Change in openvpn[master]: Trigger renegotiation of data key if getting close to the AEAD usage ...

2024-12-03 Thread MaxF (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/796?usp=email ) Change subject: Trigger renegotiation of data key if getting close to the AEAD usage limit .

[Openvpn-devel] [M] Change in openvpn[master]: Trigger renegotiation of data key if getting close to the AEAD usage ...

2024-12-02 Thread MaxF (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/796?usp=email ) Change subject: Trigger renegotiation of data key if getting close to the AEAD usage limit .

[Openvpn-devel] [L] Change in openvpn[master]: Implement HKDF expand function based on RFC 8446

2024-12-02 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/798?usp=email ) Change subject: Implement HKDF expand function based on RFC 8446 ..

[Openvpn-devel] [M] Change in openvpn[master]: Trigger renegotiation of data key if getting close to the AEAD usage ...

2024-11-29 Thread MaxF (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/796?usp=email ) Change subject: Trigger renegotiation of data key if getting close to the AEAD usage limit .

[Openvpn-devel] [L] Change in openvpn[master]: Implement HKDF expand function based on RFC 8446

2024-11-24 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/798?usp=email ) Change subject: Implement HKDF expand function based on RFC 8446 ..

[Openvpn-devel] [L] Change in openvpn[master]: Implement HKDF expand function based on RFC 8446

2024-11-22 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/798?usp=email ) Change subject: Implement HKDF expand function based on RFC 8446 ..

[Openvpn-devel] [L] Change in openvpn[master]: Implement HKDF expand function based on RFC 8446

2024-11-20 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/798?usp=email ) Change subject: Implement HKDF expand function based on RFC 8446 ..

[Openvpn-devel] [L] Change in openvpn[master]: Implement HKDF expand function based on RFC 8446

2024-11-20 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/798?usp=email ) Change subject: Implement HKDF expand function based on RFC 8446 ..

[Openvpn-devel] [L] Change in openvpn[master]: Implement HKDF expand function based on RFC 8446

2024-11-20 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/798?usp=email ) Change subject: Implement HKDF expand function based on RFC 8446 ..

[Openvpn-devel] [S] Change in openvpn[master]: Improve data channel crypto error messages

2024-10-16 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos, syzzer. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/774?usp=email ) Change subject: Improve data channel crypto error messages .

[Openvpn-devel] [L] Change in openvpn[master]: Add siphash reference implementation

2024-09-22 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/29?usp=email ) Change subject: Add siphash reference implementation .. Patch Set 6

[Openvpn-devel] [XL] Change in openvpn[master]: Implement initial packet reflection protection using bloom filter

2024-09-21 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/30?usp=email ) Change subject: Implement initial packet reflection protection using bloom filter ..

[Openvpn-devel] [S] Change in openvpn[master]: Check that tls-version-min is supported on startup

2024-07-03 Thread MaxF (Code Review)
MaxF has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/683?usp=email ) Change subject: Check that tls-version-min is supported on startup .. Abandoned Superseded by https://gerrit.openvpn.net/c/openvpn/+/684 -

[Openvpn-devel] [S] Change in openvpn[master]: Check that tls-version-min is supported on startup

2024-07-03 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/683?usp=email ) Change subject: Check that tls-version-min is supported on startup .

[Openvpn-devel] [XS] Change in openvpn[master]: mbedtls: Warn if --tls-version-min is too low

2024-07-03 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/684?usp=email to review the following change. Change subject: mbedtls: Warn if --tls-version-min is too low ..

[Openvpn-devel] [S] Change in openvpn[master]: Check that tls-version-min is supported on startup

2024-06-19 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/683?usp=email to review the following change. Change subject: Check that tls-version-min is supported on start

[Openvpn-devel] [M] Change in openvpn[master]: Fix MBEDTLS_DEPRECATED_REMOVED build errors

2024-06-18 Thread MaxF (Code Review)
MaxF has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/681?usp=email ) Change subject: Fix MBEDTLS_DEPRECATED_REMOVED build errors .. Fix MBEDTLS_DEPRECATED_REMOVED build errors This commit allows compiling Ope

[Openvpn-devel] [S] Change in openvpn[master]: mbedtls: Remove support for old TLS versions

2024-06-18 Thread MaxF (Code Review)
MaxF has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/682?usp=email ) Change subject: mbedtls: Remove support for old TLS versions .. mbedtls: Remove support for old TLS versions Recent versions of mbedtls hav

[Openvpn-devel] [S] Change in openvpn[master]: mbedtls: Remove support for old TLS versions

2024-06-14 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/682?usp=email to look at the new patch set (#2). Change subject: mbedtls: Remove support for old TLS version

[Openvpn-devel] [M] Change in openvpn[master]: Fix MBEDTLS_DEPRECATED_REMOVED build errors

2024-06-14 Thread MaxF (Code Review)
Attention is currently required from: MaxF, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/681?usp=email to look at the new patch set (#4). Change subject: Fix MBEDTLS_DEPRECATED_REMOVED build

[Openvpn-devel] [M] Change in openvpn[master]: Fix MBEDTLS_DEPRECATED_REMOVED build errors

2024-06-14 Thread MaxF (Code Review)
Attention is currently required from: MaxF, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/681?usp=email to look at the new patch set (#3). Change subject: Fix MBEDTLS_DEPRECATED_REMOVED build

[Openvpn-devel] [S] Change in openvpn[master]: mbedtls: Remove support for old TLS versions

2024-06-14 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/682?usp=email to review the following change. Change subject: mbedtls: Remove support for old TLS versions ...

[Openvpn-devel] [M] Change in openvpn[master]: Fix MBEDTLS_DEPRECATED_REMOVED build errors

2024-06-14 Thread MaxF (Code Review)
Attention is currently required from: MaxF, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/681?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed:

[Openvpn-devel] [M] Change in openvpn[master]: Fix MBEDTLS_DEPRECATED_REMOVED build errors

2024-06-13 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/681?usp=email ) Change subject: Fix MBEDTLS_DEPRECATED_REMOVED build errors .. Pat

[Openvpn-devel] [M] Change in openvpn[master]: Fix MBEDTLS_DEPRECATED_REMOVED build errors

2024-06-13 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/681?usp=email ) Change subject: Fix MBEDTLS_DEPRECATED_REMOVED build errors .. Pat

[Openvpn-devel] [M] Change in openvpn[master]: Fix MBEDTLS_DEPRECATED_REMOVED build errors

2024-06-13 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/681?usp=email to review the following change. Change subject: Fix MBEDTLS_DEPRECATED_REMOVED build errors

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Remove license warning from README.mbedtls

2024-03-13 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/562?usp=email to review the following change. Change subject: Remove license warning from README.mbedtls .

[Openvpn-devel] [S] Change in openvpn[master]: Remove license warning from README.mbedtls

2024-03-13 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/561?usp=email to review the following change. Change subject: Remove license warning from README.mbedtls .

[Openvpn-devel] [L] Change in openvpn[release/2.6]: Backport mbed TLS 3 support to OpenVPN 2.6

2023-11-20 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/404?usp=email to review the following change. Change subject: Backport mbed TLS 3 support to OpenVPN 2.6 .

[Openvpn-devel] [S] Change in openvpn[master]: Disable TLS 1.3 support with mbed TLS

2023-11-15 Thread MaxF (Code Review)
Attention is currently required from: MaxF, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/403?usp=email to look at the new patch set (#5). The change is no longer submittable: checks~ChecksSubmitRule is unsa

[Openvpn-devel] [M] Change in openvpn[master]: Enable key export with mbed TLS 3.x.y

2023-11-13 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/402?usp=email ) Change subject: Enable key export with mbed TLS 3.x.y .. Patch Set

[Openvpn-devel] [M] Change in openvpn[master]: Enable key export with mbed TLS 3.x.y

2023-11-13 Thread MaxF (Code Review)
Attention is currently required from: MaxF, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/402?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed:

[Openvpn-devel] [S] Change in openvpn[master]: Disable TLS 1.3 support with mbed TLS

2023-11-13 Thread MaxF (Code Review)
Attention is currently required from: MaxF, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/403?usp=email to look at the new patch set (#4). The change is no longer submittable: checks~ChecksSubmitRule is unsa

[Openvpn-devel] [M] Change in openvpn[master]: Enable key export with mbed TLS 3.x.y

2023-11-13 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/402?usp=email ) Change subject: Enable key export with mbed TLS 3.x.y .. Patch Set

[Openvpn-devel] [M] Change in openvpn[master]: Enable key export with mbed TLS 3.x.y

2023-11-13 Thread MaxF (Code Review)
Attention is currently required from: MaxF, flichtenheld. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/402?usp=email to look at the new patch set (#2). Change subject: Enable key export with mbed TLS 3.x.y ..

[Openvpn-devel] [S] Change in openvpn[master]: Disable TLS 1.3 support with mbed TLS

2023-11-10 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/403?usp=email to review the following change. Change subject: Disable TLS 1.3 support with mbed TLS ..

[Openvpn-devel] [M] Change in openvpn[master]: Enable key export with mbed TLS 3.x.y

2023-11-10 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/402?usp=email to review the following change. Change subject: Enable key export with mbed TLS 3.x.y ..

[Openvpn-devel] [S] Change in openvpn[master]: Fix building with cmake and mbed TLS

2023-10-30 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/377?usp=email ) Change subject: Fix building with cmake and mbed TLS .. Patch Set

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-23 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email ) Change subject: Add support for mbedtls 3.X.Y .. Patch Set 7: (2

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-23 Thread MaxF (Code Review)
Attention is currently required from: MaxF, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/370?usp=email to look at the new patch set (#7). Change subject: Add support for mbedtls 3.X.Y .

[Openvpn-devel] [S] Change in openvpn[master]: Update README.mbedtls

2023-10-23 Thread MaxF (Code Review)
Attention is currently required from: MaxF, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/372?usp=email to look at the new patch set (#8). The change is no longer submittable: checks~ChecksSubmitRule is unsa

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-19 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/370?usp=email to look at the new patch set (#6). Change subject: Add support for mbedtls 3.X.Y .

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-19 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/370?usp=email to look at the new patch set (#5). Change subject: Add support for mbedtls 3.X.Y .

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-19 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email ) Change subject: Add support for mbedtls 3.X.Y .. Patch Set 4: (1

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-19 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/370?usp=email to look at the new patch set (#4). Change subject: Add support for mbedtls 3.X.Y .

[Openvpn-devel] [S] Change in openvpn[master]: Update README.mbedtls

2023-10-19 Thread MaxF (Code Review)
Attention is currently required from: MaxF, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/372?usp=email to look at the new patch set (#5). Change subject: Update README.mbedtls ...

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-18 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email ) Change subject: Add support for mbedtls 3.X.Y .. Patch Set 3: (1

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-18 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email ) Change subject: Add support for mbedtls 3.X.Y .. Patch Set 2: (11 comments)

[Openvpn-devel] [L] Change in openvpn[master]: Add compatibility functions for mbedtls 2.X.Y

2023-10-18 Thread MaxF (Code Review)
MaxF has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/371?usp=email ) Change subject: Add compatibility functions for mbedtls 2.X.Y .. Abandoned Changes were added to the patch that implements mbedtls 3 suppo

[Openvpn-devel] [L] Change in openvpn[master]: Add compatibility functions for mbedtls 2.X.Y

2023-10-18 Thread MaxF (Code Review)
MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/371?usp=email ) Change subject: Add compatibility functions for mbedtls 2.X.Y .. Patch Set 2: (1 comment) Patchset: PS2: Abandoning this, becau

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-18 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/370?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [S] Change in openvpn[master]: Update README.mbedtls

2023-10-18 Thread MaxF (Code Review)
Attention is currently required from: MaxF, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/372?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed:

[Openvpn-devel] [M] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-18 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email ) Change subject: Add support for mbedtls 3.X.Y .. Patch Set 1: (1 comment) F

[Openvpn-devel] [M] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-18 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email ) Change subject: Add support for mbedtls 3.X.Y .. Patch Set 1: (2 comments)

[Openvpn-devel] [L] Change in openvpn[master]: Add compatibility functions for mbedtls 2.X.Y

2023-10-17 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/371?usp=email to look at the new patch set (#2). Change subject: Add compatibility functions for mbedtls 2.X

[Openvpn-devel] [M] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-17 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/370?usp=email to review the following change. Change subject: Add support for mbedtls 3.X.Y ..

[Openvpn-devel] [M] Change in openvpn[master]: Add compatibility functions for mbedtls 2.X.Y

2023-10-17 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/371?usp=email to review the following change. Change subject: Add compatibility functions for mbedtls 2.X.Y ..

[Openvpn-devel] [S] Change in openvpn[master]: Update README.mbedtls

2023-10-17 Thread MaxF (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/372?usp=email to review the following change. Change subject: Update README.mbedtls ..