Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/402?usp=email )
Change subject: Enable key export with mbed TLS 3.x.y ...................................................................... Patch Set 4: (1 comment) File src/openvpn/ssl_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/402/comment/27adbd58_9c88f0d9 : PS3, Line 202: mbedtls_ssl_export_keys_cb(void *p_expkey, > This needs a comment what is going on. […] I added some comments, let me know what you think. Also, I made it a fatal error when we get an unexpected secret_len, because for TLS 1.2, it's a fixed size and if it's different something must have gone very wrong. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/402?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8e90530726b7f7ba3cee0438f2d81a1ac42e821b Gerrit-Change-Number: 402 Gerrit-PatchSet: 4 Gerrit-Owner: MaxF <m...@max-fillinger.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 13 Nov 2023 16:35:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
