Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/682?usp=email
to review the following change.
Change subject: mbedtls: Remove support for old TLS versions
......................................................................
mbedtls: Remove support for old TLS versions
Recent versions of mbedtls have dropped support for TLS 1.0 and 1.1.
Rather than checking which versions are supported, drop support for
everything before 1.2.
Change-Id: Ia3883a26ac26df6bbb5353fb074a2e0f814737be
Signed-off-by: Max Fillinger <maximilian.fillin...@foxcrypto.com>
---
M src/openvpn/ssl_mbedtls.c
1 file changed, 1 insertion(+), 20 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/82/682/1
diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.c
index a68588e..e25fb84 100644
--- a/src/openvpn/ssl_mbedtls.c
+++ b/src/openvpn/ssl_mbedtls.c
@@ -1040,12 +1040,8 @@
{
#if defined(MBEDTLS_SSL_PROTO_TLS1_2)
return TLS_VER_1_2;
-#elif defined(MBEDTLS_SSL_PROTO_TLS1_1)
- return TLS_VER_1_1;
-#elif defined(MBEDTLS_SSL_PROTO_TLS1)
- return TLS_VER_1_0;
#else /* defined(MBEDTLS_SSL_PROTO_TLS1_2) */
- #error "mbedtls is compiled without support for TLS 1.0, 1.1 and 1.2."
+ #error "mbedtls is compiled without support for TLS 1.2."
#endif /* defined(MBEDTLS_SSL_PROTO_TLS1_2) */
}
@@ -1067,27 +1063,12 @@
switch (tls_ver)
{
-#if defined(MBEDTLS_SSL_PROTO_TLS1)
- case TLS_VER_1_0:
- *major = MBEDTLS_SSL_MAJOR_VERSION_3;
- *minor = MBEDTLS_SSL_MINOR_VERSION_1;
- break;
-#endif
-
-#if defined(MBEDTLS_SSL_PROTO_TLS1_1)
- case TLS_VER_1_1:
- *major = MBEDTLS_SSL_MAJOR_VERSION_3;
- *minor = MBEDTLS_SSL_MINOR_VERSION_2;
- break;
-#endif
-
#if defined(MBEDTLS_SSL_PROTO_TLS1_2)
case TLS_VER_1_2:
*major = MBEDTLS_SSL_MAJOR_VERSION_3;
*minor = MBEDTLS_SSL_MINOR_VERSION_3;
break;
#endif
-
default:
msg(M_FATAL, "%s: invalid or unsupported TLS version %d",
__func__, tls_ver);
break;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/682?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia3883a26ac26df6bbb5353fb074a2e0f814737be
Gerrit-Change-Number: 682
Gerrit-PatchSet: 1
Gerrit-Owner: MaxF <m...@max-fillinger.net>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
