[opensource-dev] How to ask the right questions; how to support newcomers (was: lack of respectful communications on opensl and other viewer irc channels)

2013-04-26 Thread Boroondas Gupte
On 26.04.2013 01:48, Nicky Perian wrote: > From what I have read about open source projects flaming newbies is > the norm. I surely hope that's not the case in general nor in the Second Life Viewer community. > Let's get real folks, it is not necessary to continually flame someone > asking for hel

Re: [opensource-dev] gcc 4.7.1: lotsa warnings about boost

2013-01-06 Thread Boroondas Gupte
On 06.01.2013 15:19, Nicky Perian wrote: > > > *From:* Lance Corrimal > *To:* opensource-dev@lists.secondlife.com > *Sent:* Sunday, January 6, 2013 4:56 AM > *Subject:* [opensource-dev] gcc 4.7.1: lotsa wa

[opensource-dev] (was: gcc 4.7.1: lotsa warnings about boost)

2013-01-06 Thread Boroondas Gupte
On 06.01.2013 11:56, Lance Corrimal wrote: > Whenever I'm building the current development source on openSUSE 12.2 (read: > with gcc 4.7.1) I get lots of warnings about boost-related things. Some of > them I've been able to correct myself, others I'm stumped... the causes seem > to be in 3p-boos

Re: [opensource-dev] Review Request: Fix for STORM-1854.

2012-12-02 Thread Boroondas Gupte
> On Dec. 1, 2012, 4 p.m., Nicky Perian wrote: > > https://bitbucket.org/log_linden/viewer-storm-1854/commits/cf7ad502c7c3/ > > does not match this diff. result should be &result Got fixed in https://bitbucket.org/log_linden/viewer-storm-1854/commits/b418be80903520c492e1173f3afbc4021cad5d07

Re: [opensource-dev] Review Request: Fix for STORM-1854.

2012-12-02 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/609/#review1286 --- Ship it! Ship It! - Boroondas Gupte On Nov. 30, 2012, 5:17

Re: [opensource-dev] Review Request: Fix for STORM-1854.

2012-12-01 Thread Boroondas Gupte
> On Dec. 1, 2012, 9:30 a.m., Nicky Perian wrote: > > Kokua's approach was to updated the libs and deliver them using > > viewer_manifest.py. > > Using the updated libs/includes I get the following compiler error. > > It appears when the libs are LL updated this mod will need to be backed out. >

Re: [opensource-dev] Rebuilding Breakpad

2012-11-11 Thread Boroondas Gupte
On 11.11.2012 19:17, Argent Stonecutter wrote: > Shouldn't builds be based on build rules, and not on tweaks in the > application? Chances are these tweaks aren't in the cmake binary but in build rules which are part of the CMake distribution. As these tweaks probably compensate for differences be

Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-21 Thread Boroondas Gupte
- Boroondas --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/603/#review1268 --- On Sept. 20, 2012, 6:15 p.m., Gistya Eusebio wrote

Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-21 Thread Boroondas Gupte
he code. While even experienced programmers might forget to write a virtual destructor where needed, we can probably expect them to know why it's got to be there when they see one. If you feel there needs to be an in-code comment anyway, how about something short like: // needed because cl

Re: [opensource-dev] Review Request: patch potential memory leak in llgl.h

2012-09-20 Thread Boroondas Gupte
e semicolons on the preexisting lines above are different, as these functions don't have a body.) - Boroondas Gupte On Sept. 19, 2012, 8:26 a.m., Gistya Eusebio wrote: > > --- > This is an automatically generated e-mai

[opensource-dev] HG-Repositories

2012-08-07 Thread Boroondas Gupte
>From recent changes on the wiki, I take that the role of the various official mercurial repositories has changed again. Which repository should contributions be based on, now? And wh

Re: [opensource-dev] Review Request: Don't save per-account settings if login not fully successful

2012-05-01 Thread Boroondas Gupte
description: Please distinguish "repo" (short for 'repository') from "repro" (short for 'reproduction'). - Boroondas Gupte On May 1, 2012, 9:26 a.m., Jonathan Yap wrote: > > --- > This is a

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.

2012-03-31 Thread Boroondas Gupte
a really pretty solution as far as readability is concerned. > > > > Is it really worth it? > > Boroondas Gupte wrote: > I think it'd be worth it, as it'd make the calling code much more > readable. See > http://doc.qt.nokia.com/qq/qq13-apis.html#t

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.

2012-03-30 Thread Boroondas Gupte
> On March 29, 2012, 5:28 a.m., Vaalith Jinn wrote: > > indra/newview/lllocalbitmaps.h, line 42 > > > > > > For clarity's sake i kept private enums block below where it's > > currently at. > > > > If i were to

[opensource-dev] Viewer Policy Changes: Clarity vs. giving clarifications (was: opensource-dev Digest, Vol 25, Issue 25)

2012-02-26 Thread Boroondas Gupte
On 02/26/2012 02:08 PM, John Jackson wrote: > It's just another LL intentionally fuzzy policy. > This allows them to make whatever ruling they like when the time comes and > claim it has been stated "Policy". > > You will not get any real clarification. At an inworld meeting, Oz has given the thir

Re: [opensource-dev] do these warnings matter?

2012-02-14 Thread Boroondas Gupte
On 02/14/2012 08:11 PM, Lance Corrimal wrote: > Am Dienstag, 14. Februar 2012, 19:42:04 schrieb Zi Ree: >> Am Dienstag, 14. Februar 2012, 09:55:52 schrieb Lance Corrimal: >>> 2012-02-14T08:51:24Z WARNING: getChild: Making dummy 8LLUICtrl named >>> "translate_chat_checkbox" in chat_bar >> These are

Re: [opensource-dev] space navigator 3d on linux with viewer 3?

2011-12-25 Thread Boroondas Gupte
On 12/25/2011 07:22 PM, Lance Corrimal wrote: > Got it to work just fine... all you need to do is *NOT* install the > linux driver from the 3dconnexion website, and create a few udev and > hal rules. For those wondering how to do that, it's documented on the wiki

Re: [opensource-dev] Review Request: storm-1686: add the "Neck" and "Avatar Center" attach points to the Torso choices in context menus

2011-12-01 Thread Boroondas Gupte
new points, anyway, I think. - Boroondas Gupte On Dec. 1, 2011, 10:20 a.m., Oz Linden wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondli

Re: [opensource-dev] Review Request: STORM-959 Syntax highlighting for LSL multi-line comments.

2011-10-16 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/498/#review1055 --- Looks good as far as I can tell. Can we unit-test this somehow, t

Re: [opensource-dev] linux32 build startup failures.

2011-10-15 Thread Boroondas Gupte
On 10/15/2011 02:35 AM, Nicky Perian wrote: > 2011-10-14T23:42:09Z llrender/llgl.cpp(1799) : error > 2011-10-14T23:42:09Z ERROR: LLGLState: ASSERT (mWasEnabled == > glIsEnabled(state)) > A good build but, errors at start-up on both viewer development and > kokua builds. SL downloaded binary runs w/

Re: [opensource-dev] cannot open kernel32.lib / Re: major question about the kernel32.lib

2011-09-29 Thread Boroondas Gupte
On 09/29/2011 03:17 AM, Andrew Leonard wrote: > anyone know how to fix this? i been trying all day no one is even nice > enough in groups to help On 09/29/2011 07:16 AM, Andrew Leonard wrote: > i been working on this for over 8hrs i have path the location of the > lib and uninstalled everything and

Re: [opensource-dev] Review Request: Texture Picker: Making the preview "widget" a little more flexible.

2011-09-18 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/474/#review1032 --- indra/newview/lltexturectrl.cpp

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 2.0 implementation.

2011-09-05 Thread Boroondas Gupte
ems. > > Null will fail in this case. (found this out in my implementation of it on > > Firestorm) See > > http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/0431f7d7cb8c > > Boroondas Gupte wrote: > Hu. What would 0 or NULL mean here, anyway? This isn't a

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 2.0 implementation.

2011-09-05 Thread Boroondas Gupte
> On Sept. 4, 2011, 8:16 p.m., Tankmaster Finesmith wrote: > > indra/newview/lllocalbitmaps.cpp, line 83 > > > > > > mLastModified should be 0 in order to compile on 64bit Linux systems. > > Null will fail in this cas

Re: [opensource-dev] Feedback wanted for VWR-26858 (User-defined build icons)

2011-09-05 Thread Boroondas Gupte
On 09/05/2011 08:20 PM, Jonathan Welch wrote: > Partly to solve a lack of new icon space needed by Storm-49 and partly > to improve in-world building I have created VWR-26858 > (https://jira.secondlife.com/browse/VWR-26858) and would appreciate > your comments on this proposed new feature I would l

Re: [opensource-dev] llGetGeometricCenter

2011-09-04 Thread Boroondas Gupte
[Crossposting to scripters list, as this is a LSL topic. Tread started here .] On 08/31/2011 08:52 PM, Moriz Gupte wrote: > Hello there, > I have a question that I am putting here out of desperation because > nobody see

Re: [opensource-dev] Quick test of open-38 integration

2011-08-25 Thread Boroondas Gupte
On 07/27/2011 01:18 AM, Boroondas Gupte wrote: > On 07/22/2011 04:02 PM, Oz Linden (Scott Lawrence) wrote: >> I'm planning to integrate the changes from >> >> https://codereview.secondlife.com/r/167/ >> >> to better support standalone builds. >> >&

Re: [opensource-dev] Review Request: Windows debug build fails at run time because of an absent openjpeg.dll.

2011-08-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/445/#review984 --- > Note: In code comments are for code review only and will be remo

Re: [opensource-dev] Review Request: STORM-793 Offered URL-like named object is displayed as a HTTP URL in the llGiveInventory

2011-08-17 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/442/#review982 --- Ship it! Looks good now. - Boroondas On Aug. 17, 2011, 3:21 a.

[opensource-dev] Questions about unit test for "hg policy" (was: Mercurial hook checking for well-formed XML)

2011-08-16 Thread Boroondas Gupte
Heya Oz Thanks for making Bos' hg hooks public! I've looked at the unit test you've written for hg policy and have two questions about it: 1. Is it by purpose that the return code isn't checked after the hg policy invocation on line 23

Re: [opensource-dev] Review Request: STORM-793 Offered URL-like named object is displayed as a HTTP URL in the llGiveInventory

2011-08-16 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/442/#review979 --- indra/newview/skins/default/xui/en/notifications.xml

Re: [opensource-dev] Review Request: STORM-782 Unnecessary 'Compress snapshots to disk' menu item is presented in Advanced menu

2011-08-15 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/440/#review977 --- Ship it! Indeed unused, so removal is fine. - Boroondas On Aug

Re: [opensource-dev] [re:] Snowglobe Startup Failure

2011-08-12 Thread Boroondas Gupte
On 08/07/2011 11:47 PM, a...@skyhighway.com wrote: > somewhere during installing a buncha junk i need for stuff i actually earn > money for, i made it so Snowglobe wouldn't start anymore. Ew. > [...] i thought maybe it had something to do > with Python, but i think i'm sure now that none of that

Re: [opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)

2011-08-08 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/432/#review959 --- Ship it! > The assert will not be in issue for release builds. >

Re: [opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

2011-08-05 Thread Boroondas Gupte
> On July 20, 2011, 11:14 a.m., Boroondas Gupte wrote: > > indra/newview/lltoolplacer.cpp, lines 394-404 > > <http://codereview.secondlife.com/r/317/diff/1/?file=2852#file2852line394> > > > > Where are these numbers coming from? Are they used elsewhere in

Re: [opensource-dev] autobuild command not found every time

2011-08-05 Thread Boroondas Gupte
On 08/05/2011 11:08 PM, Ace Ace wrote: > i really need someone to im me in world to help lol please name is > sexy jinn For live interactive development help, the IRC channel #opensl on Freenode is usually a good place. Not all o

Re: [opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)

2011-08-05 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/432/#review953 --- Thanks for looking into this. I've stopped counting how often I've

Re: [opensource-dev] autobuild on linux?

2011-08-05 Thread Boroondas Gupte
On 08/05/2011 08:41 PM, Ace Ace wrote: > does anyone know how to set this up on linux No real setup needed, you can check it out from hg ... mkdir ~/sldevstuff hg clone ssh://h...@bitbucket.org/lindenlab/autobuild ~/sldevstuff/autobuild ... and then run it in a viewer source checkout by s

Re: [opensource-dev] Review Request: [STORM-56] As Builder, I want more decimal places allowed in the Build tool so that I can more precisely align small prims.

2011-07-29 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/424/#review941 --- indra/llui/llspinctrl.cpp

Re: [opensource-dev] Problem to download libkdu and fmod

2011-07-29 Thread Boroondas Gupte
On 07/29/2011 02:02 AM, Laurent Bechir wrote: > Thank you for all your answers :) I've put an archive of fmod on my server, > and the link and md5sum in autobuild.xml. I've used -c ReleaseOS, and it > worked. Tip: You can use file:// urls to refer to local files, so you don't have to put the arc

Re: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else

2011-07-29 Thread Boroondas Gupte
browse/FIRE-543 (and duplicates there). - Boroondas --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/405/#review939 -------

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

2011-07-28 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/419/#review934 --- indra/newview/llchathistory.cpp

Re: [opensource-dev] Quick test of open-38 integration

2011-07-26 Thread Boroondas Gupte
On 07/22/2011 04:02 PM, Oz Linden (Scott Lawrence) wrote: > I'm planning to integrate the changes from > > https://codereview.secondlife.com/r/167/ > > to better support standalone builds. > > I've done a test (non-standalone) build in our build farm, which appears > to have completed successfully

Re: [opensource-dev] Review Request: STORM-1291 [STRING IN ENG] Gestos button. Many gestures.

2011-07-26 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/416/#review931 --- Ship it! - Boroondas On July 26, 2011, 8:32 a.m., Vadim Product

Re: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

2011-07-25 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/#review929 --- Ship it! - Boroondas On July 25, 2011, 1:51 p.m., Vadim Product

Re: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

2011-07-25 Thread Boroondas Gupte
> On July 25, 2011, 10:44 a.m., Boroondas Gupte wrote: > > indra/newview/llviewerregion.h, line 195 > > <http://codereview.secondlife.com/r/414/diff/2/?file=6759#file6759line195> > > > > Can (and maybe should) be made private now. I don't think any othe

Re: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

2011-07-25 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/#review925 --- indra/newview/llfloaterland.cpp

Re: [opensource-dev] Review Request: STORM-1233 Untranslated Profile button in the Places panel

2011-07-25 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/415/#review924 --- Ship it! - Boroondas On July 25, 2011, 9:54 a.m., Vadim Product

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

2011-07-25 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/#review923 --- Ship it! > It's up to the translation team to remove obsolete tra

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

2011-07-25 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/#review920 --- indra/newview/skins/minimal/xui/da/panel_people.xml

Re: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane

2011-07-25 Thread Boroondas Gupte
> On July 25, 2011, 7:50 a.m., Vadim ProductEngine wrote: > > indra/newview/skins/minimal/xui/da/panel_people.xml, line 69 > > <http://codereview.secondlife.com/r/387/diff/1/?file=6607#file6607line69> > > > > Missing rename here. > > Boroondas Gupte

Re: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane

2011-07-25 Thread Boroondas Gupte
-- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/#review917 --- On July 18, 2011, 10:53 a.m., Boroondas Gupte wrote: > > ---

Re: [opensource-dev] Pervious Version Archive?

2011-07-24 Thread Boroondas Gupte
On 07/24/2011 06:06 PM, Bunny Halberd wrote: > Does anyone know if there's a place where the older viewer are > archived and still available for download? > > I searched the Wiki and found this: > http://wiki.secondlife.com/wiki/Old_Viewer_versions ...but it stops > around 2.2. I'm looking for som

Re: [opensource-dev] LL Windows Boost prebuilt not API-conformant?

2011-07-24 Thread Boroondas Gupte
On 07/24/2011 01:35 PM, Nat Goodspeed wrote: > I was unaware that this problem was biting anyone else; indeed I > assumed that if it had, it would already have been fixed. > > May I recommend filing a Jira explaining the link errors you're > encountering, along with the Boost mailing-list link and

[opensource-dev] LL Windows Boost prebuilt not API-conformant? (was: Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer))

2011-07-24 Thread Boroondas Gupte
On 07/23/2011 06:53 PM, Nicky Perian wrote: > https://bitbucket.org/lindenlab/viewer-development/changeset/a0b400b5ff0e/ > The comments in this changeset describe the windows build / link > issues for this CR. Hmm ... interesting. Thanks for investigating this. Alone from the Boost API documentati

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-07-21 Thread Boroondas Gupte
r_traits,class std::allocator > short> > >(class std::basic_string,class > > std::allocator > const &,class std::basic_string > short,struct std::char_traits,class std::allocator > short> > &,class std::codecvt const &)" > > (??$dispatch@V?

[opensource-dev] Review Request: VWR-26458: fixing a simple typo in German translation

2011-07-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/408/ --- Review request for Viewer. Summary --- Found this coincidentally when

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-07-21 Thread Boroondas Gupte
hg\viewer-development-mesh\build-vc100\win_crash_logger\windows-crash-logger.vcxproj] Did the patch apply cleanly? To maintain readability, I didn't include the merge with tip, so you might want to pull https://bitbucket.org/boroondas/viewer-development-open-67 instead of m

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-07-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/313/ --- (Updated July 21, 2011, 8:43 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp])

2011-07-21 Thread Boroondas Gupte
> On July 21, 2011, 4:21 a.m., Boroondas Gupte wrote: > > indra/newview/llparticipantlist.cpp, lines 807-808 > > <http://codereview.secondlife.com/r/404/diff/2/?file=6722#file6722line807> > > > > Hmm ... looking at the comment at > > https://bitbuck

Re: [opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp])

2011-07-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/#review901 --- Ship it! - Boroondas On July 21, 2011, 7:01 a.m., Paul ProductE

Re: [opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp])

2011-07-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/#review898 --- indra/newview/llparticipantlist.cpp

Re: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else

2011-07-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/405/ --- (Updated July 21, 2011, 2:55 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else

2011-07-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/405/ --- (Updated July 21, 2011, 2:44 a.m.) Review request for Viewer. Summary (up

[opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else

2011-07-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/405/ --- Review request for Viewer. Summary --- Set the z coordinate of hoverte

Re: [opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp])

2011-07-20 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/#review896 --- indra/newview/llparticipantlist.cpp

Re: [opensource-dev] Review Request: STORM-1474 Implement Show Last Search in viewer chrome

2011-07-20 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/402/#review894 --- Ship it! - Boroondas On July 20, 2011, 9:09 a.m., Paul ProductE

Re: [opensource-dev] Review Request: STORM-519 ( "Delete" is enabled in the context menu for folders which contain worn items)

2011-07-19 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/396/#review893 --- Ship it! :-) - Boroondas On July 19, 2011, 11:11 a.m., Paul Pr

Re: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane

2011-07-18 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/ --- (Updated July 18, 2011, 10:53 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: STORM-1503 (Find floater doesn't set focus to its browser)

2011-07-15 Thread Boroondas Gupte
> On July 14, 2011, 9:05 a.m., Boroondas Gupte wrote: > > indra/newview/skins/default/xui/en/floater_search.xml, lines 40-43 > > <http://codereview.secondlife.com/r/393/diff/1/?file=6663#file6663line40> > > > > While we're editing around here,

Re: [opensource-dev] Review Request: STORM-519 ( "Delete" is enabled in the context menu for folders which contain worn items)

2011-07-14 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/396/#review877 --- indra/newview/llinventorybridge.cpp

Re: [opensource-dev] Review Request: STORM-1503 (Find floater doesn't set focus to its browser)

2011-07-14 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/393/#review878 --- Ship it! indra/newview/skins/default/xui/en/floater_search.xml <

Re: [opensource-dev] Review Request: Allow objects to have 99.99% max hollow for default hollow shape.

2011-07-12 Thread Boroondas Gupte
On 07/12/2011 09:47 PM, Dahlia Trimble wrote: > On Tue, Jul 12, 2011 at 11:54 AM, Vadim Savchuk > mailto:vsavc...@productengine.com>> wrote: > > Dahlia, please comment in the ticket for the Product Owner to notice. > > > Unfortunately the official reply mechanism has the following restrictions:

Re: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane

2011-07-11 Thread Boroondas Gupte
-- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/#review856 --- On July 10, 2011, 6:24 p.m., Boroondas Gupte wrote: > > ---

[opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane

2011-07-10 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/ --- Review request for Viewer. Summary --- The layout_panels containing th

Re: [opensource-dev] Review Request: OPEN-99: use -march=pentium3 and -march=pentium4 only for 32 bit builds

2011-07-10 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/351/ --- (Updated July 10, 2011, 12:59 p.m.) Review request for Viewer and Nyx Linde

Re: [opensource-dev] Review Request: OPEN-99: use -march=pentium3 and -march=pentium4 only for 32 bit builds

2011-07-10 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/351/ --- (Updated July 10, 2011, 12:28 p.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Shader typo

2011-07-01 Thread Boroondas Gupte
On 06/28/2011 08:45 PM, Altair Sythos Memo wrote: > SecondLife-i686-2.7.6.233972/app_settings/shaders/class2/deferred/sunlightSSAOMSF.glsl > > should be sunLightSSAOMSF.glsl > > renaming turn ON again shadows Looks like that's already been fixed in b3e5a757f275

Re: [opensource-dev] A question/comment about the behavior of auto-pilot camera.

2011-06-25 Thread Boroondas Gupte
On 06/25/2011 05:58 PM, Lee ponzu wrote: > # Go wherever this avatar goes. A long time back, the viewer had a 'Follow' option in the context menu on other avatars. If I remember correctly, it was removed due to abuse considerations. (Which I could never quite follow (sic), as this merely facilitate

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

2011-06-24 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/333/#review814 --- indra/newview/llvoicevivox.h

Re: [opensource-dev] Review Request: OPEN-99: use -march=pentium3 and -march=pentium4 only for 32 bit builds

2011-06-22 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/351/ --- (Updated June 22, 2011, 1:19 p.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-06-21 Thread Boroondas Gupte
> On June 21, 2011, 6:56 a.m., Aleric Inglewood wrote: > > indra/llvfs/lldiriterator.cpp, line 123 > > <http://codereview.secondlife.com/r/313/diff/1/?file=2823#file2823line123> > > > > What is your reasoning to use native() here and not string()? > >

Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-21 Thread Boroondas Gupte
> On June 21, 2011, 7:57 a.m., Alain Linden wrote: > > indra/llvfs/tests/lldiriterator_test.cpp, line 46 > > > > > > Personally, I dislike referencing jira items in code comments. Its > > referencing something ephemer

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-06-21 Thread Boroondas Gupte
much sense, though. - Boroondas --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/313/#review793 --- On May 25, 2011,

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-06-21 Thread Boroondas Gupte
-- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/313/#review714 --- On May 25, 2011, 1:25 p.m., Boroondas Gupte wrote: > > ---

Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-21 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/357/#review788 --- doc/contributions.txt

[opensource-dev] Review Request: OPEN-99: use -march=pentium3 and -march=pentium4 only for 32 bit builds

2011-06-20 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/351/ --- Review request for Viewer. Summary --- These flags prevent building fo

Re: [opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

2011-06-20 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/341/#review786 --- Ship it! - Boroondas On June 20, 2011, 3:29 p.m., Vadim Product

Re: [opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

2011-06-20 Thread Boroondas Gupte
> On June 16, 2011, 4:23 p.m., Boroondas Gupte wrote: > > indra/newview/llnearbychathandler.cpp, lines 375-382 > > <http://codereview.secondlife.com/r/341/diff/2/?file=2978#file2978line375> > > > > This function's return type should be changed to bool,

Re: [opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

2011-06-20 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/341/#review779 --- You third diff file (STORM-1352_2.diff) seems to be incremental in

[opensource-dev] Review Request: VWR-26066: request LLFloaterWorldMap child "zoom slider" with correct type to get rid of warning when opening map flaoter

2011-06-20 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/350/ --- Review request for Viewer. Summary --- To reproduce 1. Start the v

Re: [opensource-dev] Review Request: Local Bitmap Browser implementation.

2011-06-18 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/347/#review775 --- indra/newview/CMakeLists.txt

Re: [opensource-dev] Review Request: STORM-1392 Add Nearby Voice to the Communicate menu

2011-06-18 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/346/#review774 --- Ship it! - Boroondas On June 18, 2011, 4:12 a.m., Jonathan Yap

Re: [opensource-dev] Review Request: STORM-1392 Add Nearby Voice to the Communicate menu

2011-06-18 Thread Boroondas Gupte
> On June 18, 2011, 4:24 a.m., Boroondas Gupte wrote: > > indra/newview/llbottomtray.cpp, lines 570-574 > > <http://codereview.secondlife.com/r/346/diff/1/?file=2998#file2998line570> > > > > Wouldn't it be better to set the initial disabledness for al

Re: [opensource-dev] Review Request: STORM-1392 Add Nearby Voice to the Communicate menu

2011-06-18 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/346/#review771 --- indra/newview/llbottomtray.cpp

Re: [opensource-dev] Review Request: Update libndofdev in the linux viewer. This fixes the spacenavigator in linux.

2011-06-17 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/342/#review764 --- Ship it! - Boroondas On June 17, 2011, 10:45 a.m., Log Linden w

Re: [opensource-dev] Review Request: STORM-1320 Create a 3p-libndofdev-linux repo based on version 0.3 of Jan Ciger's linux libndofdev.

2011-06-17 Thread Boroondas Gupte
is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/340/ > --- > > (Updated June 17, 2011, 8:32 a.m.) > > > Review request for Viewer, Oz Linden, Boroondas Gupte, and Altair Memo.

Re: [opensource-dev] Review Request: STORM-1320 Create a 3p-libndofdev-linux repo based on version 0.3 of Jan Ciger's linux libndofdev.

2011-06-16 Thread Boroondas Gupte
> This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/340/ > --- > > (Updated June 16, 2011, 1:32 p.m.) > > > Review request for Vi

Re: [opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

2011-06-16 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/341/#review759 --- indra/newview/llnearbychathandler.cpp

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

2011-06-15 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/326/#review757 --- indra/newview/skins/default/xui/en/strings.xml

  1   2   3   4   5   >