----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/414/#review925 -----------------------------------------------------------
indra/newview/llfloaterland.cpp <http://codereview.secondlife.com/r/414/#comment962> +1 for moving this re-occurring code into a method. :-) indra/newview/llfloaterland.cpp <http://codereview.secondlife.com/r/414/#comment961> Is it save to remove this NULL-check? AFAIK getChild<...>() can fail. indra/newview/llfloaterregioninfo.cpp <http://codereview.secondlife.com/r/414/#comment960> Is it save to remove this NULL-check? AFAIK getChild<...>() can fail. indra/newview/llviewerregion.h <http://codereview.secondlife.com/r/414/#comment963> Can (and maybe should) be made private now. I don't think any other class has a valid reason to use the unlocalized name. Or just remove it, and use directly use mProductName in getLocalizedSimProductName(). - Boroondas On July 25, 2011, 7:36 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/414/ > ----------------------------------------------------------- > > (Updated July 25, 2011, 7:36 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Localized sim product name (e.g. "Estate / Full Region") everywhere. > > > This addresses bug STORM-1220. > http://jira.secondlife.com/browse/STORM-1220 > > > Diffs > ----- > > indra/newview/llfloaterbuyland.cpp UNKNOWN > indra/newview/llfloaterland.cpp UNKNOWN > indra/newview/llfloaterregioninfo.cpp UNKNOWN > indra/newview/llpanelplaceprofile.cpp UNKNOWN > indra/newview/llviewerregion.h UNKNOWN > indra/newview/llviewerregion.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/414/diff > > > Testing > ------- > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
