> On July 11, 2011, 8:56 a.m., Seth ProductEngine wrote: > > Looks good. > > Works for me.
Thanks for reviewing. As you write "Works for me.", I assume you tested it, too? Which languages did you try? - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/#review856 ----------------------------------------------------------- On July 10, 2011, 6:24 p.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/387/ > ----------------------------------------------------------- > > (Updated July 10, 2011, 6:24 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > The layout_panels containing the buttons didn't have unique names. > Renamed them so that their names are now unique within their parent > element. > > Removed the share_btn element and containing layout_panel from translations > that contained it, as it doesn't occur in the English version. > > The English file mixed tabs and spaces. Converted tabs to spaces for that > file. > > Stripped trailing whitespace from the English file. > > > This addresses bug STORM-1403. > http://jira.secondlife.com/browse/STORM-1403 > > > Diffs > ----- > > doc/contributions.txt 2204db549295 > indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 > > Diff: http://codereview.secondlife.com/r/387/diff > > > Testing > ------- > > Switched to French, relogged, changed to default mode and logged out. Applied > this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded > build, as I still cannot complete a build again.) > > Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and > Teleport buttons were now labeled in French. > > Not tested: > * Funktionality of the buttons. > * Languages other than French. > > > Thanks, > > Boroondas > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
