> On Sept. 4, 2011, 8:16 p.m., Tankmaster Finesmith wrote: > > indra/newview/lllocalbitmaps.cpp, line 83 > > <http://codereview.secondlife.com/r/347/diff/2/?file=7058#file7058line83> > > > > mLastModified should be 0 in order to compile on 64bit Linux systems. > > Null will fail in this case. (found this out in my implementation of it on > > Firestorm) See > > http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/0431f7d7cb8c > > Boroondas Gupte wrote: > Hu. What would 0 or NULL mean here, anyway? This isn't a pointer, is it?
Never mind, I missed that the LLSD class has an overridden operator=(Integer v). - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/347/#review1013 ----------------------------------------------------------- On Sept. 4, 2011, 8:22 a.m., Vaalith Jinn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/347/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2011, 8:22 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Local Bitmaps is a mechanism to locally load images into the viewer, track > them and optionally (per each image) > have it check if the image has been overwritten locally and if so - update it > in the viewer and inworld. > > This change affects the texture picker - adding radio checks that let the > user choose between the "Inventory" (regular inventory) and "Local" tabs > (list of locally added files). > > * Only tested this myself, as opposed to the previous implementation which > has been live for, uh, a year, > this one is completely new, written mostly from scratch and uses different > mechanisms > > ** This is strictly a review/alpha version, but i'd appreciate feedback on it > before i finalize it. > > > This addresses bug STORM-64. > http://jira.secondlife.com/browse/STORM-64 > > > Diffs > ----- > > doc/contributions.txt 8da01486a36a > indra/newview/CMakeLists.txt 8da01486a36a > indra/newview/lllocalbitmaps.h PRE-CREATION > indra/newview/lllocalbitmaps.cpp PRE-CREATION > indra/newview/lltexturectrl.h 8da01486a36a > indra/newview/lltexturectrl.cpp 8da01486a36a > indra/newview/llviewertexturelist.h 8da01486a36a > indra/newview/llwearable.h 8da01486a36a > indra/newview/llwearable.cpp 8da01486a36a > indra/newview/skins/default/xui/en/floater_texture_ctrl.xml 8da01486a36a > > Diff: http://codereview.secondlife.com/r/347/diff > > > Testing > ------- > > Texture/Sculptmap/Avatar Layer show. > Texture/Sculptmap/Avatar Layer update. > Multiple sculpties update. > > > Thanks, > > Vaalith > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
