[Openocd-development] AT91SAM9 NAND Driver

2009-12-15 Thread Dean Glazeski
Hey all, I have the AT91SAM9 branch, at91sam9-nand, updated against the current OpenOCD head at http://repo.or.cz/w/openocd/dnglaze.git, but it needs all the patches from the nand-refactor branch from the same repository. I did some updates to the nand-refactor branch based on some things David s

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-12-03 Thread David Brownell
On Monday 23 November 2009, Dean Glazeski wrote: > point.  The new play area is http://repo.or.cz/w/openocd/dnglaze.git.  I've I merged a few more of those patches, including one bit of patch merging I had requested. For the NAND refactoring stuff, please fix the error handling so it doesn't assu

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-27 Thread Dean Glazeski
On Fri, Nov 27, 2009 at 7:13 PM, David Brownell wrote: > On Friday 27 November 2009, Dean Glazeski wrote: > > On Fri, Nov 27, 2009 at 2:12 AM, David Brownell > wrote: > > > > > On Monday 23 November 2009, Dean Glazeski wrote: > > > > point. The new play area is http://repo.or.cz/w/openocd/dngla

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-27 Thread David Brownell
On Friday 27 November 2009, Dean Glazeski wrote: > On Fri, Nov 27, 2009 at 2:12 AM, David Brownell wrote: > > > On Monday 23 November 2009, Dean Glazeski wrote: > > > point. The new play area is http://repo.or.cz/w/openocd/dnglaze.git. > > I've > > > > I merged a few of these. The page command

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-27 Thread Dean Glazeski
On Fri, Nov 27, 2009 at 2:12 AM, David Brownell wrote: > On Monday 23 November 2009, Dean Glazeski wrote: > > point. The new play area is http://repo.or.cz/w/openocd/dnglaze.git. > I've > > I merged a few of these. The page command refactoring: > > + if (oob && NAND_CMD_READ0 && nand->pa

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-27 Thread David Brownell
On Monday 23 November 2009, Dean Glazeski wrote: > point.  The new play area is http://repo.or.cz/w/openocd/dnglaze.git.  I've I merged a few of these. The page command refactoring: + if (oob && NAND_CMD_READ0 && nand->page_size <= 512) { + cmd = NAND_CMD_READOOB; + }

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-25 Thread Dean Glazeski
Oh, I got ya :). I just copy and pasted it from another file. I'll fix that. // Dean Glazeski On Wed, Nov 25, 2009 at 5:53 PM, David Brownell wrote: > On Wednesday 25 November 2009, Dean Glazeski wrote: > > > > > > - ARM NAND I/O interface update ... please don't add > > > lines of '*' o

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-25 Thread David Brownell
On Wednesday 25 November 2009, Dean Glazeski wrote: > > > > - ARM NAND I/O interface update ... please don't add > > lines of '*' on the right margins, they always end > > up getting trashed by someone who likes alternate > > tab widths or somesuch. > > > > Do you mean the lines that are b

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-25 Thread Dean Glazeski
> > - ARM NAND I/O interface update ... please don't add > lines of '*' on the right margins, they always end > up getting trashed by someone who likes alternate > tab widths or somesuch. > Do you mean the lines that are block comments like: /** * Block comment. */ This should be alrig

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-25 Thread David Brownell
On Monday 23 November 2009, Dean Glazeski wrote: > The new play area is http://repo.or.cz/w/openocd/dnglaze.git. The "nand-refactor" branch reads OK, except that I'd prefer to see too-long lines replaced not with lines that are also-too-long, but with ones that have sane lengths. I should b

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-25 Thread David Brownell
On Monday 23 November 2009, Dean Glazeski wrote: > The new play area is http://repo.or.cz/w/openocd/dnglaze.git.   Looking at the "armnandio" branch ... mostly OK, but: - ARM NAND I/O refactor code copying ... surely this belongs in src/target/arm.c for even more general reuse? I've been m

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-23 Thread Dean Glazeski
Actually, I ran into a possible other option: git rebase -p master which is supposed to preserve merges by not ignoring them. It seems to work in the limited testing I've done. I'll wait for more commits on origin before I confirm. // Dean Glazeski On Mon, Nov 23, 2009 at 6:24 PM, Zach Welch

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-23 Thread Zach Welch
If you have a series (or tree) of branches, I wrote a small script to rebase them automatically; however, it falls down when something fails, in so far as you have to finish things manually (for now). Basically, it does this process for N steps and for any number of branches in your local web of c

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-23 Thread Dean Glazeski
I went ahead and moved everything over as a fork on my own. I'll leave the other around until this stuff gets hammered out and I'll remove it at that point. The new play area is http://repo.or.cz/w/openocd/dnglaze.git. I've rebased everything to the new origin/master. Is there a good way to reb

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-23 Thread Zach Welch
On Mon, 2009-11-23 at 13:04 -0600, Dean Glazeski wrote: > Hi all, > > I've finished up the implementation and documentation for an AT91SAM9 > NAND driver for OpenOCD. In total there are about 34 patches that > includes some refactor work for both the NAND controller layer and the > ARM NAND I/O p

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-23 Thread Dean Glazeski
nand-refactor and armnandio can be applied in any order, but at91sam9-nand must be after them I went ahead and fixed some of the tree problems that I noticed with gitk to remove some redundant patches to make the dependencies a bit clearer. I didn't mention this with the previous email, but I did

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-23 Thread Øyvind Harboe
I took a super quick peek: 1. What's the order in which the branches should be applied? 2. The new .c file and modification of the Makefile.am belongs in the same commit. Any reason why you split those into two commits? -- Øyvind Harboe http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale C

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-23 Thread Dean Glazeski
Hey, Alright, I went through and reordered the patches and split a few of them up. The result has been pushed to http://repo.or.cz/w/dnglaze.git. There are now two additional branches: master => synced manually with origin/master armnandio => master + arm nand i/o patches nand-refactor => maste

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-23 Thread David Brownell
On Monday 23 November 2009, Dean Glazeski wrote: > pieces.  I have the branch posted at http://repo.or.cz/w/dnglaze.git under > the at91sam9-nand head. That's an intriguing and useful first: substantial patches that could eventually be pulled from a "new" developers's GIT branch! :) That'll nee

Re: [Openocd-development] AT91SAM9 NAND Driver

2009-11-23 Thread Øyvind Harboe
Wow. That's one big patch series. Great work! :-) Did you run git rebase -i ? There seems to be some funny things going on in that the at91sam9_nand.c is added in a *later* commit than the Makefile.am is added. This means that some of these commits won't compile... If you haven't used git rebase

[Openocd-development] AT91SAM9 NAND Driver

2009-11-23 Thread Dean Glazeski
Hi all, I've finished up the implementation and documentation for an AT91SAM9 NAND driver for OpenOCD. In total there are about 34 patches that includes some refactor work for both the NAND controller layer and the ARM NAND I/O pieces. I have the branch posted at http://repo.or.cz/w/dnglaze.git