Wow. That's one big patch series. Great work! :-)
Did you run git rebase -i ? There seems to be some funny things going on
in that the at91sam9_nand.c is added in a *later* commit than the Makefile.am
is added.
This means that some of these commits won't compile...
If you haven't used git rebase -i yet, you are in for a treat. You'll
*love* it once
you get the hang of it. It allows you to carefully edit the commit
history in your
branch so it's pretty & perfect. You can reorder, join & split commits. You can
also edit the commit comments.
Check out the format of the commit comments by David & Zach and you'll
get the drift.
Can you say something about the danger of regression? It's kinda hard to
tell without diving into details... This will be *much* easier to evaluate once
you're done w/git rebase -i.
I know there will be the compulsory comments about C style
deviating a bit. I prefer the latter style below, but even if
formatting is something
that we, Zach especially, have been trying to tighten up, I hope it
won't derail a careful examination of your new feature and refactoring work.
if (CMD_ARGC == 4) {
OpenOCD style =>Z
if (CMD_ARGC == 4)
{
--
Øyvind Harboe
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and flash programmer
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
