On Monday 23 November 2009, Dean Glazeski wrote:
> point.  The new play area is http://repo.or.cz/w/openocd/dnglaze.git.  I've

I merged a few of these.  The page command refactoring:

+       if (oob && NAND_CMD_READ0 && nand->page_size <= 512) {
+               cmd = NAND_CMD_READOOB;
+       }

looks buggy for "&& NAND_CMD_READ0 && " ... and I'd drop the
needless brackets.


Later in that file nand_read_page_raw() reads

+       uint8_t command = NAND_CMD_READ0;
+       int retval;
+
+       retval = nand_page_command(nand, page, command, !data);

where "command" as a variable looks needless.
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to